[kudu-CR] Move configuration keys into its own class and make public

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8920 )

Change subject: Move configuration keys into its own class and make public
..


Patch Set 2:

Hey Clemens, sorry for the delay on this one.

I'm wary of exposing the actual key/value strings because it limits our ability 
to evolve things in the future. For example, we may want to start passing all 
of the info down into the class by serializing a protobuf into the 
configuration instead of all these separate string fields.

We already have the TableInputFormatConfigurator class with some methods for 
things like the table name, master addresses, etc. Is there an issue with using 
that from Hive?


--
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente 
Gerrit-Reviewer: Clemens Valiente 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:07:54 +
Gerrit-HasComments: No

[kudu-CR] Move configuration keys into its own class and make public

[Clemens Valiente (Code Review)]

Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8920

to look at the new patch set (#2).

Change subject: Move configuration keys into its own class and make public
..

Move configuration keys into its own class and make public

External applications using the kudu-mapreduce package need to set
these configuration properties correctly. Usually they are set in the
JobConfiguration entity of a mapreduce job. For this, it is highly
preferable to have access to the config keys as they were defined
within the kudu-mapreduce package instead of redefining them within
the application (reduces duplication and potential for errors)

Since InputFormat and OutputFormat use some similar keys (and actually
used to use slightly different property names for the same thing in the
past) this commit moves all configuration keys into a common class and
makes them public for access.

Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
---
A 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduMapReduceConstants.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M 
java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M 
java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
6 files changed, 106 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8920/2
--
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente 
Gerrit-Reviewer: Clemens Valiente 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon