[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Todd Lipcon has submitted this change and it was merged. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a This commit had some semantic conflict with the recent IWYU include cleanup. Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Reviewed-on: http://gerrit.cloudera.org:8080/7762 Reviewed-by: Alexey SerbinTested-by: Todd Lipcon --- M src/kudu/rpc/connection.h M src/kudu/rpc/connection_id.cc 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Todd Lipcon has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 2: Verified+1 Pushing without waiting for tests since this unbreaks build (ensured that build succeeded in debug jenkins build) -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7762 to look at the new patch set (#2). Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a This commit had some semantic conflict with the recent IWYU include cleanup. Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 --- M src/kudu/rpc/connection.h M src/kudu/rpc/connection_id.cc 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7762/2 -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7762/1/src/kudu/rpc/connection_id.cc File src/kudu/rpc/connection_id.cc: PS1, Line 22: #include > I thought you decided we had to add ostream everywhere that we used logging Yep, but that's only when there is a construct like LOG(INFO) << "mega info"; in the file. The in that case is needed for the ostream& operator<<(ostream&). Otherwise, IWYU will say the should be removed. -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Todd Lipcon has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7762/1/src/kudu/rpc/connection_id.cc File src/kudu/rpc/connection_id.cc: PS1, Line 22: #include > I'm not sure we need this for this version. What is this for? I thought you decided we had to add ostream everywhere that we used logging.h? At least it's included in 410 of our source files :) -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7762/1/src/kudu/rpc/connection_id.cc File src/kudu/rpc/connection_id.cc: PS1, Line 22: #include I'm not sure we need this for this version. What is this for? -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7762 to review the following change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a This commit had some semantic conflict with the recent IWYU include cleanup. Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 --- M src/kudu/rpc/connection.h M src/kudu/rpc/connection_id.cc 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7762/1 -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Alexey Serbin