[kudu-CR] build: don't use constexpr lambdas
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Reviewed-on: http://gerrit.cloudera.org:8080/11970 Reviewed-by: Adar Dembo Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: don't use constexpr lambdas
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/11970 )
Change subject: build: don't use constexpr lambdas
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc
File src/kudu/tools/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: cons
> nit: formatting
Done
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: const TableReplicaMove&
rhs) {
> Nit: indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/11970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208
Gerrit-Change-Number: 11970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:01:49 +
Gerrit-HasComments: Yes
[kudu-CR] build: don't use constexpr lambdas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:03:30 + Gerrit-HasComments: No
[kudu-CR] build: don't use constexpr lambdas
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:02:22 + Gerrit-HasComments: No
[kudu-CR] build: don't use constexpr lambdas
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11970 to look at the new patch set (#2). Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11970/2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: don't use constexpr lambdas
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11970 )
Change subject: build: don't use constexpr lambdas
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc
File src/kudu/tools/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: const
TableReplicaMove& rhs) {
Nit: indentation
--
To view, visit http://gerrit.cloudera.org:8080/11970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208
Gerrit-Change-Number: 11970
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Nov 2018 00:58:08 +
Gerrit-HasComments: Yes
[kudu-CR] build: don't use constexpr lambdas
Hello Alexey Serbin, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11970 to review the following change. Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11970/1 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
