[kudu-CR] cmake: fix protoc dependency typo

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: cmake: fix protoc dependency typo
..


cmake: fix protoc dependency typo

The effect of this typo was that protoc would always be statically
linked. Since it's only a build-time dependency, we never noticed
previously.

Change-Id: Ide6f69332527f56347b2ee3e3fc6e5b4bb543fa3
Reviewed-on: http://gerrit.cloudera.org:8080/6869
Reviewed-by: Todd Lipcon 
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide6f69332527f56347b2ee3e3fc6e5b4bb543fa3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] cmake: fix protoc dependency typo

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: cmake: fix protoc dependency typo
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6f69332527f56347b2ee3e3fc6e5b4bb543fa3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] cmake: fix protoc dependency typo

[Dan Burkert (Code Review)]

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6869

to review the following change.

Change subject: cmake: fix protoc dependency typo
..

cmake: fix protoc dependency typo

The effect of this typo was that protoc would always be statically
linked. Since it's only a build-time dependency, we never noticed
previously.

Change-Id: Ide6f69332527f56347b2ee3e3fc6e5b4bb543fa3
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/6869/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide6f69332527f56347b2ee3e3fc6e5b4bb543fa3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo