[kudu-CR] consensus: Fix KUDU-1735 regression test in 3-4-3 mode
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/9013 ) Change subject: consensus: Fix KUDU-1735 regression test in 3-4-3 mode .. Abandoned Superseded by https://gerrit.cloudera.org/c/8989/ -- To view, visit http://gerrit.cloudera.org:8080/9013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I275ba76c7fc7711e05b9dbda02a659d4245c40d0 Gerrit-Change-Number: 9013 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] consensus: Fix KUDU-1735 regression test in 3-4-3 mode
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9013 ) Change subject: consensus: Fix KUDU-1735 regression test in 3-4-3 mode .. Patch Set 1: > Uploaded patch set 1. I integrated and expanded the additional checks from this changelist into https://gerrit.cloudera.org/#/c/8989/ as a result of our offline discussion yesterday. Also, more comments are added explaining the assertions in the test. -- To view, visit http://gerrit.cloudera.org:8080/9013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I275ba76c7fc7711e05b9dbda02a659d4245c40d0 Gerrit-Change-Number: 9013 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 12 Jan 2018 19:06:56 + Gerrit-HasComments: No
[kudu-CR] consensus: Fix KUDU-1735 regression test in 3-4-3 mode
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9013 to review the following change. Change subject: consensus: Fix KUDU-1735 regression test in 3-4-3 mode .. consensus: Fix KUDU-1735 regression test in 3-4-3 mode This updates the KUDU-1735 test to run both when 3-4-3 is enabled and disabled. This test had been failing in 3-4-3 mode because a non-voter cannot commit its own addition to the config, so the fault flag that triggered a crash on commit would never fire, resulting in a test failure while waiting for the crash of the removed server. The fact that this test passed prior to the fix in commit 1277f69 was a result of the ack-counting bug fixed by that patch. Change-Id: I275ba76c7fc7711e05b9dbda02a659d4245c40d0 --- M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/util/fault_injection.cc 3 files changed, 32 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/9013/1 -- To view, visit http://gerrit.cloudera.org:8080/9013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I275ba76c7fc7711e05b9dbda02a659d4245c40d0 Gerrit-Change-Number: 9013 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin