[kudu-CR] disk failure: itest for tablet copies
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. This serves to test failures during the copy itself and during the bootstrap. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Reviewed-on: http://gerrit.cloudera.org:8080/8636 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 106 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] disk failure: itest for tablet copies
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 29 Nov 2017 00:55:25 + Gerrit-HasComments: No
[kudu-CR] disk failure: itest for tablet copies
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8636/4/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: http://gerrit.cloudera.org:8080/#/c/8636/4/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@57 PS4, Line 57: using kudu::itest::StartTabletCopy; > warning: using decl 'ExternalMiniClusterFsInspector' is unused [misc-unused Done http://gerrit.cloudera.org:8080/#/c/8636/4/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@65 PS4, Line 65: using strings::Substitute; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 28 Nov 2017 23:52:58 + Gerrit-HasComments: Yes
[kudu-CR] disk failure: itest for tablet copies
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#5). Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. This serves to test failures during the copy itself and during the bootstrap. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 106 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8636/5 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] disk failure: itest for tablet copies
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8636 )
Change subject: disk failure: itest for tablet copies
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc
File src/kudu/integration-tests/tablet_copy_client_session-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@346
PS3, Line 346: don't
> nit: don't crash
Done
http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@357
PS3, Line 357: ext_ts0->uuid()];
> nit: ext_ts0
Done
http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@364
PS3, Line 364: ASSERT_EVENTUALLY([&] {
: // Each data dir has '.', '..', and 'block_manager_ins
> we already get one of these for free from the base class and it's named ins
Done
--
To view, visit http://gerrit.cloudera.org:8080/8636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec
Gerrit-Change-Number: 8636
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 28 Nov 2017 23:44:58 +
Gerrit-HasComments: Yes
[kudu-CR] disk failure: itest for tablet copies
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#4). Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. This serves to test failures during the copy itself and during the bootstrap. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 108 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8636/4 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] disk failure: itest for tablet copies
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. Patch Set 3: Code-Review+1 (3 comments) looks good, just nits http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@346 PS3, Line 346: don't nit: don't crash http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@357 PS3, Line 357: cluster_->tablet_server(0) nit: ext_ts0 http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@364 PS3, Line 364: unique_ptr inspect( : new ExternalMiniClusterFsInspector(cluster_.get())); we already get one of these for free from the base class and it's named inspect_ -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 28 Nov 2017 23:25:47 + Gerrit-HasComments: Yes
[kudu-CR] disk failure: itest for tablet copies
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#3). Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. This serves to test failures during the copy itself and during the bootstrap. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 110 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8636/3 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] disk failure: itest for tablet copies
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. Patch Set 2: Note: build failed due to lint failure. -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 23 Nov 2017 04:09:35 + Gerrit-HasComments: No
[kudu-CR] disk failure: itest for tablet copies
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#2). Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 110 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8636/2 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] disk failure: itest for tablet copies
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8636 Change subject: disk failure: itest for tablet copies .. disk failure: itest for tablet copies A test is added to test that disk failures during copies will leave the new replica in an appropriately failed state. Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec --- M src/kudu/integration-tests/tablet_copy_client_session-itest.cc 1 file changed, 110 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8636/1 -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
