[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..

docs: add a note about RAID-0

Adds a note that a single RAID-0 device with multiple disks is not
preferable to specifying multiple fs directories across multiple disks.

Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Reviewed-on: http://gerrit.cloudera.org:8080/11580
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M docs/configuration.adoc
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 22:50:21 +
Gerrit-HasComments: No


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11580/2/docs/configuration.adoc
File docs/configuration.adoc:

http://gerrit.cloudera.org:8080/#/c/11580/2/docs/configuration.adoc@80
PS2, Line 80: If not specified, data blocks will
: be placed in the directory specified by `--fs_wal_dir`.
Nit: I'd put this ahead of the RAID note, since it deals with the semantics 
rather than the effects.



--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 22:33:34 +
Gerrit-HasComments: Yes


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11580/2/docs/configuration.adoc
File docs/configuration.adoc:

http://gerrit.cloudera.org:8080/#/c/11580/2/docs/configuration.adoc@80
PS2, Line 80: es rather than delegating the
: striping to a RAID-0 array.
> Nit: I'd put this ahead of the RAID note, since it deals with the semantics
Done



--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 22:37:50 +
Gerrit-HasComments: Yes


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11580

to look at the new patch set (#3).

Change subject: docs: add a note about RAID-0
..

docs: add a note about RAID-0

Adds a note that a single RAID-0 device with multiple disks is not
preferable to specifying multiple fs directories across multiple disks.

Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
---
M docs/configuration.adoc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/11580/3
--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 2: Verified+1

Overriding -1 since this is a docs patch


--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 20:44:18 +
Gerrit-HasComments: No


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change.

Change subject: docs: add a note about RAID-0
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc
File docs/configuration.adoc:

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@76
PS1, Line 76: Note that while RAID-0
: devices with multiple drives may perform better than single 
drives, using a
: single RAID-0 device instead of specifying multiple data 
directories may reduce
: the amount of parallelism with which Kudu can operate.
Maybe: "Note that while a single data directory backed by a RAID-0 device will 
outperform a single data directory backed by a single device, it is better to 
let Kudu manage its own striping over multiple storage devices rather than 
delegating the striping to a RAID-0 array."



--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 19:56:10 +
Gerrit-HasComments: Yes


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11580

to look at the new patch set (#2).

Change subject: docs: add a note about RAID-0
..

docs: add a note about RAID-0

Adds a note that a single RAID-0 device with multiple disks is not
preferable to specifying multiple fs directories across multiple disks.

Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
---
M docs/configuration.adoc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/11580/2
--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc
File docs/configuration.adoc:

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@77
PS1, Line 77: R
> the ones with
Went with a different sentence entirely.


http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@76
PS1, Line 76:
: Note that while a single data directory backed by a RAID-0 array 
will
: outperform a single data directory backed by a single storage 
device, it is
: better to let Kudu manage its own striping over multip
> Maybe: "Note that while a single data directory backed by a RAID-0 device w
Taken near-verbatim


http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@76
PS1, Line 76:
: Note that while a single data directory backed by a RAID-0 array 
will
: outperform a single data directory backed by a single storage 
device, it is
: better to let Kudu manage its own striping over multipl
> Maybe put this in a separate Note paragraph below?
I considered that, but I think here is more appropriate since we discuss 
striping already.



--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 20:01:14 +
Gerrit-HasComments: Yes


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11580 )

Change subject: docs: add a note about RAID-0
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc
File docs/configuration.adoc:

http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@77
PS1, Line 77:
the ones with


http://gerrit.cloudera.org:8080/#/c/11580/1/docs/configuration.adoc@76
PS1, Line 76: Note that while RAID-0
: devices with multiple drives may perform better than single 
drives, using a
: single RAID-0 device instead of specifying multiple data 
directories may reduce
: the amount of parallelism with which Kudu can operate.
Maybe put this in a separate Note paragraph below?



--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 04 Oct 2018 19:59:07 +
Gerrit-HasComments: Yes


[kudu-CR] docs: add a note about RAID-0

2018-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11580


Change subject: docs: add a note about RAID-0
..

docs: add a note about RAID-0

Adds a note that a single RAID-0 device with multiple disks is not
preferable to specifying multiple fs directories across multiple disks.

Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
---
M docs/configuration.adoc
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/11580/1
--
To view, visit http://gerrit.cloudera.org:8080/11580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb17fae9459be04211bd0a7db6eca8e94e443f71
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong