[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-12 Thread Dinesh Bhat (Code Review) 
Dinesh Bhat has posted comments on this change.

Change subject: fs_tool: improve format for dumping a rowset
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-12 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: fs_tool: improve format for dumping a rowset
..


Patch Set 1: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2830/

-- 
To view, visit http://gerrit.cloudera.org:8080/3946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Todd Lipcon (Code Review) 
Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3946

Change subject: fs_tool: improve format for dumping a rowset
..

fs_tool: improve format for dumping a rowset

Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
---
M src/kudu/tools/fs_tool.cc
1 file changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/3946/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: fs_tool: improve format for dumping a rowset
..


Patch Set 1:

Given that the tool will now take a different code path entirely, could you 
amend the commit message to show "old" and "new" command line output?

-- 
To view, visit http://gerrit.cloudera.org:8080/3946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: fs_tool: improve format for dumping a rowset
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2819/

-- 
To view, visit http://gerrit.cloudera.org:8080/3946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No