[kudu-CR] java: re-revisit maven shade configuration
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8792 ) Change subject: java: re-revisit maven shade configuration .. java: re-revisit maven shade configuration I introduced a bug in the previous iteration of this patch[1]. kudu-spark-tools uber-jar should include the kudu-client-tools classes, since the Spark ITBLL job relies on the BigLinkedListCommon class. [1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9 Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce Reviewed-on: http://gerrit.cloudera.org:8080/8792 Reviewed-by: Jean-Daniel CryansTested-by: Kudu Jenkins --- M java/kudu-spark-tools/pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce Gerrit-Change-Number: 8792 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: re-revisit maven shade configuration
Hello Jean-Daniel Cryans, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8792 to review the following change. Change subject: java: re-revisit maven shade configuration .. java: re-revisit maven shade configuration I introduced a bug in the previous iteration of this patch[1]. kudu-spark-tools uber-jar should include the kudu-client-tools classes, since the Spark ITBLL job relies on the BigLinkedListCommon class. [1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9 Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce --- M java/kudu-spark-tools/pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8792/1 -- To view, visit http://gerrit.cloudera.org:8080/8792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce Gerrit-Change-Number: 8792 Gerrit-PatchSet: 1 Gerrit-Owner: Dan BurkertGerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] java: re-revisit maven shade configuration
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8792 ) Change subject: java: re-revisit maven shade configuration .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce Gerrit-Change-Number: 8792 Gerrit-PatchSet: 1 Gerrit-Owner: Dan BurkertGerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 08 Dec 2017 00:00:58 + Gerrit-HasComments: No