[kudu-CR] log: fix some incorrect assumptions on BlockingQueue shutdown
Todd Lipcon has submitted this change and it was merged. Change subject: log: fix some incorrect assumptions on BlockingQueue shutdown .. log: fix some incorrect assumptions on BlockingQueue shutdown There was an incorrect comment in the Log::AppendThread body in which it claimed that BlockingQueue::Drain would potentially return false and also return elements at the same time. This was in fact not the case. This patch adds unit tests to verify the actual behavior, and simplifies the code accordingly. Change-Id: I43e1304ce242f2def26a29504b76bb3e74a93ca3 Reviewed-on: http://gerrit.cloudera.org:8080/6855 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M src/kudu/consensus/log.cc M src/kudu/util/blocking_queue-test.cc M src/kudu/util/blocking_queue.h 3 files changed, 35 insertions(+), 10 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43e1304ce242f2def26a29504b76bb3e74a93ca3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] log: fix some incorrect assumptions on BlockingQueue shutdown
Adar Dembo has posted comments on this change. Change subject: log: fix some incorrect assumptions on BlockingQueue shutdown .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e1304ce242f2def26a29504b76bb3e74a93ca3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] log: fix some incorrect assumptions on BlockingQueue shutdown
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6855 to review the following change. Change subject: log: fix some incorrect assumptions on BlockingQueue shutdown .. log: fix some incorrect assumptions on BlockingQueue shutdown There was an incorrect comment in the Log::AppendThread body in which it claimed that BlockingQueue::Drain would potentially return false and also return elements at the same time. This was in fact not the case. This patch adds unit tests to verify the actual behavior, and simplifies the code accordingly. Change-Id: I43e1304ce242f2def26a29504b76bb3e74a93ca3 --- M src/kudu/consensus/log.cc M src/kudu/util/blocking_queue-test.cc M src/kudu/util/blocking_queue.h 3 files changed, 35 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/6855/1 -- To view, visit http://gerrit.cloudera.org:8080/6855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43e1304ce242f2def26a29504b76bb3e74a93ca3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo
