[kudu-CR] logging.cc: Call GetLoggingDirectories before first write
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 ) Change subject: logging.cc: Call GetLoggingDirectories before first write .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@1 PS2, Line 1: Parent: 8eff8f90 ([doc] remove the supportng of el6) What was the manifestation before, which led you to make this patch, could you please elaborate? Could that be baked into a test? http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@7 PS2, Line 7: logging.cc: nit: [logging] like: git log --grep="\[logging" -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 01 Aug 2023 12:54:05 + Gerrit-HasComments: Yes
[kudu-CR] logging.cc: Call GetLoggingDirectories before first write
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20292 to look at the new patch set (#2). Change subject: logging.cc: Call GetLoggingDirectories before first write .. logging.cc: Call GetLoggingDirectories before first write Glog has a function called GetLoggingDirectories, which is explicitly not thread-safe[1]. The comment promises it's not an issue since it is called in InitGoogle, but it's not true right now, so it's called after InitGoogleLogging as a workaround. The workaround simply makes sure that GetLoggingDirectories is executed in a single thread so logging_directories_list will be initialized in a thread-safe location. 1: https://github.com/google/glog/blob/674283420118bb919f83ceb3d9dee31ef43ff3aa/src/logging.cc#L2325 Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 --- M src/kudu/util/logging.cc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/20292/2 -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] logging.cc: Call GetLoggingDirectories before first write
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20292 Change subject: logging.cc: Call GetLoggingDirectories before first write .. logging.cc: Call GetLoggingDirectories before first write Glog has a function called GetLoggingDirectories, which is explicitly not thread-safe[1]. The comment promises it's not an issue since it is called in InitGoogle, but it's not true right now, so it's called after InitGoogleLogging as a workaround. The workaround simply makes sure that GetLoggingDirectories in a single thread so logging_directories_list will be initialized in a thread-safe location. 1: https://github.com/google/glog/blob/674283420118bb919f83ceb3d9dee31ef43ff3aa/src/logging.cc#L2325 Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 --- M src/kudu/util/logging.cc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/20292/1 -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai
[kudu-CR] logging.cc: Call GetLoggingDirectories before first write
Ádám Bakai has abandoned this change. ( http://gerrit.cloudera.org:8080/20016 ) Change subject: logging.cc: Call GetLoggingDirectories before first write .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/20016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I3e5cb73261015833c45ca5dd24e03bd1198b55ef Gerrit-Change-Number: 20016 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] logging.cc: Call GetLoggingDirectories before first write
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20016 to look at the new patch set (#2). Change subject: logging.cc: Call GetLoggingDirectories before first write .. logging.cc: Call GetLoggingDirectories before first write Glog has a function called GetLoggingDirectories, which is explicitly not thread-safe[1]. The comment promises it's not an issue since it is called in InitGoogle, but it's not true right now, so it's called after InitGoogleLogging as a workaround. The workaround simply makes sure that GetLoggingDirectories in a single thread so logging_directories_list will be initialized in a thread-safe location. 1: https://github.com/google/glog/blob/674283420118bb919f83ceb3d9dee31ef43ff3aa/src/logging.cc#L2325 Change-Id: I3e5cb73261015833c45ca5dd24e03bd1198b55ef --- M src/kudu/util/logging.cc 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/20016/2 -- To view, visit http://gerrit.cloudera.org:8080/20016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e5cb73261015833c45ca5dd24e03bd1198b55ef Gerrit-Change-Number: 20016 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
