[kudu-CR] row operations: suppress a gcc warning

2019-04-05 Thread Adar Dembo (Code Review) 
Hello Mike Percy, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/12943

to review the following change.


Change subject: row_operations: suppress a gcc warning
..

row_operations: suppress a gcc warning

I couldn't get this one to budge with pragma suppressions, so I added a
default value instead.

Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
---
M src/kudu/common/row_operations.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12943/1
--
To view, visit http://gerrit.cloudera.org:8080/12943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
Gerrit-Change-Number: 12943
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] row operations: suppress a gcc warning

2019-04-06 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12943 )

Change subject: row_operations: suppress a gcc warning
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/12943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
Gerrit-Change-Number: 12943
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Sat, 06 Apr 2019 21:42:40 +
Gerrit-HasComments: No

[kudu-CR] row operations: suppress a gcc warning

2019-04-06 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12943 )

Change subject: row_operations: suppress a gcc warning
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
Gerrit-Change-Number: 12943
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Sat, 06 Apr 2019 21:42:53 +
Gerrit-HasComments: No

[kudu-CR] row operations: suppress a gcc warning

2019-04-07 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12943 )

Change subject: row_operations: suppress a gcc warning
..

row_operations: suppress a gcc warning

I couldn't get this one to budge with pragma suppressions, so I added a
default value instead.

Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
Reviewed-on: http://gerrit.cloudera.org:8080/12943
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
---
M src/kudu/common/row_operations.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/12943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788
Gerrit-Change-Number: 12943
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon