[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: subprocess: use SIGKILL instead of SIGTERM death signal
..


subprocess: use SIGKILL instead of SIGTERM death signal

This addresses a potential source of test timeouts if a test starts a
minicluster, pauses one of the daemons with SIGSTOP, and then exits
unexpectedly (eg due to a CHECK failure). With the SIGTERM death signal,
I found that this resulted in the test hanging on exit: apparently it
delivered the SIGTERM to the stopped child and was then waiting on it
indefinitely.

After changing to SIGKILL I see the broken test failing from the FATAL
as expected (rather than timing out).

Change-Id: Icc411b8c031c1c117bdf0d82f272da2263c97d88
Reviewed-on: http://gerrit.cloudera.org:8080/4139
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/util/subprocess.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc411b8c031c1c117bdf0d82f272da2263c97d88
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: subprocess: use SIGKILL instead of SIGTERM death signal
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc411b8c031c1c117bdf0d82f272da2263c97d88
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: subprocess: use SIGKILL instead of SIGTERM death signal
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3103/

-- 
To view, visit http://gerrit.cloudera.org:8080/4139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc411b8c031c1c117bdf0d82f272da2263c97d88
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No