[kudu-CR] tpch: dont clear data when loading is disabled
Adar Dembo has submitted this change and it was merged. Change subject: tpch: dont clear data when loading is disabled .. tpch: dont clear data when loading is disabled Previously, the benchmark would clear the minicluster data on every startup, even if 'tpch_load_data' was disabled. With this change, we only clear the minicluster when we are loading fresh data. Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Reviewed-on: http://gerrit.cloudera.org:8080/5691 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/benchmarks/tpch/tpch_real_world.cc 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] tpch: dont clear data when loading is disabled
Adar Dembo has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] tpch: dont clear data when loading is disabled
Jean-Daniel Cryans has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] tpch: dont clear data when loading is disabled
Adar Dembo has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] tpch: dont clear data when loading is disabled
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5691 to review the following change. Change subject: tpch: dont clear data when loading is disabled .. tpch: dont clear data when loading is disabled Previously, the benchmark would clear the minicluster data on every startup, even if 'tpch_load_data' was disabled. With this change, we only clear the minicluster when we are loading fresh data. Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a --- M src/kudu/benchmarks/tpch/tpch_real_world.cc 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/5691/1 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans
