[kudu-CR] KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1755/ -- To view, visit http://gerrit.cloudera.org:8080/3321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ecf8d780de1aa89fae4e0510d8291eb1f1cee11 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3321 to review the following change. Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup This fixes a bug seen in a recent YCSB stress test that I ran in which I was accidentally writing tens of thousands of duplicate keys per second. After a tablet server restarted, it failed to come up due to a pending commit which referred to no mutated stores. This patch tweaks the logic for this safety check: a commit with no mutated stores trivially has "no active stores". However, that's not the same as having "only inactive stores" -- the subtlety is in the difference in behavior when a commit has no stores at all. The patch adds a new targeted test in tablet_bootstrap-test as well as a more end-to-end test in ts_recovery-itest. Both reproduced the bug reliably before this patch. Change-Id: I8ecf8d780de1aa89fae4e0510d8291eb1f1cee11 --- M src/kudu/consensus/log-test-base.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc 7 files changed, 136 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/3321/1 -- To view, visit http://gerrit.cloudera.org:8080/3321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ecf8d780de1aa89fae4e0510d8291eb1f1cee11 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves
[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations
Dan Burkert has posted comments on this change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations .. Patch Set 2: (1 comment) LGTM, just the small nit. http://gerrit.cloudera.org:8080/#/c/3319/2//COMMIT_MSG Commit Message: PS2, Line 18: procseses processes -- To view, visit http://gerrit.cloudera.org:8080/3319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44220d3c5ee1816f2bcf345c6062d33616145da2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1753/ -- To view, visit http://gerrit.cloudera.org:8080/3309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1353: remove per-tablet replica locations cache
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/1752/ -- To view, visit http://gerrit.cloudera.org:8080/2887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations
Kudu Jenkins has posted comments on this change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1751/ -- To view, visit http://gerrit.cloudera.org:8080/3319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44220d3c5ee1816f2bcf345c6062d33616145da2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Adar Dembo has uploaded a new patch set (#2). Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas WaitForReplicasAndUpdateLocations() is called by many itests during test setup. The context is almost always the same: 1. Start a mini cluster, waiting for all tservers to heartbeat. 2. Create a client. 3. Create a table using the client, waiting for table creation to finish. 4. Using WaitForReplicasAndUpdateLocations(), create a tablet to tserver multimap via direct GetTableLocations() RPCs. 5. Send RPCs directly to specific tablets using the map built in step 4. Today's implementation of GetTableLocations() also guarantees that step #4 only completes when all replicas have finished bootstrapping. I have a patch outstanding that removes that guarantee. Why? Because it's not terribly useful outside of testing (a tserver can restart at any time, so clients must always be prepared for TABLET_NOT_RUNNING responses) and because it simplifies master state. To keep these itests working, we need to find another way to provide the guarantee. So here's the fix: use ExternalMiniCluster::WaitForTabletsRunning() to ensure that all tablets on every server are actually running. But first we must augment it to wait for a specific tablet count, otherwise it may return despite a tserver working on a slow CreateTablet() RPC. Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 --- M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/ts_recovery-itest.cc 5 files changed, 50 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/3308/2 -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Kudu Jenkins has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1754/ -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Adar Dembo has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 364: (min_tablet_count == -1 || > isn't this somewhat redundant? i.e the size will always be >= -1 Yeah, will remove. http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 242:int min_tablet_count); > it strikes me that the timeout is usually the last argument, but here's the I don't feel strongly. Will switch. http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/ts_itest-base.h File src/kudu/integration-tests/ts_itest-base.h: Line 180: // Like the above, an expired deadline is not considered to be a failure. > can you explain this a bit further? Sure. I've updated the comment. -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Improve tpch usability
Mike Percy has submitted this change and it was merged. Change subject: Improve tpch usability .. Improve tpch usability * tpch.sh should use $ROOT to find the CPU scaling script (I had a problem with it otherwise) * tpch1.cc should print the error if the CHECK fails (e.g. cannot create the data directory) * Allow for skipping the line count check (e.g. if we run with SF != 1) * Allow for passing command-line parameters to tpch1 Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Reviewed-on: http://gerrit.cloudera.org:8080/3279 Reviewed-by: Adar Dembo Reviewed-by: Jean-Daniel Cryans Tested-by: Mike Percy --- M src/kudu/benchmarks/tpch/tpch1.cc M src/kudu/scripts/tpch.sh 2 files changed, 12 insertions(+), 8 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Mike Percy: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] Improve tpch usability
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 3: Overriding Jenkins due to flaky test -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Improve tpch usability
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Todd Lipcon has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 364: (min_tablet_count == -1 || isn't this somewhat redundant? i.e the size will always be >= -1 http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 242:int min_tablet_count); it strikes me that the timeout is usually the last argument, but here's the middle one. Would make more sense if this last argument had a default, I think... feel free to ignore, though, if you don't want to seek out all the call sites http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/ts_itest-base.h File src/kudu/integration-tests/ts_itest-base.h: Line 180: // Like the above, an expired deadline is not considered to be a failure. can you explain this a bit further? -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations
Kudu Jenkins has posted comments on this change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1750/ -- To view, visit http://gerrit.cloudera.org:8080/3319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44220d3c5ee1816f2bcf345c6062d33616145da2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3319 to review the following change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations .. [java client] fix reruns of TestKuduTable.testGetLocations The test expected a table count including the table created in testAlterTable, which meant that surefire reruns would always fail, as they clean up the minicluster state (via @AfterClass) but only run the particular failed test. Why not generalize? My thought process went something like this: 1. Let's add an @After to BaseKuduTest that enumerates all tables and deletes them. 2. #1 is a tax on every test, and besides, if we're going to undo all destructive changes, we should also restart stopped procseses. 3. If we're going to do #2, we may as well convert the existing @BeforeClass and @AfterClass into @Before and @After instead, since that's the same thing semantically but less code and guaranteed to capture every change. 4. But cluster setup in the Java tests is slow due to the Thread.sleep(300) performed by every started daemon. Let's do what we do in C++ tests and ask the servers to dump a file, sleeping until that file appears. 5. #4 is a lot of refactoring and doesn't address the multiple master case well. Let's punt on the whole endeavour and do a targeted fix instead. Change-Id: I44220d3c5ee1816f2bcf345c6062d33616145da2 --- M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 1 file changed, 30 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3319/1 -- To view, visit http://gerrit.cloudera.org:8080/3319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44220d3c5ee1816f2bcf345c6062d33616145da2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/1749/ -- To view, visit http://gerrit.cloudera.org:8080/3304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#4). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. KUDU-1398 CFile index blocks can store shortest separating prefix This changes the values stored as index keys to be a shortest key between the first key of the data block and the last key of the previous data block. Two exceptions: 1. This change does not apply to deltafiles. Deltafiles expect to be able to decode an index key into a DeltaKey. 2. The first key in a file, which could always be "", is left the same as before for compatibility with bloomfiles. The way the change works is illustrated with the example from the JIRA, extended: Block 1: apple, banana, cardamom Block 2: carrot, epazote, fennel Block 3: fig, guava, kiwi Before: ['apple' -> block 1, 'carrot' -> block 2, 'fig' -> block 3] After: ['apple' -> block 1, 'carr' -> block 2, 'fi' -> block 3] Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315 --- M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/binary_plain_block.cc M src/kudu/cfile/binary_plain_block.h M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/binary_prefix_block.h M src/kudu/cfile/block_encodings.h M src/kudu/cfile/bshuf_block.h M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/cfile_util.h M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/cfile_writer.h M src/kudu/cfile/gvint_block.cc M src/kudu/cfile/gvint_block.h M src/kudu/cfile/index_block.cc M src/kudu/cfile/plain_bitmap_block.h M src/kudu/cfile/plain_block.h M src/kudu/cfile/rle_block.h M src/kudu/tablet/deltafile.cc 19 files changed, 204 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3304/4 -- To view, visit http://gerrit.cloudera.org:8080/3304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR](gh-pages) Add weekly update for 06/06
Mike Percy has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3316/5/_posts/2016-06-06-weekly-update.md File _posts/2016-06-06-weekly-update.md: Line 19: * Jean-Daniel Cryans, put up [0.9.0 RC1](http://mail-archives.apache.org/mod_mbox/incubator-kudu-dev/201606.mbox/%3CCAGpTDNduoQM0ktuZc1eW1XeXCcXhvPGftJ%3DLRB8Er5c2dZptvw%40mail.gmail.com%3E) nit: Jean-Daniel Cryans doesn't need a comma after it -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/06
Dan Burkert has submitted this change and it was merged. Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Reviewed-on: http://gerrit.cloudera.org:8080/3316 Reviewed-by: David Ribeiro Alves Reviewed-by: Dan Burkert Tested-by: Dan Burkert --- A _posts/2016-06-06-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved; Verified David Ribeiro Alves: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add weekly update for 06/06
Dan Burkert has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/06
Hello Dan Burkert, David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3316 to look at the new patch set (#4). Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 --- A _posts/2016-06-06-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3316/4 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add weekly update for 06/06
Dan Burkert has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/06
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/06
Hello Dan Burkert, David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3316 to look at the new patch set (#3). Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 --- A _posts/2016-06-06-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3316/3 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add weekly update for 06/06
Dan Burkert has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3316/2/_posts/2016-06-06-weekly-update.md File _posts/2016-06-06-weekly-update.md: PS2, Line 24: the > nit: I mean "the raft consensus implementation" or "RaftConsensus" not the If you use the first, Raft should be capitalized. -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/06
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 2: Code-Review+2 (1 comment) lgtm, fix the nit if you think it's worth it. http://gerrit.cloudera.org:8080/#/c/3316/2/_posts/2016-06-06-weekly-update.md File _posts/2016-06-06-weekly-update.md: PS2, Line 24: the nit: I mean "the raft consensus implementation" or "RaftConsensus" not the two :) -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/06
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3316 to look at the new patch set (#2). Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 --- A _posts/2016-06-06-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3316/2 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add weekly update for 06/06
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3316/1/_posts/2016-06-06-weekly-update.md File _posts/2016-06-06-weekly-update.md: PS1, Line 21: to > to _vote_ on it Done PS1, Line 24: Raft > s/raft/the raft consensus implementation or RaftConsensus Done PS1, Line 26: implementations > mention that this will provide an upgrade path from single to multi node Oh yeah good point. PS1, Line 29: adds > "adds resources usage"? you mean resource usage monitoring, right? Yeah it's definitely missing something, went with your suggestion. -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/06
Dan Burkert has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 1: Code-Review+1 LGTM modulo David's comments. -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/06
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3316/1/_posts/2016-06-06-weekly-update.md File _posts/2016-06-06-weekly-update.md: PS1, Line 21: to to _vote_ on it PS1, Line 24: Raft s/raft/the raft consensus implementation or RaftConsensus PS1, Line 26: implementations mention that this will provide an upgrade path from single to multi node PS1, Line 29: adds "adds resources usage"? you mean resource usage monitoring, right? -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/06
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3316 Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 --- A _posts/2016-06-06-weekly-update.md 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3316/1 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3228/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1192: state_->UpdateLastReceivedOpIdUnlocked(last_from_leader); should we update this method's name? now that it does't always update the last received and updates the other watermark http://gerrit.cloudera.org:8080/#/c/3228/3/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 201: void InsertPayloadExpectTimeout(int start_row, int num_rows, int payload_size); this naming of this method is weird because it doesn't actually expect the timeout. PS3, Line 2314: leader leader follower? PS3, Line 2363: replicatoin typo PS3, Line 2395: first nit: line the names up? If I remember the logs correctly both nodes's logs ended up in no ops from different terms but with the same index? did you figure out that that the last ops don't have to match exactly? -- To view, visit http://gerrit.cloudera.org:8080/3228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
