[GitHub] [incubator-livy] jahstreet commented on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn
jahstreet commented on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn URL: https://github.com/apache/incubator-livy/pull/242#issuecomment-551597413 @runzhiwang Yeah, I see, will go through once again during weekend. Good job man! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] runzhiwang commented on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn
runzhiwang commented on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn URL: https://github.com/apache/incubator-livy/pull/242#issuecomment-551585902 @jahstreet Thank you for your comments. I have updated the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn
codecov-io edited a comment on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn URL: https://github.com/apache/incubator-livy/pull/242#issuecomment-538712243 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=h1) Report > Merging [#242](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/9042ff5b4a03cd302a884b5a74280d4b476792b7?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `68.6%`. [](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #242 +/- ## + Coverage 67.83% 67.85% +0.02% - Complexity 937 947 +10 Files 102 102 Lines 5876 5917 +41 Branches891 904 +13 + Hits 3986 4015 +29 - Misses 1316 1326 +10 - Partials574 576 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.09% <100%> (+0.07%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `65.26% <67.46%> (-0.75%)` | `48 <6> (+8)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.87% <0%> (-0.46%)` | `11% <0%> (ø)` | | | [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh) | `61.11% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (+1.25%)` | `45% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=footer). Last update [9042ff5...f949f66](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn
codecov-io edited a comment on issue #242: [LIVY-336] Livy should not spawn one thread per job to track the job on Yarn URL: https://github.com/apache/incubator-livy/pull/242#issuecomment-538712243 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=h1) Report > Merging [#242](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/9042ff5b4a03cd302a884b5a74280d4b476792b7?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `68.6%`. [](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #242 +/- ## + Coverage 67.83% 67.85% +0.02% - Complexity 937 947 +10 Files 102 102 Lines 5876 5917 +41 Branches891 904 +13 + Hits 3986 4015 +29 - Misses 1316 1326 +10 - Partials574 576 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.09% <100%> (+0.07%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `65.26% <67.46%> (-0.75%)` | `48 <6> (+8)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.87% <0%> (-0.46%)` | `11% <0%> (ø)` | | | [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh) | `61.11% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/242/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (+1.25%)` | `45% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=footer). Last update [9042ff5...f949f66](https://codecov.io/gh/apache/incubator-livy/pull/242?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
