[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `30.95%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 67.96% -0.12% - Complexity 939 941 +2 Files 101 102 +1 Lines 5853 5878 +25 Branches886 891 +5 + Hits 3985 3995 +10 - Misses 1296 1313 +17 + Partials572 570 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.67% <0%> (-0.65%)` | `13 <0> (ø)` | | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.04%)` | `21 <0> (ø)` | :arrow_down: | | [.../scala/org/apache/livy/server/auth/LdapUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwVXRpbHMuc2NhbGE=) | `20% <20%> (ø)` | `0 <0> (?)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.48% <27.27%> (+0.6%)` | `11 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `46% <0%> (+1%)` | :arrow_up: | | [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.34% <0%> (+0.32%)` | `13% <0%> (ø)` | :arrow_down: | | [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `88.57% <0%> (+5.71%)` | `9% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...80be383](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `30.95%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 67.96% -0.12% - Complexity 939 941 +2 Files 101 102 +1 Lines 5853 5878 +25 Branches886 891 +5 + Hits 3985 3995 +10 - Misses 1296 1313 +17 + Partials572 570 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.67% <0%> (-0.65%)` | `13 <0> (ø)` | | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.04%)` | `21 <0> (ø)` | :arrow_down: | | [.../scala/org/apache/livy/server/auth/LdapUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwVXRpbHMuc2NhbGE=) | `20% <20%> (ø)` | `0 <0> (?)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.48% <27.27%> (+0.6%)` | `11 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `46% <0%> (+1%)` | :arrow_up: | | [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.34% <0%> (+0.32%)` | `13% <0%> (ø)` | :arrow_down: | | [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `88.57% <0%> (+5.71%)` | `9% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...80be383](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `30.95%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 67.96% -0.12% - Complexity 939 941 +2 Files 101 102 +1 Lines 5853 5878 +25 Branches886 891 +5 + Hits 3985 3995 +10 - Misses 1296 1313 +17 + Partials572 570 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.67% <0%> (-0.65%)` | `13 <0> (ø)` | | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.04%)` | `21 <0> (ø)` | :arrow_down: | | [.../scala/org/apache/livy/server/auth/LdapUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwVXRpbHMuc2NhbGE=) | `20% <20%> (ø)` | `0 <0> (?)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.48% <27.27%> (+0.6%)` | `11 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `46% <0%> (+1%)` | :arrow_up: | | [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.34% <0%> (+0.32%)` | `13% <0%> (ø)` | :arrow_down: | | [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `88.57% <0%> (+5.71%)` | `9% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...80be383](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `25%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 67.95% -0.14% - Complexity 939 940 +1 Files 101 102 +1 Lines 5853 5876 +23 Branches886 891 +5 + Hits 3985 3993 +8 - Misses 1296 1312 +16 + Partials572 571 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.67% <0%> (-0.65%)` | `13 <0> (ø)` | | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.04%)` | `21 <0> (ø)` | :arrow_down: | | [.../scala/org/apache/livy/server/auth/LdapUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwVXRpbHMuc2NhbGE=) | `20% <20%> (ø)` | `0 <0> (?)` | | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `46% <0%> (+1%)` | :arrow_up: | | [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.34% <0%> (+0.32%)` | `13% <0%> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `67.32% <0%> (+1.3%)` | `40% <0%> (ø)` | :arrow_down: | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...5adc825](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 68.07% -0.02% Complexity 939 939 Files 101 101 Lines 5853 5860 +7 Branches886 886 + Hits 3985 3989 +4 - Misses 1296 1299 +3 Partials572 572 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `56.31% <100%> (ø)` | `13 <0> (ø)` | :arrow_down: | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.11% <100%> (+0.13%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (ø)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.42% <0%> (-0.46%)` | `11% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...17c526c](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 68.07% -0.02% Complexity 939 939 Files 101 101 Lines 5853 5860 +7 Branches886 886 + Hits 3985 3989 +4 - Misses 1296 1299 +3 Partials572 572 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `56.31% <100%> (ø)` | `13 <0> (ø)` | :arrow_down: | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.11% <100%> (+0.13%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (ø)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.42% <0%> (-0.46%)` | `11% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...17c526c](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/2e7d691c03caa6eaa1d170b2ab03265a65ff12f2?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.08% 68.07% -0.02% Complexity 939 939 Files 101 101 Lines 5853 5860 +7 Branches886 886 + Hits 3985 3989 +4 - Misses 1296 1299 +3 Partials572 572 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `56.31% <100%> (ø)` | `13 <0> (ø)` | :arrow_down: | | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.11% <100%> (+0.13%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (ø)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.42% <0%> (-0.46%)` | `11% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [2e7d691...17c526c](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.46% +<.01% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3927 +5 - Misses 1247 1248 +1 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `50% <0%> (-2.95%)` | `7% <0%> (ø)` | | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...ee8db46](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.45% 68.37% -0.09% + Complexity 927 924 -3 Files 100 100 Lines 5729 5736 +7 Branches870 870 Hits 3922 3922 - Misses 1247 1251 +4 - Partials560 563 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.66% <0%> (-2.1%)` | `43% <0%> (-3%)` | | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `72.28% <0%> (-1.21%)` | `20% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...860728c](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## - Coverage 68.45% 68.37% -0.09% + Complexity 927 924 -3 Files 100 100 Lines 5729 5736 +7 Branches870 870 Hits 3922 3922 - Misses 1247 1251 +4 - Partials560 563 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.66% <0%> (-2.1%)` | `43% <0%> (-3%)` | | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `72.28% <0%> (-1.21%)` | `20% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...860728c](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.51% +0.05% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3930 +8 + Misses 1247 1245 -2 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `67.32% <0%> (+1.3%)` | `40% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...0d96ea5](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.51% +0.05% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3930 +8 + Misses 1247 1245 -2 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `67.32% <0%> (+1.3%)` | `40% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...0d96ea5](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.51% +0.05% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3930 +8 + Misses 1247 1245 -2 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `67.32% <0%> (+1.3%)` | `40% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...0d96ea5](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.47% +0.02% Complexity 927 927 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3928 +6 Misses 1247 1247 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `50% <0%> (-2.95%)` | `7% <0%> (ø)` | | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `45% <0%> (-1%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...d21f47f](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.47% +0.02% Complexity 927 927 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3928 +6 Misses 1247 1247 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `50% <0%> (-2.95%)` | `7% <0%> (ø)` | | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (ø)` | `45% <0%> (-1%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...d21f47f](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.47% +0.02% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3928 +6 Misses 1247 1247 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...5aaf019](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.47% +0.02% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3928 +6 Misses 1247 1247 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...5aaf019](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.47% +0.02% + Complexity 927 926 -1 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3928 +6 Misses 1247 1247 - Partials560 561 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.91% <0%> (-0.84%)` | `45% <0%> (-1%)` | | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...5aaf019](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.74% +0.28% Complexity 927 927 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3943 +21 + Misses 1247 1235 -12 + Partials560 558 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `82.24% <0%> (+2.95%)` | `12% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `62.24% <0%> (+3.06%)` | `20% <0%> (+1%)` | :arrow_up: | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `77.1% <0%> (+3.61%)` | `20% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...d7ccabe](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.74% +0.28% Complexity 927 927 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3943 +21 + Misses 1247 1235 -12 + Partials560 558 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `82.24% <0%> (+2.95%)` | `12% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `62.24% <0%> (+3.06%)` | `20% <0%> (+1%)` | :arrow_up: | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `77.1% <0%> (+3.61%)` | `20% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...d7ccabe](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/0804c8ea8ece67d01ababec616c9ad8e3b15dc9f?src=pr=desc) will **increase** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.45% 68.74% +0.28% Complexity 927 927 Files 100 100 Lines 5729 5736 +7 Branches870 870 + Hits 3922 3943 +21 + Misses 1247 1235 -12 + Partials560 558 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `82.24% <0%> (+2.95%)` | `12% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `62.24% <0%> (+3.06%)` | `20% <0%> (+1%)` | :arrow_up: | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `77.1% <0%> (+3.61%)` | `20% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [0804c8e...d7ccabe](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=h1) Report > Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/b8251eb9b3d63c77c61a5950dee5958b654d9633?src=pr=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #236 +/- ## + Coverage 68.37% 68.44% +0.07% Complexity 921 921 Files 100 100 Lines 5729 5736 +7 Branches871 871 + Hits 3917 3926 +9 + Misses 1247 1246 -1 + Partials565 564 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: | | [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `66.01% <0%> (-1.31%)` | `40% <0%> (ø)` | | | [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.81% <0%> (+0.84%)` | `41% <0%> (ø)` | :arrow_down: | | [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: | | [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=footer). Last update [b8251eb...bda47d7](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
