[GitHub] incubator-livy issue #121: [LIVY-518][BUILD] Support Spark 2.4

2018-11-07 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/incubator-livy/pull/121
  
Thanks guys!


---

[GitHub] incubator-livy issue #121: [LIVY-518][BUILD] Support Spark 2.4

2018-11-07 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on the issue:

https://github.com/apache/incubator-livy/pull/121
  
Great! Thank you, @HyukjinKwon , @mgaido91 , @vanzin !


---

[GitHub] incubator-livy issue #121: [LIVY-518][BUILD] Support Spark 2.4

2018-11-07 Thread vanzin 
Github user vanzin commented on the issue:

https://github.com/apache/incubator-livy/pull/121
  
Merging to master.


---

[GitHub] incubator-livy issue #121: [LIVY-518][BUILD] Support Spark 2.4

2018-11-07 Thread vanzin 
Github user vanzin commented on the issue:

https://github.com/apache/incubator-livy/pull/121
  
Hmm... it might be good to open a Spark bug. Should be easy to create a 
repro - basically what you have in the shell session you tried above, but in a 
small scala class. (Start session - use it - stop it - remove metastore db - 
start new session - try to use it.)

Given that this seems to be a Spark issue, guess we'll go with the test 
changes.


---

[GitHub] incubator-livy issue #121: [LIVY-518][BUILD] Support Spark 2.4

2018-11-05 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-livy/pull/121
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=h1) 
Report
> Merging 
[#121](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-livy/commit/0bcc290dd2bccef85645f1a35938c241974b5c17?src=pr=desc)
 will **increase** coverage by `0.09%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-livy/pull/121/graphs/tree.svg?width=650=0MkVbiUFwE=150=pr)](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=tree)

```diff
@@ Coverage Diff  @@
## master #121  +/-   ##

+ Coverage 70.87%   70.96%   +0.09% 
+ Complexity  926  925   -1 

  Files   100  100  
  Lines  5510 5511   +1 
  Branches829  829  

+ Hits   3905 3911   +6 
+ Misses 1065 1059   -6 
- Partials540  541   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[...n/scala/org/apache/livy/utils/LivySparkUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/121/diff?src=pr=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9MaXZ5U3BhcmtVdGlscy5zY2FsYQ==)
 | `66.66% <100%> (+0.46%)` | `0 <0> (ø)` | :arrow_down: |
| 
[...java/org/apache/livy/rsc/rpc/KryoMessageCodec.java](https://codecov.io/gh/apache/incubator-livy/pull/121/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvS3J5b01lc3NhZ2VDb2RlYy5qYXZh)
 | `94.54% <0%> (-3.64%)` | `18% <0%> (-1%)` | |
| 
[...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/121/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=)
 | `77.96% <0%> (ø)` | `41% <0%> (ø)` | :arrow_down: |
| 
[.../java/org/apache/livy/rsc/driver/SparkEntries.java](https://codecov.io/gh/apache/incubator-livy/pull/121/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvU3BhcmtFbnRyaWVzLmphdmE=)
 | `65.62% <0%> (+1.56%)` | `10% <0%> (ø)` | :arrow_down: |
| 
[...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/121/diff?src=pr=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==)
 | `83.85% <0%> (+3.72%)` | `26% <0%> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=footer).
 Last update 
[0bcc290...0705f18](https://codecov.io/gh/apache/incubator-livy/pull/121?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---