Re: Review Request 33339: Add a Java example framework to test persistent volumes.

[haosdent huang]

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
> > src/examples/java/TestPersistentVolumeFramework.java, line 29
> > 
> >
> > as this is an "example" framework, it'd be great if it could have 
> > (extensive) javadocs: newbies and users alike are likely to look inside 
> > here first to learn (I sure did :) and providing them with good, extensive 
> > guidance as to why stuff is done the way it is, it would be great!
> > 
> > Ideally, all public classes + public methods should have javadocs (not 
> > sure if this is also in the public google java style guide, it sure was a 
> > "MUST" in our internal one)
> > 
> > Thanks!

Acording to the exist java example framework 
(TestExecutor.java/TestMultipleExecutorsFramework.java/...), don't have 
javadocs here. Do we still need add javadocs here, or keep same as other exist 
examples?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review86113
---


On May 18, 2015, 4:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9/
> ---
> 
> (Updated May 18, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2610
> https://issues.apache.org/jira/browse/MESOS-2610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a Java example framework to test persistent volumes.
> 
> 
> Diffs
> -
> 
>   configure.ac 7f9e52916b9d78f2bbff9d6ed9871444a0fda629 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION 
>   src/examples/java/test-persistent-volume-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp f85b81562158c5499e9804d8d7b6811bb0a3ef16 
>   src/tests/java_persistent_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 34719: Added QOS_KILLED as status reason

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review86929
---

Ship it!


Ship It!

- Till Toenshoff


On June 4, 2015, 5:43 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> ---
> 
> (Updated June 4, 2015, 5:43 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 6186c92c6fe9cf8fa136d93d5af43e0377406baf 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Review Request 35182: Fix handling large docker image info on inspect.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35182/
---

Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.


Bugs: MESOS-2809
https://issues.apache.org/jira/browse/MESOS-2809


Repository: mesos


Description
---

Fix handling large docker image info on inspect.


Diffs
-

  src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 
  src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f 

Diff: https://reviews.apache.org/r/35182/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 35182: Fix handling large docker image info on inspect.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35182/#review86948
---


Patch looks great!

Reviews applied: [35182]

All tests passed.

- Mesos ReviewBot


On June 7, 2015, 1:21 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35182/
> ---
> 
> (Updated June 7, 2015, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2809
> https://issues.apache.org/jira/browse/MESOS-2809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix handling large docker image info on inspect.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 
>   src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f 
> 
> Diff: https://reviews.apache.org/r/35182/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>