Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7:26 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7:42 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs (updated) - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review93026 --- Patch looks great! Reviews applied: [36810, 36811] All tests passed. - Mesos ReviewBot On July 25, 2015, 8:23 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated July 25, 2015, 8:23 a.m.) Review request for mesos, Adam B and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs - configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 Diff: https://reviews.apache.org/r/36811/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 25, 2015, 7:20 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- rebased to make r36720 happy. Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs (updated) - src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93022 --- Bad patch! Reviews applied: [36733, 36717, 36318] Failed command: ./support/apply-review.sh -n -r 36318 Error: 2015-07-25 07:28:15 URL:https://reviews.apache.org/r/36318/diff/raw/ [23397/23397] - 36318.patch [1] error: patch failed: src/master/master.hpp:89 error: src/master/master.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On July 25, 2015, 7:26 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7:26 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36318: Refactored framework struct in master to support http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 25, 2015, 7:40 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- This change refactors the framework struct in master to introduce support for http frameworks. - pid becomes a optional field now in the framework struct. - added optional fields for supporting http frameworks to the framework struct Diffs (updated) - src/common/http.hpp 765860fa7d0ce354320e9d293d09719be87efca0 src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca Diff: https://reviews.apache.org/r/36318/diff/ Testing --- make check + tests now go in a separate patch now. Thanks, Anand Mazumdar
Review Request 36811: Don't check protobuf jar when --disable-java flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs - configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 Diff: https://reviews.apache.org/r/36811/diff/ Testing --- Thanks, haosdent huang
Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated July 25, 2015, 8:21 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs - configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 Diff: https://reviews.apache.org/r/36811/diff/ Testing (updated) --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 25, 2015, 8:21 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing (updated) --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 25, 2015, 2:11 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- missing ; to satisfy review bot. *Sigh, my bad* Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs (updated) - src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 2:32 p.m.) Review request for mesos and Ben Mahler. Changes --- *Trigger reviewbot again* Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Review Request 36814: Use executor in mesos-execute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36814/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-527 https://issues.apache.org/jira/browse/MESOS-527 Repository: mesos Description --- Use executor in mesos-execute. Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36814/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93033 --- Patch looks great! Reviews applied: [36733, 36717, 36318, 36720] All tests passed. - Mesos ReviewBot On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 2:32 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36814: Use executor in mesos-execute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36814/#review93034 --- Patch looks great! Reviews applied: [36814] All tests passed. - Mesos ReviewBot On July 25, 2015, 3:01 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36814/ --- (Updated July 25, 2015, 3:01 p.m.) Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-527 https://issues.apache.org/jira/browse/MESOS-527 Repository: mesos Description --- Use executor in mesos-execute. Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36814/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36318: Refactored framework struct in master to support http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 25, 2015, 6:49 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone. Changes --- Modified code to use the encoder from MESOS-3067 Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- This change refactors the framework struct in master to introduce support for http frameworks. - pid becomes a optional field now in the framework struct. - added optional fields for supporting http frameworks to the framework struct Diffs (updated) - src/common/http.hpp 765860fa7d0ce354320e9d293d09719be87efca0 src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca Diff: https://reviews.apache.org/r/36318/diff/ Testing --- make check + tests now go in a separate patch now. Thanks, Anand Mazumdar
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7 a.m.) Review request for mesos and Ben Mahler. Changes --- Moved the tests to use the decoder from MESOS-3067. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs (updated) - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93021 --- Bad patch! Reviews applied: [36733] Failed command: ./support/apply-review.sh -n -r 36733 Error: 2015-07-25 07:07:12 URL:https://reviews.apache.org/r/36733/diff/raw/ [58421/58421] - 36733.patch [1] error: patch failed: src/master/master.hpp:901 error: src/master/master.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On July 25, 2015, 7 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Re: Review Request 36816: Support HTTP checks in Mesos health check program
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review93036 --- Patch looks great! Reviews applied: [36816] All tests passed. - Mesos ReviewBot On July 25, 2015, 6:57 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated July 25, 2015, 6:57 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2533 https://issues.apache.org/jira/browse/MESOS-2533 Repository: mesos Description --- Support HTTP checks in Mesos health check program Diffs - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/36816/diff/ Testing --- * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp make check Thanks, haosdent huang
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/#review93035 --- Patch looks great! Reviews applied: [35797] All tests passed. - Mesos ReviewBot On July 25, 2015, 6:38 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 25, 2015, 6:38 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- This updates both the master as well as the allocator. Added test for master. Diffs - src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 25, 2015, 6:38 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description (updated) --- This updates both the master as well as the allocator. Added test for master. Diffs (updated) - src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 36816: Support HTTP checks in Mesos health check program
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated July 25, 2015, 6:57 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2533 https://issues.apache.org/jira/browse/MESOS-2533 Repository: mesos Description --- Support HTTP checks in Mesos health check program Diffs - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/36816/diff/ Testing (updated) --- * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp make check Thanks, haosdent huang
Review Request 36816: Support HTTP checks in Mesos health check program
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- Review request for mesos and Adam B. Bugs: MESOS-2533 https://issues.apache.org/jira/browse/MESOS-2533 Repository: mesos Description --- Support HTTP checks in Mesos health check program Diffs - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/36816/diff/ Testing --- Thanks, haosdent huang
