date:20150731


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review93709
---


Patch looks great!

Reviews applied: [36978, 36979]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 8:04 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36979/
> ---
> 
> (Updated July 31, 2015, 8:04 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3142
> https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updating all references to os::shell
> For more details see MESOS-3142.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a 
>   src/tests/containerizer/isolator_tests.cpp 
> ff6e2b7e190a58a4809d6e71addb15dabe418e17 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 4bee74acba2b1472c80cabbc9d0384bd04c543aa 
> 
> Diff: https://reviews.apache.org/r/36979/diff/
> 
> 
> Testing
> ---
> 
> make check
> *Note*: this patch fixes breakages introduce by the refactoring in: 
> https://reviews.apache.org/r/36978
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to handle invalid input uniformly.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66 

Diff: https://reviews.apache.org/r/36987/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---

(Updated July 31, 2015, 3:12 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66 

Diff: https://reviews.apache.org/r/36987/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Artem Harutyunyan



> On July 31, 2015, 12:39 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 343
> > 
> >
> > This change seems to eliminate the essence of the test, namely the 
> > leading white space.
> 
> Klaus Ma wrote:
> There are two UT cases here:
> 
> - FetcherTest-OSNetUriTest
> - FetcherTest-OSNetUriSpaceTest
> 
> This fix only handle #1, which did not handle leading white space :)

You're right :facepalm:. Should be fixed now.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
---


On July 31, 2015, 8:23 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 8:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Artem Harutyunyan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/
---

(Updated July 31, 2015, 8:23 a.m.)


Review request for mesos, Bernd Mathiske and Klaus Ma.


Changes
---

Actually add whitespace to URL.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Factored out the pattern for URL generation in (another)fetcher test.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 

Diff: https://reviews.apache.org/r/36946/diff/


Testing
---

GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check


Thanks,

Artem Harutyunyan

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/#review93727
---


Bad patch!

Reviews applied: [36040, 35934, 35939, 35947, 35702, 35983, 35984]

Failed command: ./support/apply-review.sh -n -r 35984

Error:
 2015-07-31 15:36:52 URL:https://reviews.apache.org/r/35984/diff/raw/ 
[33591/33591] -> "35984.patch" [1]
error: patch failed: src/Makefile.am:1518
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On July 31, 2015, 3:12 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36987/
> ---
> 
> (Updated July 31, 2015, 3:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
>   src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66 
> 
> Diff: https://reviews.apache.org/r/36987/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93728
---

Ship it!


Ship It!

- haosdent huang


On July 31, 2015, 3:23 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93733
---


Patch looks great!

Reviews applied: [36946]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 3:23 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.



> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, line 749
> > 
> >
> > I think reserve is too abstract and may collide with future actions 
> > (think quota). How about `/dynamic/reserve`?
> 
> Alexander Rukletsov wrote:
> Though we currently do not support slashes in endpoints, I think we 
> should fix that first before introducing a `/reserve` endpoint, given these 
> endpoint are not targeted for 0.23.
> 
> Joris Van Remoortere wrote:
> Cody had some patches for enabling sub namespaces in endpoints (as in 
> enabling slashes). Might be worth pulling those in.
> 
> Alexander Rukletsov wrote:
> Yep, it's https://issues.apache.org/jira/browse/MESOS-2130, I plan to 
> bring up the discussion today at the community sync.
> 
> Michael Park wrote:
> The concensus for now seems that (1) we introduce the allocator changes, 
> but address the allocator refactor sooner rather than later, (2) go with 
> `/reserve` for now and update them once the HTTP API folks get to supporting 
> the nested endpoint stuff.
> 
> Alexander Rukletsov wrote:
> And (3) we update endpoints names before the following release, i.e. 
> there is no Mesos release, where `/reserve` will exist. Correct?
> 
> Michael Park wrote:
> That is the ideal outcome. But if we commit this now/soon, whether we can 
> update the names before 0.24.0 gets out entirely depends on whether the 
> nested endpoint names capabilities get committed on time.
> 
> Alexander Rukletsov wrote:
> I think we agreed that we should, in order to avoid deprecation cycle for 
> "old" endpoints.

I synced with BenH and Jie regarding this topic, they both suggested that we 
should get this in as is and update later. Jie suggested that if the HTTP API 
doesn't make it in in time, we can either not mention it in the `CHANGELOG` or 
mention it as an alpha feature that is subject to change.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review88781
---


On July 28, 2015, 9:03 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35702/
> ---
> 
> (Updated July 28, 2015, 9:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This involved a lot more challenges than I anticipated, I've captured the 
> various approaches and limitations and deal-breakers of those approaches 
> here: [Master Endpoint Implementation 
> Challenges](https://docs.google.com/document/d/1cwVz4aKiCYP9Y4MOwHYZkyaiuEv7fArCye-vPvB2lAI/edit#)
> 
> Key points:
> 
> * This is a stop-gap solution until we shift the offer creation/management 
> logic from the master to the allocator.
> * `updateAvailable` and `updateSlave` are kept separate because
>   (1) `updateAvailable` is allowed to fail whereas `updateSlave` must not.
>   (2) `updateAvailable` returns a `Future` whereas `updateSlave` does not.
>   (3) `updateAvailable` never leaves the allocator in an over-allocated state 
> and must not, whereas `updateSlave` does, and can.
> * The algorithm:
> * Initially, the master pessimistically assume that what seems like 
> "available" resources will be gone.
>   This is due to the race between the allocator scheduling an `allocate` 
> call to itself vs master's `allocator->updateAvailable` invocation.
>   As such, we first try to satisfy the request only with the offered 
> resources.
> * We greedily rescind one offer at a time until we've rescinded 
> sufficiently many offers.
>   IMPORTANT: We perform `recoverResources(..., Filters())` rather than 
> `recoverResources(..., None())` so that we can pretty much always win the 
> race against `allocate`.
>  In the case that we lose, no disaster occurs. We simply fail 
> to satisfy the request.
> * If we still don't have enough resources after resciding all offers, be 
> optimistic and forward the request to the allocator since there may be 
> available resources to satisfy the request.
> * If the allocator returns a failure, report the error to the user with 
> `PreconditionFailed`. This could be updated to be `Forbidden`, or `Conflict` 
> maybe as well. We'll pick one eventually.
> 
> This approach is clearly not ideal, since we would prefer to rescind as 
> little offers as possible.
> The challenges of implementing the ideal solution in the current state is 
> described in the document above.
> 
> TODO(mpark):

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
---

(Updated July 31, 2015, 8:54 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Changes
---

Used `DISTCHECK_CONFIGURE_FLAGS` to pass flags to make distcheck


Bugs: MESOS-2963 and MESOS-781
https://issues.apache.org/jira/browse/MESOS-2963
https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
---

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment 
variable that are: ` ` for the default build, `--enable-libevent` for libevent, 
and `--enable-libevent --enable-ssl` for SSL.


Diffs (updated)
-

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing
---

`OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" 
./support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Review Request 36999: Libprocess: Added missing libevent_ssl_socket.hpp to Makefile.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36999/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-2963
https://issues.apache.org/jira/browse/MESOS-2963


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a 

Diff: https://reviews.apache.org/r/36999/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
---

(Updated July 31, 2015, 8:55 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-2963 and MESOS-781
https://issues.apache.org/jira/browse/MESOS-2963
https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
---

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment 
variable that are: ` ` for the default build, `--enable-libevent` for libevent, 
and `--enable-libevent --enable-ssl` for SSL.


Diffs
-

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing
---

`OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" 
./support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
---

(Updated July 31, 2015, 9:02 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-2963 and MESOS-781
https://issues.apache.org/jira/browse/MESOS-2963
https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
---

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment 
variable that are: ` ` for the default build, `--enable-libevent` for libevent, 
and `--enable-libevent --enable-ssl` for SSL.


Diffs
-

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing (updated)
---

`OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" 
support/jenkins_build.sh`
`OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent 
--enable-ssl" support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.



> On July 21, 2015, 9:17 p.m., Vinod Kone wrote:
> > did you also test with ubuntu?
> 
> Vinod Kone wrote:
> any updates on this?

Sorry this took a while. It turned out I needed a solution to MESOS-781 to get 
this to work correctly.
I ran the test with: 
`OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" 
support/jenkins_build.sh`
`OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent 
--enable-ssl" support/jenkins_build.sh`
The ssl dependencies were already installed on ubuntu:14.10 so I did not need 
to augment it.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review92478
---


On July 31, 2015, 8:55 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> ---
> 
> (Updated July 31, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-2963 and MESOS-781
> https://issues.apache.org/jira/browse/MESOS-2963
> https://issues.apache.org/jira/browse/MESOS-781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment 
> variable that are: ` ` for the default build, `--enable-libevent` for 
> libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> ---
> 
> `OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" 
> ./support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 37000: Refactor Subprocess logic in linux/perf.cpp to use common subroutine.

2015-07-31 Thread Paul Brett


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37000/
---

Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Cong Wang.


Bugs: MESOS-3185
https://issues.apache.org/jira/browse/MESOS-3185


Repository: mesos


Description
---

Refactor Subprocess logic in linux/perf.cpp to use common subroutine.


Diffs
-

  src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 

Diff: https://reviews.apache.org/r/37000/diff/


Testing
---

sudo make check


Thanks,

Paul Brett

Re: Review Request 36999: Libprocess: Added missing libevent_ssl_socket.hpp to Makefile.

2015-07-31 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36999/#review93786
---

Ship it!



3rdparty/libprocess/Makefile.am (lines 81 - 82)


reorder alphabetically.


- Vinod Kone


On July 31, 2015, 8:54 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36999/
> ---
> 
> (Updated July 31, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-2963
> https://issues.apache.org/jira/browse/MESOS-2963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a 
> 
> Diff: https://reviews.apache.org/r/36999/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

2015-07-31 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review93787
---

Ship it!


Ship It!

- Vinod Kone


On July 31, 2015, 9:02 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> ---
> 
> (Updated July 31, 2015, 9:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-2963 and MESOS-781
> https://issues.apache.org/jira/browse/MESOS-2963
> https://issues.apache.org/jira/browse/MESOS-781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment 
> variable that are: ` ` for the default build, `--enable-libevent` for 
> libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> ---
> 
> `OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" 
> support/jenkins_build.sh`
> `OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent 
> --enable-ssl" support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/
---

(Updated July 31, 2015, 9:53 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
Michael Park.


Changes
---

rebased.


Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
2752fc4633cb8b2293c7009c5cb97006fc40f0be 
  3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/36829/diff/


Testing
---

requires follow-up patch.


Thanks,

Joris Van Remoortere

Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/
---

(Updated July 31, 2015, 9:53 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
Michael Park.


Changes
---

rebased.


Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122


Repository: mesos


Description
---

use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.


Diffs (updated)
-

  3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb 

Diff: https://reviews.apache.org/r/36830/diff/


Testing
---

created a function with an `UNIMPLEMENTED()` body and verified the runtime 
error occured when configured by default, and a compile-time error ocurred when 
configured with `--enable-static-unimplemented`


Thanks,

Joris Van Remoortere

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/
---

(Updated July 31, 2015, 9:54 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
Michael Park.


Changes
---

rebased.


Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122


Repository: mesos


Description
---

use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.


Diffs (updated)
-

  configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 

Diff: https://reviews.apache.org/r/36842/diff/


Testing
---

created a function with an `UNIMPLEMENTED()` body and verified the runtime 
error occured when configured by default, and a compile-time error ocurred when 
configured with `--enable-static-unimplemented`


Thanks,

Joris Van Remoortere

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---

(Updated July 31, 2015, 9:56 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Reordered the patches.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66 

Diff: https://reviews.apache.org/r/36987/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---

(Updated July 31, 2015, 9:56 p.m.)

Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris
Van Remoortere, and Vinod Kone.

Changes
---

Rebased.

Bugs: MESOS-2600
https://issues.apache.org/jira/browse/MESOS-2600

Repository: mesos

Description
---

This involved a lot more challenges than I anticipated, I've captured the
various approaches and limitations and deal-breakers of those approaches here:
[Master Endpoint Implementation
Challenges](https://docs.google.com/document/d/1cwVz4aKiCYP9Y4MOwHYZkyaiuEv7fArCye-vPvB2lAI/edit#)

Key points:

* This is a stop-gap solution until we shift the offer creation/management
logic from the master to the allocator.
* `updateAvailable` and `updateSlave` are kept separate because
(1) `updateAvailable` is allowed to fail whereas `updateSlave` must not.
(2) `updateAvailable` returns a `Future` whereas `updateSlave` does not.
(3) `updateAvailable` never leaves the allocator in an over-allocated state
and must not, whereas `updateSlave` does, and can.
* The algorithm:
* Initially, the master pessimistically assume that what seems like
"available" resources will be gone.
This is due to the race between the allocator scheduling an `allocate`
call to itself vs master's `allocator->updateAvailable` invocation.
As such, we first try to satisfy the request only with the offered
resources.
* We greedily rescind one offer at a time until we've rescinded
sufficiently many offers.
IMPORTANT: We perform `recoverResources(..., Filters())` rather than
`recoverResources(..., None())` so that we can pretty much always win the race
against `allocate`.
In the case that we lose, no disaster occurs. We simply fail
to satisfy the request.
* If we still don't have enough resources after resciding all offers, be
optimistic and forward the request to the allocator since there may be
available resources to satisfy the request.
* If the allocator returns a failure, report the error to the user with
`PreconditionFailed`. This could be updated to be `Forbidden`, or `Conflict`
maybe as well. We'll pick one eventually.

This approach is clearly not ideal, since we would prefer to rescind as little
offers as possible.
The challenges of implementing the ideal solution in the current state is
described in the document above.

TODO(mpark): Add more comments and test cases.

Diffs (updated)
-

src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/master/validation.hpp 43b8d84556e7f0a891dddf6185bbce7ca50b360a
src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5

Diff: https://reviews.apache.org/r/35702/diff/

Testing
---

`make check`

Thanks,

Michael Park

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35984/
---

(Updated July 31, 2015, 9:57 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
Van Remoortere, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-2600
https://issues.apache.org/jira/browse/MESOS-2600


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/tests/reservation_master_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35984/diff/


Testing
---

(1) Added `src/tests/reservation_master_endpoints_tests.cpp`
(2) `make check`


Thanks,

Michael Park

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/
---

(Updated July 31, 2015, 9:57 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
Van Remoortere, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-2600
https://issues.apache.org/jira/browse/MESOS-2600


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 

Diff: https://reviews.apache.org/r/35983/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.



> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, line 507
> > 
> >
> > The code until this line is basically request validation and 
> > authorization. Though it's not how we do it now, do you think it makes 
> > sense to split the function into smaller logical parts?
> > 
> > How about something like this:
> > 
> > ```
> > Future Master::Http::reserve(const Request& request) const
> > {
> >   return Master::Http::reserveValidate();
> > }
> > 
> > Future Master::Http::reserveValidate(const Request& request) 
> > const
> > {
> >   <...>
> >   return Master::Http::reserveAuthorize();
> > }
> > 
> > <...>
> > ```
> 
> Michael Park wrote:
> Yeah, I think it does make sense to break huge functions down to the 
> smaller logical pieces. I think we can do a more general refactoring for the 
> validation pattern, since they all pretty much do the same thing. But I think 
> we can consider doing that uniformly, outside of this patch. What do you 
> think?
> 
> Alexander Rukletsov wrote:
> I personally prefer sacrificing consistency, but write new code "right". 
> However, generally we tend to favour consistency over local improvements, so 
> feel free to "fix" the issue by creating a JIRA : ).

I've filed a JIRA ticket for this here: 
https://issues.apache.org/jira/browse/MESOS-3186


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review91472
---


On July 31, 2015, 9:56 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35702/
> ---
> 
> (Updated July 31, 2015, 9:56 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This involved a lot more challenges than I anticipated, I've captured the 
> various approaches and limitations and deal-breakers of those approaches 
> here: [Master Endpoint Implementation 
> Challenges](https://docs.google.com/document/d/1cwVz4aKiCYP9Y4MOwHYZkyaiuEv7fArCye-vPvB2lAI/edit#)
> 
> Key points:
> 
> * This is a stop-gap solution until we shift the offer creation/management 
> logic from the master to the allocator.
> * `updateAvailable` and `updateSlave` are kept separate because
>   (1) `updateAvailable` is allowed to fail whereas `updateSlave` must not.
>   (2) `updateAvailable` returns a `Future` whereas `updateSlave` does not.
>   (3) `updateAvailable` never leaves the allocator in an over-allocated state 
> and must not, whereas `updateSlave` does, and can.
> * The algorithm:
> * Initially, the master pessimistically assume that what seems like 
> "available" resources will be gone.
>   This is due to the race between the allocator scheduling an `allocate` 
> call to itself vs master's `allocator->updateAvailable` invocation.
>   As such, we first try to satisfy the request only with the offered 
> resources.
> * We greedily rescind one offer at a time until we've rescinded 
> sufficiently many offers.
>   IMPORTANT: We perform `recoverResources(..., Filters())` rather than 
> `recoverResources(..., None())` so that we can pretty much always win the 
> race against `allocate`.
>  In the case that we lose, no disaster occurs. We simply fail 
> to satisfy the request.
> * If we still don't have enough resources after resciding all offers, be 
> optimistic and forward the request to the allocator since there may be 
> available resources to satisfy the request.
> * If the allocator returns a failure, report the error to the user with 
> `PreconditionFailed`. This could be updated to be `Forbidden`, or `Conflict` 
> maybe as well. We'll pick one eventually.
> 
> This approach is clearly not ideal, since we would prefer to rescind as 
> little offers as possible.
> The challenges of implementing the ideal solution in the current state is 
> described in the document above.
> 
> TODO(mpark): Add more comments and test cases.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
>   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
>   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
>   src/master/validation.hpp 43b8d84556e7f0a891dddf6185bbce7ca50b360a 
>   src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 
> 
> Diff: https://reviews.apache.org/r/35702/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
>

Re: Review Request 36930: Forced the network isolator to use the mount namespace.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36930/
---

(Updated July 31, 2015, 10:23 p.m.)


Review request for mesos, Chi Zhang and Vinod Kone.


Changes
---

Added comments.


Repository: mesos


Description
---

Forced the network isolator to use the mount namespace.

The code of the network isolator actually relies on the fact that the child is 
in a seprate mount namespace. For example:
https://github.com/apache/mesos/blob/master/src/slave/containerizer/isolators/network/port_mapping.cpp#L1527
https://github.com/apache/mesos/blob/master/src/slave/containerizer/isolators/network/port_mapping.cpp#L3533

It originally depends on mount namespace, but was removed in this patch:
https://reviews.apache.org/r/26274

That was a bug to me. It didn't cause any issue because we don't clone the 
mounts (since we are not using mount namespace) anymore after the above patch. 
So the kernel won't have an extra reference to the mount when we try to umount 
it in `_cleanup()`.


Diffs (updated)
-

  src/slave/containerizer/isolators/network/port_mapping.cpp 
3f6e9df8711995d0dd3903c6170fdd5ad61aac5a 

Diff: https://reviews.apache.org/r/36930/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 36956: Created a test abstraction for preparing test rootfs.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/
---

(Updated July 31, 2015, 10:23 p.m.)


Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan 
Xu.


Changes
---

Rebased.


Bugs: MESOS-3179
https://issues.apache.org/jira/browse/MESOS-3179


Repository: mesos


Description
---

Created a test abstraction for preparing test rootfs.


Diffs (updated)
-

  src/tests/containerizer/launch_tests.cpp 
73c8c5fa17936b1bab4817e9f1e691144e87c35f 
  src/tests/containerizer/rootfs.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36956/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 36929: Fixed a few issues in test launcher header.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36929/
---

(Updated July 31, 2015, 10:23 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments.


Repository: mesos


Description
---

Fixed a few issues in test launcher header.


Diffs (updated)
-

  src/tests/containerizer/launcher.hpp b80e84196f8b494e6e5a3c96c86f63fe432a7bb0 

Diff: https://reviews.apache.org/r/36929/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 36954: Performed a self bind mount of rootfs itself in fs::chroot::enter().


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36954/
---

(Updated July 31, 2015, 10:23 p.m.)


Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan 
Xu.


Changes
---

Review comments.


Bugs: MESOS-3178
https://issues.apache.org/jira/browse/MESOS-3178


Repository: mesos


Description
---

Performed a self bind mount of rootfs itself in fs::chroot::enter().

See the attached ticket for the motivation.


Diffs (updated)
-

  src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd 

Diff: https://reviews.apache.org/r/36954/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35984/#review93802
---


Patch looks great!

Reviews applied: [36987, 35702, 35983, 35984]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 9:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35984/
> ---
> 
> (Updated July 31, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/tests/reservation_master_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35984/diff/
> 
> 
> Testing
> ---
> 
> (1) Added `src/tests/reservation_master_endpoints_tests.cpp`
> (2) `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93803
---

Ship it!


Ship It!

- Michael Park


On July 31, 2015, 9:53 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36830/
> ---
> 
> (Updated July 31, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb 
> 
> Diff: https://reviews.apache.org/r/36830/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93804
---

Ship it!


Ship It!

- Michael Park


On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> ---
> 
> (Updated July 31, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36842/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93806
---

Ship it!


`s/UNIMPLEMENTED()/UNIMPLEMENTED/` -- I'll fix this before I commit it for you.

- Michael Park


On July 31, 2015, 9:53 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36829/
> ---
> 
> (Updated July 31, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 2752fc4633cb8b2293c7009c5cb97006fc40f0be 
>   3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36829/diff/
> 
> 
> Testing
> ---
> 
> requires follow-up patch.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/#review93808
---

Ship it!


Ship It!

- Michael Park


On July 23, 2015, 12:17 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36712/
> ---
> 
> (Updated July 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent.cpp 
> 02f9e61c1357e7b450e53b252b49d1979e782ae8 
> 
> Diff: https://reviews.apache.org/r/36712/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/
---

Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.


Bugs: MESOS-3016
https://issues.apache.org/jira/browse/MESOS-3016


Repository: mesos


Description
---

Currently, only FrameworkID and TaskID are sent to the hook.


Diffs
-

  include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
  src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
  src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
  src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
  src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 

Diff: https://reviews.apache.org/r/37007/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

2015-07-31 Thread Ben Mahler


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93823
---



configure.ac (lines 1560 - 1561)


Hm.. coming across this I can't tell how this works, mind adding a comment?

The following seems like magic:

```
inline Try cloexec(int fd)
{
  UNIMPLEMENTED; // what is this symbol? can't find it
}
```


- Ben Mahler


On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> ---
> 
> (Updated July 31, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36842/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

2015-07-31 Thread Ben Mahler



> On Aug. 1, 2015, 12:22 a.m., Ben Mahler wrote:
> > configure.ac, lines 1560-1561
> > 
> >
> > Hm.. coming across this I can't tell how this works, mind adding a 
> > comment?
> > 
> > The following seems like magic:
> > 
> > ```
> > inline Try cloexec(int fd)
> > {
> >   UNIMPLEMENTED; // what is this symbol? can't find it
> > }
> > ```

Ah, sorry I was looking at UNIMPLEMENTED in some of the committed os.hpp code 
before unimplemented.hpp was committed, I guess the commit order was wrong?

Anyway, perhaps having a pointer to stout's unimplemented.hpp would be nice in 
the configure.ac code.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93823
---


On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> ---
> 
> (Updated July 31, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36842/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93825
---


Patch looks great!

Reviews applied: [37007]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 11:27 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37007/
> ---
> 
> (Updated July 31, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3016
> https://issues.apache.org/jira/browse/MESOS-3016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, only FrameworkID and TaskID are sent to the hook.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
>   src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
>   src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
>   src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
>   src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 
> 
> Diff: https://reviews.apache.org/r/37007/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 37010: stout: Removed unused 'fatal' and 'fatalerror' macros.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37010/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ce850337dd4591027993c242dae321f21516f065 
  3rdparty/libprocess/3rdparty/stout/include/stout/fatal.hpp 
053ef82d9d152984b5e7a1b915353356be2cdd2f 

Diff: https://reviews.apache.org/r/37010/diff/


Testing
---

`make check`


Thanks,

Michael Park

Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/exec/exec.cpp d59a7e1df0d4786ee72b410f4fbb3b71e585b39d 
  src/zookeeper/zookeeper.cpp fe862aa0b2f0124a786a805ec6be9615599da2fb 

Diff: https://reviews.apache.org/r/37012/diff/


Testing
---

`make check`


Thanks,

Michael Park

Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/src/fatal.hpp 87a55dca4fe53c1f3fc7fb03914f3ec4270aa5b4 
  3rdparty/libprocess/src/fatal.cpp 76d5ee42be50651863f88189341d59cfd406bae4 

Diff: https://reviews.apache.org/r/37011/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93827
---



include/mesos/hook.hpp (line 89)


`s/executorID/executorId/` -- here and below.



src/slave/slave.cpp 


Why did this have to move? I guess we want the `update` within the `if 
(executor == NULL)` statement block to have the old value?


- Michael Park


On July 31, 2015, 11:27 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37007/
> ---
> 
> (Updated July 31, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3016
> https://issues.apache.org/jira/browse/MESOS-3016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, only FrameworkID and TaskID are sent to the hook.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
>   src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
>   src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
>   src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
>   src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 
> 
> Diff: https://reviews.apache.org/r/37007/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/#review93830
---


Patch looks great!

Reviews applied: [37010, 37011, 37012]

All tests passed.

- Mesos ReviewBot


On Aug. 1, 2015, 2:10 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37012/
> ---
> 
> (Updated Aug. 1, 2015, 2:10 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d59a7e1df0d4786ee72b410f4fbb3b71e585b39d 
>   src/zookeeper/zookeeper.cpp fe862aa0b2f0124a786a805ec6be9615599da2fb 
> 
> Diff: https://reviews.apache.org/r/37012/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/
---

(Updated Aug. 1, 2015, 12:24 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.


Changes
---

fixed typo.


Bugs: MESOS-3016
https://issues.apache.org/jira/browse/MESOS-3016


Repository: mesos


Description
---

Currently, only FrameworkID and TaskID are sent to the hook.


Diffs (updated)
-

  include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
  src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
  src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
  src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
  src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 

Diff: https://reviews.apache.org/r/37007/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya



> On July 31, 2015, 10:22 p.m., Michael Park wrote:
> > src/slave/slave.cpp, lines 2740-2743
> > 
> >
> > Why did this have to move? I guess we want the `update` within the `if 
> > (executor == NULL)` statement block to have the old value?

I coule be off, but I think a hook would have already been called for the 
previous update, so we don't need to call it again. Further, the hook is pretty 
much useless without the executorId, as it is hard for a module to figure out 
the correct context with just frameworkId and taskId.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93827
---


On Aug. 1, 2015, 12:24 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37007/
> ---
> 
> (Updated Aug. 1, 2015, 12:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3016
> https://issues.apache.org/jira/browse/MESOS-3016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, only FrameworkID and TaskID are sent to the hook.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
>   src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
>   src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
>   src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
>   src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 
> 
> Diff: https://reviews.apache.org/r/37007/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

2015-07-31 Thread Artem Harutyunyan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/#review93832
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 31, 2015, 7:10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37011/
> ---
> 
> (Updated July 31, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/fatal.hpp 87a55dca4fe53c1f3fc7fb03914f3ec4270aa5b4 
>   3rdparty/libprocess/src/fatal.cpp 76d5ee42be50651863f88189341d59cfd406bae4 
> 
> Diff: https://reviews.apache.org/r/37011/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.