Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 6:05 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.apache.org/jira/browse/MESOS-2588 Repository: mesos Description --- Create pre-launch hook before a docker container launches in slave. Diffs (updated) - include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/36185/diff/ Testing --- # Add a new unit test HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook make check -j8 GTEST_FILTER=-* sudo ./bin/mesos-tests.sh --verbose --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook Thanks, haosdent huang
Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95536 --- src/tests/hook_tests.cpp (line 573) https://reviews.apache.org/r/36185/#comment150563 path::join(flags.sandbox_directory, foo) src/tests/hook_tests.cpp (line 618) https://reviews.apache.org/r/36185/#comment150562 I don't think you need to create a temporary docker again, you can simply reuse the docker you created in the beginning of the test. - Timothy Chen On Aug. 16, 2015, 6:05 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 6:05 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.apache.org/jira/browse/MESOS-2588 Repository: mesos Description --- Create pre-launch hook before a docker container launches in slave. Diffs - include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/36185/diff/ Testing --- # Add a new unit test HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook make check -j8 GTEST_FILTER=-* sudo ./bin/mesos-tests.sh --verbose --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook Thanks, haosdent huang
Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.
On Aug. 16, 2015, 6:53 a.m., Timothy Chen wrote: I think other than the minor issues I see this seems to good to go, once you fix this I'll run this locally and this should be ready to go. The jenkins seems have problem. https://builds.apache.org/job/Mesos/705/ The job hang 2 days. I could pass make -j8 distcheck local, and not sure the reviewbot failure because by my patch or others. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95537 --- On Aug. 16, 2015, 7:15 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 7:15 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.apache.org/jira/browse/MESOS-2588 Repository: mesos Description --- Create pre-launch hook before a docker container launches in slave. Diffs - include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/36185/diff/ Testing --- # Add a new unit test HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook make check -j8 GTEST_FILTER=-* sudo ./bin/mesos-tests.sh --verbose --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook Thanks, haosdent huang
Re: Review Request 37246: Refactor store to use updated DockerImage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- (Updated Aug. 16, 2015, 8:34 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactor local store to use updated DockerImage. Diffs (updated) - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37246/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37247: Added Docker image reference store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 16, 2015, 8:35 a.m.) Review request for mesos and Timothy Chen. Changes --- Fixed build error. Bugs: MESOS-3021 https://issues.apache.org/jira/browse/MESOS-3021 Repository: mesos Description --- Added Docker image reference store. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/messages/docker_provisioner.hpp PRE-CREATION src/messages/docker_provisioner.proto PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37247/diff/ Testing --- make check Tests will be added in a later review. Thanks, Lily Chen
Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- (Updated Aug. 16, 2015, 8:33 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Refactor Docker Image to exclude path and manifest. Diffs (updated) - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37245/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 16, 2015, 8:32 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added store interface and moved store implementation to LocalStore subclass. Diffs (updated) - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37199/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 16, 2015, 8:33 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers. Diffs (updated) - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c Diff: https://reviews.apache.org/r/37200/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37496: Move docker provisioner local store into dedicated folders.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 16, 2015, 8:36 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Move docker provisioner local store into dedicated folders. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37496/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 16, 2015, 8:38 a.m.) Review request for mesos, Jojy Varghese and Timothy Chen. Changes --- Addressed comments. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37198: Add Docker image provisioner and copy backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 16, 2015, 8:31 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838 src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c src/tests/containerizer/provisioner.hpp c4ba46794fe5d7875fda11155367f521c34ea339 Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37197: Docker image store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 16, 2015, 8:31 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37505: Fix broken health check in docker executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description --- Fix broken health check in docker executor. Diffs - src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing --- # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose Thanks, haosdent huang
Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 7:15 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.apache.org/jira/browse/MESOS-2588 Repository: mesos Description --- Create pre-launch hook before a docker container launches in slave. Diffs (updated) - include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/36185/diff/ Testing --- # Add a new unit test HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook make check -j8 GTEST_FILTER=-* sudo ./bin/mesos-tests.sh --verbose --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook Thanks, haosdent huang
Re: Review Request 37505: Fix broken health check in docker executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review95541 --- Patch looks great! Reviews applied: [37505] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Aug. 16, 2015, 9:12 a.m.) Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description --- Fix broken health check in docker executor. Diffs - src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing --- # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose Thanks, haosdent huang
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95540 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37199, 37200, 37245, 37246, 37247, 37495, 37496, 37497] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 8:38 a.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 16, 2015, 8:38 a.m.) Review request for mesos, Jojy Varghese and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95539 --- Patch looks great! Reviews applied: [36185] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 7:15 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 7:15 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.apache.org/jira/browse/MESOS-2588 Repository: mesos Description --- Create pre-launch hook before a docker container launches in slave. Diffs - include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/36185/diff/ Testing --- # Add a new unit test HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook make check -j8 GTEST_FILTER=-* sudo ./bin/mesos-tests.sh --verbose --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook Thanks, haosdent huang
Re: Review Request 37493: Detect gflags when present and link when building Python module
On Aug. 16, 2015, 3:42 a.m., Timothy Chen wrote: configure.ac, line 561 https://reviews.apache.org/r/37493/diff/1/?file=1040648#file1040648line561 I think we can basically follow the same syntax we've calling AC_CHECK_LIB in the other places [AC_CHECK_LIB([leveldb], [leveldb_open], [found_leveldb=yes])]) Otherwise this looks good to me. +1 - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 --- On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95547 --- Ship it! Definitely a band-aid but given that we keep tracking this for a proper fix, I'ld say it is an improvement already worth committing :). Thanks a bunch Greg! - Till Toenshoff On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/ --- (Updated Aug. 13, 2015, 4:49 p.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-1013 https://issues.apache.org/jira/browse/MESOS-1013 Repository: mesos Description --- Fix flaky ExamplesTest.JavaLog Diffs - src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56 Diff: https://reviews.apache.org/r/37414/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95548 --- Ship it! Definitely a band-aid but given that we keep tracking this for a proper fix, I'ld say it is an improvement already worth committing :). Thanks a bunch Greg! - Till Toenshoff On Aug. 14, 2015, 4:56 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/ --- (Updated Aug. 14, 2015, 4:56 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-830 https://issues.apache.org/jira/browse/MESOS-830 Repository: mesos Description --- Fix flaky ExamplesTest.JavaFramework Diffs - src/examples/java/TestFramework.java 265005b9d1a6a053b812c133a4817c3d9e61179e Diff: https://reviews.apache.org/r/37415/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaFramework bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
On Aug. 14, 2015, 10:28 p.m., haosdent huang wrote: Again, sorry it's taken so long to get round to doing this review and s many thanks for doing this! I've only got halfway through, I'll try my best to do more in the next few days, less craziness (here's to hoping, anyway!) I notice the one file runs for 1,000 lines - the Resource class is probably worth having in its own .java file, and probably Flags too - maybe you can refactor further other parts too. In general, I like Java class files to only rarely exceed the 300-400 lines - bigger than that, it usually signals design choices that are sub-optimal in separating concerns. As I mentioned, it's great that you're doing this: as someone who wants to learn more about persistence framework, I'm looking forward to having this committed and being able to also hack around with it :) Maybe, we may also get a blog entry out of it, as we expose persistent volumes to a wider public and show folks how to use them in a Java framework. Thank you for your work! Let me update it. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95473 --- On June 21, 2015, 9:57 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:57 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95559 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 11:41 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/ --- (Updated 八月 16, 2015, 11:41 p.m.) Review request for mesos and Anand Mazumdar. Repository: mesos Description --- As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet. Diffs - src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b Diff: https://reviews.apache.org/r/37511/diff/ Testing --- make check No new tests yet because it's not clear how to simulate scheduler disconnection on the master. Thanks, Vinod Kone
Re: Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/#review95560 --- Patch looks great! Reviews applied: [37508] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 7:07 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/ --- (Updated Aug. 16, 2015, 7:07 p.m.) Review request for mesos. Bugs: MESOS-3264 https://issues.apache.org/jira/browse/MESOS-3264 Repository: mesos Description --- Add destruct ShutdownHook in java MesosExecutorDriver. Diffs - src/java/src/org/apache/mesos/MesosExecutorDriver.java 6741b3239daa435045ab01f830cf495dd2e65a3f Diff: https://reviews.apache.org/r/37508/diff/ Testing --- Thanks, haosdent huang
Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description --- As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet. Diffs - src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b Diff: https://reviews.apache.org/r/37511/diff/ Testing --- make check No new tests yet because it's not clear how to simulate scheduler disconnection on the master. Thanks, Vinod Kone
Review Request 37512: Added user doc for Scheduler HTTP API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos Description --- Mostly copy pasted from the design doc with some formatting. Diffs - docs/scheduler_http_api.md PRE-CREATION Diff: https://reviews.apache.org/r/37512/diff/ Testing --- gist: https://gist.github.com/vinodkone/5ae803ee35274ca46a3e Thanks, Vinod Kone
Re: Review Request 37509: Log Scheduler HTTP API Requests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37509/#review95556 --- Ship it! Ship It! - Vinod Kone On Aug. 16, 2015, 8:27 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37509/ --- (Updated Aug. 16, 2015, 8:27 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- We were not logging the API requests for the HTTP scheduler API. Diffs - src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e Diff: https://reviews.apache.org/r/37509/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37510: Add more logging to the scheduler library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95563 --- Bad patch! Reviews applied: [37510] Failed command: ./support/apply-review.sh -n -r 37510 Error: 2015-08-17 05:22:06 URL:https://reviews.apache.org/r/37510/diff/raw/ [1013/1013] - 37510.patch [1] error: patch failed: src/scheduler/scheduler.cpp:300 error: src/scheduler/scheduler.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 16, 2015, 9:18 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/ --- (Updated Aug. 16, 2015, 9:18 p.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- Trivial change involving adding more logging to the scheduler library while sending/receiving events. Diffs - src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a Diff: https://reviews.apache.org/r/37510/diff/ Testing --- make check Thanks, Anand Mazumdar
Review Request 37509: Log Scheduler HTTP API Requests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37509/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- We were not logging the API requests for the HTTP scheduler API. Diffs - src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e Diff: https://reviews.apache.org/r/37509/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37024: Exposes mesos version information in components.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review95552
---
Patch looks great!
Reviews applied: [37024]
All tests passed.
- Mesos ReviewBot
On Aug. 16, 2015, 5:38 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---
(Updated Aug. 16, 2015, 5:38 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
---
Add an endpoint that exposes component version.
Diffs
-
include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2
include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd
src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5
src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02
src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version_info.hpp PRE-CREATION
src/version/version_info.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
---
Manual test result:
```
$ curl http://localhost:5050/version 2/dev/null|jq .
{
version: 0.24.0,
build_user: haosdent,
build_time: 1439702338,
build_date: 2015-08-16 13:18:58
}
```
Thanks,
haosdent huang
Re: Review Request 37510: Add more logging to the scheduler library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95554 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 9:18 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/ --- (Updated 八月 16, 2015, 9:18 p.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- Trivial change involving adding more logging to the scheduler library while sending/receiving events. Diffs - src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a Diff: https://reviews.apache.org/r/37510/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37410: Disallow copy construction/assignment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37410/ --- (Updated Aug. 16, 2015, 8:40 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Rebased Repository: mesos Description --- Disallow copy construction/assignment for the Mesos scheduler library. Diffs (updated) - include/mesos/v1/scheduler.hpp c939de3777fd52dae313a012987e29f35d17b1fc Diff: https://reviews.apache.org/r/37410/diff/ Testing --- make check Thanks, Anand Mazumdar
Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/ --- Review request for mesos. Bugs: MESOS-3264 https://issues.apache.org/jira/browse/MESOS-3264 Repository: mesos Description --- Add destruct ShutdownHook in java MesosExecutorDriver. Diffs - src/java/src/org/apache/mesos/MesosExecutorDriver.java 6741b3239daa435045ab01f830cf495dd2e65a3f Diff: https://reviews.apache.org/r/37508/diff/ Testing --- Thanks, haosdent huang
Review Request 37510: Add more logging to the scheduler library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Trivial change involving adding more logging to the scheduler library while sending/receiving events. Diffs - src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a Diff: https://reviews.apache.org/r/37510/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37510: Add more logging to the scheduler library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95551 --- Ship it! Ship It! - Vinod Kone On Aug. 16, 2015, 9:18 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/ --- (Updated Aug. 16, 2015, 9:18 p.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- Trivial change involving adding more logging to the scheduler library while sending/receiving events. Diffs - src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a Diff: https://reviews.apache.org/r/37510/diff/ Testing --- make check Thanks, Anand Mazumdar
Review Request 37513: added Scrapinghub to powered by mesos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37513/ --- Review request for mesos. Bugs: MESOS-3276 https://issues.apache.org/jira/browse/MESOS-3276 Repository: mesos Description --- added Scrapinghub to powered by mesos Diffs - docs/powered-by-mesos.md 13a8fb1192001f9ebedfb38bb291af02b58e879c Diff: https://reviews.apache.org/r/37513/diff/ Testing --- Thanks, Shuai Lin
