Re: Review Request 37247: Added Docker image reference store.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review96659
---

Ship it!


Ship It!


src/slave/containerizer/provisioners/docker/reference_store.hpp (line 49)


Add a TODO somewhere for this.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 171)


Check the result and log if something went wrong.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 193)


more specific reasons like: Skipped loading image due to missing layers



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 197)


Loaded instead of Obtained


- Timothy Chen


On Aug. 26, 2015, 5:57 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37247/
> ---
> 
> (Updated Aug. 26, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Timothy Chen.
> 
> 
> Bugs: MESOS-3021
> https://issues.apache.org/jira/browse/MESOS-3021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Docker image reference store.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/messages/docker_provisioner.hpp PRE-CREATION 
>   src/messages/docker_provisioner.proto PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37247/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tests will be added in a later review.
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review96661
---



src/master/http.cpp (line 525)


adjust alignment.


- Guangya Liu


On Aug. 4, 2015, 2:32 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Aug. 4, 2015, 2:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
>   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
>   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---

(Updated Aug. 27, 2015, 1:38 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Fixed open issues.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Changed hashmap, hashset to use std::unordered_{set,map} instead of 
boost::unordered_{set,map}.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
25684a405bfa9c4ab65641568341652a8efaf925 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
ecab60a21765c58b0732de747509aa6382d31c06 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
a8573ed67e20b5206afd69bab4f5dc094a7e882f 
  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
3802a29b82da57217dd75c6b1611fd21c91cfc03 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
b625ffaeb3672f58fbd9558a868f87404e659c53 

Diff: https://reviews.apache.org/r/37187/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---

(Updated Aug. 27, 2015, 1:39 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Fixed open issues.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Added std::hash template specializations.


Diffs (updated)
-

  3rdparty/libprocess/include/process/address.hpp 
df78f8e525c40b87e734e16979d3315f89e12594 
  3rdparty/libprocess/include/process/pid.hpp 
8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
  3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
  3rdparty/libprocess/src/tests/http_tests.cpp 
c22f9d35b5dc959ce9816d3358ebff92b853bf52 

Diff: https://reviews.apache.org/r/37188/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

[Jan Schlicht]

> On Aug. 26, 2015, 11:13 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/pid.hpp, line 153
> > 
> >
> > there is an extra space hiding here :-)

There was another one in line 140, removed that one as well.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96593
---


On Aug. 27, 2015, 1:39 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> ---
> 
> (Updated Aug. 27, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c22f9d35b5dc959ce9816d3358ebff92b853bf52 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37188: Added std::hash template specializations.

[Jan Schlicht]

> On Aug. 26, 2015, 11:13 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/http_tests.cpp, line 806
> > 
> >
> > I think we tend to put a new line after an expression that doesn't fit 
> > on 1 line.
> > Same for the one below.

I added some new lines.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96593
---


On Aug. 27, 2015, 1:39 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> ---
> 
> (Updated Aug. 27, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c22f9d35b5dc959ce9816d3358ebff92b853bf52 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---

(Updated Aug. 27, 2015, 1:42 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Added new lines & converted hash_value to std::hash in v1/mesos.hpp.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Added std::hash template specializations.


Diffs (updated)
-

  include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
  include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
  src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
  src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
  src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
  src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
  src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
  src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
  src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
  src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 

Diff: https://reviews.apache.org/r/37189/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96672
---


There's an instance of `hash_value` still in 
`3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp` currently.
Turns out `boost::hash_combine(seed, value)` combines the result of 
`hash_value(value)` into `seed` which makes this work.
We'll replace `boost::hash_combine` in a follow-up patch, for now let's change 
`hash_value` for `net::IP` into `std::hash`.
This subsequently requires updating 2 callsites of `boost::hash_combine`, one 
in `3rdparty/libprocess/include/process/address.hpp` and the other in 
`3rdparty/libprocess/src/pid.cpp`.


3rdparty/libprocess/src/pid.cpp (line 153)


This is 81 chars, we could either `s/upid/pid/`, or wrap the argument. I'll 
leave this up to you.


- Michael Park


On Aug. 27, 2015, 11:39 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> ---
> 
> (Updated Aug. 27, 2015, 11:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c22f9d35b5dc959ce9816d3358ebff92b853bf52 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96673
---


It looks like there's an unused instance of `hash_value` in 
`src/linux/routing/filter/ip.hpp`. Can we get rid of that one?

- Michael Park


On Aug. 27, 2015, 11:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 11:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37188: Added std::hash template specializations.

[Michael Park]

> On Aug. 26, 2015, 9:13 p.m., Joris Van Remoortere wrote:
> > @Mpark: For the standard hashers, do we want to follow this pattern?
> > ```
> > template <>
> >   struct hash {
> > 
> > typedef size_t result_type;
> > 
> > typedef T argument_type;
> > 
> > result_type operator()(const argument_type &that) const {
> >   // body
> > }
> > 
> >   };
> > ```
> > 
> > Are we replacing all uses of the hash based boost containers? If so, should 
> > we clean up the remaining instances of `hash_value` implementations? 
> > Grepping through I still see some.

@Joris: Thanks for the review!

@Jan:
  (1) Let's follow the pattern Joris mentions above since the standard 
technically requires the `result_type`, and `argument_type` typedefs.
  (2) I've pointed out the parts where `hash_value` is still left over in the 
codebase more specifically in the reviews, let's take care of those as well.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96593
---


On Aug. 27, 2015, 11:39 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> ---
> 
> (Updated Aug. 27, 2015, 11:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c22f9d35b5dc959ce9816d3358ebff92b853bf52 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96675
---


Patch looks great!

Reviews applied: [37187, 37188, 37189]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 11:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 11:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37427: Docker registry: adding TokenManager.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96685
---



src/tests/provisioners/docker_provisioner_tests.cpp (lines 52 - 82)


*IF* we can't generalize the SSL testing class (comment below), then let's 
move openssl_util.hpp into the libprocess public headers instead so we don't 
have to do this.



src/tests/provisioners/docker_provisioner_tests.cpp (lines 229 - 231)


Can you pull `SSLTest` out of `ssl_tests.cpp` into an accessible place so 
you can re-use it?
I think this is worth it right now.


- Joris Van Remoortere


On Aug. 26, 2015, 1:03 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> ---
> 
> (Updated Aug. 26, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 37289: Corrected the comments for DRFSorter::dirty.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/#review96686
---

Ship it!


Ship It!

- Michael Park


On Aug. 14, 2015, 12:06 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37289/
> ---
> 
> (Updated Aug. 14, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3245
> https://issues.apache.org/jira/browse/MESOS-3245
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected the comments for DRFSorter::dirty.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> f66ade06c6a5b4bf816839477cec2d18036c7b1a 
> 
> Diff: https://reviews.apache.org/r/37289/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---

(Updated Aug. 27, 2015, 5:12 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Add result_type, argument_type for std::hash specializations.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Changed hashmap, hashset to use std::unordered_{set,map} instead of 
boost::unordered_{set,map}.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
25684a405bfa9c4ab65641568341652a8efaf925 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
ecab60a21765c58b0732de747509aa6382d31c06 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
0b745866d0fe15335ac46cff53643e6770e18357 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
a8573ed67e20b5206afd69bab4f5dc094a7e882f 
  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
3802a29b82da57217dd75c6b1611fd21c91cfc03 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
b625ffaeb3672f58fbd9558a868f87404e659c53 

Diff: https://reviews.apache.org/r/37187/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---

(Updated Aug. 27, 2015, 5:14 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Add result_type, argument_type for std::hash specializations.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Added std::hash template specializations.


Diffs (updated)
-

  3rdparty/libprocess/include/process/address.hpp 
df78f8e525c40b87e734e16979d3315f89e12594 
  3rdparty/libprocess/include/process/pid.hpp 
8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
  3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
  3rdparty/libprocess/src/tests/http_tests.cpp 
c22f9d35b5dc959ce9816d3358ebff92b853bf52 

Diff: https://reviews.apache.org/r/37188/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---

(Updated Aug. 27, 2015, 5:15 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Add result_type, argument_type for std::hash specializations.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

Added std::hash template specializations.


Diffs (updated)
-

  include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
  include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
  src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
  src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
  src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
  src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
  src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
  src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
  src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
  src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
  src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 

Diff: https://reviews.apache.org/r/37189/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96689
---


Patch looks great!

Reviews applied: [37187, 37188, 37189]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 3:15 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 3:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---

(Updated Aug. 27, 2015, 6:24 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Remove unused std::hash


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description (updated)
---

[3/3] Mesos: Added std::hash template specializations.


Diffs (updated)
-

  include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
  include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
  src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
  src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
  src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
  src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
  src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
  src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
  src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
  src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
  src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 

Diff: https://reviews.apache.org/r/37189/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---

(Updated Aug. 27, 2015, 6:22 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description (updated)
---

[1/3] Changed hashmap, hashset to use std::unordered_{set,map} instead of 
boost::unordered_{set,map}.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
25684a405bfa9c4ab65641568341652a8efaf925 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
ecab60a21765c58b0732de747509aa6382d31c06 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
0b745866d0fe15335ac46cff53643e6770e18357 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
a8573ed67e20b5206afd69bab4f5dc094a7e882f 
  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
3802a29b82da57217dd75c6b1611fd21c91cfc03 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
b625ffaeb3672f58fbd9558a868f87404e659c53 

Diff: https://reviews.apache.org/r/37187/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---

(Updated Aug. 27, 2015, 6:23 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Move header.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description (updated)
---

[2/3] libprocess: Added std::hash template specializations.


Diffs (updated)
-

  3rdparty/libprocess/include/process/address.hpp 
df78f8e525c40b87e734e16979d3315f89e12594 
  3rdparty/libprocess/include/process/pid.hpp 
8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
  3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
  3rdparty/libprocess/src/tests/http_tests.cpp 
c22f9d35b5dc959ce9816d3358ebff92b853bf52 

Diff: https://reviews.apache.org/r/37188/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated Aug. 27, 2015, 9:24 a.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-2964
https://issues.apache.org/jira/browse/MESOS-2964


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Joseph Wu]

> On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote:
> >

Thanks for your comments!


> On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote:
> > include/mesos/mesos.proto, line 101
> > 
> >
> > It might be useful to specify what the epoch is (e.g., 
> > seconds-since-Unix-epoch).

The `seconds` field actually just expresses "seconds" (like a `Duration` 
object, rather than a `Time` object).  In the next review in this chain, we use 
this protobuf twice, once as "epoch seconds" and once as a duration.


> On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote:
> > include/mesos/mesos.proto, line 102
> > 
> >
> > BTW, have you considered using a simpler representation, such as just a 
> > single int64 holding # of nanoseconds (or microseconds) since the Unix 
> > epoch? Using nanoseconds you'd be able to express ~292 years -- maybe 
> > that's not a wide enough range?

We were aiming at something that could be used like the `struct timespec`.  So 
rather than the range of times that can be represented, we were looking for 
usability (would you rather think in terms of seconds or millions of 
nanoseconds?); with the option for extra precision.

(It would be somewhat simpler, code-wise, to just use nanoseconds.)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96648
---


On Aug. 26, 2015, 3:56 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 26, 2015, 3:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict 
> with Duration.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Joseph Wu]

> On Aug. 26, 2015, 11 p.m., Alexander Rukletsov wrote:
> > Do you plan to migrate existing protobufs to `TimeSpec` or use it for new 
> > protobufs only?

For now, the plan is to have new protobufs use it.  And we can change existing 
protobufs to use it, if they benefit from having integer time.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96638
---


On Aug. 26, 2015, 3:56 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 26, 2015, 3:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict 
> with Duration.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96702
---


Patch looks great!

Reviews applied: [37187, 37188, 37189]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 4:24 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [3/3] Mesos: Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37826/#review96709
---

Ship it!


Ship It!

Note: This would be useful for maintenance primitives too!

- Joseph Wu


On Aug. 26, 2015, 8:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37826/
> ---
> 
> (Updated Aug. 26, 2015, 8:38 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 57d5fdf45273c620655b44b5f5572290cffa4bf6 
> 
> Diff: https://reviews.apache.org/r/37826/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37827/#review96713
---

Ship it!



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 179 - 181)


From the method name, I think it's not completely obvious what the type is.

Since I wouldn't want to type `Try>` 
either, you could consider renaming to something like 
`protobuf::parseRepeated`.


- Joseph Wu


On Aug. 26, 2015, 8:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37827/
> ---
> 
> (Updated Aug. 26, 2015, 8:38 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> c56d6a3098293eb3659b3066f10e875927ec3ac3 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
> cfc2803e42284f641879fb24bce1282215c8ea52 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
> a1d4084661345f9367c75f9db61279f032b93e69 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 
> bbd36d39e9588eb8eea6d739451ad3bab029ca08 
> 
> Diff: https://reviews.apache.org/r/37827/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> **NOTE**: Filed 
> [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to clean up 
> protobuf generation.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/#review96715
---

Ship it!


LGTM, modulo the comment I made in the previous review.

- Joseph Wu


On Aug. 26, 2015, 8:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37830/
> ---
> 
> (Updated Aug. 26, 2015, 8:38 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
> 
> Diff: https://reviews.apache.org/r/37830/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 36404: Added support for peek() to process::io

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/#review96720
---


Patch looks great!

Reviews applied: [36999, 36646, 36404]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 4:24 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36404/
> ---
> 
> (Updated Aug. 27, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-2964
> https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/io.hpp 
> 975923f40f82357f31b89428f24d01df6a8ac9fc 
>   3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> c642bab9e2845668767ad237985cb9ce1109 
> 
> Diff: https://reviews.apache.org/r/36404/diff/
> 
> 
> Testing
> ---
> 
> - Added a test case for process::io::peek
> - make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---

(Updated Aug. 27, 2015, 8:02 p.m.)


Review request for mesos, Alexander Rojas and Michael Park.


Changes
---

Add std::hash again: it's used if compiled with 
`--with-network-isolator`


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

[3/3] Mesos: Added std::hash template specializations.


Diffs (updated)
-

  include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
  include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
  src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
  src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
  src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
  src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
  src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
  src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
  src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
  src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
  src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 

Diff: https://reviews.apache.org/r/37189/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Neil Conway]

> On Aug. 27, 2015, 5:34 a.m., Neil Conway wrote:
> > include/mesos/mesos.proto, line 102
> > 
> >
> > BTW, have you considered using a simpler representation, such as just a 
> > single int64 holding # of nanoseconds (or microseconds) since the Unix 
> > epoch? Using nanoseconds you'd be able to express ~292 years -- maybe 
> > that's not a wide enough range?
> 
> Joseph Wu wrote:
> We were aiming at something that could be used like the `struct 
> timespec`.  So rather than the range of times that can be represented, we 
> were looking for usability (would you rather think in terms of seconds or 
> millions of nanoseconds?); with the option for extra precision.
> 
> (It would be somewhat simpler, code-wise, to just use nanoseconds.)

Fair enough. For what it is worth, personally I find a single field to be more 
usable than an embedded message with two fields, one of which is optional. 
If/when humans are generating/reading messages, I agree that seconds would be 
simpler.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96648
---


On Aug. 26, 2015, 10:56 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 26, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict 
> with Duration.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96732
---


Patch looks great!

Reviews applied: [37187, 37188, 37189]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 6:02 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 6:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [3/3] Mesos: Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Joseph Wu]

> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, line 56
> > 
> >
> > I'm not sure `0` is a valid protobuf tag.

After double checking the docs... It is valid for enums: 
https://developers.google.com/protocol-buffers/docs/proto#enum (But not valid 
for non-enums.)

For example: 
https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L434


> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 136
> > 
> >
> > Why do we need this message? I've checked several following patches and 
> > haven't seen any use cases. Shall I look further up review chain?

We use this later on when we add the `/maintenance/start` and 
`/maintenance/stop` endpoints, which both take a list of machines.
However, considering this https://reviews.apache.org/r/37826/ new review, it 
may not be necessary for much longer.


> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > src/Makefile.am, line 913
> > 
> >
> > Looks like we maintain alphabetical order here.

Good catch.  I think the `EXECUTOR_PROTO` and `ISOLATOR_PROTO` threw me off :)


> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, lines 31-37
> > 
> >
> > IIUC, here you group a bunch of machines based on time intervals. Why 
> > this grouping is necessary? We can simplify the design significantly and 
> > reduce the number of protobufs if we represent schedule by a set of 
> > maintenance events, each per machine, which may occasionally overlap in 
> > time.
> > 
> > See my comment in https://reviews.apache.org/r/37314 with a proposal 
> > for a joined "maintenance event" message.

We should definitely discuss this further.

The motivation behind this "schedule" and "window" representation is that 
operators generally think in these terms too.  Since these protos are what the 
operators are expected to use to interact with maintenance primitives, we'd 
like it to match their understanding.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96642
---


On Aug. 27, 2015, 11:58 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 11:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---

(Updated Aug. 27, 2015, 11:58 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Address some of Alex's comments.


Bugs: MESOS-3066
https://issues.apache.org/jira/browse/MESOS-3066


Repository: mesos


Description
---

* MachineInfo - Describes a single box that holds one or more agents.
* MachineInfos - A list of boxes.
* maintenance::Window - A set of machines and a planned downtime period.
* maintenance::Schedule - A set of maintenance windows.
* maintenance::Mode - An enum for the three states of maintenance: Normal, 
Draining, Deactivated.
* Registry::MaintenanceStatus - Holds the maintenance mode of a machine.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp PRE-CREATION 
  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 

Diff: https://reviews.apache.org/r/36571/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 36620: Added Non-Freezeer Task Killer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96734
---


What's the status on this review? Is it still WIP?

Would love to get this patch in given the perf ROOT tests are always broken on 
newer kernels.


src/linux/cgroups.cpp (lines 1776 - 1791)


Could you please introduce a new function under cgroups namespace and put 
this logic there:

```
// Kill all processes in the given cgroup.
Future cgroups::kill(
const string& hierarchy,
const string& cgroup)
{
  ...
  if (freezerCheckError.isNone()) {
  } else {
  }
  
  return ...;
}
```

You may want to rename the exsiting `cgroups::kill(hierarchy, cgroup, 
signal)` to `cgroups::signal`.


- Jie Yu


On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> ---
> 
> (Updated Aug. 24, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
> https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

[Joris Van Remoortere]

> On Aug. 26, 2015, 7:03 p.m., Joris Van Remoortere wrote:
> > src/master/http.cpp, line 1448
> > 
> >
> > I don't know if we require a new line here. I wouldn't mind one. 
> > thoughts?
> 
> Joseph Wu wrote:
> It'll run over 80 characters without the newline.

Sorry, i meant between statements. Not to go over 80 characters.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96567
---


On Aug. 26, 2015, 9:46 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37325/
> ---
> 
> (Updated Aug. 26, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2067 and MESOS-3069
> https://issues.apache.org/jira/browse/MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-3069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint: /maintenance.schedule
> 
> Registry operation = maintenance::UpdateSchedule
>   Replaces the schedule with the given one.  Also sets all scheduled machines 
> into Draining mode.
> 
> Other changes:
>   Added a note about the "strict" flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/maintenance.hpp PRE-CREATION 
>   src/master/maintenance.cpp PRE-CREATION 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 
>   src/tests/maintenance.hpp PRE-CREATION 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
>   src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 
> 
> Diff: https://reviews.apache.org/r/37325/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> New Tests:
>   RegistrarTest.UpdateMaintenanceSchedule
> Schedules 3 machines, 1 at a time.  Rearranges schedules.
> Checks that machines are put into Draining mode.  Removes machines.
>   MasterMaintenanceTest.UpdateSchedule
> Hits the new endpoint with some valid and invalid schedules.
> Only tests a subset of invalid schedules (requires other endpoints to 
> fully test).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37188: Added std::hash template specializations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96738
---

Ship it!


Ship It!

- Michael Park


On Aug. 27, 2015, 4:23 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> ---
> 
> (Updated Aug. 27, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [2/3] libprocess: Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c22f9d35b5dc959ce9816d3358ebff92b853bf52 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/#review96736
---

Ship it!


Ship It!

- Michael Park


On Aug. 27, 2015, 4:22 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37187/
> ---
> 
> (Updated Aug. 27, 2015, 4:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [1/3] Changed hashmap, hashset to use std::unordered_{set,map} instead of 
> boost::unordered_{set,map}.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 25684a405bfa9c4ab65641568341652a8efaf925 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> ecab60a21765c58b0732de747509aa6382d31c06 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 0b745866d0fe15335ac46cff53643e6770e18357 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
> a8573ed67e20b5206afd69bab4f5dc094a7e882f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
> 3802a29b82da57217dd75c6b1611fd21c91cfc03 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
> b625ffaeb3672f58fbd9558a868f87404e659c53 
> 
> Diff: https://reviews.apache.org/r/37187/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 37189: Added std::hash template specializations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96739
---

Ship it!


Ship It!

- Michael Park


On Aug. 27, 2015, 6:02 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> ---
> 
> (Updated Aug. 27, 2015, 6:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [3/3] Mesos: Added std::hash template specializations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---

(Updated Aug. 27, 2015, 12:33 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Rebase on master (patch needed an update).


Bugs: MESOS-3066
https://issues.apache.org/jira/browse/MESOS-3066


Repository: mesos


Description
---

* MachineInfo - Describes a single box that holds one or more agents.
* MachineInfos - A list of boxes.
* maintenance::Window - A set of machines and a planned downtime period.
* maintenance::Schedule - A set of maintenance windows.
* maintenance::Mode - An enum for the three states of maintenance: Normal, 
Draining, Deactivated.
* Registry::MaintenanceStatus - Holds the maintenance mode of a machine.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp PRE-CREATION 
  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 

Diff: https://reviews.apache.org/r/36571/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96742
---



include/mesos/mesos.proto (lines 101 - 102)


What are we representing here? Is this a duration or a date? I.e., since 
the epoch?

My suggestion is to have a DurationInfo and DateInfo and that let's us 
iterate on DateInfo and add things like time zones in the future.


- Benjamin Hindman


On Aug. 26, 2015, 10:56 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 26, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict 
> with Duration.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96743
---

Ship it!



include/mesos/mesos.proto (lines 926 - 927)


Why do we need the URL? Can we comment for folks so they know what they 
might need/use this for?


- Benjamin Hindman


On Aug. 26, 2015, 5:46 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 26, 2015, 5:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/
---

(Updated Aug. 27, 2015, 8:11 p.m.)


Review request for mesos.


Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322


Repository: mesos


Description
---

See MESOS-3322.


Diffs (updated)
-

  LICENSE c3aaa437af10533132698df3348114195d338965 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/37824/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 37823: libprocess: Update vendored copy of google-glog to 0.3.4

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37823/
---

(Updated Aug. 27, 2015, 8:11 p.m.)


Review request for mesos.


Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322


Repository: mesos


Description
---

This means we no longer need to apply a custom patch to glog.
Fixes MESOS-3322.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
997cc0d0e316e316136d4746e50e9e292a82b36b 
  3rdparty/libprocess/3rdparty/Makefile.am 
eb34251d24b1e5d1540151b59cf1062ca85aeb03 
  3rdparty/libprocess/3rdparty/glog-0.3.3.patch 
76b8c0fe3b4615371e265bab713d62c896b7c3d6 
  3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 
92fa52d296fea2884bd58d6010b0f869611999f7 
  3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
f44c7153166225279b973615ef0441c6f945da5b 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
12506a1369de005285268f895f365aba0c560f78 

Diff: https://reviews.apache.org/r/37823/diff/


Testing
---

Rebuilt, "make check". Briefly tested building with cmake, although that seems 
broken on my machine for reasons unrelated to glog.


Thanks,

Neil Conway

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---

(Updated Aug. 27, 2015, 1:14 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
---

Break TimeSpec into TimeInfo and DurationInfo, so as to explicitly form the 
type wherever it is used.


Bugs: MESOS-3299
https://issues.apache.org/jira/browse/MESOS-3299


Repository: mesos


Description (updated)
---

Instead of using doubles, time and duration can be represented as integers for 
nanoseconds.

This will be important if frameworks need to compare times to make decisions 
(such as for maintenance primitives).

Note about the naming:

* TimeInfo will directly correspond with the Time class.
* DurationInfo will directly correspond with the Duration class.


Diffs (updated)
-

  include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37655/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/#review96747
---


Bad patch!

Reviews applied: [37823]

Failed command: ./support/apply-review.sh -n -r 37823

Error:
 2015-08-27 20:25:09 URL:https://reviews.apache.org/r/37823/diff/raw/ 
[9017/9017] -> "37823.patch" [1]
error: missing binary patch data for 
'3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: binary patch does not apply to 
'3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 27, 2015, 8:11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37824/
> ---
> 
> (Updated Aug. 27, 2015, 8:11 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3322
> https://issues.apache.org/jira/browse/MESOS-3322
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3322.
> 
> 
> Diffs
> -
> 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/37824/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 37853: Overlay filesystem provisioning backend

[Mei Wan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

Review request for mesos.


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs
-

  src/Makefile.am 7b620ff 
  src/slave/containerizer/provisioners/backend.cpp 2f7c335 
  src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96746
---

Ship it!



include/mesos/maintenance/maintenance.proto (line 54)


How about we move Mode into MachineInfo so that we can use this as a 
property of machines regardless of whether or not we're doing maintenance? 
I.e., MachineInfo::DRAINING.



include/mesos/mesos.proto (line 127)


This stuff also needs to go into v1 please!



src/master/registry.proto (line 43)


If we ever want to capture non-maintenance information about machines here 
I'd recommend that we s/MaintenanceStatus/MachineStatus/, and for now with only 
one field ('machine_info') that we might add to later. Meanwhile, we can move 
'mode' into MachineInfo and make the current MachineInfo be a MachineID ...


- Benjamin Hindman


On Aug. 27, 2015, 7:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Vinod Kone]

> On Aug. 27, 2015, 6:04 a.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, line 56
> > 
> >
> > I'm not sure `0` is a valid protobuf tag.
> 
> Joseph Wu wrote:
> After double checking the docs... It is valid for enums: 
> https://developers.google.com/protocol-buffers/docs/proto#enum (But not valid 
> for non-enums.)
> 
> For example: 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L434

I would strongly recommend to use a start value of 1 instead of 0 because it's 
hard to tell the difference between an enum being unset to enum being set to 
the first value. This is especially true if the enum is going to be used as 
optional. Looks like it is used as a required field for now, but who knows.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96642
---


On Aug. 27, 2015, 7:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36620: Added Non-Freezeer Task Killer.

[Timothy Chen]

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote:
> > src/linux/cgroups.cpp, lines 1776-1791
> > 
> >
> > Could you please introduce a new function under cgroups namespace and 
> > put this logic there:
> > 
> > ```
> > // Kill all processes in the given cgroup.
> > Future cgroups::kill(
> > const string& hierarchy,
> > const string& cgroup)
> > {
> >   ...
> >   if (freezerCheckError.isNone()) {
> >   } else {
> >   }
> >   
> >   return ...;
> > }
> > ```
> > 
> > You may want to rename the exsiting `cgroups::kill(hierarchy, cgroup, 
> > signal)` to `cgroups::signal`.

Hi jie, thanks for chiming in. This should be ready after the comments are 
addressed. I'll try to merge this as well when it's done. I'll ping Joerg about 
this.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96734
---


On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> ---
> 
> (Updated Aug. 24, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
> https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37812: Used linux filesystem isolator by default if possible.

[Jie Yu]

> On Aug. 27, 2015, 12:03 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 145
> > 
> >
> > This is quite subtle, I think we should log and also put some 
> > documentation around slave that we only choose linux filesystem by default 
> > with root.

The logging is already there (see code below): `LOG(INFO) << "Using isolation: 
" << isolation;`

Adjusted the comments above.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96615
---


On Aug. 26, 2015, 9:04 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> ---
> 
> (Updated Aug. 26, 2015, 9:04 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used linux filesystem isolator by default if possible.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 377de50da90edd64dab812fda3730fa4d7d63b13 
> 
> Diff: https://reviews.apache.org/r/37812/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37314/#review96748
---

Ship it!



include/mesos/type_utils.hpp (lines 152 - 153)


Let's check for the presence of the fields first see other examples below.



src/master/master.hpp (lines 893 - 896)


hashmap machines;

struct {
  std::list<...> schedules;
} maintenance;

maintenance.schedules...;


- Benjamin Hindman


On Aug. 26, 2015, 6:49 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37314/
> ---
> 
> (Updated Aug. 26, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3045
> https://issues.apache.org/jira/browse/MESOS-3045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note: Tests will be added with the related HTTP endpoints and registrar 
> operations, later in this review chain.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37314/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37812: Used linux filesystem isolator by default if possible.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/
---

(Updated Aug. 27, 2015, 9:05 p.m.)


Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Changes
---

Added more comments.


Repository: mesos


Description
---

Used linux filesystem isolator by default if possible.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
377de50da90edd64dab812fda3730fa4d7d63b13 

Diff: https://reviews.apache.org/r/37812/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/
---

Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
---

Ensured that cgroups isolation is not used if multiple slaves are launched.


Diffs
-

  src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
  src/tests/event_call_framework_test.sh 
8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
  src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
  src/tests/no_executor_framework_test.sh 
b5bb111ceb99d4dc836537516de57c1ba0582371 
  src/tests/persistent_volume_framework_test.sh 
c96fb707c4c05a21dac17c4e73d7fac3493f920e 
  src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
  src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 

Diff: https://reviews.apache.org/r/37856/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96755
---

Ship it!



include/mesos/mesos.proto (line 100)


How about a TODO that suggests adding time zone information?


- Benjamin Hindman


On Aug. 27, 2015, 8:14 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 27, 2015, 8:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, time and duration can be represented as integers 
> for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * TimeInfo will directly correspond with the Time class.
> * DurationInfo will directly correspond with the Duration class.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

[Jie Yu]

The patch looks great! Thanks Mei!

Looks like you've already rebased your patch to the current master, am I
right?

- Jie

On Thu, Aug 27, 2015 at 1:50 PM, Mei Wan  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Implemented the overlay filesystem backend by layering the images as a
> read-only filesystem.
>
>
> Diffs
> -
>
>   src/Makefile.am 7b620ff
>   src/slave/containerizer/provisioners/backend.cpp 2f7c335
>   src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION
>   src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37853/diff/
>
>
> Testing
> ---
>
> I haven't done any official testing. When I was working off Ian's branch,
> I tested it manually and the provisioning works.
>
>
> Thanks,
>
> Mei Wan
>
>

Re: Review Request 37853: Overlay filesystem provisioning backend

[Mei Wan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Aug. 27, 2015, 9:11 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs
-

  src/Makefile.am 7b620ff 
  src/slave/containerizer/provisioners/backend.cpp 2f7c335 
  src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Vinod Kone]

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote:
> > This review is a bit hard to follow because it's doing multiple things. I 
> > would recommend you to split this into multiple reviews
> > 
> > #1) Expose framework user in state.json
> > #2) Update framework user on re-registration (need a test for this!)
> 
> Aditi Dixit wrote:
> Added the test. How do I split this into multiple reviews? Discard this 
> one and open two new ones by shifting the code into new branches and then 
> opening review requests?
> 
> Joseph Wu wrote:
> You could:
> ```
> # To update this review into the first in a review chain:
> git branch temp # Save your work.
>  # i.e. the re-registration stuff.
> git add --update
> git commit --amend
> 
> # For the second review:
> git checkout temp -- . # Restore everything you deleted into a second 
> commit.
> git commit
> 
> support/post-reviews.py
> ```

Thanks Joseph for the workflow tip. I typically do splits a little differently.

$ git reset HEAD~
$ git add -p  # Selectively add chunks of a file(s) to the index!
$ git commit -m "First review"  # Make sure to add the "Review: " line if 
you want the current review to be updated
$ git add -a # Add the rest of the changes to the index
$ git commit -m "Second review"

I'll take a look once you split and update.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96240
---


On Aug. 25, 2015, 8:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> ---
> 
> (Updated Aug. 25, 2015, 8:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
> https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user to master's state, slave's state (not exposed) and updated user in 
> all slaves that have the registered framework. Added the test too.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 37197: Docker image store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---

(Updated Aug. 27, 2015, 9:49 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
and Timothy Chen.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Stored images currently kept indefinitely.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37197/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37198: Add Docker image provisioner and copy backend.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---

(Updated Aug. 27, 2015, 9:51 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Changes
---

Replaced docker-specific backend with shared backend and addressed style 
comments.


Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850


Repository: mesos


Description (updated)
---

Add Docker image provisioner.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
4ff1c463efc527e239317ffa2d8a5607b11d2607 
  src/slave/containerizer/provisioner.hpp 
541dd4e0b2f0c92a45c00cab6132a2be69654838 
  src/slave/containerizer/provisioner.cpp 
efc7e6996ff6663bebaf61989a7e040bd2ad7a5e 
  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
  src/tests/containerizer/provisioner.hpp 
a26b8138d8cc3086058b15a797dd15354a84019f 

Diff: https://reviews.apache.org/r/37198/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---

(Updated Aug. 27, 2015, 9:52 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Refactored DockerImage struct to store a list of layer ids instead of linked 
list of DockerLayers.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37200/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 27, 2015, 9:54 p.m.)


Review request for mesos, Till Toenshoff and Timothy Chen.


Changes
---

Addressed comments.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---

(Updated Aug. 27, 2015, 9:55 p.m.)


Review request for mesos, Till Toenshoff and Timothy Chen.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Move docker provisioner local store into dedicated folders.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37496/diff/


Testing
---

sudo make check 
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 27, 2015, 9:54 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

[Bernd Mathiske]

> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 458
> > 
> >
> > Is it common knowledge that the sandbox holds the logs?  (If not, a 
> > short comment would suffice.)

It kinda is, but it will be reasonable to state this here in a comment.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
---


On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> ---
> 
> (Updated Aug. 26, 2015, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f 
> 
> Diff: https://reviews.apache.org/r/37813/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX, where the bug showed up.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Re: Review Request 37812: Used linux filesystem isolator by default if possible.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96769
---

Ship it!


Ship It!

- Timothy Chen


On Aug. 27, 2015, 9:05 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> ---
> 
> (Updated Aug. 27, 2015, 9:05 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used linux filesystem isolator by default if possible.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 377de50da90edd64dab812fda3730fa4d7d63b13 
> 
> Diff: https://reviews.apache.org/r/37812/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96770
---



src/tests/environment.cpp 


It works now?


- Timothy Chen


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/
---

(Updated Aug. 27, 2015, 9:57 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added Docker provisioner paths which handles path manipulation.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37497/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96762
---

Ship it!



src/master/http.cpp (line 1407)


This looks like something we could do during comparison or creating a hash 
but not here?



src/master/http.cpp (line 1421)


How about calling it just 'result' and then do a CHECK since it should 
always be true?



src/master/maintenance.hpp (line 84)


s/interval/unavailability/



src/tests/master_maintenance_tests.cpp (line 76)


maintenance::Schedule schedule = maintenance::createSchedule(...);

post(
  ...,
  
  JSON::Protobuf(schedule));
  
Here and everywhere else please.

Also, let's move the 'create*' functions to protobuf_utils.h|cpp and also 
make them return protobufs that we then do JSON::Protobuf on, thanks!


- Benjamin Hindman


On Aug. 26, 2015, 9:46 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37325/
> ---
> 
> (Updated Aug. 26, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2067 and MESOS-3069
> https://issues.apache.org/jira/browse/MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-3069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint: /maintenance.schedule
> 
> Registry operation = maintenance::UpdateSchedule
>   Replaces the schedule with the given one.  Also sets all scheduled machines 
> into Draining mode.
> 
> Other changes:
>   Added a note about the "strict" flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/maintenance.hpp PRE-CREATION 
>   src/master/maintenance.cpp PRE-CREATION 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 
>   src/tests/maintenance.hpp PRE-CREATION 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
>   src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 
> 
> Diff: https://reviews.apache.org/r/37325/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> New Tests:
>   RegistrarTest.UpdateMaintenanceSchedule
> Schedules 3 machines, 1 at a time.  Rearranges schedules.
> Checks that machines are put into Draining mode.  Removes machines.
>   MasterMaintenanceTest.UpdateSchedule
> Hits the new endpoint with some valid and invalid schedules.
> Only tests a subset of invalid schedules (requires other endpoints to 
> fully test).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Alexander Rukletsov]

> On Aug. 27, 2015, 6:04 a.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, lines 31-37
> > 
> >
> > IIUC, here you group a bunch of machines based on time intervals. Why 
> > this grouping is necessary? We can simplify the design significantly and 
> > reduce the number of protobufs if we represent schedule by a set of 
> > maintenance events, each per machine, which may occasionally overlap in 
> > time.
> > 
> > See my comment in https://reviews.apache.org/r/37314 with a proposal 
> > for a joined "maintenance event" message.
> 
> Joseph Wu wrote:
> We should definitely discuss this further.
> 
> The motivation behind this "schedule" and "window" representation is that 
> operators generally think in these terms too.  Since these protos are what 
> the operators are expected to use to interact with maintenance primitives, 
> we'd like it to match their understanding.

Absolutely, we should not surprise operators. But they do not speak protobufs, 
they will be sending JSON requests, which we may convert to something 
(protobufs) that is most convenient for us in terms of storage and retrieval.


> On Aug. 27, 2015, 6:04 a.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 136
> > 
> >
> > Why do we need this message? I've checked several following patches and 
> > haven't seen any use cases. Shall I look further up review chain?
> 
> Joseph Wu wrote:
> We use this later on when we add the `/maintenance/start` and 
> `/maintenance/stop` endpoints, which both take a list of machines.
> However, considering this https://reviews.apache.org/r/37826/ new review, 
> it may not be necessary for much longer.

Yeah, I would say the API should not much influence storage decisions. As long 
as we do not use it for storage, let's avoid it in protobufs.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96642
---


On Aug. 27, 2015, 7:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96775
---


Patch looks great!

Reviews applied: [37726, 37734, 37735, 37738, 37812, 37856]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

[Jie Yu]

> On Aug. 27, 2015, 9:58 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 298
> > 
> >
> > It works now?

See my change in MultipleSlaves test. Basically, I fixed the isolation used in 
that test so that port mapping isolator won't be used.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96770
---


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96778
---



include/mesos/mesos.proto (line 97)


This will overflow in less than 247 years. Be prepared to find a different 
patch by then! :-)


- Bernd Mathiske


On Aug. 27, 2015, 1:14 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> ---
> 
> (Updated Aug. 27, 2015, 1:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of using doubles, time and duration can be represented as integers 
> for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions 
> (such as for maintenance primitives).
> 
> Note about the naming:
> 
> * TimeInfo will directly correspond with the Time class.
> * DurationInfo will directly correspond with the Duration class.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---

(Updated Aug. 27, 2015, 3:24 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem 
Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
---

Add TODO for TimeInfo time zones.


Bugs: MESOS-3299
https://issues.apache.org/jira/browse/MESOS-3299


Repository: mesos


Description
---

Instead of using doubles, time and duration can be represented as integers for 
nanoseconds.

This will be important if frameworks need to compare times to make decisions 
(such as for maintenance primitives).

Note about the naming:

* TimeInfo will directly correspond with the Time class.
* DurationInfo will directly correspond with the Duration class.


Diffs (updated)
-

  include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37655/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/#review96780
---


Bad patch!

Reviews applied: [37196, 37197, 37198, 37200]

Failed command: ./support/apply-review.sh -n -r 37200

Error:
 2015-08-27 22:38:32 URL:https://reviews.apache.org/r/37200/diff/raw/ 
[28082/28082] -> "37200.patch" [1]
37200.patch:457: trailing whitespace.
  return Failure("Untar image failed with exit code: " + 
warning: 1 line adds whitespace errors.
Successfully applied: Refactored DockerImage struct to store a list of layer 
ids instead of linked list of DockerLayers.

Refactored DockerImage struct to store a list of layer ids instead of linked 
list of DockerLayers.


Review: https://reviews.apache.org/r/37200
src/slave/containerizer/provisioners/docker/store.cpp:184: trailing whitespace.
+  return Failure("Untar image failed with exit code: " + 
Failed to commit patch

- Mesos ReviewBot


On Aug. 27, 2015, 9:57 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37497/
> ---
> 
> (Updated Aug. 27, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
> Timothy Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Docker provisioner paths which handles path manipulation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37497/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review96763
---


This looks great! Thanks Mei! I think the main thing left here is the test. You 
should be able to write some simple tests that test the overlay functionality 
(see the bind mount tests). Looking forward to the tests!


src/slave/containerizer/provisioners/backends/overlay.cpp (line 58)


You also want to check if overlay fs is supported or not. Not every linux 
kernel supports overlay fs.



src/slave/containerizer/provisioners/backends/overlay.cpp (line 98)


No need to use process:: prefix as you already have `using namespace 
process` above.

Please all such occurances in this file.



src/slave/containerizer/provisioners/backends/overlay.cpp (lines 101 - 103)


Hum, I'd like to understand why overlay backend cannot support 1 layer. Any 
reason?



src/slave/containerizer/provisioners/backends/overlay.cpp (lines 110 - 114)


Could you please add a comment about the ordering the layers will be 
stacked.

I think we should add a document at the backend interface as well stating 
that layers are stacking in such a way that the front layer in the vector will 
be the bottom most layer (i.e., applied first).

The lowerdir here should actually reverse the order of the layers vector.

```
The specified lower directories will be stacked beginning from the 
rightmost one and going left.  In the above example lower1 will be the top, 
lower2 the middle and lower3 the bottom layer.
```



src/slave/containerizer/provisioners/backends/overlay.cpp (line 111)


I think you should be able to use strings::join here:

```
strings::join(":", layers);
```


- Jie Yu


On Aug. 27, 2015, 9:11 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Aug. 27, 2015, 9:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff 
>   src/slave/containerizer/provisioners/backend.cpp 2f7c335 
>   src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/
---

(Updated Aug. 27, 2015, 3:46 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Update Unavailability to use the TimeInfo and DurationInfo.  Commenting tweaks.


Bugs: MESOS-2061 and MESOS-2066
https://issues.apache.org/jira/browse/MESOS-2061
https://issues.apache.org/jira/browse/MESOS-2066


Repository: mesos


Description
---

MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
MESOS-2066: Add the Unavailability field to Offers.

Also copied to v1 API.

No integration with other components (that part is tracked in separate JIRAs, 
see MESOS-1474).


Diffs (updated)
-

  include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/36321/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---

(Updated Aug. 27, 2015, 10:59 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched 
to 'mcypark'.


Changes
---

Fixed race condition and moved thread initialization into ProcessManager.


Bugs: MESOS-3158
https://issues.apache.org/jira/browse/MESOS-3158


Repository: mesos


Description
---

Join threads in libprocess when shutting down.


Diffs (updated)
-

  3rdparty/libprocess/src/event_loop.hpp 
36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
  3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
  3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
  3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6 

Diff: https://reviews.apache.org/r/37821/diff/


Testing (updated)
---

After configuring with both "../configure" and "../configure --enable-libevent 
--enable-ssl":

make check


Also, to check for race conditions related to the initialization/shutdown of 
libprocess, try something like:

for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
--gtest_filter=ProcessTest.Spawn; done


Thanks,

Greg Mann

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/
---

(Updated Aug. 27, 2015, 11 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Added a TODO to address generalizing functionality, addressed comments and 
rebased on master.


Bugs: MESOS-2797
https://issues.apache.org/jira/browse/MESOS-2797


Repository: mesos


Description
---

Capped number of parallel inspect instances on a docker ps call.


Diffs (updated)
-

  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/slave/constants.hpp ccfe89c44556de619139551eb988cceebc88bdb5 

Diff: https://reviews.apache.org/r/35330/diff/


Testing
---

sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure 
--gtest_shuffle --gtest_repeat=30


Thanks,

Lily Chen

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

[Timothy Chen]

> On June 16, 2015, 10:02 p.m., Ben Mahler wrote:
> > High level review, why don't we just have an abstraction for limiting the 
> > number of concurrent operations?
> > 
> > You could keep this abstraction local to this file for now and consider 
> > pulling it out into libprocess.
> > For example, rather than using a 'RateLimiter' here, we use a 
> > 'ConcurrencyLimiter':
> > 
> > ```
> > // Limits concurrency of asynchronous operations.
> > class ConcurrencyLimiter
> > {
> > public:
> >   ConcurrencyLimit(size_t concurrency);
> >   
> >   // Adds a unit of asynchronous work to execute. The work may
> >   // be postponed to ensure the concurrency limit is not violated.
> >   // Returns the result of the work.
> >   template 
> >   Future add(const std::function& work);
> > };
> > ```
> > 
> > Then you only need a fairly clean, minimal change to the existing source to 
> > leverage this, and you can use it elsewhere too.
> > Not sure if 'ConcurrencyLimiter' is the clearest name, but hopefully you 
> > get the high level idea.
> 
> Jie Yu wrote:
> +1
> 
> I like this idea! Remember that we have an abstraction `Sequence` in 
> libprocess (3rdparty/libprocess/include/process/sequence.hpp). It has the 
> same interface as this one, but the semantics is different (as you can tell 
> from the name). I would probably call it `Parallel(size_t concurrency)`.
> 
> Timothy Chen wrote:
> Hi Ben/Jie,
> 
> That sounds great to me as well! And in the end we simply just return the 
> list of all the results, so I think we can then do a collect call on all the 
> futures to aggregate the results.
> 
> Lily how does that sound to you?
> 
> Lily Chen wrote:
> This is a definitely a good idea. I'll take a look.

Going to merge this as Lily added a TODO to generalize this.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/#review88134
---


On Aug. 27, 2015, 11 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35330/
> ---
> 
> (Updated Aug. 27, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2797
> https://issues.apache.org/jira/browse/MESOS-2797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Capped number of parallel inspect instances on a docker ps call.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/slave/constants.hpp ccfe89c44556de619139551eb988cceebc88bdb5 
> 
> Diff: https://reviews.apache.org/r/35330/diff/
> 
> 
> Testing
> ---
> 
> sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure 
> --gtest_shuffle --gtest_repeat=30
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Greg Mann]

> On Aug. 27, 2015, 6:14 a.m., Neil Conway wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2212
> > 
> >
> > Somewhat race-prone: we might see "shutting_down.load() == false", 
> > proceed to deliver the inbound message, and yet the shutdown code can 
> > proceed concurrently. After a bit of poking I couldn't find a situation in 
> > which that would be problematic, but maybe worth exploring if there's a 
> > known data race/hang...

Thanks Neil, good point. It turns out the race condition was occurring in 
schedule() and was easily fixed by moving a boolean test. However, you're right 
that currently it's possible for processes to get queued up in 
ProcessManager::handle() after shutting_down has been set to true, and this is 
not great.

I could move the "if (shutting_down.load())" test closer to the actual calls to 
deliver() and dispatch(), which would require duplicating it a number of times. 
It would be messy, but would lessen the raciness. Placing the test in deliver() 
seems like a lot of unnecessary work when internal libprocess messages are 
sent, and we still want to let internal processes send/receive messages while 
they're terminating.

Perhaps there's another superior location for this test that I'm not finding?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96655
---


On Aug. 27, 2015, 10:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> ---
> 
> (Updated Aug. 27, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and 
> switched to 'mcypark'.
> 
> 
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Join threads in libprocess when shutting down.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
>   3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
>   3rdparty/libprocess/src/libevent.cpp 
> d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
>   3rdparty/libprocess/src/process.cpp 
> 755187c8761137cb2bf2f7295b29a63f63c68bc6 
> 
> Diff: https://reviews.apache.org/r/37821/diff/
> 
> 
> Testing
> ---
> 
> After configuring with both "../configure" and "../configure 
> --enable-libevent --enable-ssl":
> 
> make check
> 
> 
> Also, to check for race conditions related to the initialization/shutdown of 
> libprocess, try something like:
> 
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
> --gtest_filter=ProcessTest.Spawn; done
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96790
---



3rdparty/libprocess/src/process.cpp (line 660)


AFAICS you can make this parameter a const ref.



3rdparty/libprocess/src/process.cpp (line 2181)


Why "const long& cpus", rather than just "long cpus"?

Anyway, I think it might be better to move the calculation of "cpus" (along 
with the explanatory comment) into init_threads().



3rdparty/libprocess/src/process.cpp (line 2191)


std::cref, assuming you can change the parameter to const ref above.


- Neil Conway


On Aug. 27, 2015, 10:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> ---
> 
> (Updated Aug. 27, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and 
> switched to 'mcypark'.
> 
> 
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Join threads in libprocess when shutting down.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
>   3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
>   3rdparty/libprocess/src/libevent.cpp 
> d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
>   3rdparty/libprocess/src/process.cpp 
> 755187c8761137cb2bf2f7295b29a63f63c68bc6 
> 
> Diff: https://reviews.apache.org/r/37821/diff/
> 
> 
> Testing
> ---
> 
> After configuring with both "../configure" and "../configure 
> --enable-libevent --enable-ssl":
> 
> make check
> 
> 
> Also, to check for race conditions related to the initialization/shutdown of 
> libprocess, try something like:
> 
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
> --gtest_filter=ProcessTest.Spawn; done
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37197: Docker image store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---

(Updated Aug. 27, 2015, 11:39 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Stored images currently kept indefinitely.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37197/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37198: Add Docker image provisioner and copy backend.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---

(Updated Aug. 27, 2015, 11:40 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850


Repository: mesos


Description
---

Add Docker image provisioner.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
4ff1c463efc527e239317ffa2d8a5607b11d2607 
  src/slave/containerizer/provisioner.hpp 
541dd4e0b2f0c92a45c00cab6132a2be69654838 
  src/slave/containerizer/provisioner.cpp 
efc7e6996ff6663bebaf61989a7e040bd2ad7a5e 
  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
  src/tests/containerizer/provisioner.hpp 
a26b8138d8cc3086058b15a797dd15354a84019f 

Diff: https://reviews.apache.org/r/37198/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---

(Updated Aug. 27, 2015, 4:41 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Reworked and rearranged a lot of the protobufs, according to comments.  Added 
some ascii art for the maintenance schedule.


Bugs: MESOS-3066
https://issues.apache.org/jira/browse/MESOS-3066


Repository: mesos


Description (updated)
---

New protobufs:

* MachineAddress - Describes a single box that holds one or more agents.
* MachineAddresses - A list of boxes.
* MachineInfo - Holds a box and some extra information about its status.
* MachineInfo::Mode - An enum for the three states of a machine: UP, DRAINING, 
DOWN.
* maintenance::Window - A set of machines and a planned downtime period.
* maintenance::Schedule - A set of maintenance windows.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp PRE-CREATION 
  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 

Diff: https://reviews.apache.org/r/36571/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---

(Updated Aug. 27, 2015, 11:41 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Changes
---

Fixed typos.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Refactored DockerImage struct to store a list of layer ids instead of linked 
list of DockerLayers.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37200/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 27, 2015, 11:41 p.m.)


Review request for mesos, Till Toenshoff and Timothy Chen.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 27, 2015, 11:42 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Joseph Wu]

> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, lines 31-37
> > 
> >
> > IIUC, here you group a bunch of machines based on time intervals. Why 
> > this grouping is necessary? We can simplify the design significantly and 
> > reduce the number of protobufs if we represent schedule by a set of 
> > maintenance events, each per machine, which may occasionally overlap in 
> > time.
> > 
> > See my comment in https://reviews.apache.org/r/37314 with a proposal 
> > for a joined "maintenance event" message.
> 
> Joseph Wu wrote:
> We should definitely discuss this further.
> 
> The motivation behind this "schedule" and "window" representation is that 
> operators generally think in these terms too.  Since these protos are what 
> the operators are expected to use to interact with maintenance primitives, 
> we'd like it to match their understanding.
> 
> Alexander Rukletsov wrote:
> Absolutely, we should not surprise operators. But they do not speak 
> protobufs, they will be sending JSON requests, which we may convert to 
> something (protobufs) that is most convenient for us in terms of storage and 
> retrieval.

I think a 1-to-1 protobuf-JSON symmetry is useful for documenting both JSON and 
protobuf at once.  We'll probably keep this how it is.  However, we'll be using 
your suggested "joined message".


> On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, line 56
> > 
> >
> > I'm not sure `0` is a valid protobuf tag.
> 
> Joseph Wu wrote:
> After double checking the docs... It is valid for enums: 
> https://developers.google.com/protocol-buffers/docs/proto#enum (But not valid 
> for non-enums.)
> 
> For example: 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L434
> 
> Vinod Kone wrote:
> I would strongly recommend to use a start value of 1 instead of 0 because 
> it's hard to tell the difference between an enum being unset to enum being 
> set to the first value. This is especially true if the enum is going to be 
> used as optional. Looks like it is used as a required field for now, but who 
> knows.

Good point.  I'll increment by one.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96642
---


On Aug. 27, 2015, 4:41 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 4:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New protobufs:
> 
> * MachineAddress - Describes a single box that holds one or more agents.
> * MachineAddresses - A list of boxes.
> * MachineInfo - Holds a box and some extra information about its status.
> * MachineInfo::Mode - An enum for the three states of a machine: UP, 
> DRAINING, DOWN.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/
---

(Updated Aug. 27, 2015, 11:44 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
Timothy Chen, and Jiang Yan Xu.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added Docker provisioner paths which handles path manipulation.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37497/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---

(Updated Aug. 27, 2015, 11:43 p.m.)


Review request for mesos, Till Toenshoff and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Move docker provisioner local store into dedicated folders.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37496/diff/


Testing
---

sudo make check 
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Review Request 37863: Fixed user cgroup failing test on centos 7.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/
---

Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3294
https://issues.apache.org/jira/browse/MESOS-3294


Repository: mesos


Description
---

Fixed user cgroup failing test on centos 7.

This is due to a bug that exists in CentOS 7 where the cgroup is named 
differently under /sys/fs/cgroup.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
2755d06b0a097f46bc75fb9b830bc131f7a2255c 

Diff: https://reviews.apache.org/r/37863/diff/


Testing
---

make check on CentOS7


Thanks,

Timothy Chen

Re: Review Request 37863: Fixed user cgroup failing test on centos 7.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/#review96797
---

Ship it!



src/tests/containerizer/isolator_tests.cpp (lines 1268 - 1272)


I would do the following so that it's more easy to understand.
```
if (!os::exists(...) &&
strings::startsWith(...)) {
  // swap as you did
}
```



src/tests/containerizer/isolator_tests.cpp (line 1279)


Please remove this.


- Jie Yu


On Aug. 27, 2015, 11:52 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37863/
> ---
> 
> (Updated Aug. 27, 2015, 11:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3294
> https://issues.apache.org/jira/browse/MESOS-3294
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed user cgroup failing test on centos 7.
> 
> This is due to a bug that exists in CentOS 7 where the cgroup is named 
> differently under /sys/fs/cgroup.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 2755d06b0a097f46bc75fb9b830bc131f7a2255c 
> 
> Diff: https://reviews.apache.org/r/37863/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS7
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/#review96798
---

Ship it!


Ship It!

- Timothy Chen


On Aug. 27, 2015, 11 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35330/
> ---
> 
> (Updated Aug. 27, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2797
> https://issues.apache.org/jira/browse/MESOS-2797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Capped number of parallel inspect instances on a docker ps call.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/slave/constants.hpp ccfe89c44556de619139551eb988cceebc88bdb5 
> 
> Diff: https://reviews.apache.org/r/35330/diff/
> 
> 
> Testing
> ---
> 
> sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure 
> --gtest_shuffle --gtest_repeat=30
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96796
---



include/mesos/maintenance/maintenance.proto (lines 37 - 39)


Let's extend one of the windows to multiple lines to indicate that a single 
window can have multiple machines.



include/mesos/mesos.proto (line 164)


Let's add `Info` suffix for clarity.



src/Makefile.am (lines 156 - 157)


Don't we need to add `v1/**` protos somewhere as well?


- Alexander Rukletsov


On Aug. 27, 2015, 11:41 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> ---
> 
> (Updated Aug. 27, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New protobufs:
> 
> * MachineAddress - Describes a single box that holds one or more agents.
> * MachineAddresses - A list of boxes.
> * MachineInfo - Holds a box and some extra information about its status.
> * MachineInfo::Mode - An enum for the three states of a machine: UP, 
> DRAINING, DOWN.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96800
---

Ship it!


Ship It!


src/tests/environment.cpp 


Got it, just thought it's not related when I read the rb description.


- Timothy Chen


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96802
---


Patch looks great!

Reviews applied: [37821]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 10:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> ---
> 
> (Updated Aug. 27, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and 
> switched to 'mcypark'.
> 
> 
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Join threads in libprocess when shutting down.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
>   3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
>   3rdparty/libprocess/src/libevent.cpp 
> d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
>   3rdparty/libprocess/src/process.cpp 
> 755187c8761137cb2bf2f7295b29a63f63c68bc6 
> 
> Diff: https://reviews.apache.org/r/37821/diff/
> 
> 
> Testing
> ---
> 
> After configuring with both "../configure" and "../configure 
> --enable-libevent --enable-ssl":
> 
> make check
> 
> 
> Also, to check for race conditions related to the initialization/shutdown of 
> libprocess, try something like:
> 
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
> --gtest_filter=ProcessTest.Spawn; done
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37773: Docker: Adding registry client.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/
---

(Updated Aug. 28, 2015, 12:03 a.m.)


Review request for mesos, Lily Chen and Timothy Chen.


Changes
---

Changes after refactoring SSL test.


Summary (updated)
-

Docker: Adding registry client.


Repository: mesos


Description
---

Added implementation for docker registry's Get Manifest and Get Blob APIs.


Diffs (updated)
-

  3rdparty/libprocess/include/process/tests/ssl_test.hpp PRE-CREATION 
  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/registry_client.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/registry_client.cpp PRE-CREATION 
  src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37773/diff/


Testing
---

make check


Thanks,

Jojy Varghese

Re: Review Request 37773: Docker: Adding registry client.

[Jojy Varghese]

> On Aug. 26, 2015, midnight, Lily Chen wrote:
> >

This was a WIP for you to get the patch :). Anywaz addressed the issues.


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.hpp, line 89
> > 
> >
> > Isn't the authorization server returned as the realm in the 401 
> > response? At least for docker hub?

The tokenmanager design had token managers created per realm. So yes currently 
the design remains same. Can change if required.


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.hpp, line 157
> > 
> >
> > Fix tupo in regiistry

irony :)


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 146
> > 
> >
> > Capitalize Beginning of error messages, same applies throughout.

for internal error messages (that bubbles up), the leaf level messsages are 
recommended to start with lower case. This is so that when the root level 
logger logs the message, it does not look like : "Failed to do operation foo: 
Failed to fetch data".


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 237
> > 
> >
> > Use explicity type instead of auto and remove space between capture and 
> > parameter lists

Saw the pattern in other code. Basically, we are allowed to declare lambdas 
like this. Here the return type is void.


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 360
> > 
> >
> > should we make this some sort of constant?

Didnt seem necessary. Is not used anywhere else. URL class uses literal too.


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 412
> > 
> >
> > Is casting "" to string necessary?

Yes. Compiler cant resolve type 2 times.


> On Aug. 26, 2015, midnight, Lily Chen wrote:
> > src/tests/provisioners/docker_provisioner_tests.cpp, line 95
> > 
> >
> > If we remove a bunch of temporary files during teardown, should we 
> > consider using a TemporaryDirectoryTest?

Not sure if we need a separate class to do it. Moreover, what we are trying to 
accomplish here is to have the blobs saved in a separate dir and not it the 
tests working directory or sandbox.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review96446
---


On Aug. 28, 2015, 12:03 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37773/
> ---
> 
> (Updated Aug. 28, 2015, 12:03 a.m.)
> 
> 
> Review request for mesos, Lily Chen and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for docker registry's Get Manifest and Get Blob APIs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/tests/ssl_test.hpp PRE-CREATION 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37773/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 37863: Fixed user cgroup failing test on centos 7.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/
---

(Updated Aug. 28, 2015, 12:05 a.m.)


Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3294
https://issues.apache.org/jira/browse/MESOS-3294


Repository: mesos


Description
---

Fixed user cgroup failing test on centos 7.

This is due to a bug that exists in CentOS 7 where the cgroup is named 
differently under /sys/fs/cgroup.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
2755d06b0a097f46bc75fb9b830bc131f7a2255c 

Diff: https://reviews.apache.org/r/37863/diff/


Testing
---

make check on CentOS7


Thanks,

Timothy Chen

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/#review96806
---

Ship it!


Barring the s/MachineInfo/MachineID/ renames from previous reviews!

- Benjamin Hindman


On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37170/
> ---
> 
> (Updated Aug. 26, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37170/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>