Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 5, 2015, noon)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Update according @kaysoky's reviews.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
997cc0d0e316e316136d4746e50e9e292a82b36b 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
12506a1369de005285268f895f365aba0c560f78 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 72-84
> > 
> >
> > (This is just speculation, since I haven't tried this on a Windows 
> > box.)  
> > `TRUE` won't quite work on Windows, because it'll get run as a binary, 
> > and therefore won't be found.
> > 
> > Perhaps you should define a macro, like:
> > 
> > ```
> > if (WIN32)
> >   set(CMAKE_NOOP ${CMAKE_COMMAND} -E echo)
> > else (WIN32)
> >   set(CMAKE_NOOP TRUE)
> > endif (WIN32)
> > ```
> > 
> > The `-E echo` is fairly close to a no-op.
> > 
> > See: http://public.kitware.com/pipermail/cmake/2014-June/057885.html

Thank you very much! Because I install mingw in windows before, so it could 
pass. I have already remove it.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review97108
---


On Sept. 5, 2015, noon, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> ---
> 
> (Updated Sept. 5, 2015, noon)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 997cc0d0e316e316136d4746e50e9e292a82b36b 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 12506a1369de005285268f895f365aba0c560f78 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e 
>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37024: Exposes mesos version information in components.

[haosdent huang]

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote:
> > Couple of comments:
> > 
> > Let's not call the actor VersionInfo, since that sounds like a protobuf 
> > message. How about 'VersionProcess' and we avoid the wrapper type entirely 
> > since Version is taken in stout?
> > 
> > Also, can we instantiate this from the main entrypoints rather than inside 
> > master/slave? Would be nice to offer it from the drivers as well (sched.cpp 
> > / exec.cpp).
> 
> Ben Mahler wrote:
> Could you also follow up with a test for this in a separate patch?
> 
> haosdent huang wrote:
> Sure

@bmahler Sorry for a bit unclear you reviews before.
* If change VersionInfo -> VersionProcess, VersionInfoProcess seems don't have 
meaningful names.
* "the main entrypoints" refer to the Master::initialize()/Slave::initialize()?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review97180
---


On Aug. 16, 2015, 5:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Aug. 16, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component version.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
>   src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02 
>   src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version_info.hpp PRE-CREATION 
>   src/version/version_info.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Yong Qiao Wang]

> On 九月 4, 2015, 7:42 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4118
> > 
> >
> > Instead of not calling updateTask() the logic should be inside 
> > updateTask() to do the right thing. Note that updateTask() already has 
> > logic to deal with duplicate terminal updates.
> 
> Vinod Kone wrote:
> Also, needs a test!

Thanks a billion for your many times review.  I have updated the changes by 
your usful comments.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97790
---


On 九月 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> ---
> 
> (Updated 九月 2, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97864
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38125: Included hostname in SlaveID.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38125/#review97871
---


What is the benefit of this change? I'm a bit reluctant to conflate ID and 
additional information. A high-level question: can hostname change on the slave 
failover? If yes, we may end up in a situation, when the information in the 
`SlaveID` is misleading, which is worse than absence of it.

- Alexander Rukletsov


On Sept. 4, 2015, 10:57 a.m., Bernd Mathiske wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38125/
> ---
> 
> (Updated Sept. 4, 2015, 10:57 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-115
> https://issues.apache.org/jira/browse/MESOS-115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now including the hostname in the SlaveID, for human consumption. Also 
> testing this in a unit test.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
> 
> Diff: https://reviews.apache.org/r/38125/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---

Review request for mesos.


Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022


Repository: mesos


Description
---

export additional message metrics from scheduler driver


Diffs
-

  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 

Diff: https://reviews.apache.org/r/38145/diff/


Testing
---


Thanks,

Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/
---

(Updated 九月 5, 2015, 1:38 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864


Repository: mesos


Description
---

Only update the task status when its old status is not terminal.


Diffs (updated)
-

  src/master/master.cpp 5589eca 

Diff: https://reviews.apache.org/r/38051/diff/


Testing (updated)
---

UT:

1. make successfully!
2. make check successfully!
3. Run test framework successfully!


Thanks,

Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---

(Updated 九月 5, 2015, 2:06 p.m.)


Review request for mesos.


Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022


Repository: mesos


Description
---

export additional message metrics from scheduler driver


Diffs (updated)
-

  src/sched/sched.cpp 012af05 
  src/tests/scheduler_driver_tests.cpp 4963f5d 

Diff: https://reviews.apache.org/r/38145/diff/


Testing
---

UT:

1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:

#  curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}


Thanks,

Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97866
---


Patch looks great!

Reviews applied: [38051]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 1:38 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> ---
> 
> (Updated Sept. 5, 2015, 1:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 5589eca 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[haosdent huang]

> On Aug. 31, 2015, 6:50 p.m., Joseph Wu wrote:
> > cmake/MesosConfigure.cmake, line 125
> > 
> >
> > Why do you need this?  (If you do need it, comment why.)
> > 
> > It doesn't look like the inputs have any semicolons.

Because cmake convert list [a, b, c] to string "a;b;c". When we write a string 
to file, need replace ";" to " " first.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
---


On Sept. 4, 2015, 4:24 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 4, 2015, 4:24 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97860
---


Patch looks great!

Reviews applied: [38145]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

> On 九月 5, 2015, 1:04 p.m., haosdent huang wrote:
> > src/sched/sched.cpp, line 102
> > 
> >
> > I think need change order to match dictionnary order here.

Thanks a million! I will update the order in the updated code diff.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97857
---


On 九月 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated 九月 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---

Ship it!


Ship It!

- haosdent huang


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

> On Sept. 5, 2015, 3:27 p.m., haosdent huang wrote:
> > Ship It!

Looks good for me. But you need find a committer help you review and commit 
this patch. :-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 5, 2015, 12:43 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
997cc0d0e316e316136d4746e50e9e292a82b36b 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
12506a1369de005285268f895f365aba0c560f78 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---

(Updated 九月 5, 2015, 12:41 p.m.)


Review request for mesos.


Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022


Repository: mesos


Description
---

export additional message metrics from scheduler driver


Diffs
-

  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 

Diff: https://reviews.apache.org/r/38145/diff/


Testing (updated)
---

UT:

1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:

#  curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}


Thanks,

Yong Qiao Wang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 5, 2015, 12:40 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Update according @kaysoky reviews


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97857
---



src/sched/sched.cpp (line 102)


I think need change order to match dictionnary order here.


- haosdent huang


On Sept. 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97869
---


Patch looks great!

Reviews applied: [38145]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 5, 2015, 12:45 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38117: Export per container SNMP statistics

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review97870
---



src/slave/containerizer/isolators/network/port_mapping.cpp (line 1148)


A bit duplicate code here, is it possible to determine which hashmap should 
use, and then fill it?


- haosdent huang


On Sept. 4, 2015, 1:17 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> ---
> 
> (Updated Sept. 4, 2015, 1:17 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone.
> 
> 
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These stats are those we get by `netstat -s`, they are important for diagnose 
> networking issues.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 34ba2294b0bd7d57aa9de073692a2ea8ec62681d 
>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 49fb0007356eedf7095d34a1312e99bafa8fdc4d 
> 
> Diff: https://reviews.apache.org/r/38117/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/
---

(Updated Sept. 5, 2015, 10:05 p.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.


Changes
---

Fixing typo


Bugs: MESOS-3375
https://issues.apache.org/jira/browse/MESOS-3375


Repository: mesos


Description
---

Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
ought to be changed as the executor HTTP API design evolves.


Diffs (updated)
-

  include/mesos/v1/executor/executor.hpp PRE-CREATION 
  include/mesos/v1/executor/executor.proto PRE-CREATION 
  src/Makefile.am 5fdca0f 

Diff: https://reviews.apache.org/r/38143/diff/


Testing
---

make && make check


Thanks,

Isabel Jimenez

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

> On 九月 5, 2015, 3:27 p.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
> Looks good for me. But you need find a committer help you review and 
> commit this patch. :-)

Thanks again. That's very nice of you.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---


On 九月 5, 2015, 11:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated 九月 5, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review97881
---

Ship it!


Ship It!

- Guangya Liu


On 九月 4, 2015, 11:19 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35702/
> ---
> 
> (Updated 九月 4, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This involved a lot more challenges than I anticipated, I've captured the 
> various approaches and limitations and deal-breakers of those approaches 
> here: [Master Endpoint Implementation 
> Challenges](https://docs.google.com/document/d/1cwVz4aKiCYP9Y4MOwHYZkyaiuEv7fArCye-vPvB2lAI/edit#)
> 
> Key points:
> 
> * This is a stop-gap solution until we shift the offer creation/management 
> logic from the master to the allocator.
> * `updateAvailable` and `updateSlave` are kept separate because
>   (1) `updateAvailable` is allowed to fail whereas `updateSlave` must not.
>   (2) `updateAvailable` returns a `Future` whereas `updateSlave` does not.
>   (3) `updateAvailable` never leaves the allocator in an over-allocated state 
> and must not, whereas `updateSlave` does, and can.
> * The algorithm:
> * Initially, the master pessimistically assume that what seems like 
> "available" resources will be gone.
>   This is due to the race between the allocator scheduling an `allocate` 
> call to itself vs master's
>   `allocator->updateAvailable` invocation.
>   As such, we first try to satisfy the request only with the offered 
> resources.
> * We greedily rescind one offer at a time until we've rescinded 
> sufficiently many offers.
>   IMPORTANT: We perform `recoverResources(..., Filters())` which has a 
> default `refuse_sec` of 5 seconds,
>   rather than `recoverResources(..., None())` so that we can virtually 
> always win the race against `allocate`.
>   In the rare case that we do lose, no disaster occurs. We simply fail to 
> satisfy the request.
> * If we still don't have enough resources after resciding all offers, be 
> semi-optimistic and forward the
>   request to the allocator since there may be available resources to 
> satisfy the request.
> * If the allocator returns a failure, report the error to the user with 
> `Conflict`.
> 
> This approach is clearly not ideal, since we would prefer to rescind as 
> little offers as possible.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/master/validation.hpp 43b8d84556e7f0a891dddf6185bbce7ca50b360a 
>   src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 
> 
> Diff: https://reviews.apache.org/r/35702/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97872
---



include/mesos/v1/executor/executor.proto (line 47)


Here we're refering to 'Events', for the Subscribed event message 
FrameworkInfo will have the framework_id. Please note that this protobuf ought 
to have minor changes as the design evolves:

https://docs.google.com/document/d/1dFmTrSZXCo5zj8H8SkJ4HT-V0z2YYnEZVV8Fd_-AupM/edit?usp=sharing



include/mesos/v1/executor/executor.proto (line 91)


arojas is the orginal author of this TODO, if the assignee for this TODO 
needs to be rewritten, we should do it in a separate patch.



include/mesos/v1/executor/executor.proto (line 169)


The design here follows the design for the scheduler HTTP API. All event 
messages require their type. Depending on the 'type' of call message, you 
should expect an optional corresponding type of message. 
For example if you have a 'Call' message of 'type' 'UPDATE' your call 
message will have the optional 'update' message inside with their required 
'status' , 'timestamp' and 'uuid'.


- Isabel Jimenez


On Sept. 5, 2015, 2:35 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 5, 2015, 2:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote:
> > include/mesos/v1/executor/executor.proto, line 47
> > 
> >
> > I think that the framework id need to be set when call "SUBSCRIBE" but 
> > not after "SUBSCRIBED"?

Here we're refering to 'Events', for the Subscribed event message FrameworkInfo 
will have the framework_id. Please note that this protobuf ought to have minor 
changes as the design evolves:
https://docs.google.com/document/d/1dFmTrSZXCo5zj8H8SkJ4HT-V0z2YYnEZVV8Fd_-AupM/edit?usp=sharing


> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote:
> > include/mesos/v1/executor/executor.proto, line 91
> > 
> >
> > s/arojas/yourid?

arojas is the orginal author of this TODO, if the assignee for this TODO needs 
to be rewritten, we should do it in a separate patch.


> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote:
> > include/mesos/v1/executor/executor.proto, line 169
> > 
> >
> > Do you mean that when type is Subscribe, there is no need to set any 
> > message? Why? I think that the framework id, executor id, command should be 
> > set?

The design here follows the design for the scheduler HTTP API. All call and 
event messages require their type. Depending on the 'type' of call message, you 
should expect an optional corresponding type of message. 
For example if you have a 'Call' message of 'type' 'UPDATE' your call message 
will have the optional 'update' message inside with their required 'status' , 
'timestamp' and 'uuid'.


- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97846
---


On Sept. 5, 2015, 2:35 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 5, 2015, 2:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97880
---

Ship it!


Thanks Isabel for the explanation!

- Guangya Liu


On 九月 5, 2015, 10:05 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated 九月 5, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97876
---


Patch looks great!

Reviews applied: [38143]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 10:05 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 5, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
---

(Updated 九月 6, 2015, 2:40 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Changes
---

Rebase


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add quiesce logic in allocator


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
cb4020dea897ef198cd9898cabecf61edfade834 
  src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
  src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 

Diff: https://reviews.apache.org/r/37873/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review97882
---


Patch looks great!

Reviews applied: [37168]

All tests passed.

- Mesos ReviewBot


On Sept. 6, 2015, 4:11 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated Sept. 6, 2015, 4:11 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5fdca0f 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 3f56b30 
>   src/tests/flags.hpp 06da36d 
>   src/tests/script.cpp bcc1fab 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote:
> > include/mesos/v1/executor/executor.proto, line 169
> > 
> >
> > Do you mean that when type is Subscribe, there is no need to set any 
> > message? Why? I think that the framework id, executor id, command should be 
> > set?
> 
> Isabel Jimenez wrote:
> The design here follows the design for the scheduler HTTP API. All call 
> and event messages require their type. Depending on the 'type' of call 
> message, you should expect an optional corresponding type of message. 
> For example if you have a 'Call' message of 'type' 'UPDATE' your call 
> message will have the optional 'update' message inside with their required 
> 'status' , 'timestamp' and 'uuid'.

Here you can find the design doc for the scheduler HTTP API: 
https://docs.google.com/document/d/1pnIY_HckimKNvpqhKRhbc9eSItWNFT-priXh_urR-T0/edit?usp=sharing


- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97846
---


On Sept. 5, 2015, 10:05 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 5, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated Sept. 6, 2015, 4:11 a.m.)


Review request for mesos and Michael Park.


Changes
---

Update the code diff to address commnets:
* Add comments to describe the example logic
* Use command executor instead of test_executor.cpp


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 5fdca0f 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 3f56b30 
  src/tests/flags.hpp 06da36d 
  src/tests/script.cpp bcc1fab 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma