Re: Review Request 38343: mesos: Fixed punctuation in log message.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98815
---


Patch looks great!

Reviews applied: [38343]

All tests passed.

- Mesos ReviewBot


On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> ---
> 
> (Updated Sept. 14, 2015, 5:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per style guide, log messages should not end in a period.
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticator.cpp 
> f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 
> 
> Diff: https://reviews.apache.org/r/38343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38343: mesos: Fixed punctuation in log message.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98813
---

Ship it!


Ship It!

- Klaus Ma


On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> ---
> 
> (Updated Sept. 14, 2015, 5:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per style guide, log messages should not end in a period.
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticator.cpp 
> f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 
> 
> Diff: https://reviews.apache.org/r/38343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/
---

(Updated Sept. 14, 2015, 5:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Add dependency to RB-38342, and remove `JSON::Protobuf`


Bugs: MESOS-3405
https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
---

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Diffs (updated)
-

  include/mesos/resources.hpp 6c3a065 
  src/common/http.cpp 9c0d31e 
  src/examples/persistent_volume_framework.cpp 426d338 
  src/launcher/executor.cpp 50b3c6e 
  src/master/contender.cpp 67562f1 
  src/master/http.cpp 73e8857 
  src/master/registrar.cpp d81560a 
  src/slave/containerizer/fetcher.cpp 2b2298c 
  src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
  src/slave/monitor.cpp 8d8b422 
  src/tests/containerizer/launch_tests.cpp d211fc0 
  src/tests/fault_tolerance_tests.cpp 061e099 
  src/tests/http_api_tests.cpp 7938bbb 
  src/tests/master_maintenance_tests.cpp fb8dca3 
  src/tests/master_tests.cpp dd65fcc 
  src/tests/mesos.cpp ab2d85b 
  src/tests/reservation_endpoints_tests.cpp dfab497 
  src/tests/script.cpp bcc1fab 
  src/tests/slave_tests.cpp 447c43c 
  src/usage/main.cpp 86fd796 

Diff: https://reviews.apache.org/r/38335/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/
---

Review request for mesos and Michael Park.


Bugs: MESOS-3405
https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
---

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 

Diff: https://reviews.apache.org/r/38342/diff/


Testing
---

cd 3rdparty/libprocess/3rdparty/stout
./boostrap
./configure
make


Thanks,

Klaus Ma

Review Request 38343: mesos: Fixed punctuation in log message.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/
---

Review request for mesos, Joris Van Remoortere and Niklas Nielsen.


Repository: mesos


Description
---

Per style guide, log messages should not end in a period.


Diffs
-

  src/authentication/cram_md5/authenticator.cpp 
f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 

Diff: https://reviews.apache.org/r/38343/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review98808
---

Ship it!



include/mesos/type_utils.hpp (line 326)


Maybe put the IP in parens rather than after a comma? And what if one is 
missing? Do you want to print just the IP with no parens if no hostname and 
just the hostname if no IP?



src/master/master.cpp (line 3755)


s/Down/DOWN/



src/master/master.cpp (line 3760)


Rather than say the machine is "under maintenance", can we just specify 
that it's down? I can see an operator bringing the machine down having nothing 
to do with maintenance and this log message throwing somebody off track (this 
is in fact one of the reasons we decided to just make the 'machine' endpoints 
be independent of 'maintenance' IIRC). Same comment applies below too.



src/master/master.cpp (line 3763)


s/Down/DOWN/



src/master/master.cpp (line 3944)


s/Down/DOWN/



src/tests/master_maintenance_tests.cpp (line 689)


Are you waiting for the same reason as above? I'd add more to the comment 
here as you did above as well.


- Benjamin Hindman


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37623/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37623/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Benjamin Hindman]

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote:
> > src/master/http.cpp, lines 1622-1624
> > 
> >
> > Why don't we want to send lost slave messages?

Sorry, I meant: why don't we want to let lost slave messages get sent in the 
normal flow? Why do we need/want to do it immediately and explicitly here?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
---


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37622/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
---



src/master/http.cpp (lines 1622 - 1624)


Why don't we want to send lost slave messages?


- Benjamin Hindman


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37622/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37621/#review98804
---

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37621/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 1fc9e7351d090f751c92ad6f11ecc25cdf1255d2 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37621/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98803
---

Ship it!



src/master/master.cpp (line 3283)


Don't need the extra newline here.


- Benjamin Hindman


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
> 
> Diff: https://reviews.apache.org/r/37284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review98802
---

Ship it!


Still a Ship It, just a minor nit.


src/messages/messages.proto (line 171)


Can we put a newline above this please? Thanks!


- Benjamin Hindman


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 
>   src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 
>   src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 
>   src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
> 
> Diff: https://reviews.apache.org/r/37282/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review98801
---

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37177/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp 
> 7fec3ffe063e766dcec4952001fa5c6e20d9eec8 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
>   src/tests/master_allocator_tests.cpp 
> 89331965553505f6b7eebf39ad27d943df816a24 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
>   src/tests/reservation_endpoints_tests.cpp 
> dfab4971e04a81ac98ed118ea877bcca5db17bb5 
>   src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
>   src/tests/resource_offers_tests.cpp 
> 882a9ff4d09aace486182828bf43b643b0d0c519 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
> 
> Diff: https://reviews.apache.org/r/37177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review98800
---

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37176/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 217c7c434874b3870668c69799d6b59ce1d83973 
>   src/master/allocator/sorter/drf/sorter.cpp 
> bfc273493419fe46a4d907f4f7fa282cff71b800 
>   src/master/allocator/sorter/sorter.hpp 
> 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 
> 
> Diff: https://reviews.apache.org/r/37176/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98798
---

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
> 
> Diff: https://reviews.apache.org/r/37175/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review98797
---

Ship it!



src/master/allocator/mesos/hierarchical.hpp (line 296)


With all the great cleanup here I wonder now if we should do 
'Option maintenance' similar to how we had a 'Maintenance' struct 
in master to capture all the maintenance specific bits. Otherwise, these 
changes look great to me!


- Benjamin Hindman


On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37173/
> ---
> 
> (Updated Sept. 13, 2015, 8:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   include/mesos/master/allocator.proto 
> 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
>   src/tests/master_allocator_tests.cpp 
> 89331965553505f6b7eebf39ad27d943df816a24 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
>   src/tests/reservation_endpoints_tests.cpp 
> dfab4971e04a81ac98ed118ea877bcca5db17bb5 
>   src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
> 
> Diff: https://reviews.apache.org/r/37173/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review98796
---

Ship it!


Still looks good to me, but let's not forget the v1 API additions too please!

- Benjamin Hindman


On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> ---
> 
> (Updated Sept. 13, 2015, 8:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37172/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98795
---

Ship it!


Ship It!

- Jian Qiu


On 九月 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> ---
> 
> (Updated 九月 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
> 
> Diff: https://reviews.apache.org/r/37284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/#review98794
---

Ship it!


Looks great!


src/master/master.cpp (line 3950)


Kill newline?


- Benjamin Hindman


On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37170/
> ---
> 
> (Updated Sept. 13, 2015, 8:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/master/machine.hpp PRE-CREATION 
>   src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd 
>   src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
> 
> Diff: https://reviews.apache.org/r/37170/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38251/
---

(Updated 九月 14, 2015, 2:19 a.m.)


Review request for mesos, Joris Van Remoortere and Vinod Kone.


Bugs: MESOS-3169
https://issues.apache.org/jira/browse/MESOS-3169


Repository: mesos


Description
---

FrameworkInfo should only be updated if the re-registration is valid


Diffs
-

  src/master/master.cpp 4b60e637b19e749e27c4a8eb9b0a95c7e9305c5f 

Diff: https://reviews.apache.org/r/38251/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98792
---



src/master/http.cpp (line 1606)


s/machineInfos/machines


- Qian Zhang


On Sept. 14, 2015, 4:34 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> ---
> 
> (Updated Sept. 14, 2015, 4:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37622/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
---



src/master/master.cpp (lines 4131 - 4134)


I think we have done this in Master::Http::maintenanceSchedule(), so why we 
do it again here? Maybe remove the duplicated code from 
Master::Http::maintenanceSchedule()?


- Qian Zhang


On Sept. 14, 2015, 4:33 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> ---
> 
> (Updated Sept. 14, 2015, 4:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
> 
> Diff: https://reviews.apache.org/r/37175/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98789
---


Patch looks great!

Reviews applied: [37821]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 11:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> ---
> 
> (Updated Sept. 13, 2015, 11:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Join threads in libprocess when shutting down.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
>   3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
>   3rdparty/libprocess/src/libevent.cpp 
> ee7906470069b0391dde7cd685b1d4eb3a158c03 
>   3rdparty/libprocess/src/process.cpp 
> 4afa30569b4d235637b49a624602e6b199c32e0e 
> 
> Diff: https://reviews.apache.org/r/37821/diff/
> 
> 
> Testing
> ---
> 
> After configuring with both "../configure" and "../configure 
> --enable-libevent --enable-ssl":
> 
> make check
> 
> 
> Also, to check for race conditions related to the initialization/shutdown of 
> libprocess, try something like:
> 
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
> --gtest_filter=ProcessTest.Spawn; done
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---

(Updated Sept. 13, 2015, 11:01 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Michael Park.


Changes
---

Added shutdown check in ProcessManager::enqueue().


Bugs: MESOS-3158
https://issues.apache.org/jira/browse/MESOS-3158


Repository: mesos


Description
---

Join threads in libprocess when shutting down.


Diffs (updated)
-

  3rdparty/libprocess/src/event_loop.hpp 
36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
  3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
  3rdparty/libprocess/src/libevent.cpp ee7906470069b0391dde7cd685b1d4eb3a158c03 
  3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e 

Diff: https://reviews.apache.org/r/37821/diff/


Testing
---

After configuring with both "../configure" and "../configure --enable-libevent 
--enable-ssl":

make check


Also, to check for race conditions related to the initialization/shutdown of 
libprocess, try something like:

for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
--gtest_filter=ProcessTest.Spawn; done


Thanks,

Greg Mann

Re: Review Request 37821: Join threads in libprocess when shutting down.

[Greg Mann]

> On Sept. 10, 2015, 8:20 a.m., Michael Park wrote:
> > I've made a few nit comments below but I have some higher-level questions.
> > 
> >   (1) In this patch, when the destructor of `ProcessManager` is invoked we 
> > immediately start to ignore messages. It's not obvious to me that this is 
> > necessary or desired. Could we just enqueue the `TerminateEvent` by calling 
> > `process::terminate(process, false)`, let it race against other messages 
> > that may be coming in, and ignore anything that arrives after 
> > `TerminateEvent`?
> >   (2) What are the implications of shutting down the event loop via 
> > `EventLoop::stop()`? This would be useful to know to learn about the 
> > required order between process termination, event loop shutdown, and thread 
> > pool joins.
> 
> Greg Mann wrote:
> Thanks for the review mpark!!
> 
> Regarding (2), `EventLoop::stop()` calls methods from libevent/libev that 
> terminate the event loop after all active callbacks have completed. This 
> means that we can have messages coming in from a socket after this call is 
> made.
> 
> Regarding (1), I was worried about messages coming in on sockets 
> preventing the queues from draining, but as I think Joris mentioned in our 
> previous discussion, if messages are coming in fast enough to prevent 
> draining, then they're coming in too fast for just about anything to happen, 
> so it's not worth worrying about. Further, it's possible that an existing 
> process needs to receive a socket message in order to terminate, so they 
> should be allowed. I think that we can do away with `draining_queue`.
> 
> Once the event loop is stopped, we won't have any new socket messages 
> coming in, but the question is if we still need a boolean check in 
> `ProcessManager::handle()` to make sure that any final callbacks on the event 
> loop don't attempt to queue up events. I think this would only be necessary 
> if it's possible for a socket message to spawn a new process directly, and 
> I'm not yet sure if that is the case? If the socket message attempts to queue 
> up an event on an existing process, the run queue will be empty, so it won't 
> be possible, but if it adds a process to the run queue, we have a problem. 
> I've removed the boolean check from `ProcessManager::handle()` for now.

So I see that new processes can be spawned and enqueued by socket messages, 
which means that at shutdown, new processes could get enqueued after the queue 
has been drained but before the process threads have exited. To avoid this, I 
added a check on `joining_threads` into `ProcessManager::enqueue()` and moved 
the `joining_threads.store(true)` to occur immediately following the queue 
draining.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98329
---


On Sept. 13, 2015, 11:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> ---
> 
> (Updated Sept. 13, 2015, 11:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Join threads in libprocess when shutting down.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
>   3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
>   3rdparty/libprocess/src/libevent.cpp 
> ee7906470069b0391dde7cd685b1d4eb3a158c03 
>   3rdparty/libprocess/src/process.cpp 
> 4afa30569b4d235637b49a624602e6b199c32e0e 
> 
> Diff: https://reviews.apache.org/r/37821/diff/
> 
> 
> Testing
> ---
> 
> After configuring with both "../configure" and "../configure 
> --enable-libevent --enable-ssl":
> 
> make check
> 
> 
> Also, to check for race conditions related to the initialization/shutdown of 
> libprocess, try something like:
> 
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests 
> --gtest_filter=ProcessTest.Spawn; done
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

[Joris Van Remoortere]

> On Aug. 28, 2015, 8:49 p.m., Benjamin Hindman wrote:
> > src/tests/master_maintenance_tests.cpp, line 97
> > 
> >
> > Can we do this ASAP? Either now or already as an independent review on 
> > this chain so that we make sure we follow up?

Created MESOS-3418 for this.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review96925
---


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37283/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37283/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

[Joris Van Remoortere]

> On Aug. 31, 2015, 1:56 p.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 1118
> > 
> >
> > s/send inverse offer/deallocate resources/

This is tricky. We decided to use the word "de-allocate" in the allocator code. 
At the same time, we're still using the "inverse offer" terminology elsewhere 
(in the master and scheduler API), as well as in presentations and 
documentation. Considering the latter, I think it is more usefull for users to 
see error messages using the "inverse offer" terminology.


> On Aug. 31, 2015, 1:56 p.m., Qian Zhang wrote:
> > src/master/master.cpp, line 623
> > 
> >
> > In future, we may need to add more callback functions, so here can we 
> > change to use a general structure to keep the callback functions that we 
> > want to pass into allocator? So in future, if we want to add more callback  
> > functions, just need to change that structure rather than the signature of 
> > allocator->initialize()

I understand your reasoning here. In this case I prefer making it "harder" on a 
developer to modify the API, as the C++ compiler will guide them through all 
the consequences of changing the API. If we turned this into a dynamic change 
of behavior, then it would increase the risk of bugs or half-implemented 
features.

Regardless, this API will be getting some love (refactoring) in the near 
future, where some of your concerns will be addressed :-)


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review97073
---


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37177/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.hpp 
> 7fec3ffe063e766dcec4952001fa5c6e20d9eec8 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
>   src/tests/master_allocator_tests.cpp 
> 89331965553505f6b7eebf39ad27d943df816a24 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
>   src/tests/reservation_endpoints_tests.cpp 
> dfab4971e04a81ac98ed118ea877bcca5db17bb5 
>   src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
>   src/tests/resource_offers_tests.cpp 
> 882a9ff4d09aace486182828bf43b643b0d0c519 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
> 
> Diff: https://reviews.apache.org/r/37177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

[Joris Van Remoortere]

> On Sept. 10, 2015, 3 a.m., Benjamin Hindman wrote:
> > src/master/allocator/sorter/drf/sorter.cpp, lines 173-177
> > 
> >
> > A suggestion to keep 'allocation' const& and avoid the double lookup:
> > 
> > foreachpair (const string& name, const Allocation& allocation, 
> > allocations) {
> >   Option resources = allocation.resources.get(slaveId);
> >   if (resources.isSome()) {
> > result.emplace(name, resources.get());
> >   }
> > }

Added a comment, as per our discussion offline.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review98320
---


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37176/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 217c7c434874b3870668c69799d6b59ce1d83973 
>   src/master/allocator/sorter/drf/sorter.cpp 
> bfc273493419fe46a4d907f4f7fa282cff71b800 
>   src/master/allocator/sorter/sorter.hpp 
> 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 
> 
> Diff: https://reviews.apache.org/r/37176/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

[Joris Van Remoortere]

> On Sept. 2, 2015, 10:04 p.m., Joseph Wu wrote:
> > include/mesos/master/allocator.hpp, lines 138-141
> > 
> >
> > Consider Doxygen-ification.

I don't want to start another debate around "mixed vs not mixed doxygen 
comments"; so we can doxygenify this whole file in a separate review :-)
Thanks for looking out though!


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review97527
---


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> ---
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> fbf353d8bdd4322275057e392a958fca77ecd8b3 
>   src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
> 
> Diff: https://reviews.apache.org/r/37175/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37283/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---

(Updated Sept. 13, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37623/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 

Diff: https://reviews.apache.org/r/37180/diff/


Testing
---

The tests break as expected.
With the scheduler API change there are CHECKs that fail.
Once we update the API these will be resolved.


Thanks,

Joris Van Remoortere

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
fbf353d8bdd4322275057e392a958fca77ecd8b3 
  src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 

Diff: https://reviews.apache.org/r/37280/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37621/
---

(Updated Sept. 13, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/sched/sched.cpp 1fc9e7351d090f751c92ad6f11ecc25cdf1255d2 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37621/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
---

(Updated Sept. 13, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 

Diff: https://reviews.apache.org/r/37284/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 

Diff: https://reviews.apache.org/r/37234/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 
  src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 
  src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 
  src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 

Diff: https://reviews.apache.org/r/37282/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
---

(Updated Sept. 13, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37622/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
fbf353d8bdd4322275057e392a958fca77ecd8b3 
  src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
  src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
  src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 

Diff: https://reviews.apache.org/r/37175/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37178/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
217c7c434874b3870668c69799d6b59ce1d83973 
  src/master/allocator/sorter/drf/sorter.cpp 
bfc273493419fe46a4d907f4f7fa282cff71b800 
  src/master/allocator/sorter/sorter.hpp 
536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 

Diff: https://reviews.apache.org/r/37176/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/
---

(Updated Sept. 13, 2015, 8:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp 
7fec3ffe063e766dcec4952001fa5c6e20d9eec8 
  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
fbf353d8bdd4322275057e392a958fca77ecd8b3 
  src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/hierarchical_allocator_tests.cpp 
9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
  src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
  src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
  src/tests/reservation_endpoints_tests.cpp 
dfab4971e04a81ac98ed118ea877bcca5db17bb5 
  src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
  src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 
  src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 

Diff: https://reviews.apache.org/r/37177/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
---

(Updated Sept. 13, 2015, 8:32 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
fbf353d8bdd4322275057e392a958fca77ecd8b3 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/hierarchical_allocator_tests.cpp 
9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
  src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
  src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
  src/tests/reservation_endpoints_tests.cpp 
dfab4971e04a81ac98ed118ea877bcca5db17bb5 
  src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
  src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 

Diff: https://reviews.apache.org/r/37173/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
---

(Updated Sept. 13, 2015, 8:32 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b 
  src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 
  src/master/machine.hpp PRE-CREATION 
  src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd 
  src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 
  src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 

Diff: https://reviews.apache.org/r/37170/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
---

(Updated Sept. 13, 2015, 8:32 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37172/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Joris Van Remoortere]

> On Sept. 6, 2015, 8:14 a.m., Klaus Ma wrote:
> > src/master/http.cpp, line 1570
> > 
> >
> > Should be LostSlaveMessage?

We end up sending both. I've modified the comment to make this more clear. 
Thanks!


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97884
---


On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> ---
> 
> (Updated Sept. 2, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37622/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review98779
---


Patch looks great!

Reviews applied: [38338]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 5:34 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> ---
> 
> (Updated Sept. 13, 2015, 5:34 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3392
> https://issues.apache.org/jira/browse/MESOS-3392
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced option for Docker cli volume plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
> 
> Diff: https://reviews.apache.org/r/38338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

[haosdent huang]

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote:
> > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that 
> > you've upgraded to GMock 1.7 (in commie 
> > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my 
> > understanding here just to make sure we're on the same page.
> > 
> > I've run CMake on my OS X machine and included the output below[1]. You can 
> > see that I'm running vanilla OS X, and that my compiler is clang. When I 
> > swap out the GMock version to be v1.6 (instead of v1.7, which is what it 
> > currently is), I get the error tr1/tuple error you see at [2].
> > 
> > BUT, when I run it with GMock v1.7, the issue is fixed. To confirm the fix, 
> > I consulted the source of `gtest-port.h` and found some code[3] that 
> > appears to intelligently figure out whether this flag should be set 
> > automatically.
> > 
> > If this is true, then I think this patch can omit this flag set entirely.
> > 
> > 
> > [1] CMake config output:
> > ```
> >  ~/src/mesos/build $ cmake ..
> > -- The C compiler identification is AppleClang 6.1.0.6020053
> > -- The CXX compiler identification is AppleClang 6.1.0.6020053
> > -- Check for working C compiler: /usr/bin/cc
> > -- Check for working C compiler: /usr/bin/cc -- works
> > -- Detecting C compiler ABI info
> > -- Detecting C compiler ABI info - done
> > -- Check for working CXX compiler: /usr/bin/c++
> > -- Check for working CXX compiler: /usr/bin/c++ -- works
> > -- Detecting CXX compiler ABI info
> > -- Detecting CXX compiler ABI info - done
> > -- 
> > -- * Beginning Mesos CMake configuration step *
> > -- 
> > -- INSTALLATION PREFIX: /usr/local
> > -- MACHINE SPECS:
> > -- Hostname:
> > -- OS:   DARWIN(14.1.0)
> > -- Arch: X86_64
> > -- BitMode:
> > -- BuildID:
> > -- 
> > -- Performing Test COMPILER_SUPPORTS_CXX11
> > -- Performing Test COMPILER_SUPPORTS_CXX11 - Success
> > -- Looking for include file pthread.h
> > -- Looking for include file pthread.h - found
> > -- Looking for pthread_create
> > -- Looking for pthread_create - found
> > -- Found Threads: TRUE
> > -- Found ZLIB: /usr/lib/libz.dylib (found version "1.2.5")
> > -- Found APR headers: /usr/include/apr-1
> > -- Found APR library: /usr/lib/libapr-1.dylib
> > -- Found APRUTIL headers: /usr/include/apr-1
> > -- Found APRUTIL library: /usr/lib/libaprutil-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_client-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_delta-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_diff-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_fs-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_fs_fs-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_fs_util-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_ra-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_ra_local-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_ra_serf-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_ra_svn-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_repos-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_subr-1.dylib
> > -- Found SVN lib: /usr/local/lib/libsvn_wc-1.dylib
> > -- Found SVN: 
> > /usr/local/lib/libsvn_client-1.dylib;/usr/local/lib/libsvn_delta-1.dylib;/usr/local/lib/libsvn_diff-1.dylib;/usr/local/lib/libsvn_fs-1.dylib;/usr/local/lib/libsvn_fs_fs-1.dylib;/usr/local/lib/libsvn_fs_util-1.dylib;/usr/local/lib/libsvn_ra-1.dylib;/usr/local/lib/libsvn_ra_local-1.dylib;/usr/local/lib/libsvn_ra_serf-1.dylib;/usr/local/lib/libsvn_ra_svn-1.dylib;/usr/local/lib/libsvn_repos-1.dylib;/usr/local/lib/libsvn_subr-1.dylib;/usr/local/lib/libsvn_wc-1.dylib
> > -- Configuring done
> > -- Generating done
> > -- Build files have been written to: /Users/alex/src/mesos/build
> > ```
> > 
> > [2] Error generated with GMock v1.6 on my machine:
> > ```
> > libtool: compile:  g++ -DHAVE_CONFIG_H -I. 
> > -I/Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest
> >  -I./build-aux 
> > -I/Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest
> >  
> > -I/Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest/include
> >  -D_THREAD_SAFE -DGTEST_HAS_PTHREAD=1 -g -O2 -MT src/gtest-all.lo -MD -MP 
> > -MF src/.deps/gtest-all.Tpo -c 
> > /Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest/src/gtest-all.cc
> >   -fno-common -DPIC -o src/.libs/gtest-all.o
> > In file included from 
> > /Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest/src/gtest-all.cc:39:
> > In file included from 
> > /Users/alex/src/mesos/build/3rdparty/libprocess/3rdparty/gmock-1.6.0/src/gmock-1.6.0/gtest/include/gtest/gtest.h:57:
> > In file included from 
> > /Users/alex

Re: Review Request 38337: Extract gz file in fetcher.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/#review98775
---


Patch looks great!

Reviews applied: [38337]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 5:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38337/
> ---
> 
> (Updated Sept. 13, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3407
> https://issues.apache.org/jira/browse/MESOS-3407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extract gz file in fetcher.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
>   src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 
> 
> Diff: https://reviews.apache.org/r/38337/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="FetcherTest.ExtractGzipFile" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 38338: Enhanced option for Docker cli volume plugin.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-3392
https://issues.apache.org/jira/browse/MESOS-3392


Repository: mesos


Description
---

Enhanced option for Docker cli volume plugin.


Diffs
-

  include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 

Diff: https://reviews.apache.org/r/38338/diff/


Testing
---


Thanks,

haosdent huang

Review Request 38337: Extract gz file in fetcher.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/
---

Review request for mesos and Michael Park.


Bugs: MESOS-3407
https://issues.apache.org/jira/browse/MESOS-3407


Repository: mesos


Description
---

Extract gz file in fetcher.


Diffs
-

  src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
  src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 

Diff: https://reviews.apache.org/r/38337/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" 
--verbose


Thanks,

haosdent huang

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/#review98771
---


Bad patch!

Reviews applied: [38335]

Failed command: ./support/apply-review.sh -n -r 38335

Error:
 2015-09-13 16:39:45 URL:https://reviews.apache.org/r/38335/diff/raw/ 
[27283/27283] -> "38335.patch" [1]
Successfully applied: Add JSON::protobuf for google::protobuf::RepeatedPtrField

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Review: https://reviews.apache.org/r/38335
Checking 9 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  include/mesos/resources.hpp
  src/common/http.cpp
  src/master/http.cpp
  src/slave/containerizer/mesos/containerizer.cpp
  src/tests/reservation_endpoints_tests.cpp
stout:
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto
Failed to commit patch

- Mesos ReviewBot


On Sept. 13, 2015, 4:19 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38335/
> ---
> 
> (Updated Sept. 13, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 
>   include/mesos/resources.hpp 6c3a065 
>   src/common/http.cpp 9c0d31e 
>   src/master/http.cpp 73e8857 
>   src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
>   src/tests/reservation_endpoints_tests.cpp dfab497 
> 
> Diff: https://reviews.apache.org/r/38335/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

[Klaus Ma]

> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 600-601
> > 
> >
> > the `+` should be at the end of the line (before the newline).
> > Can you also please change the error message to:
> > ```
> > "Command line flag '" + name +
> > " duplicates environment variable definition with the same name"
> > ```
> > also, please feel free to use all 80 columns.
> > 
> > Now, an interesting question (for the shepherd/committer to decide) is 
> > whether we should just emit a WARN and have the command line (explicit) 
> > setting override the OS Env (implicit).
> > 
> > Also, whether we should only WARN, but proceed, if the **values** are 
> > the same:
> > 
> > ```MESOS_IP=127.0.0.1
> > ... --ip=127.0.0.1
> > ```
> > could (arguably) be considered a valid setting.
> > 
> > As a general approach, I'd suggest however to stick with current 
> > behavior, to avoid breaking stuff that is currently working just fine (and 
> > relying on the executable to error out in case of misconfigurations).
> 
> Klaus Ma wrote:
> I used @haosdent's suggestion as follow, it looks better than mine :).
> 
> return Error(
> "Duplicate flag '" + name "' in command line with environment");
> 
> Your question is interesting, and I think it's a great improvement. Agree 
> with you to keep current behavior, we can log a new ticket to trace that 
> question.

The behavior was updated to over-write environment by command line.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/#review98568
---


On Sept. 13, 2015, 5:30 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38259/
> ---
> 
> (Updated Sept. 13, 2015, 5:30 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3340
> https://issues.apache.org/jira/browse/MESOS-3340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, it appears that re-defining a flag on the command-line that was 
> already defined via a OS Env var (MESOS_*) causes the Master to fail with a 
> not very helpful message.
> 
> For example, if one has MESOS_QUORUM defined, this happens:
> 
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> 
> which is not very helpful.
> 
> Current solution is to throw error if any duplication; over-write may make 
> user confused about the result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ebf8cd6 
> 
> Diff: https://reviews.apache.org/r/38259/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/
---

Review request for mesos and Michael Park.


Bugs: MESOS-3405
https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
---

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 
  include/mesos/resources.hpp 6c3a065 
  src/common/http.cpp 9c0d31e 
  src/master/http.cpp 73e8857 
  src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
  src/tests/reservation_endpoints_tests.cpp dfab497 

Diff: https://reviews.apache.org/r/38335/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/#review98768
---


Patch looks great!

Reviews applied: [38334]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 1:45 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38334/
> ---
> 
> (Updated Sept. 13, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3408
> https://issues.apache.org/jira/browse/MESOS-3408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Labels field of FrameworkInfo into v1 mesos.proto
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 
> 
> Diff: https://reviews.apache.org/r/38334/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/
---

(Updated Sept. 13, 2015, 9:45 p.m.)


Review request for mesos.


Bugs: MESOS-3408
https://issues.apache.org/jira/browse/MESOS-3408


Repository: mesos


Description
---

Added Labels field of FrameworkInfo into v1 mesos.proto


Diffs (updated)
-

  include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 

Diff: https://reviews.apache.org/r/38334/diff/


Testing
---

make check


Thanks,

Qian Zhang

Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/
---

Review request for mesos.


Bugs: MESOS-3408
https://issues.apache.org/jira/browse/MESOS-3408


Repository: mesos


Description
---

Added Labels field of FrameworkInfo into v1 mesos.proto


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
7eb51e8771e95f57548fc35753e75c6d56cd97cd 
  3rdparty/libprocess/include/process/latch.hpp 
8a9d12165ea7442ddc68d20d15c8458b388bb679 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/clock.cpp 58060985bf8ab8a1bbd78b687b4c96836e13b86a 
  3rdparty/libprocess/src/latch.cpp f433a05236b2045127e2d22dfb375283b1e07a5d 
  3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e 
  3rdparty/libprocess/src/process_reference.hpp 
e6110bba2a54948be68e58ab9de988565b7d95a8 
  docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
  include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/sched/sched.cpp 1fc9e7351d090f751c92ad6f11ecc25cdf1255d2 
  src/tests/reservation_endpoints_tests.cpp 
dfab4971e04a81ac98ed118ea877bcca5db17bb5 

Diff: https://reviews.apache.org/r/38334/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38333/#review98764
---


Patch looks great!

Reviews applied: [38333]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 6:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38333/
> ---
> 
> (Updated Sept. 13, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-3349
> https://issues.apache.org/jira/browse/MESOS-3349
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made container sandbox a shared mount to address MESOS-3349.
> 
> See the discussion in https://reviews.apache.org/r/38329/ for more context.
> 
> The idea is to mark container sandbox a shared mount (do a self bind mount 
> first) so that persistent volume mounts can be propagated.
> 
> This is less invasive than marking '/' as a shared mount.
> 
> One followup for this patch is to set the default filesystem isolator to 
> posix as the linux isolator will manipulate host mount table.
> 
> We also need to address the TODO in `LinuxFilesystemIsolator::_recover` so 
> that tests do not leak mounts in the host mount table.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
>   src/slave/containerizer/provisioners/appc/provisioner.cpp 
> cd29a00fa0db8af294c10bb7a2e0cb4252bd2993 
>   src/slave/containerizer/provisioners/backends/bind.cpp 
> 1cdae61786790dc6a475ae5f73c8cc92d2bbf739 
> 
> Diff: https://reviews.apache.org/r/38333/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Centos5 and Centos6
> 
> 
> Thanks,
> 
> Jie Yu
> 
>