Re: Review Request 39432: Add /master/frameworks to master endpoint

2015-10-31 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/#review104639
---


Patch looks great!

Reviews applied: [39432]

All tests passed.

- Mesos ReviewBot


On Oct. 31, 2015, 6:18 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39432/
> ---
> 
> (Updated Oct. 31, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add /master/frameworks to master endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39432/diff/
> 
> 
> Testing
> ---
> 
> Unit Test:
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from MasterTest
> [ RUN  ] MasterTest.FrameworksEndpointWithoutFrameworks
> [   OK ] MasterTest.FrameworksEndpointWithoutFrameworks (804 ms)
> [ RUN  ] MasterTest.FrameworksEndpointOneFramework
> [   OK ] MasterTest.FrameworksEndpointOneFramework (918 ms)
> [--] 2 tests from MasterTest (1722 ms total)
>  
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (1742 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks"; 
> 2>/dev/null| jq .
> {
>   "unregistered_frameworks": [],
>   "frameworks": [
> {
>   "webui_url": "",
>   "user": "root",
>   "used_resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "unregistered_time": 0,
>   "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "hostname": "devstack007.cn.ibm.com",
>   "failover_timeout": 0,
>   "executors": [],
>   "completed_tasks": [],
>   "checkpoint": false,
>   "capabilities": [],
>   "active": true,
>   "name": "",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "offers": [],
>   "pid": 
> "scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
>   "registered_time": 1445236263.95058,
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "role": "*",
>   "tasks": [
> {
>   "statuses": [
> {
>   "timestamp": 1445236266.63443,
>   "state": "TASK_RUNNING",
>   "container_status": {
> "network_infos": [
>   {
> "ip_address": "9.111.242.187"
>   }
> ]
>   }
> }
>   ],
>   "state": "TASK_RUNNING",
>   "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "name": "cluster-test",
>   "id": "cluster-test",
>   "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "executor_id": ""
> }
>   ]
> }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-10-31 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/#review104641
---

Ship it!


Ship It!

- Guangya Liu


On 十月 30, 2015, 12:21 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39791/
> ---
> 
> (Updated 十月 30, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the deleted comment says, we were setting it to emtpy because the 'uuid' 
> was a required field until 0.22.x. Since we are at 0.26 now, it should be 
> safe to just unset it.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
>   src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 
> 
> Diff: https://reviews.apache.org/r/39791/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-10-31 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39719/
---

(Updated Oct. 31, 2015, 5:55 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3806
https://issues.apache.org/jira/browse/MESOS-3806


Repository: mesos


Description
---

Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806


Diffs (updated)
-

  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a126cd6ee15adb8d92e85ab562e998e3647f999a 
  src/slave/containerizer/mesos/mark_mounts_rslave.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39719/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-31 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38900/
---

(Updated Oct. 31, 2015, 5:57 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-3428
https://issues.apache.org/jira/browse/MESOS-3428


Repository: mesos


Description
---

Update command executor to support rootfs.


Diffs (updated)
-

  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/constants.hpp de6b58a93346c618a9214032d891c1004203ca56 
  src/slave/constants.cpp b69471b2d57aad0c254ef3bb7dce9405abeab93a 
  src/slave/containerizer/mesos/containerizer.hpp 
4aad8a3be43b331efc6b8157b2fae090df16c1b4 
  src/slave/containerizer/mesos/containerizer.cpp 
91e4ea3a907ad165c359e7422135138737e14085 
  src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 

Diff: https://reviews.apache.org/r/38900/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 39258: Add filesystem isolator with command executor test.

2015-10-31 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
---

(Updated Oct. 31, 2015, 5:58 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Repository: mesos


Description
---

Add filesystem isolator with command executor test.


Diffs (updated)
-

  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/containerizer/mesos/containerizer.cpp 
91e4ea3a907ad165c359e7422135138737e14085 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
912fc5abadb1219fc4baec1a751010522bc7a7d0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
e99c1c9876b836be5d3efcef7408b5ed01d8984e 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
39008f620183d242407fea5377bfceffc57b 
  src/tests/containerizer/provisioner.hpp 
507e1413470ef4f36ead657203073115d5324bef 
  src/tests/containerizer/store.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39258/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-31 Thread Timothy Chen 


> On Oct. 14, 2015, 7:23 p.m., Jie Yu wrote:
> > src/slave/slave.cpp, lines 3390-3393
> > 
> >
> > Hum... Does that mean that if the user task does not specify a user 
> > (e.g., rely on framework.user), we are going to launch the task under root?

That's right, otherwise I don't think we could have done all other operations 
for them in the first place if it's non-root right?
Wouldn't this be the same for custom executor as well?


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38900/#review102682
---


On Oct. 31, 2015, 5:57 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38900/
> ---
> 
> (Updated Oct. 31, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3428
> https://issues.apache.org/jira/browse/MESOS-3428
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update command executor to support rootfs.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/slave/constants.hpp de6b58a93346c618a9214032d891c1004203ca56 
>   src/slave/constants.cpp b69471b2d57aad0c254ef3bb7dce9405abeab93a 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4aad8a3be43b331efc6b8157b2fae090df16c1b4 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 91e4ea3a907ad165c359e7422135138737e14085 
>   src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 
> 
> Diff: https://reviews.apache.org/r/38900/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 39258: Add filesystem isolator with command executor test.

2015-10-31 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104643
---


Bad patch!

Reviews applied: [39719, 38900, 39258]

Failed command: make -j3 distcheck

Error:
 make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.26.0"; then find "mesos-0.26.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.26.0" || { sleep 5 && rm -rf 
"mesos-0.26.0"; }; else :; fi
test -d "mesos-0.26.0" || mkdir "mesos-0.26.0"
 (cd 3rdparty && make  top_distdir=../mesos-0.26.0 
distdir=../mesos-0.26.0/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd libprocess && make  top_distdir=../../mesos-0.26.0 
distdir=../../mesos-0.26.0/3rdparty/libprocess \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.26.0/3rdparty/libprocess" || mkdir 
"../../mesos-0.26.0/3rdparty/libprocess"
 (cd 3rdparty && make  top_distdir=../../../mesos-0.26.0 
distdir=../../../mesos-0.26.0/3rdparty/libprocess/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd stout && make  top_distdir=../../../../mesos-0.26.0 
distdir=../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" || mkdir 
"../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
 (cd include && make  top_distdir=../../../../../mesos-0.26.0 
distdir=../../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout/include \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
|| find "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" 
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r 
"../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd include && make  top_distdir=../../../mesos-0.26.0 
distdir=../../../mesos-0.26.0/3rdparty/libprocess/include \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
|| find "../../mesos-0.26.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.26.0/3rdparty/libprocess"
make[3]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd src && make  top_distdir=../mesos-0.26.0 distdir=../mesos-0.26.0/src \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `tests/containerizer/provisioner.hpp', 
needed by `distdir'.  Stop.
make[2]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory 
`/home/je

Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
fc2df6831ae2cb1a91c7a8cc92965939576e575d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39804/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
675b2e712358a55b3580026936890eaf80e5af71 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Review Request 39805: Moved filesystems tests to their own file.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Moved filesystems tests to their own file.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
8934ba79685685d5f5eae5991057c6ad3c8eea8e 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
26e1377ee625748b7fdbec327fef9ac602535f83 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39805/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Review Request 39834: Made `path_tests.cpp` standalone.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
---

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Made `path_tests.cpp` standalone.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
ad9ce324eaf940f68d04c6db7ba37d05efb1216a 

Diff: https://reviews.apache.org/r/39834/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2015-10-31 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review104646
---


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019, 39802, 39803]

Failed command: ./support/apply-review.sh -n -r 39803

Error:
 2015-11-01 00:50:37 URL:https://reviews.apache.org/r/39803/diff/raw/ 
[18127/18127] -> "39803.patch" [1]
Successfully applied: Windows: Implemented stout/os/stat.hpp`.

Windows: Implemented stout/os/stat.hpp`.


Review: https://reviews.apache.org/r/39803
Checking 4 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp:109:  
Redundant blank line at the end of a code block should be deleted.  
[whitespace/blank_line] [3]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Nov. 1, 2015, 12:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> ---
> 
> (Updated Nov. 1, 2015, 12:28 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `path_tests.cpp` standalone.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> ad9ce324eaf940f68d04c6db7ba37d05efb1216a 
> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39805: Moved filesystems tests to their own file.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/
---

(Updated Nov. 1, 2015, 1:22 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Moved filesystems tests to their own file.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
8934ba79685685d5f5eae5991057c6ad3c8eea8e 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
26e1377ee625748b7fdbec327fef9ac602535f83 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39805/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39805: Moved filesystems tests to their own file.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/#review104648
---



3rdparty/libprocess/3rdparty/stout/Makefile.am (line 45)


Oh, interesting, I thought that the lineup here was identical to that of 
`git diff`. I guess not.


- Alex Clemmer


On Nov. 1, 2015, 1:22 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39805/
> ---
> 
> (Updated Nov. 1, 2015, 1:22 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved filesystems tests to their own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
> 8934ba79685685d5f5eae5991057c6ad3c8eea8e 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 26e1377ee625748b7fdbec327fef9ac602535f83 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39805/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2015-10-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

(Updated Nov. 1, 2015, 1:31 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
675b2e712358a55b3580026936890eaf80e5af71 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-10-31 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39719/#review104654
---



src/Makefile.am (lines 1165 - 1170)


You don't have to add a new binary. You can just add a subcommand for 
mesos-containerizer binary. See the example in 
src/containerizer/mesos/launch.hpp|cpp


- Jie Yu


On Oct. 31, 2015, 5:55 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39719/
> ---
> 
> (Updated Oct. 31, 2015, 5:55 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3806
> https://issues.apache.org/jira/browse/MESOS-3806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> a126cd6ee15adb8d92e85ab562e998e3647f999a 
>   src/slave/containerizer/mesos/mark_mounts_rslave.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39719/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>