Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, line 52
> > 
> >
> > I feel this shouldn't be left for later.

I think I have to apologize for the confusion I create with this ticket. The 
implementation of this function is a stub, it is expanded (and documented) in 
the next patch by Jörg. The reason for this is poor job we did in splitting 
tasks between contributors.


> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 70-74
> > 
> >
> > These are TODO's right?
> > 
> > Also, typos:
> > s/including:/including/
> > The third "Check" s/Check/check/
> > s/reservatin/reservation/

Please see above.


> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 83-88
> > 
> >
> > Why don't you just parse a QuotaInfo object instead of a 
> > form-serialized body (with JSON components)?
> > 
> > The maintenance endpoints do this for simplicity.

Because we didn't want to expose the internal structure (`QuotaInfo`) to the 
outside world. In the future we may want to allow operators to set quotas for 
multiple roles in one call, which we can easier do if we do not tie the 
operator API to `QuotaInfo` protobuf. Does it make sense?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
---


On Nov. 5, 2015, 7:28 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote:
> > src/master/quota_handler.cpp, line 164
> > 
> >
> > Do we want to filter out the slave which is not active (slave->active 
> > == false)?

I think it makes sense to include this check, though it makes things slightly 
more pessimistic.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review105062
---


On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 5, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
---


As discussed, let's re-iterate on the actual function / signature.


3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 130)


Add blank line here please.



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (lines 131 - 135)


According to our doxygen-styleguide, we are using C comments;

```
/**
 * 
 * 
 */
```



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 141)


Why not use `nullptr` instead?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 142)






3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 154)


s/0/CURLE_OK/


- Till Toenshoff


On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> ---
> 
> (Updated Nov. 6, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [stout]: Added function to simultaneously query size and mtime of URI.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
> 
> Diff: https://reviews.apache.org/r/39594/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?

One of the comments I got earlier from Bernd is that it is hard to track what 
resources are available, hence I decided to re-introduce the resources 
explicitly.


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, line 201
> > 
> >
> > Can you change this comment to more closely match your test?
> > 
> > I find `12 > 11` to be a better sanity check than `100 > 11`.

This comment does not refer to a specific test, it rather illustrates what a 
sanity check may be.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Nov. 9, 2015, 6:19 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Changes
---

Cleanup and rebase.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 39285: Added Quota Request Validation.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105668
---

Ship it!


Ship It!

- Klaus Ma


On Nov. 9, 2015, 8:51 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Nov. 9, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

> On Nov. 5, 2015, 10:48 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 166-168
> > 
> >
> > I checked the codepaths for `Operation::RESERVE` and apparently there's 
> > nothing preventing you from reserving revocable resources.  (Unless I'm not 
> > seeing it.)
> > 
> > I think we shouldn't allow this.  If we did, we may end up double 
> > counting (or worse) the same resources.  For example, if the 
> > `ResourceEstimator` always returned the total CPU on the agent, we would 
> > see that agent as having 2x CPU (half revocable).

Yep, it's possible, but I wouldn't do it either. Maybe a `TODO` is not the 
right tag for this comment. I'll consider killing it.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review105318
---


On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 5, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Klaus Ma]

> On Nov. 7, 2015, 12:19 a.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 140
> > 
> >
> > Suggest to move it into the loop; if any role is not known by master, 
> > we did not need to continue to check others.
> 
> Alexander Rukletsov wrote:
> I think the flow is more readable how it's now: in the loop we 
> reconstruct the "reference" role, afterwards we check whether it is known to 
> the master. Also, my gut feeling is that typos in roles will not be that 
> frequent, so checking it once instead of per resource makes sense to me.
> 
> Joerg Schad wrote:
> There should just be a single role per request, why should I check that 
> in the loop?

`::protobuf::parse()` will be heavy, we can end loop early if the role is not 
known by master. But as @AlexR said, typos in role is rare case, it also make 
sense to me to keep current behavior.


> On Nov. 7, 2015, 12:19 a.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 180
> > 
> >
> > Should we move it into `validateQuotaRequest`? If any role is exist in 
> > master, we did not need to continue to check others. And in QuotaHandler, 
> > we had the pointer to master `Master* master`.
> 
> Alexander Rukletsov wrote:
> I'd keep it here, because it's related to how we currently process the 
> request, rather than whether the request is valid.
> 
> Joerg Schad wrote:
> There was an earlier comment from Joris mentioning that this isn't really 
> part of validatating the request (as it also involves state of the master).

Agree :).


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105440
---


On Nov. 9, 2015, 8:51 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Nov. 9, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

> On Nov. 3, 2015, 7:14 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 237
> > 
> >
> > move to upper line?

That's what `clang-format` suggests. Also, I think it's slightly readable this 
way.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review104880
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

> On Oct. 6, 2015, 12:40 p.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, line 65
> > 
> >
> > Just as early comments: What about PUT and DELETE?
> 
> Alexander Rukletsov wrote:
> See my comment in the subsequent review: 
> https://reviews.apache.org/r/39285/diff/4?file=1103067#file1103067line60
> I think we should move this line out of this function.
> 
> Guangya Liu wrote:
> PUT is not MVP, DELETE should be still in MVP, right?

Yes.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review101638
---


On Nov. 5, 2015, 7:28 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39947: Refactored mock allocator into a separate header file.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/#review105670
---

Ship it!


Ship It!

- Joris Van Remoortere


On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39947/
> ---
> 
> (Updated Nov. 5, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored mock allocator into a separate header file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/tests/allocator.hpp PRE-CREATION 
>   src/tests/hierarchical_allocator_tests.cpp 
> 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 
>   src/tests/master_allocator_tests.cpp 
> 1fe3757f224281c312008e9010a95559cfff3dcf 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
>   src/tests/reservation_endpoints_tests.cpp 
> f5f9c4834779a3a84d12d9be77e674e2d6088b5d 
>   src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 
>   src/tests/resource_offers_tests.cpp 
> af40a072bf5221cda42147e6f2c09d020a7f63f2 
>   src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c 
> 
> Diff: https://reviews.apache.org/r/39947/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/
---

(Updated Nov. 9, 2015, 6:18 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Quoting shell variables; Cleanup.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38883/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Bernd Mathiske]

> On Oct. 7, 2015, 7:41 a.m., Bernd Mathiske wrote:
> > src/master/quota_handler.cpp, line 66
> > 
> >
> > Given that we have the request object, we can output more diagnostic 
> > info here.
> 
> Guangya Liu wrote:
> I think that we can use BadRequest("Expecting POST"); instead, please 
> refer to https://github.com/apache/mesos/blob/master/src/master/http.cpp#L686
> 
> Alexander Rukletsov wrote:
> We are using `BadRequest` in the caller. The intention is to send HTTP 
> responses only from the "entry" function, which processes the request 
> (`Master::QuotaHandler::request()`, will be renamed to 
> `Master::QuotaHandler::set()`). All callees return errors. Does it make sense?

Yes, but the argument of Error() here could include what the request was, so a 
human can inspect it in the log. Unless it is clear from the context that the 
request has already been logged. But I prefer context-free extra diagnostics :-)


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review101764
---


On Nov. 5, 2015, 11:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

> On Oct. 13, 2015, 3:35 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 60
> > 
> >
> > Should we follow the pattern of other validation routines where we use 
> > the validation namespace and pull these utility routines into a separate 
> > file?
> > 
> > I think we can separate the validation of the request from the content 
> > of the protobuf. Syntax vs. semantic.
> > 
> > See maintenance as an example.
> 
> Alexander Rukletsov wrote:
> The reason it's conflated into one function is because in order to do 
> proper validation we should convert JSON to protobuf. Some checks are 
> performed with the JSON object and some with the converted protobuf. I though 
> that having three functions `validateJSON`, `convertToQuotaInfo`, and 
> `validateQuotaInfo` is too much.
> 
> Joseph Wu wrote:
> What specific validation are you doing to the JSON objects (other than 
> converting to Protobuf)?  And why can't the validation wait until after the 
> JSON->Protobuf conversion sufficient?

Let's discuss this in the next review https://reviews.apache.org/r/39285/, 
where validation is actually implemented.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review102247
---


On Nov. 5, 2015, 7:28 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Bernd Mathiske]

> On Oct. 7, 2015, 7:41 a.m., Bernd Mathiske wrote:
> > src/master/quota_handler.cpp, line 74
> > 
> >
> > Again, we could output more info here.
> 
> Alexander Rukletsov wrote:
> What exactly?

I checked the error() method. It suffices.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review101764
---


On Nov. 5, 2015, 11:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 9, 2015, 12:51 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs
-

  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing (updated)
---

make test


Thanks,

Joerg Schad

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 159-186
> > 
> >
> > How to handle the following cases? Say two roles request quota: r1 and 
> > r2.
> > 
> > When r1 request quota as 5, the availableInCluster is 10 and r1 set 
> > quota succeed.
> > 
> > When r2 request quota as 7 again, the availableInCluster is still 10 as 
> > no one used resources in the cluster, so r2 set quota also succeed.
> > 
> > But now the quota for r1 and r2 is 12 which exceeds 10, is this a valid 
> > case? Thanks.

This is a sanity check, the precise bookkeeping and quota allocation is done by 
an allocator module.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review104875
---


On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 5, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39595: Took mtime into account in the fetcher cache.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105587
---



src/hdfs/hdfs.hpp (lines 204 - 208)


The examples of our doxygen-styleguide suggest that we should be using C 
style comments. Same goes with the parameter description which should be 
starting with a capital letter.

```
  /**
   * Obtain path modification time.
   *
   * @param path Path to the resource to query.
   * @return Returns the last modification time of the resource in seconds
   *   since the POSIX epoch, or an Error if it cannot be retrieved.
   */
```



src/hdfs/hdfs.hpp (line 237)


Good catch.



src/slave/containerizer/fetcher.hpp (line 255)


Let's only use the key here...

```
bool hasKey(const std::string& key);
```



src/slave/containerizer/fetcher.cpp (line 318)


`if(sizeAndMtime.size.isError()) {` ?



src/slave/containerizer/fetcher.cpp (line 325)


This is not how we wrap ternary operator expressions. We use variable 
indentation...

```
const auto optionalMtime = Option(
sizeAndMtime.mtime.isSome() ? Option(sizeAndMtime.mtime.get())
: None());
```


- Till Toenshoff


On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Nov. 6, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 9, 2015, 1:37 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

plus manual cleanup not matching that pattern or in protobuf
definitions, and updating the C++ style guide.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
  

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39591/
---

(Updated Nov. 9, 2015, 1:37 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
2b003d26d6b6b65b1d7b1dd6396f808c35b53177 
  3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp 
27087041d8255b96159bb10c184f00cf5bc9c34e 
  3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 
4893e7ba0b7d83fd3ba36bf18aa541c60293cc23 
  3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp 
b9a9c20125229c8150660e5969e136b07cecb169 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
e9cf85637157f98a0eac166096bb18fa5652c669 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
0d51c8d418acb49b52cebfb644ee0476d6ec4502 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 
b550bfee696c85c0ade3feaf5d38e20eb4c1ce78 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
e58ee43623d72b52dd8682e3d976da74e8bec9e8 
  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
5d0970fe9f712d7162eec522c83905292892c94d 
  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
12ba1ca861114e60f8276c0ee91c543abcfc2519 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
38dabd45aa1d7f02e9991ce4ae28b44cd39db87c 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp 
ab609a0d7922298eaf89648200fabd843f8201e0 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 
3c320a319edce83af0287b0b014234f7e7ec6e0b 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
a289f8303740394ec1a0900e643d33e3c18a831d 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
7cf4feff87dd08201a410596d2862383c29021af 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
25252015d04884dae7238129e2d7313a615967ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
d9d0fd4febd540252ae53fb4af7eb061983d0133 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
642bd4ce640cfdbf3c122cec64d72c9434d89fa3 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
f766359fdd5a75e3a80d19be3e5c233e87357bde 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
85c773ac675c88b313dffda7a9c32bac42ebe62d 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
51ec75868e614042c339ab0eaa995c9996ddf124 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
d207dc5ad7558818da7fd0d04c6ef8df217b78c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
9625894b69417faa796be5c4313b759cbcc1ce90 
  3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp 
6cbb2ac50dd23d78465e8690112fc01114ada07b 
  3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 
89340fd79167a311c698740454db19e83c286952 
  3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 
60f0c8c67317872883857a1cd8f39d6d6a45d0c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
5748c9e6d39551eee287f3e9804505cb2fd3fdd0 
  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
52d1eea6d04092caa8eba39ad69c2a474f854a8d 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp 
ce94fef4aeeb098668decc36606ee667915a15cd 
  3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp 
95b730c83ec357b33afae0d04182f7a72ffd28c4 
  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
ddd3dd9e015c583e04d72ac9a9b5a5ed6f1d49d5 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
db5e33220844d20ef08a7324f641eeb1ff6d2052 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp 
75b4f9f249ee362e4e12070c1699a8bcd15385e9 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 
b6925962ae65ad9d41bf9fff77973c1117afcbd2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
91d82a8fae27c002458cad0bbdc45b312d2ec70d 
  

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39592/
---

(Updated Nov. 9, 2015, 1:37 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done


Diffs
-

  3rdparty/libprocess/examples/example.cpp 
22ae083d8b5bf59cf52e18405e005cfe94edb81d 
  3rdparty/libprocess/include/process/address.hpp 
7b94979716fed0e2e93967335112835c4b6720a6 
  3rdparty/libprocess/include/process/async.hpp 
676aa4c6849487b2d91b4a2ce458c719396f22f0 
  3rdparty/libprocess/include/process/check.hpp 
4b43b704d6a87725bdde040cbc981dd2da1ad709 
  3rdparty/libprocess/include/process/clock.hpp 
1107a329caf77f15901d87808eee72818601510c 
  3rdparty/libprocess/include/process/collect.hpp 
2a8547b939dda08ce1debbf422654fa9f4593125 
  3rdparty/libprocess/include/process/defer.hpp 
c9caf58aab58c5ed8b5288a43405f88ba3b19c03 
  3rdparty/libprocess/include/process/deferred.hpp 
00072e014159761c18aa7b21fa15dfdbb95f2271 
  3rdparty/libprocess/include/process/delay.hpp 
65e316e12b96f96058292faa4fc7a7f34c5c1c73 
  3rdparty/libprocess/include/process/dispatch.hpp 
c5b8137586113016d702451260c18ff5cfa7c0a2 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/executor.hpp 
0693e4e362aafe208847651bcf83956c26643de7 
  3rdparty/libprocess/include/process/filter.hpp 
db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/firewall.hpp 
b5c7d9976b7a5cbf3cc621559dc361e15059ee67 
  3rdparty/libprocess/include/process/future.hpp 
3916150691e9a0880b8b826734fa74bd33d18cfd 
  3rdparty/libprocess/include/process/gc.hpp 
72fde54ce2f727c89ca49485a0dfee124cb6fc2f 
  3rdparty/libprocess/include/process/gmock.hpp 
575f1ecb3dfbfb7d8f011d408c1e24619406c2b0 
  3rdparty/libprocess/include/process/gtest.hpp 
2ae2a5a16e61304c969c4802990b31beb3964f25 
  3rdparty/libprocess/include/process/help.hpp 
2412db913207b8d6953297870e41a657c742b2a1 
  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/include/process/id.hpp 
a0bb5dbd93bc7e2f245e012032d54969eefd1d3e 
  3rdparty/libprocess/include/process/io.hpp 
73bf30b97c342632e753658fb1f283aa362ce48b 
  3rdparty/libprocess/include/process/latch.hpp 
8a9d12165ea7442ddc68d20d15c8458b388bb679 
  3rdparty/libprocess/include/process/limiter.hpp 
f2efe84212e3a98e5a29e2ec07adc73b5da1ad14 
  3rdparty/libprocess/include/process/logging.hpp 
03fb1bd51e105d0070760af6232dab03e85127d2 
  3rdparty/libprocess/include/process/message.hpp 
e9c7e050a771ff88cbec49f5adb37c04138479be 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
  3rdparty/libprocess/include/process/metrics/gauge.hpp 
13934b8c48012a4ef38ba587deb1bce058425ccc 
  3rdparty/libprocess/include/process/metrics/metric.hpp 
c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f2e84d8e62df58812b660c858eb3b0366db4 
  3rdparty/libprocess/include/process/metrics/timer.hpp 
08f16b89b436eda86418974c5ef16c6ad0e74a5d 
  3rdparty/libprocess/include/process/mime.hpp 
decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
  3rdparty/libprocess/include/process/mutex.hpp 
46e25df66325b029cb3e9bbc5e94d66aa5bac4e8 
  3rdparty/libprocess/include/process/network.hpp 
61bfa8243728dc19ab0e6fb43d33ca83fb3709c3 
  3rdparty/libprocess/include/process/once.hpp 
cbb18680037bac148d7e915081c484791bd6f892 
  3rdparty/libprocess/include/process/owned.hpp 
1b41477d555ce567c58033f8993dc2ae0ac80a05 
  3rdparty/libprocess/include/process/pid.hpp 
e87cfcaf0f93cd9dd0ce7df7299a58fa58982fa7 
  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/include/process/profiler.hpp 
4082b8ae579aa11c688da961e126a94d8f121762 
  3rdparty/libprocess/include/process/protobuf.hpp 
91b51b0ffbdbe791183afacd3fd16238f3af135e 
  3rdparty/libprocess/include/process/queue.hpp 
7e3538763659dd3ca6c8cd61d17abb3af32bb01b 
  3rdparty/libprocess/include/process/reap.hpp 
ca5acc4c8f5a62a49b7fde83946e283ea40baa65 
  3rdparty/libprocess/include/process/run.hpp 
98de0fd30cc1dc5561c924a0e5e5fc18e24cf7a1 
  3rdparty/libprocess/include/process/sequence.hpp 
41da6978c7f2ec198587f024f0fc02f882082cc5 
  3rdparty/libprocess/include/process/shared.hpp 
4f602cc8d6b0d07c8796ffe09772b72a4ce5ddd2 
  3rdparty/libprocess/include/process/socket.hpp 
ebee78909feb5a4032da68f51d08dbf11b03b332 
  3rdparty/libprocess/include/process/ssl/gtest.hpp 
91991f509e480a94de00c6bf20ff0abf083dda8a 
  

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

> On Oct. 8, 2015, 10:21 a.m., Bernd Mathiske wrote:
> > src/tests/master_quota_tests.cpp, line 132
> > 
> >
> > How about adding each test function and have it do nothing, with a TODO 
> > inside, but with a comment of the top what it is supposed to test - instead 
> > of this comment?
> 
> Alexander Rukletsov wrote:
> It's a good idea, I'll do that.

After the second thought, I think a TODO is better. The stubs for tests with 
comments can become outdated in a while, so I would prefer not to invest much 
effort into it.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review101885
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105755
---


Can you split this into 2 reviews? one adding --parent option and the other 
updating apply-review.sh to use apply-reviews.py?

- Vinod Kone


On Nov. 9, 2015, 3:31 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Nov. 9, 2015, 3:31 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39949/
---

(Updated Nov. 9, 2015, 2:23 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
Conway.


Bugs: MESOS-3864
https://issues.apache.org/jira/browse/MESOS-3864


Repository: mesos


Description
---

* Renamed `initialized` to `initialize_started`.
* Renamed `initializing` to `initialize_complete`.
* Removed the (2) condition, described below: 

The initialization synchronization logic contains three conditions, which check:
1) Was `initialize` called and is it done?
2) Was `initialize` called and is it not done?
3) Are you the first to call `initialize`?

Condition (3) uses `compare_exchange_strong` between `initialized` and `false`. 
 This returns `true` (and sets `initialized` to true) iff the caller is the 
first to reach that expression.

The second simultaneous caller of `initialize` will either satisify condition 
(2) or (3) and then wait on `initializing`.  For the second caller, (2) and (3) 
are identical because `compare_exchange_strong` between `true` and `false` will 
always return false, thereby putting the second caller into the waiting loop.


Diffs
-

  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/39949/diff/


Testing
---

`make check`

Replaced `process::initialize();` in `3rdparty/libprocess/src/tests/main.cpp` 
with:
```

  const size_t numThreads = 50;

  std::thread* runningThreads[numThreads];

  // Create additional threads.
  for (size_t i = 0; i < numThreads; i++) {
runningThreads[i] = new std::thread([]() {
  process::initialize();
});
  }

  for (size_t i = 0; i < numThreads; i++) {
runningThreads[i]->join();
delete runningThreads[i];
  }
```
(Also added `#include ` to the header).

Rebuilt `libprocess-tests` with the modification and ran it a few times.
`3rdparty/libprocess/libprocess-tests`


Thanks,

Joseph Wu

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/
---

(Updated Nov. 9, 2015, 2:23 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-3864
https://issues.apache.org/jira/browse/MESOS-3864


Repository: mesos


Description
---

These are remnants of commented-out code, dating back to when libprocess was 
originally open-sourced.


Diffs
-

  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/39948/diff/


Testing
---

None.  Comment change only.


Thanks,

Joseph Wu

Re: Review Request 40107: Removed unused checks in command executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/
---

(Updated Nov. 9, 2015, 9:37 p.m.)


Review request for mesos, Anand Mazumdar and Till Toenshoff.


Repository: mesos


Description
---

Removed unused checks in command executor.


Diffs
-

  src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 

Diff: https://reviews.apache.org/r/40107/diff/


Testing (updated)
---

make check


Thanks,

Timothy Chen

Review Request 40107: Removed unused checks in command executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/
---

Review request for mesos, Anand Mazumdar and Till Toenshoff.


Repository: mesos


Description
---

Removed unused checks in command executor.


Diffs
-

  src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 

Diff: https://reviews.apache.org/r/40107/diff/


Testing
---


Thanks,

Timothy Chen

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105728
---

Ship it!



support/apply-reviews.py (line 42)


the comment only mentions Review Board but the code works for github too?



support/apply-reviews.py (lines 140 - 145)


More and more I look at this code, I feel like the global options is not a 
great idea. I think if these functions took explicit arguments instead of 
depending on global options, it would make it much easy to reason about.

Can you add a TODO for now to clean this up.



support/apply-reviews.py (line 143)


new line please.



support/apply-reviews.py (line 145)


new line please.



support/apply-reviews.py (line 149)


s/the//



support/apply-reviews.py (line 193)


Needs a comment on what this returns.



support/apply-reviews.py (lines 219 - 220)


indentation.



support/apply-reviews.py (lines 259 - 260)


indentation.



support/apply-reviews.py (line 275)


why the temp variable?


- Vinod Kone


On Nov. 9, 2015, 3:32 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Nov. 9, 2015, 3:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40102/#review105759
---


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559]

Failed command: ./support/apply-review.sh -n -r 39559

Error:
 2015-11-09 22:27:15 URL:https://reviews.apache.org/r/39559/diff/raw/ 
[10306/10306] -> "39559.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:65
error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does not 
apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:83
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 9:53 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40102/
> ---
> 
> (Updated Nov. 9, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3860
> https://issues.apache.org/jira/browse/MESOS-3860
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Unified POSIX and Windows implementation of process.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 741639a942971e48e2dac42db238d423e61cac21 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 99afbf8e9424b3644aaec2739bb3734bdaffbfde 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 
> 204acaf7836e8a516e10767cc9f9632bca352cce 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> e8238383c3c5feb688b10e37e544556ba9d43107 
> 
> Diff: https://reviews.apache.org/r/40102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/
---

(Updated Nov. 10, 2015, 4:58 a.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-3705
https://issues.apache.org/jira/browse/MESOS-3705


Repository: mesos


Description
---

When using the same socket to send multiple HTTP requests to different actors. 
If the actor responsible for handling the first request is stuck handling 
another event while a subsequent request can reply immediatly, the order of the 
responses is altered violating HTTP Pipelining.

This patch fixes that problem enforcing that every response is sent in the 
order the corresponding request arrived. It also adds a test to reproduce the 
issue and verify the fix works.


Diffs (updated)
-

  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39276/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review105788
---


Patch looks great!

Reviews applied: [39276, 37998, 37999, 38000, 38094, 38627, 38950, 39043]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 4:03 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Nov. 10, 2015, 4:03 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/
---

(Updated Nov. 10, 2015, 5 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3232
https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/38094/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
---

(Updated Nov. 10, 2015, 4:58 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

`ProcessManager::handle()` is a method used to process HTTP requests, its 
signature returns a boolean which is not used anywhere and it doesn't allow for 
asynchronous operations within handle.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/37998/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 10, 2015, 4:59 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Nov. 10, 2015, 4:59 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 40125: Fixed quoted strings in executor log messages on agent

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/#review105794
---


Bad patch!

Reviews applied: [40125]

Failed command: ./support/apply-review.sh -n -r 40125

Error:
 2015-11-10 05:50:58 URL:https://reviews.apache.org/r/40125/diff/raw/ 
[7206/7206] -> "40125.patch" [1]
error: patch failed: src/slave/slave.cpp:1626
error: src/slave/slave.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 5:46 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40125/
> ---
> 
> (Updated Nov. 10, 2015, 5:46 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As part of MESOS-3480, we introduced an output operator for the `Executor` 
> struct on agent. It seems like the changes for MESOS-3772 got interpolated 
> with that change later leading to erroneous quotes in executor log messages.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
> 
> Diff: https://reviews.apache.org/r/40125/diff/
> 
> 
> Testing
> ---
> 
> make check. I still wonder though how this escaped without merge conflicts 
> when committing MESOS-3772.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
---

(Updated Nov. 10, 2015, 5:01 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3072
https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
---

Allows developers to provide their own parameters when loading modules instead 
of using the ones provided by the user when loading Mesos. This helps to deal 
with default modules (those used when the user doesn't provide any), and for 
testing of the modules.


Diffs (updated)
-

  src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
  src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Nov. 10, 2015, 5:03 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
Toenshoff.


Changes
---

Rebase


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Nov. 10, 2015, 5:02 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 
  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/#review105780
---


Bad patch!

Reviews applied: [39832, 39882, 39839, 38579, 39015, 39016, 39017, 39053, 
39112, 39340, 39840, 38580, 40120]

Failed command: ./support/apply-review.sh -n -r 40120

Error:
 2015-11-10 01:44:58 URL:https://reviews.apache.org/r/40120/diff/raw/ 
[18570/18570] -> "40120.patch" [1]
error: src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp: 
does not exist in index
error: src/tests/containerizer/provisioner_docker_tests.cpp: does not exist in 
index
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 1:25 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39250/
> ---
> 
> (Updated Nov. 10, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Puller refactor: moved untar to a common place
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f314f20d989ed0125e15d2a14d0f8e56c56976d5 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 8010b8aa75a2fc2e4b537f915f9dca028e407b63 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39250/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105786
---



support/apply-reviews.py (lines 187 - 188)


Can we enhance it as following:
```
amend=options['no_amend'] ? '' : '-e'
cmd = 'git commit --author \'{author}\' {amend} -am \'{message}\''\
.format(author=quote(data['author']),
amend=amend,
message=quote(data['message']))
```

With this, we can now get rid of `amend_patch()`. This will speed up the 
process since we don't have to call `git commit --amend`. As we know, a call to 
`git commit --amend` without any staged file forces a full run of 
mesos-style.py, which can take several seconds.


- Kapil Arya


On Nov. 9, 2015, 10:32 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Nov. 9, 2015, 10:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review105787
---


Bad patch!

Reviews applied: [39276]

Failed command: ./support/apply-review.sh -n -r 39276

Error:
 2015-11-10 04:17:56 URL:https://reviews.apache.org/r/39276/diff/raw/ 
[12246/12246] -> "39276.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:3154
error: 3rdparty/libprocess/src/process.cpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/tests/http_tests.cpp:28
error: 3rdparty/libprocess/src/tests/http_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 4:03 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Nov. 10, 2015, 4:03 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105790
---


Bad patch!

Reviews applied: [40062]

Failed command: ./support/apply-review.sh -n -r 40062

Error:
 2015-11-10 05:28:49 URL:https://reviews.apache.org/r/40062/diff/raw/ 
[4997/4997] -> "40062.patch" [1]
error: patch failed: src/slave/slave.cpp:3341
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/slave_tests.cpp:618
error: src/tests/slave_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 5:16 a.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> ---
> 
> (Updated Nov. 10, 2015, 5:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Review Request 40125: Fixed quoted strings in executor log messages on agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/
---

Review request for mesos, Joris Van Remoortere and Neil Conway.


Repository: mesos


Description
---

As part of MESOS-3480, we introduced an output operator for the `Executor` 
struct on agent. It seems like the changes for MESOS-3772 got interpolated with 
that change later leading to erroneous quotes in executor log messages.


Diffs
-

  src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 

Diff: https://reviews.apache.org/r/40125/diff/


Testing
---

make check. I still wonder though how this escaped without merge conflicts when 
committing MESOS-3772.


Thanks,

Anand Mazumdar

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105795
---


Patch looks great!

Reviews applied: [40062]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 5:16 a.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> ---
> 
> (Updated Nov. 10, 2015, 5:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

[Vaibhav Khanduja]

> On Nov. 9, 2015, 7:27 p.m., Joseph Wu wrote:
> > include/mesos/mesos.proto, line 372
> > 
> >
> > Should we also remove this from v1/mesos.proto?

Fixed


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105723
---


On Nov. 9, 2015, 1:16 a.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> ---
> 
> (Updated Nov. 9, 2015, 1:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

> On Nov. 2, 2015, 8:38 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, 
> > lines 34-71
> > 
> >
> > Can you please explain why we can't just use `mktemp` here?
> > I acknowledge that the idea behind `mktemp` is to guarantee that the 
> > directory name can't collide with an existing one, but the custom 
> > implementation you provide also doesn't do that while generating the name, 
> > correct?
> 
> Joseph Wu wrote:
> Windows doesn't have a temp-directory function.  Are you suggesting 
> calling `mktemp` and then using the file's name as the argument to `mkdir`?
> 
> Joris Van Remoortere wrote:
> Indeed. It seems like that's what we are doing manually right now?
> 
> Alex Clemmer wrote:
> I'm not a C programmer, so feel free to tell me if there is faulty 
> reasoning here, but a colleague looked at an early version of this code and 
> told me that in some versions of the C standard library on Windows `_mktemp` 
> and `_mktemp_s` will replace the template `XX` with the process ID, and 
> append a single letter to the end, meaning that there are 26 unique filenames 
> possible. And, while `mktemp` and `mkstemp` seem to be used only in the test 
> harness, `mkdtemp` is in a few places that seem important. So, I figured, it 
> will take me not-too-long to just write the function myself, so why not. I 
> looked at some other implementations (_e.g._ that of Postgres) but they were 
> mostly quite complex due to trying to be cryptographically secure. So I opted 
> for my simple approach.
> 
> I think you are right that we should retry if there is a name collision 
> though, so based on my read, I suggest that I make that change.
> 
> Does this seem reasonable to you?

Ok, per the extended discussion, I've decided to leave this alone. The reasons, 
summarized, are:

(1) We agree we can't use `_mktemp_s` and `_mktemp` due to the documentation 
explicitly saying only 26 filenames are possible
(2) This is only used in tests, unlike `mkstemp` (which, by the way, does not 
suffer from this problem), which means it is ok for this not to be a completely 
robust solution. (BTW, we should also _never_ use `mktemp` on Linux either, for 
the same reason as above; this is just a general problem with implementations 
of this routine, especially on older systems.)
(3) The existing solutions that are Apache v2 compatible are dramatically more 
complicated, and not worth the code review overhead


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review104778
---


On Nov. 9, 2015, 5:58 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> ---
> 
> (Updated Nov. 9, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 741639a942971e48e2dac42db238d423e61cac21 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> fc2df6831ae2cb1a91c7a8cc92965939576e575d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39989/#review105714
---


Patch looks great!

Reviews applied: [39985, 39986, 39987, 39988, 39989]

All tests passed.

- Mesos ReviewBot


On Nov. 9, 2015, 5:26 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39989/
> ---
> 
> (Updated Nov. 9, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added framework authorization for dynamic reservation.
> Note: this review is continued from https://reviews.apache.org/r/37127/
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
> 
> Diff: https://reviews.apache.org/r/39989/diff/
> 
> 
> Testing
> ---
> 
> This is the fifth in a chain of 5 patches. New reservation tests were added 
> to `reservation_tests.cpp` to validate the authentication of framework 
> reserve and unreserve operations using ACLs. `make check` was run to test 
> after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105685
---


Bad patch!

Reviews applied: [38705, 38883, 39410]

Failed command: ./support/apply-review.sh -n -r 39410

Error:
 2015-11-09 15:41:06 URL:https://reviews.apache.org/r/39410/diff/raw/ 
[13112/13112] -> "39410.patch" [1]
error: support/apply-reviews.py: does not exist in index
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 3:31 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Nov. 9, 2015, 3:31 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105692
---


Bad patch!

Reviews applied: [40087]

Failed command: ./support/apply-review.sh -n -r 40087

Error:
 2015-11-09 16:39:19 URL:https://reviews.apache.org/r/40087/diff/raw/ [981/981] 
-> "40087.patch" [1]
40087.patch:10: trailing whitespace.
supports HTTP, HTTPS, FTP and FTPS protocols. If the requested URI is based on 
40087.patch:11: trailing whitespace.
some other protocol, then the fetcher tries to utilise local a Hadoop client 
warning: 2 lines add whitespace errors.
Successfully applied: Added a list of protocols supported by the Mesos fetcher 
as requested in MESOS-2783

Documentation. Added a list of protocols supported by the Mesos fetcher as 
requested in MESOS-2783


Review: https://reviews.apache.org/r/40087
docs/fetcher.md:20: trailing whitespace.
+supports HTTP, HTTPS, FTP and FTPS protocols. If the requested URI is based on 
docs/fetcher.md:21: trailing whitespace.
+some other protocol, then the fetcher tries to utilise local a Hadoop client 
Failed to commit patch

- Mesos ReviewBot


On Nov. 9, 2015, 4:34 p.m., Andrey Dyatlov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> ---
> 
> (Updated Nov. 9, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation. Added a list of protocols supported by the Mesos fetcher as 
> requested in MESOS-2783
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 
> 
> Diff: https://reviews.apache.org/r/40087/diff/
> 
> 
> Testing
> ---
> 
> Problem: In the description of the MESOS-2783 the list of protocols or 
> schemas supported by the Mesos fetcher is requested. The bug is marked as 
> resolved, but the documentation still doesn't contain this list. 
> Solution: The list was made according to the following source files: 
> src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
> 
> 
> Thanks,
> 
> Andrey Dyatlov
> 
>

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/
---

(Updated Nov. 9, 2015, 4:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Joris' comment.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Processing quota request consists of several stages: request validation, sanity 
check and so on. This patch creates a basic workflow for quota requests, while 
the stages are implemented in subsequent patches.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38059/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39989/
---

(Updated Nov. 9, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Added framework authorization for dynamic reservation.
Note: this review is continued from https://reviews.apache.org/r/37127/


Diffs (updated)
-

  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 

Diff: https://reviews.apache.org/r/39989/diff/


Testing
---

This is the fifth in a chain of 5 patches. New reservation tests were added to 
`reservation_tests.cpp` to validate the authentication of framework reserve and 
unreserve operations using ACLs. `make check` was run to test after all patches 
were applied.


Thanks,

Greg Mann

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/
---

(Updated Nov. 9, 2015, 5:58 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::mkdtemp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
741639a942971e48e2dac42db238d423e61cac21 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
fc2df6831ae2cb1a91c7a8cc92965939576e575d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 

Diff: https://reviews.apache.org/r/39559/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 9, 2015, 5:49 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased; updated comments.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39966: Fix a typo in ssl.md: After -> Before

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39966/#review105712
---

Ship it!


Ship It!

- Joris Van Remoortere


On Nov. 5, 2015, 4:02 a.m., Chengwei Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39966/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Chengwei Yang 
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 6bc8cc6563766535d4fa258a7c5d859b15293868 
> 
> Diff: https://reviews.apache.org/r/39966/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 9, 2015, 5:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39988/
---

(Updated Nov. 9, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Added authorization for dynamic reservation master endpoints.
Note: this review is continued from https://reviews.apache.org/r/37126/


Diffs (updated)
-

  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 

Diff: https://reviews.apache.org/r/39988/diff/


Testing
---

This is the fourth in a chain of 5 patches. Added new reservation endpoints 
tests to validate authorization of reserve and unreserve operations using ACLs. 
`make check` was run to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 9, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39985/
---

(Updated Nov. 9, 2015, 5:25 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Introduced ACL protobuf definitions for dynamic reservation.
Note: this review is continued from https://reviews.apache.org/r/37002/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/39985/diff/


Testing
---

This is the first in a chain of 5 patches. `make check` was used to test at the 
end of the chain.


Thanks,

Greg Mann

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39987/
---

(Updated Nov. 9, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Added 'Master::authorize' for Reserve/Unreserve.
Note: this review is continued from https://reviews.apache.org/r/37125/


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 

Diff: https://reviews.apache.org/r/39987/diff/


Testing
---

This is the third in a chain of 5 patches. `make check` was used to test after 
all patches were applied.


Thanks,

Greg Mann

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/
---

(Updated Nov. 9, 2015, 5:37 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Comments; rebased.


Bugs: MESOS-3074
https://issues.apache.org/jira/browse/MESOS-3074


Repository: mesos


Description
---

Performs a check whether a quota request is reasonable and can be satisfied at 
the moment. A precise answer is impossible here, but a sanity check is still 
helpful, because it allows us to filter knowingly unsatisfiable requests.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38110/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39018: Added JSON parsing for Resources.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/
---

(Updated Nov. 9, 2015, 4:48 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Catch error from `Resources::validate()`.


Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description
---

This includes code changes necessary for JSON parsing of Resources. 
Documentation changes will be posted soon in another review 
(https://reviews.apache.org/r/39102/).


Diffs (updated)
-

  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/39018/diff/


Testing
---

New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
added: `ResourcesTest.ParsingFromJSONWithRoles` and 
`ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
scenarios that might show up in user-supplied JSON.

`make check` was used to confirm that all tests pass.

The original resources parsing format is used throughout many other tests 
(check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
original parsing continues to work correctly.


Thanks,

Greg Mann

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Nov. 9, 2015, 7:32 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 9, 2015, 4:06 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/
---

(Updated Nov. 9, 2015, 3:25 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Updated comments; rebased.


Bugs: MESOS-3716
https://issues.apache.org/jira/browse/MESOS-3716


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  src/master/allocator/mesos/allocator.hpp 
c5375aa89b210e46c41ac7d68d119749de15d2f5 
  src/master/allocator/mesos/hierarchical.hpp 
cfd937ba306273c24fb5337dfeb1a15e1545169b 
  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
  src/tests/allocator.hpp 4ab476638dedc96f1073bb9cb8bd0fd44102611d 

Diff: https://reviews.apache.org/r/38218/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105693
---



docs/fetcher.md (line 19)


s/, it/and it



docs/fetcher.md (line 20)


s/supports/supports the



docs/fetcher.md (line 21)


s/local a/a local



docs/fetcher.md (line 22)


s/./, e.g., HDFS, S3. See the slave [confifuration 
documentation](/documentation/latest/configuration/) for how to configure the 
slave with a path to the Hadoop client.


- Bernd Mathiske


On Nov. 9, 2015, 8:34 a.m., Andrey Dyatlov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> ---
> 
> (Updated Nov. 9, 2015, 8:34 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation. Added a list of protocols supported by the Mesos fetcher as 
> requested in MESOS-2783
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 
> 
> Diff: https://reviews.apache.org/r/40087/diff/
> 
> 
> Testing
> ---
> 
> Problem: In the description of the MESOS-2783 the list of protocols or 
> schemas supported by the Mesos fetcher is requested. The bug is marked as 
> resolved, but the documentation still doesn't contain this list. 
> Solution: The list was made according to the following source files: 
> src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
> 
> 
> Thanks,
> 
> Andrey Dyatlov
> 
>

Re: Review Request 39317: Quota: Moved `QuotaInfo` protobuf into a separate package.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Nov. 9, 2015, 3:23 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/
---

(Updated Nov. 9, 2015, 3:59 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Added a file for validation.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Processing quota request consists of several stages: request validation, sanity 
check and so on. This patch creates a basic workflow for quota requests, while 
the stages are implemented in subsequent patches.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38059/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39018: Added JSON parsing for Resources.

[Greg Mann]

> On Nov. 9, 2015, 6:43 a.m., Adam B wrote:
> > src/common/resources.cpp, lines 356-357
> > 
> >
> > Doesn't Resources::validate() return an Error? Why not use that Error 
> > and its message with your return?

Derp. Fixed it, thanks Adam.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review105653
---


On Nov. 9, 2015, 4:48 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
> 
> (Updated Nov. 9, 2015, 4:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review 
> (https://reviews.apache.org/r/39102/).
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> ---
> 
> New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
> added: `ResourcesTest.ParsingFromJSONWithRoles` and 
> `ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
> scenarios that might show up in user-supplied JSON.
> 
> `make check` was used to confirm that all tests pass.
> 
> The original resources parsing format is used throughout many other tests 
> (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
> original parsing continues to work correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 9, 2015, 7:31 a.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs (updated)
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 9, 2015, 7:31 a.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

[Andrey Dyatlov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/
---

Review request for mesos, Alexander Rojas and Bernd Mathiske.


Bugs: MESOS-2783
https://issues.apache.org/jira/browse/MESOS-2783


Repository: mesos


Description
---

Documentation. Added a list of protocols supported by the Mesos fetcher as 
requested in MESOS-2783


Diffs
-

  docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 

Diff: https://reviews.apache.org/r/40087/diff/


Testing
---

Problem: In the description of the MESOS-2783 the list of protocols or schemas 
supported by the Mesos fetcher is requested. The bug is marked as resolved, but 
the documentation still doesn't contain this list. 
Solution: The list was made according to the following source files: 
src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.


Thanks,

Andrey Dyatlov

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Joseph Wu]

> On Nov. 5, 2015, 12:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 83-88
> > 
> >
> > Why don't you just parse a QuotaInfo object instead of a 
> > form-serialized body (with JSON components)?
> > 
> > The maintenance endpoints do this for simplicity.
> 
> Alexander Rukletsov wrote:
> Because we didn't want to expose the internal structure (`QuotaInfo`) to 
> the outside world. In the future we may want to allow operators to set quotas 
> for multiple roles in one call, which we can easier do if we do not tie the 
> operator API to `QuotaInfo` protobuf. Does it make sense?

`QuotaInfo` should already be exposed, since it's in the `include` folder.

As for setting multiple `QuotaInfo`s in a single call, wouldn't that be simpler 
to implement via a JSON array?
(Maybe you can parse the request body as an array, but reject calls with more 
than one quota request in the MVP.)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
---


On Nov. 9, 2015, 8:39 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 9, 2015, 8:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38747: Adding digest utilities

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/
---

(Updated Nov. 9, 2015, 8:17 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Michael Park, and Timothy 
Chen.


Changes
---

adding mpark as reviewer


Repository: mesos


Description (updated)
---

Added templatized implementations for digests.


Diffs
-

  3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
99c9754b6a5c7ceb12808a782da9cb9fb3fc731e 
  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38747/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 9, 2015, 7:31 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad

Re: Review Request 39331: Support docker local store pull image simultaneously

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/
---

(Updated Nov. 9, 2015, 11:26 a.m.)


Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Timothy 
Chen.


Bugs: MESOS-3736
https://issues.apache.org/jira/browse/MESOS-3736


Repository: mesos


Description
---

Support docker local store pull image simultaneously


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.hpp 
95e46b9914c018b3e2472f98a54bc33ff9a46e17 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
bb02d650e16d45fcf337a7954f7a26143fb2c69f 
  src/tests/containerizer/provisioner_docker_tests.cpp 
fe6a90fe32364eec8ef923a000db19183603c338 

Diff: https://reviews.apache.org/r/39331/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

*This is not ready to be merged.
*Still considering two question:
 1. Handling simultaneous failure. If the first request is called and is 
written into the hashmap. All the other requests will be waiting for the future 
of the first request. But because its return type is 'Future', 
if its future status is 'FAILED/DISCARDED', the other requests will be waiting 
forever. 
Solved by logic check: if it is the first call to get() Image_A, promise 
associate with metadateManager->get(). If not, check whether that promised 
future failed/discarded. If yes, over write to the hashmap.

 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be 
unique because there is chance that layer_ids can be changed. 
One solution is to have 'stringify(image)' as key.


Thanks,

Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review105733
---


Bad patch!

Reviews applied: [39331]

Failed command: ./support/apply-review.sh -n -r 39331

Error:
 2015-11-09 19:55:37 URL:https://reviews.apache.org/r/39331/diff/raw/ 
[7525/7525] -> "39331.patch" [1]
error: src/slave/containerizer/mesos/provisioner/docker/store.hpp: does not 
exist in index
error: src/slave/containerizer/mesos/provisioner/docker/store.cpp: does not 
exist in index
error: src/tests/containerizer/provisioner_docker_tests.cpp: does not exist in 
index
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 7:26 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39331/
> ---
> 
> (Updated Nov. 9, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3736
> https://issues.apache.org/jira/browse/MESOS-3736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support docker local store pull image simultaneously
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 95e46b9914c018b3e2472f98a54bc33ff9a46e17 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> bb02d650e16d45fcf337a7954f7a26143fb2c69f 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> fe6a90fe32364eec8ef923a000db19183603c338 
> 
> Diff: https://reviews.apache.org/r/39331/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> *This is not ready to be merged.
> *Still considering two question:
>  1. Handling simultaneous failure. If the first request is called and is 
> written into the hashmap. All the other requests will be waiting for the 
> future of the first request. But because its return type is 
> 'Future', if its future status is 'FAILED/DISCARDED', the 
> other requests will be waiting forever. 
> Solved by logic check: if it is the first call to get() Image_A, promise 
> associate with metadateManager->get(). If not, check whether that promised 
> future failed/discarded. If yes, over write to the hashmap.
> 
>  2. The current hashmap uses 'stringify(image::name)' as key, but it may not 
> be unique because there is chance that layer_ids can be changed. 
> One solution is to have 'stringify(image)' as key.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105723
---



include/mesos/mesos.proto 


Should we also remove this from v1/mesos.proto?


- Joseph Wu


On Nov. 8, 2015, 5:16 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> ---
> 
> (Updated Nov. 8, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

[Joseph Wu]

> On Nov. 7, 2015, 7:35 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 742-770
> > 
> >
> > Could we document why we're not just using process::Once to clean this 
> > up?
> > 
> > The only thing that comes to mind is the performance implications of 
> > changing from a spin loop to the mutex condition variable approach, given 
> > that this gets called all over the place.

I don't know why we don't use `Once` either.  Perhaps because the 
synchronization logic predates `Once`?  (And that wouldn't be a very good 
reason.)

`Once` was added April 30, 2012:
https://github.com/apache/mesos/commit/6c3b107e4e02d5ba0673eb3145d71ec9d256a639#diff-0eebc8689450916990abe080d86c2acb

The libprocess synchronization logic has been mostly unchanged since June 04, 
2011:
https://github.com/apache/mesos/commit/cd757cf75637c92c438bf4cd22f21ba1b5be702f#diff-128d3b56fc8c9ec0176fdbadcfd11fc2


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39949/#review105602
---


On Nov. 6, 2015, 2:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39949/
> ---
> 
> (Updated Nov. 6, 2015, 2:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3820
> https://issues.apache.org/jira/browse/MESOS-3820
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Renamed `initialized` to `initialize_started`.
> * Renamed `initializing` to `initialize_complete`.
> * Removed the (2) condition, described below: 
> 
> The initialization synchronization logic contains three conditions, which 
> check:
> 1) Was `initialize` called and is it done?
> 2) Was `initialize` called and is it not done?
> 3) Are you the first to call `initialize`?
> 
> Condition (3) uses `compare_exchange_strong` between `initialized` and 
> `false`.  This returns `true` (and sets `initialized` to true) iff the caller 
> is the first to reach that expression.
> 
> The second simultaneous caller of `initialize` will either satisify condition 
> (2) or (3) and then wait on `initializing`.  For the second caller, (2) and 
> (3) are identical because `compare_exchange_strong` between `true` and 
> `false` will always return false, thereby putting the second caller into the 
> waiting loop.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
> 
> Diff: https://reviews.apache.org/r/39949/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Replaced `process::initialize();` in `3rdparty/libprocess/src/tests/main.cpp` 
> with:
> ```
> 
>   const size_t numThreads = 50;
> 
>   std::thread* runningThreads[numThreads];
> 
>   // Create additional threads.
>   for (size_t i = 0; i < numThreads; i++) {
> runningThreads[i] = new std::thread([]() {
>   process::initialize();
> });
>   }
> 
>   for (size_t i = 0; i < numThreads; i++) {
> runningThreads[i]->join();
> delete runningThreads[i];
>   }
> ```
> (Also added `#include ` to the header).
> 
> Rebuilt `libprocess-tests` with the modification and ran it a few times.
> `3rdparty/libprocess/libprocess-tests`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 9, 2015, 8:25 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad

Re: Review Request 39636: FreeBSD: Add basic support to stout

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39636/#review105800
---


Bad patch!

Reviews applied: [39634, 39635]

Failed command: ./support/apply-review.sh -n -r 39635

Error:
 2015-11-10 06:54:05 URL:https://reviews.apache.org/r/39635/diff/raw/ 
[4293/4293] -> "39635.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/http_tests.cpp:885
error: 3rdparty/libprocess/src/tests/http_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 6:35 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39636/
> ---
> 
> (Updated Nov. 10, 2015, 6:35 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Add basic support to stout
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> dc7c6522b283916b975a77957909f6cdc02944d3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 9428717fac4655898d7768957f02937592e1a398 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> fc2df6831ae2cb1a91c7a8cc92965939576e575d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
> 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 1baf142d53fd06149c80d4b2677c2a976c05ef71 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> e9b05ef3b59fd068137cb12e36591de2d4a801a1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
> 0a98e9e310d3931c2341053595b7d62f68214783 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 8a8ede325cfe8f024e1be4db24b0c8118d18f359 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
> 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39636/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> gmake check on FreeBSD 10.2 (failing, log attached)
> 
> 
> File Attachments
> 
> 
> check.log
>   
> https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Nov. 9, 2015, 11:48 p.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

> On Nov. 9, 2015, 8:11 p.m., Kapil Arya wrote:
> > support/apply-reviews.py, lines 196-197
> > 
> >
> > Can we enhance it as following:
> > ```
> > amend=options['no_amend'] ? '' : '-e'
> > cmd = 'git commit --author \'{author}\' {amend} -am \'{message}\''\
> > .format(author=quote(data['author']),
> > amend=amend,
> > message=quote(data['message']))
> > ```
> > 
> > With this, we can now get rid of `amend_patch()`. This will speed up 
> > the process since we don't have to call `git commit --amend`. As we know, a 
> > call to `git commit --amend` without any staged file forces a full run of 
> > mesos-style.py, which can take several seconds.

TIL Python does not have a ternary operator, but point taken :).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105786
---


On Nov. 9, 2015, 7:32 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Nov. 9, 2015, 7:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39636: FreeBSD: Add basic support to stout

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39636/
---

(Updated Nov. 10, 2015, 6:35 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Add basic support to stout


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
fc2df6831ae2cb1a91c7a8cc92965939576e575d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
e9b05ef3b59fd068137cb12e36591de2d4a801a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
0a98e9e310d3931c2341053595b7d62f68214783 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
8a8ede325cfe8f024e1be4db24b0c8118d18f359 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39636/diff/


Testing
---

make check on ubuntu 14.04

gmake check on FreeBSD 10.2 (failing, log attached)


File Attachments


check.log
  
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log


Thanks,

David Forsythe

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 10, 2015, 6:35 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Joris Van Remoortere]

> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 1
> > 
> >
> > It seems other feature named file without "_handler"; any consideration 
> > for it?
> 
> Joerg Schad wrote:
> In this case the file acutally only includes the handler part (basically 
> in order not to overload the http code) and hence the name seems to be 
> precise.

We can re-visit this later if we find the pattern here doesn't warrant the 
`_handler` extension. Dropping for now.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105425
---


On Nov. 9, 2015, 11:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 9, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 9, 2015, 11:57 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description
---

Added '--chain' option to apply-reviews.py.


Diffs
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/39420/diff/


Testing (updated)
---

Tested with python 2.7.

- With and without '-c'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105801
---


Let's just try and make this chain a little easier to follow. Right now the 
reviews are heavily inter-leaved.


src/master/quota_handler.cpp (line 48)


Let's sync this to a `Try` to avoid confusion.



src/master/quota_handler.cpp (lines 63 - 67)


Let's just leave the comment here, since Joerg is implementing this 
validation. This will reduce the rebasing overhead.



src/master/quota_handler.cpp (line 69)


Let's just construct a dummy `QuotaInfo` here (like your did above) to 
avoid the intricate dependency between this and the next patch.



src/master/quota_handler.cpp (line 74)


We're prefacing what is bout to happen here, right? s/Populated/Populate/
s/We do it/We do this



src/master/quota_handler.cpp (line 79)


Can we initialize this as `quota = {quotaInfo}`?



src/master/quota_handler.cpp (line 82)


s/Update registry/Update the registry/


- Joris Van Remoortere


On Nov. 9, 2015, 11:14 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 9, 2015, 11:14 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 
>   src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 9, 2015, 11:56 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description (updated)
---

Added '--chain' option to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/39420/diff/


Testing (updated)
---

Tested with python 2.7.

- with and without '-c'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 40125: Fixed quoted strings in executor log messages on agent

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/#review105797
---

Ship it!


Ship It!

- Joris Van Remoortere


On Nov. 10, 2015, 5:46 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40125/
> ---
> 
> (Updated Nov. 10, 2015, 5:46 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As part of MESOS-3480, we introduced an output operator for the `Executor` 
> struct on agent. It seems like the changes for MESOS-3772 got interpolated 
> with that change later leading to erroneous quotes in executor log messages.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
> 
> Diff: https://reviews.apache.org/r/40125/diff/
> 
> 
> Testing
> ---
> 
> make check. I still wonder though how this escaped without merge conflicts 
> when committing MESOS-3772.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
---

(Updated Nov. 10, 2015, 6:35 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
b73196cfa18e0d270e2533fbf733ad91e0559286 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
---

make check on ubuntu


Thanks,

David Forsythe

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105798
---

Ship it!



src/master/master.hpp (line 859)


If we want to signify that this is not implemented, let's use the 
`http::NotImplemented` message. Here and below.


- Joris Van Remoortere


On Nov. 9, 2015, 11:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Nov. 9, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/
---

(Updated Nov. 9, 2015, 2:52 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

More cleanup.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38705/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/
---

(Updated Nov. 9, 2015, 2:57 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

More cleanups.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38883/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Nov. 9, 2015, 2:57 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 9, 2015, 2:58 a.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs (updated)
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105664
---


Bad patch!

Reviews applied: [38705, 38883, 39410, 39420]

Failed command: ./support/apply-review.sh -n -r 39420

Error:
 2015-11-09 11:14:00 URL:https://reviews.apache.org/r/39420/diff/raw/ 
[4921/4921] -> "39420.patch" [1]
error: patch failed: support/apply-review.sh:1
error: support/apply-review.sh: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 10:58 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Nov. 9, 2015, 10:58 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/
---

(Updated Nov. 9, 2015, 11:33 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3232
https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/38094/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 9, 2015, 11:10 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 9, 2015, 11:30 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad