Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review114898
---


Patch looks great!

Reviews applied: [42100]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 17, 2016, 6:49 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 17, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Jan. 17, 2016, 6:49 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description (updated)
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Jan. 17, 2016, 6:48 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

put all trap handlers in the same function


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/42100


Diffs (updated)
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review114896
---


Thanks! Just a small comment below.


support/docker_build.sh (lines 125 - 135)


Are you sure that this doesn't over-write the period trap?


http://stackoverflow.com/questions/3338030/multiple-bash-traps-for-the-same-signal


- Ben Mahler


On Jan. 9, 2016, 2:38 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 9, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32975/#review114895
---



src/tests/fetcher_tests.cpp (line 706)


What about adding another test case, e.g. `ROOT_ExtractChownUser`, which 
would be executed when the tests are running as the root user, and 
automatically disabled if not. 

In this test case we can set chown target to some famous linux system user, 
e.g. `daemon`.


- Shuai Lin


On Jan. 13, 2016, 6:06 p.m., Jim Klucar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32975/
> ---
> 
> (Updated Jan. 13, 2016, 6:06 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1790
> https://issues.apache.org/jira/browse/MESOS-1790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added chown to CommandInfo.URI protocol buffer as an optional
> boolean that defaults to true, the current chown behavior.
> 
> The fetcher was updated to skip the os::chown operation if the chown
> boolean is set to false.
> 
> No documentation was updated.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 
>   src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b 
>   src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 
>   src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e 
> 
> Diff: https://reviews.apache.org/r/32975/diff/
> 
> 
> Testing
> ---
> 
> Unit testing this functionality is difficult because it would require that 
> the user running the test to have permission to chown a file to someone other 
> than themselves. I didn't want to add that as a requirement to build. I added 
> the new field to the existing test cases just to see that they populate.
> 
> 
> Thanks,
> 
> Jim Klucar
> 
>

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/
---

(Updated Jan. 17, 2016, 3:33 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-4249
https://issues.apache.org/jira/browse/MESOS-4249


Repository: mesos


Description (updated)
---

This still requires the slave work dir is a mounted volume, otherwise
the slave has no way to fetch into the task container's sandbox.


Diffs
-

  src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece 

Diff: https://reviews.apache.org/r/42390/diff/


Testing
---

- Start a master, then start the slave inside a docker container, with the 
work_dir being a mounted volume
- Start a simple framework, which, on receiving the first offer, launches a 
task with a uri in the command info
- When the task container is launched, check the file is fetched into the 
sandbox
```sh
$ docker exec  ls /mnt/mesos/sandbox
robots.txt
stderr
stdout
```


Thanks,

Shuai Lin

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 一月 17, 2016, 2:24 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

The function of `createFrameworkInfo` was updated by enabling
caller can set a bool parameter to create a framework which can
use revocable resources.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
9362dd306497ba01e0f387c3862456cdcac6f863 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42040: Added Quota Operator Documentation.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review114892
---

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 13, 2016, 2:43 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> ---
> 
> (Updated Jan. 13, 2016, 2:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van 
> Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Operator Documentation.
> 
> 
> Diffs
> -
> 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/quota.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42040/diff/
> 
> 
> Testing
> ---
> 
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
> Used docker website renderer to check output and links
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 42386: Updated createFrameworkInfo for hierarchical_allocator_tests.cpp.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review114891
---



src/tests/hierarchical_allocator_tests.cpp (line 201)


Should be "bool", not "const bool&".


- Neil Conway


On Jan. 16, 2016, 5 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated Jan. 16, 2016, 5 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
> https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function of `createFrameworkInfo` was updated by enabling
> caller can set a bool parameter to create a framework which can
> use revocable resources.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42305: Updated comments around sorters in the allocator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114890
---

Ship it!



src/master/allocator/mesos/hierarchical.hpp (line 409)


I think you mean `Level 1`?


- Joris Van Remoortere


On Jan. 14, 2016, 3:39 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42305/
> ---
> 
> (Updated Jan. 14, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4128
> https://issues.apache.org/jira/browse/MESOS-4128
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5f08b6e7d18766d7d0f8350a280ec577b4895fb9 
> 
> Diff: https://reviews.apache.org/r/42305/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42222: Added a comment on allocator recovery.

[Joris Van Remoortere]

> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 205-206
> > 
> >
> > It looks like if we trip the `resume` call in `addSlave`, this delayed 
> > resume will crash the master due to the `CHECK(paused)` that currently 
> > resides in `resume`.
> > 
> > Something I'm missing?

Thanks for your review Ben!
I'm committing just the comment change for this patch.
I'll leave this issue open as we want to address it in a separate patch.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review114628
---


On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4/
> ---
> 
> (Updated Jan. 12, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/4/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42222: Added a comment on allocator recovery.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review114888
---

Ship it!


I've rephrased and moved the comment as per BenM's suggestion.
Let's tackle the other comments in separate reviews. I think it is valuable to 
add this comment now regardless.

- Joris Van Remoortere


On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4/
> ---
> 
> (Updated Jan. 12, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/4/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42254: Checked whether the remaining cluster resources is allocatable.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42254/#review114887
---

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 13, 2016, 3:29 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42254/
> ---
> 
> (Updated Jan. 13, 2016, 3:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Checked whether the remaining cluster resources is allocatable.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> d541bfa3f4190865c65d35c9d1ffdb8a3f194056 
> 
> Diff: https://reviews.apache.org/r/42254/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 42221: Removed references to wDRF from allocator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114886
---

Ship it!



src/master/allocator/mesos/hierarchical.cpp (line 1245)


How about `allocatedStage2`?


- Joris Van Remoortere


On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> ---
> 
> (Updated Jan. 12, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/42221/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/#review114884
---

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 7, 2016, 9:47 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42035/
> ---
> 
> (Updated Jan. 7, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Jie 
> Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4310
> https://issues.apache.org/jira/browse/MESOS-4310
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos agent provides a flag, `--[no-]switch_user`, which instructs
> the agent to run tasks as the user who submitted the task instead of the
> user that is running the agent process itself.
> 
> On POSIX, this requires the usual suspects (`su`, `chown`, and `chroot`,
> for example to do things like make sure the correct user owns the
> executor directory, and things like that.
> 
> On Windows, many of these operations have very different semantics. To
> use one example, to `chown` on Windows, you normally have to give
> *permission* for something to `chown` an object, and then that thing
> actually has to use that permission to `chown` it, on its own.
> 
> Clearly a semantic mismatch of this magnitude will require some work to
> formally bridge, and the result is that we will simply disable the
> functionality entirely on the Windows agent until we are prepared to go
> back and support it formally.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
>   src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
>   src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/42035/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39834: Made `path_tests.cpp` standalone.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review114883
---

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 4, 2016, 7:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> ---
> 
> (Updated Jan. 4, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `path_tests.cpp` standalone.
> 
> NB, more of these tests will move when `Hopcroft` is done with his 
> `os::symlink` changeset.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 821dbb185f09e2f279d95fd354ce2168cddf1bac 
> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39805: Moved filesystems tests to their own file.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/#review114881
---


Missing includes `stout/os/touch.hpp` and `stout/os/rm.hpp` from 
`path_tests.cpp`

- Joris Van Remoortere


On Jan. 15, 2016, 7:34 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39805/
> ---
> 
> (Updated Jan. 15, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved filesystems tests to their own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
> 3cff837886d94d623c732371380f1c62750022f4 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 62ad461eb228b688f1ceac16cfb003561ed5a806 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39805/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/#review114880
---

Ship it!


Ship It!

- Jie Yu


On Jan. 16, 2016, 4:38 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42336/
> ---
> 
> (Updated Jan. 16, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented endpoint failure when HTTP authentication is disabled.
> 
> The `/reserve` and `/unreserve` endpoints currently do not work when HTTP 
> authentication is disabled. To enable correct behavior, the `principal` field 
> of `ReservationInfo` is being migrated from `required` to `optional`. This 
> patch documents this behavior of these endpoints.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42336/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

(Updated Jan. 16, 2016, 8:44 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-4415
https://issues.apache.org/jira/browse/MESOS-4415


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ec851dcb08d938defeb6066810011e003d594b29 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
e738cdbf5846950c475c159fb9a770acc45159f5 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42334/#review114879
---

Ship it!



src/master/validation.cpp (line 667)


We don't put \n in error message. I'll fix it for you.



src/master/validation.cpp (line 669)


We don't put period in the end. I'll fix it for you.


- Jie Yu


On Jan. 16, 2016, 4:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42334/
> ---
> 
> (Updated Jan. 16, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed `ReservationInfo.principal` from required to optional.
> 
> In order to allow dynamic reservation without a principal, this field is 
> being changed to optional. However, the current patch alters the master to 
> invalidate any reserve operations that do not set this field. After a 
> deprecation cycle, the master will allow the field to be unset.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd 
>   include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c 
>   src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 
>   src/tests/master_validation_tests.cpp 
> fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/42334/diff/
> 
> 
> Testing
> ---
> 
> A new test was added, 
> `ReserveOperationValidationTest.ReservationInfoMissingPrincipal`, within the 
> master validation tests, to ensure that a `ReservationInfo` with no principal 
> will be invalidated.
> 
> `make check` was used to test.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

(Updated Jan. 16, 2016, 8:37 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3645
https://issues.apache.org/jira/browse/MESOS-3645


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ec851dcb08d938defeb6066810011e003d594b29 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 
ffe074830ef90f492990bf695e686c885b9a155c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
5b38b9af654d7d1c574f0cc573083b66693ced1d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
27edf1b4f8647a2720f2962eafa110d694b3baed 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review114875
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 32)


also `snake_case` for this function name as we did in `stat`.


- Joris Van Remoortere


On Jan. 15, 2016, 7:29 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 15, 2016, 7:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ec851dcb08d938defeb6066810011e003d594b29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 42379: Add reverse_foreach in libprocess.

[Jie Yu]

Maybe include boost::adaptor into stout under namespace adaptor? I liked
the adaptor idea since it can be composed.

- Jie

On Sat, Jan 16, 2016 at 10:48 AM, Benjamin Mahler 
wrote:

> It seems unfortunate to introduce alternative looping constructs, for
> example the following would be the more composable approach:
>
> foreach (int i, reversed(numbers)) {
>
> }
>
> I remember this coming up before:
>
> http://mail-archives.apache.org/mod_mbox/mesos-dev/201410.mbox/%3c20141002211204.18846.48...@reviews.apache.org%3E
>
> Thoughts?
>
> On Saturday, January 16, 2016, Jie Yu  wrote:
>
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/42379/#review114871
>> ---
>>
>> Ship it!
>>
>>
>>
>> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp (lines 55 -
>> 58)
>> 
>>
>> Ca you move this below 'foreachvalue'?
>>
>>
>> - Jie Yu
>>
>>
>> On Jan. 16, 2016, 1:32 a.m., Timothy Chen wrote:
>> >
>> > ---
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/42379/
>> > ---
>> >
>> > (Updated Jan. 16, 2016, 1:32 a.m.)
>> >
>> >
>> > Review request for mesos and Jie Yu.
>> >
>> >
>> > Repository: mesos
>> >
>> >
>> > Description
>> > ---
>> >
>> > Add reverse_foreach in libprocess.
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp
>> 7fb0044790ee249b69e07b81a26851bd5bfb110f
>> >
>> > Diff: https://reviews.apache.org/r/42379/diff/
>> >
>> >
>> > Testing
>> > ---
>> >
>> > make check
>> >
>> >
>> > Thanks,
>> >
>> > Timothy Chen
>> >
>> >
>>
>>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review114874
---



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 (line 224)


new line



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
(line 64)


new line


- Joris Van Remoortere


On Jan. 16, 2016, 2:24 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 16, 2016, 2:24 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ec851dcb08d938defeb6066810011e003d594b29 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 
> ffe074830ef90f492990bf695e686c885b9a155c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 27edf1b4f8647a2720f2962eafa110d694b3baed 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 40731: Added a test fixture for checking floating point precision.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
---

(Updated Jan. 16, 2016, 7:26 p.m.)


Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil 
Conway.


Summary (updated)
-

Added a test fixture for checking floating point precision.


Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552


Repository: mesos


Description
---

Adding the test framework submitted by Mandeep (@mchadha) 
https://reviews.apache.org/r/39056/


Diffs (updated)
-

  src/tests/reservation_tests.cpp 61d275c47fbb02baf22e4ad8f9b1580886da51d9 

Diff: https://reviews.apache.org/r/40731/diff/


Testing
---

Ran make check after adding Mandeep's test case to the GTEST framework.


Thanks,

Avinash sridharan

Re: Review Request 42379: Add reverse_foreach in libprocess.

[Benjamin Mahler]

It seems unfortunate to introduce alternative looping constructs, for
example the following would be the more composable approach:

foreach (int i, reversed(numbers)) {

}

I remember this coming up before:
http://mail-archives.apache.org/mod_mbox/mesos-dev/201410.mbox/%3c20141002211204.18846.48...@reviews.apache.org%3E

Thoughts?

On Saturday, January 16, 2016, Jie Yu  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42379/#review114871
> ---
>
> Ship it!
>
>
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp (lines 55 -
> 58)
> 
>
> Ca you move this below 'foreachvalue'?
>
>
> - Jie Yu
>
>
> On Jan. 16, 2016, 1:32 a.m., Timothy Chen wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/42379/
> > ---
> >
> > (Updated Jan. 16, 2016, 1:32 a.m.)
> >
> >
> > Review request for mesos and Jie Yu.
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > ---
> >
> > Add reverse_foreach in libprocess.
> >
> >
> > Diffs
> > -
> >
> >   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp
> 7fb0044790ee249b69e07b81a26851bd5bfb110f
> >
> > Diff: https://reviews.apache.org/r/42379/diff/
> >
> >
> > Testing
> > ---
> >
> > make check
> >
> >
> > Thanks,
> >
> > Timothy Chen
> >
> >
>
>

Re: Review Request 40553: Enable mesos tests installation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 16, 2016, 5:41 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Update summary with a period.


Summary (updated)
-

Enable mesos tests installation.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fab16f697f90abc11d681222f10f518d70da908b 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 42379: Add reverse_foreach in libprocess.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42379/#review114871
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp (lines 55 - 58)


Ca you move this below 'foreachvalue'?


- Jie Yu


On Jan. 16, 2016, 1:32 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42379/
> ---
> 
> (Updated Jan. 16, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reverse_foreach in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
> 7fb0044790ee249b69e07b81a26851bd5bfb110f 
> 
> Diff: https://reviews.apache.org/r/42379/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review114869
---


Patch looks great!

Reviews applied: [42390]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 3:59 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> ---
> 
> (Updated Jan. 16, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This still requires the slave work dir is a mounted volume, otherwise the 
> slave has no way to fetch into the task container's sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece 
> 
> Diff: https://reviews.apache.org/r/42390/diff/
> 
> 
> Testing
> ---
> 
> - Start a master, then start the slave inside a docker container, with the 
> work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a 
> task with a uri in the command info
> - When the task container is launched, check the file is fetched into the 
> sandbox
> ```sh
> $ docker exec  ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

[Greg Mann]

> On Jan. 16, 2016, 1:17 p.m., Guangya Liu wrote:
> > src/master/validation.cpp, lines 663-664
> > 
> >
> > I saw that most comments including some verison info if we want to 
> > deprecate sth in one release. Please refer to 
> > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L909-L910 
> > for detail.

Thanks Guangya! I looked back on the last devlist discussion on this point, and 
it looks like we're maintaining our standard of +/- one version for mixed 
cluster compatibility. So, I think we can target the 0.28.0 release for 
allowing dynamic reservation without a principal.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42334/#review114862
---


On Jan. 16, 2016, 4:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42334/
> ---
> 
> (Updated Jan. 16, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed `ReservationInfo.principal` from required to optional.
> 
> In order to allow dynamic reservation without a principal, this field is 
> being changed to optional. However, the current patch alters the master to 
> invalidate any reserve operations that do not set this field. After a 
> deprecation cycle, the master will allow the field to be unset.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd 
>   include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c 
>   src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 
>   src/tests/master_validation_tests.cpp 
> fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/42334/diff/
> 
> 
> Testing
> ---
> 
> A new test was added, 
> `ReserveOperationValidationTest.ReservationInfoMissingPrincipal`, within the 
> master validation tests, to ensure that a `ReservationInfo` with no principal 
> will be invalidated.
> 
> `make check` was used to test.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/
---

(Updated Jan. 16, 2016, 4:38 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Added target version to docs.


Bugs: MESOS-4382
https://issues.apache.org/jira/browse/MESOS-4382


Repository: mesos


Description
---

Documented endpoint failure when HTTP authentication is disabled.

The `/reserve` and `/unreserve` endpoints currently do not work when HTTP 
authentication is disabled. To enable correct behavior, the `principal` field 
of `ReservationInfo` is being migrated from `required` to `optional`. This 
patch documents this behavior of these endpoints.


Diffs (updated)
-

  docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 

Diff: https://reviews.apache.org/r/42336/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 16, 2016, 4:31 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Added target version to comment.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42368/
---

(Updated Jan. 16, 2016, 4:31 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Added target version to comment.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added reservation endpoint test without auth and principal.

Currently, dynamic reservation endpoints will not work when HTTP authentication 
is not set. This test checks that these endpoints will fail as expected in this 
case.


Diffs (updated)
-

  src/tests/reservation_endpoints_tests.cpp 
b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 

Diff: https://reviews.apache.org/r/42368/diff/


Testing
---

A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was 
added, and make check was used to test. The new test was also run with 
`--gtest_repeat=1000 --gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42334/
---

(Updated Jan. 16, 2016, 4:30 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-4382
https://issues.apache.org/jira/browse/MESOS-4382


Repository: mesos


Description
---

Changed `ReservationInfo.principal` from required to optional.

In order to allow dynamic reservation without a principal, this field is being 
changed to optional. However, the current patch alters the master to invalidate 
any reserve operations that do not set this field. After a deprecation cycle, 
the master will allow the field to be unset.


Diffs (updated)
-

  include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd 
  include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c 
  src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 
  src/tests/master_validation_tests.cpp 
fbf8fadbc04a7cbc60ee6091e0224339389b400f 

Diff: https://reviews.apache.org/r/42334/diff/


Testing
---

A new test was added, 
`ReserveOperationValidationTest.ReservationInfoMissingPrincipal`, within the 
master validation tests, to ensure that a `ReservationInfo` with no principal 
will be invalidated.

`make check` was used to test.


Thanks,

Greg Mann

Review Request 42390: Fixed fetching uris when slave is running inside a container.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-4249
https://issues.apache.org/jira/browse/MESOS-4249


Repository: mesos


Description
---

This still requires the slave work dir is a mounted volume, otherwise the slave 
has no way to fetch into the task container's sandbox.


Diffs
-

  src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece 

Diff: https://reviews.apache.org/r/42390/diff/


Testing
---

- Start a master, then start the slave inside a docker container, with the 
work_dir being a mounted volume
- Start a simple framework, which, on receiving the first offer, launches a 
task with a uri in the command info
- When the task container is launched, check the file is fetched into the 
sandbox
```sh
$ docker exec  ls /mnt/mesos/sandbox
robots.txt
stderr
stdout
```


Thanks,

Shuai Lin

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41769/#review114863
---


Patch looks great!

Reviews applied: [41769]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 12:45 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41769/
> ---
> 
> (Updated Jan. 16, 2016, 12:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Klaus 
> Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-4411
> https://issues.apache.org/jira/browse/MESOS-4411
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made allocator traverse all roles for quota allocation.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 72e69a0f42dd724713f2a7a75f1b92ef16eb5569 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/41769/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42334/#review114862
---



include/mesos/mesos.proto (lines 575 - 576)


Does "username of the operator" is a MUST? I think that a end user can 
reserve resources with any principal?



src/master/validation.cpp (lines 663 - 664)


I saw that most comments including some verison info if we want to 
deprecate sth in one release. Please refer to 
https://github.com/apache/mesos/blob/master/src/master/master.cpp#L909-L910 for 
detail.


- Guangya Liu


On 一月 15, 2016, 11:06 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42334/
> ---
> 
> (Updated 一月 15, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed `ReservationInfo.principal` from required to optional.
> 
> In order to allow dynamic reservation without a principal, this field is 
> being changed to optional. However, the current patch alters the master to 
> invalidate any reserve operations that do not set this field. After a 
> deprecation cycle, the master will allow the field to be unset.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd 
>   include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c 
>   src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 
>   src/tests/master_validation_tests.cpp 
> fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/42334/diff/
> 
> 
> Testing
> ---
> 
> A new test was added, 
> `ReserveOperationValidationTest.ReservationInfoMissingPrincipal`, within the 
> master validation tests, to ensure that a `ReservationInfo` with no principal 
> will be invalidated.
> 
> `make check` was used to test.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/#review114861
---



docs/reservation.md (line 60)


s/in a future version/after the deprecation cycle of 0.27.0 ?


- Guangya Liu


On 一月 15, 2016, 11:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42336/
> ---
> 
> (Updated 一月 15, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented endpoint failure when HTTP authentication is disabled.
> 
> The `/reserve` and `/unreserve` endpoints currently do not work when HTTP 
> authentication is disabled. To enable correct behavior, the `principal` field 
> of `ReservationInfo` is being migrated from `required` to `optional`. This 
> patch documents this behavior of these endpoints.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42336/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41769/
---

(Updated 一月 16, 2016, 12:45 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Klaus Ma, 
and Neil Conway.


Bugs: MESOS-4411
https://issues.apache.org/jira/browse/MESOS-4411


Repository: mesos


Description
---

Made allocator traverse all roles for quota allocation.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
72e69a0f42dd724713f2a7a75f1b92ef16eb5569 
  src/tests/hierarchical_allocator_tests.cpp 
9362dd306497ba01e0f387c3862456cdcac6f863 

Diff: https://reviews.apache.org/r/41769/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41769/
---

(Updated 一月 16, 2016, 12:44 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Klaus Ma, 
and Neil Conway.


Repository: mesos


Description
---

Made allocator traverse all roles for quota allocation.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
72e69a0f42dd724713f2a7a75f1b92ef16eb5569 
  src/tests/hierarchical_allocator_tests.cpp 
9362dd306497ba01e0f387c3862456cdcac6f863 

Diff: https://reviews.apache.org/r/41769/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 42379: Add reverse_foreach in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42379/#review114856
---

Ship it!


Ship It!

- haosdent huang


On Jan. 16, 2016, 1:32 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42379/
> ---
> 
> (Updated Jan. 16, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reverse_foreach in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
> 7fb0044790ee249b69e07b81a26851bd5bfb110f 
> 
> Diff: https://reviews.apache.org/r/42379/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review114855
---

Ship it!


Ship It!

- haosdent huang


On Jan. 16, 2016, 8:45 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 16, 2016, 8:45 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review114854
---


Patch looks great!

Reviews applied: [42379, 42389]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 8:45 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 16, 2016, 8:45 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42124: Updated /state to show usage slack and allocation slack resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42124/#review114853
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 42386, 40632, 
41847, 41791, 42113, 42194, 41848, 42123, 42124]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 8:03 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42124/
> ---
> 
> (Updated Jan. 16, 2016, 8:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4327
> https://issues.apache.org/jira/browse/MESOS-4327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated /state to show usage slack and allocation slack resources.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
> 
> Diff: https://reviews.apache.org/r/42124/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from HTTPTest
> [ RUN  ] HTTPTest.ModelResources
> I0111 11:06:26.616374 1928241920 resources.cpp:513] Parsing resources as JSON 
> failed: cpus:1;cpus(foo):1;mem:512;disk:1024;ports(foo):[1-10];bar:1
> Trying semicolon-delimited string format instead
> [   OK ] HTTPTest.ModelResources (2 ms)
> [--] 1 test from HTTPTest (2 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (12 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/
---

Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Fixed unmount order in linux filesystem isolator cleanup.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ace9e305c24a9841f1716c9bf40cd13b16ef0cec 

Diff: https://reviews.apache.org/r/42389/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review114852
---


Going to rebase this patch and use the newer primitive for this fix.

- Timothy Chen


On Jan. 16, 2016, 12:49 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Jan. 16, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40553: Enable mesos tests installation

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review114851
---


Bad patch!

Reviews applied: [39780, 39781, 39782, 40553]

Failed command: ./support/apply-review.sh -n -r 40553

Error:
 2016-01-16 08:40:21 URL:https://reviews.apache.org/r/40553/diff/raw/ 
[46635/46635] -> "40553.patch" [1]
Total errors found: 0
Checking 16 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 16, 2016, 5:53 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 16, 2016, 5:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fab16f697f90abc11d681222f10f518d70da908b 
>   src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review114848
---


Bad patch!

Reviews applied: [40731]

Failed command: ./support/apply-review.sh -n -r 40731

Error:
 2016-01-16 08:11:59 URL:https://reviews.apache.org/r/40731/diff/raw/ 
[3731/3731] -> "40731.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 16, 2016, 5:48 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> ---
> 
> (Updated Jan. 16, 2016, 5:48 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding the test framework submitted by Mandeep (@mchadha) 
> https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_tests.cpp 61d275c47fbb02baf22e4ad8f9b1580886da51d9 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> ---
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42124: Updated /state to show usage slack and allocation slack resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42124/
---

(Updated 一月 16, 2016, 8:03 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Updated dependency


Bugs: MESOS-4327
https://issues.apache.org/jira/browse/MESOS-4327


Repository: mesos


Description
---

Updated /state to show usage slack and allocation slack resources.


Diffs (updated)
-

  src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752 
  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 

Diff: https://reviews.apache.org/r/42124/diff/


Testing
---

make
make check

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from HTTPTest
[ RUN  ] HTTPTest.ModelResources
I0111 11:06:26.616374 1928241920 resources.cpp:513] Parsing resources as JSON 
failed: cpus:1;cpus(foo):1;mem:512;disk:1024;ports(foo):[1-10];bar:1
Trying semicolon-delimited string format instead
[   OK ] HTTPTest.ModelResources (2 ms)
[--] 1 test from HTTPTest (2 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (12 ms total)
[  PASSED  ] 1 test.


Thanks,

Guangya Liu

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42123/
---

(Updated 一月 16, 2016, 8 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Updated unit test.


Bugs: MESOS-4322
https://issues.apache.org/jira/browse/MESOS-4322


Repository: mesos


Description
---

The current load qos controller is calculating executor used
resources via revocable() API, but this is not right as the
revocable() will include both USAGE SLACK and ALLOCATION SLACK.

This patch is updating the load qos controller only get USAGE
SLACK revocable resources for executors.

The unit test was already covered in oversubscription_tests.cpp.


Diffs (updated)
-

  src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 

Diff: https://reviews.apache.org/r/42123/diff/


Testing
---

make
make check


Thanks,

Guangya Liu