Re: Review Request 43546: Added common compression utilities.

2016-02-13 Thread Shuai Lin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43546/#review119146
---



Should we link this review request to 
https://issues.apache.org/jira/browse/MESOS-4669 ?

- Shuai Lin


On Feb. 13, 2016, 1:42 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43546/
> ---
> 
> (Updated Feb. 13, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for GZIP compress and uncompress.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.hpp 738c309eac6bb2dffd517298a5105d23fc9bf371 
>   src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e 
>   src/tests/common/command_utils_tests.cpp 
> 9207a1bd6e53a8094db47ddecdcb9d39089c4c51 
> 
> Diff: https://reviews.apache.org/r/43546/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Shuai Lin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/#review119147
---



I think this review request should be linked to 
https://issues.apache.org/jira/browse/MESOS-3193 .

- Shuai Lin


On Feb. 13, 2016, 1:43 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43336/
> ---
> 
> (Updated Feb. 13, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4596
> https://issues.apache.org/jira/browse/MESOS-4596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for simple image discovery for Appc images.
> 
> TODO: Add tests.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 
> 
> Diff: https://reviews.apache.org/r/43336/diff/
> 
> 
> Testing
> ---
> 
> Tested with local http(s) server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-02-13 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/
---

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-4663
https://issues.apache.org/jira/browse/MESOS-4663


Repository: mesos


Description
---

Speed up ExamplesTest.PersistentVolumeFramework.


Diffs
-

  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/tests/persistent_volume_framework_test.sh 
074cdcbc4a738170e84887c1773cd7c118112d58 

Diff: https://reviews.apache.org/r/43558/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 43546: Added common compression utilities.

2016-02-13 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43546/
---

(Updated Feb. 13, 2016, 4:30 p.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Bugs: MESOS-4669
https://issues.apache.org/jira/browse/MESOS-4669


Repository: mesos


Description
---

Added support for GZIP compress and uncompress.


Diffs (updated)
-

  src/common/command_utils.hpp 738c309eac6bb2dffd517298a5105d23fc9bf371 
  src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e 
  src/tests/common/command_utils_tests.cpp 
9207a1bd6e53a8094db47ddecdcb9d39089c4c51 

Diff: https://reviews.apache.org/r/43546/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Jojy Varghese


> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, line 89
> > 
> >
> > No need for 'doFetchImage' since only this function is using it. Can 
> > you just inline it here?

The idea was that this method will remain common for all discovery types.


> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, line 93
> > 
> >
> > No need for 'const' here as it'll be file local method.

The idea was that all discovery related methods like this would be class 
methods because the fetcher is after all appc discovery spec implementation.


> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, lines 207-212
> > 
> >
> > Hum, do you need to mkdir? will untar create it?

No when i tested with rkt image (coreos/etcd2), after decompressin when i untar 
the tar file, i will untar without creating a directory.


> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, line 214
> > 
> >
> > Do you need to remove aciBundle?
> > 
> > ```
> > .then([]() -> Future {
> >   return os::rm(...);
> > });
> > ```

I could but I thought we agreed that this is a temp directory which will be 
deleted by the caller. The caller would do 'ls' in this directory and pick only 
the directories.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/#review119123
---


On Feb. 13, 2016, 1:43 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43336/
> ---
> 
> (Updated Feb. 13, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4596
> https://issues.apache.org/jira/browse/MESOS-4596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for simple image discovery for Appc images.
> 
> TODO: Add tests.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 
> 
> Diff: https://reviews.apache.org/r/43336/diff/
> 
> 
> Testing
> ---
> 
> Tested with local http(s) server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-02-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/#review119149
---



Patch looks great!

Reviews applied: [43558]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 13, 2016, 3:58 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43558/
> ---
> 
> (Updated Feb. 13, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-4663
> https://issues.apache.org/jira/browse/MESOS-4663
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest.PersistentVolumeFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/tests/persistent_volume_framework_test.sh 
> 074cdcbc4a738170e84887c1773cd7c118112d58 
> 
> Diff: https://reviews.apache.org/r/43558/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 41854: Added module initialization to Master main().

2016-02-13 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/
---

(Updated Feb. 13, 2016, 5:32 p.m.)


Review request for mesos, Anand Mazumdar and Kapil Arya.


Changes
---

Added missing period to commit message.


Summary (updated)
-

Added module initialization to Master main().


Bugs: MESOS-4253
https://issues.apache.org/jira/browse/MESOS-4253


Repository: mesos


Description (updated)
---

Added module initialization to Master main().


Diffs (updated)
-

  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 

Diff: https://reviews.apache.org/r/41854/diff/


Testing
---

make && make check

[==] 932 tests from 119 test cases ran. (210502 ms total)
[  PASSED  ] 932 tests.


Thanks,

Marco Massenzio



Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha


> On Feb. 13, 2016, 12:57 a.m., Greg Mann wrote:
> > include/mesos/resources.hpp, line 222
> > 
> >
> > I might recommend renaming this method, due to the ubiquitous `get()` 
> > method of the `Future` and `Option` types. Perhaps `find()` instead?

There is a method `Option find(const Resources& targets) const;` 
which does different from what this function does. This method extracts the 
Resource object from Resources that matches the passed in Resource& by not 
comparing the num_consumers.
So, let us rename this to:
`Option locate(const Resource& that) const;`

Does it sound ok to you?


> On Feb. 13, 2016, 12:57 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto, lines 988-989
> > 
> >
> > I'm curious if we'll really need these operations? Might it be enough 
> > to simply make a persistent volume shareable when it's created? The same 
> > might be the case for other shareable resources as well.

I think that supporting SHARE as add-on operations for resources that can be 
shared (but are not created as shared) is useful. Same argument for UNSHARE.
Keeping in mind that this feature is for sharing resources (not just sharing of 
persistent volumes), I feel that these 2 apis have a need to co-exist.


> On Feb. 13, 2016, 12:57 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto, line 688
> > 
> >
> > I don't think this field belongs in the protobuf. If this information 
> > doesn't need to be communicated on the wire, the master can simply track it 
> > internally, and reconstruct it upon agent reregistration after master 
> > failover.

As stated in the design doc, this has been done to make implementation simpler. 
Resource is used quite extensively in code and hence it was easier to embed 
num_consumers in it.
I agree we can keep num_consumers as a hashmap, such as:
`hashmap consumers;` and expose it in a singleton or 
something like that such that multiple classes can have access to it, esp. the 
sorter, allocator and master.
However, the num_consumers vary based on its context. For example:
i) For role, it contains the total tasks within a specific role that master has 
assigned this resource. This is across frameworks.
ii) For framework, it contains the total tasks within a specific framework that 
master has assigned this resource.
iii) For slave, it contains the total tasks within a slave that master has 
assigned this resource (this should be same as (i) for persistent volumes).
etc...
So we would need to maintain multiple hashmaps to reflect this. Secondly, there 
needs to be a `hashmap::find` for every access to num_consumers which can be 
avoided if we embed it within Resource::ShareInfo.

Another point that has been raised is if we should reconsider and actually 
expose `num_consumerss` to frameworks since that would give a good idea for 
frameworks to know when a `DESTROY` can be issued. Note that the `DESTROY` is 
not guaranteed to succeed though since another framework of the same role might 
have issued a launch task using this resource in the mantime (and that is the 
reason we did not expose this in the first place). However, I think we can 
consider exposing this to frameworks if we feel that would provide frameworks 
with some meaningful information regarding possibility of DESTROY being 
successful. Note that the same issue exists with non-shareable persistent 
volumes as well, but the use case is not as bad since there can be only 1 task 
that can use the persistent volume.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42992/#review119090
---


On Feb. 5, 2016, 10:57 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42992/
> ---
> 
> (Updated Feb. 5, 2016, 10:57 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added new Offer::Operation of SHARE and UNSHARE for resources.
> Added ShareInfo within Resources protobuf to allow for sharing of resources
> and keep track of consumers of such resources.
> Shareable resources keeps track of its consumers and makes decision based on
> that during task launch and task termination.
> Allow DESTROY or UNSHARE for shared volumes only if reference count is 0.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/resources.hpp 

Re: Review Request 41854: Added module initialization to Master main().

2016-02-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/#review119158
---



Patch looks great!

Reviews applied: [41760, 41854]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 13, 2016, 5:32 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41854/
> ---
> 
> (Updated Feb. 13, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
> https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added module initialization to Master main().
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 
> 
> Diff: https://reviews.apache.org/r/41854/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> [==] 932 tests from 119 test cases ran. (210502 ms total)
> [  PASSED  ] 932 tests.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>



Re: Review Request 41854: Added module initialization to Master main() method

2016-02-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/#review119143
---



Bad patch!

Reviews applied: [41760, 41854]

Failed command: ./support/apply-review.sh -n -r 41854

Error:
2016-02-13 08:11:46 URL:https://reviews.apache.org/r/41854/diff/raw/ 
[2316/2316] -> "41854.patch" [1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/11426/console

- Mesos ReviewBot


On Feb. 13, 2016, 7:02 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41854/
> ---
> 
> (Updated Feb. 13, 2016, 7:02 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
> https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added module initialization to Master main() method
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 
> 
> Diff: https://reviews.apache.org/r/41854/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> [==] 932 tests from 119 test cases ran. (210502 ms total)
> [  PASSED  ] 932 tests.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>



Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/
---

(Updated Feb. 14, 2016, 2:58 a.m.)


Review request for mesos and Adam B.


Changes
---

Addressed Adam's comments.


Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945


Repository: mesos


Description
---

Update docs for --weights flag and authorization.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
  docs/configuration.md eea985cc251d6edd8476ade174b10a58aebefab1 

Diff: https://reviews.apache.org/r/42705/diff/


Testing
---


Thanks,

Yongqiao Wang



Re: Review Request 43562: Updated protobuf Resources to include ShareInfo.

2016-02-13 Thread Anindya Sinha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43562/
---

(Updated Feb. 14, 2016, 6:29 a.m.)


Review request for mesos.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added ShareInfo within Resources protobuf to allow for sharing of resources
and keep track of consumers of such resources.
Added new Offer::Operation of SHARE and UNSHARE for resources.


Diffs
-

  include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
  include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 

Diff: https://reviews.apache.org/r/43562/diff/


Testing
---


Thanks,

Anindya Sinha



Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/#review119167
---



Patch looks great!

Reviews applied: [42705]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 14, 2016, 3:01 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42705/
> ---
> 
> (Updated Feb. 14, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs for --weights flag and authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/configuration.md eea985cc251d6edd8476ade174b10a58aebefab1 
> 
> Diff: https://reviews.apache.org/r/42705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>



Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-02-13 Thread Klaus Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43561/
---

(Updated Feb. 14, 2016, 2:38 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Enhance test cases.


Bugs: MESOS-4627
https://issues.apache.org/jira/browse/MESOS-4627


Repository: mesos


Description
---

Improve Ranges parsing to handle single values.


Diffs (updated)
-

  src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 

Diff: https://reviews.apache.org/r/43561/diff/


Testing (updated)
---

make
make check GTEST_FILTER=~"*"
./src/mesos-test


Thanks,

Klaus Ma



Review Request 43562: Updated protobuf Resources to include ShareInfo.

2016-02-13 Thread Anindya Sinha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43562/
---

Review request for mesos.


Repository: mesos


Description
---

Added ShareInfo within Resources protobuf to allow for sharing of resources
and keep track of consumers of such resources.
Added new Offer::Operation of SHARE and UNSHARE for resources.


Diffs
-

  include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
  include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 

Diff: https://reviews.apache.org/r/43562/diff/


Testing
---


Thanks,

Anindya Sinha



Re: Review Request 42993: Support for multiple frameworks sharing the same resource.

2016-02-13 Thread Anindya Sinha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42993/
---

(Updated Feb. 14, 2016, 6:25 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

The allocator tracks allocated shared resources separately from the
remaining allocated resources so that multiple frameworks see the
same view of the shared resource at any given time. This avoids
unnecessary copies of the same shared resource when multiple
frameworks use such resources simultaneously.


Diffs (updated)
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/master/allocator/sorter/drf/sorter.hpp 
4669149b81de39b4bb921ef7cd6787aa583f6e40 
  src/master/allocator/sorter/drf/sorter.cpp 
18797e42a9c2bd20392020237cfae600a5ffe12c 
  src/master/allocator/sorter/sorter.hpp 
a0a779b81f6d048271f15256b38ff907ae144b83 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 

Diff: https://reviews.apache.org/r/42993/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha



Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42992/
---

(Updated Feb. 14, 2016, 6:24 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description (updated)
---

Shareable resources keeps track of its consumers and makes decision based on
that during task launch and task termination.
Allow DESTROY or UNSHARE for shared volumes only if reference count is 0.


Diffs (updated)
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
  src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/master/allocator/sorter/drf/sorter.cpp 
18797e42a9c2bd20392020237cfae600a5ffe12c 
  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 

Diff: https://reviews.apache.org/r/42992/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha



Re: Review Request 43491: Added note about implicit default filter to javadoc.

2016-02-13 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43491/#review119166
---


Ship it!




Ship It!

- Alexander Rojas


On Feb. 14, 2016, 3:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43491/
> ---
> 
> (Updated Feb. 14, 2016, 3:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Bernd Mathiske, and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make framework developers aware that the MesosSchedulerDriver will add an 
> implicit filter declining unused resources.
> 
> 
> Diffs
> -
> 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> efe71b03eb45b295df0e5c250b753a766ed7688c 
> 
> Diff: https://reviews.apache.org/r/43491/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/
---

(Updated Feb. 14, 2016, 3:01 a.m.)


Review request for mesos and Adam B.


Changes
---

Restore the blank line.


Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945


Repository: mesos


Description
---

Update docs for --weights flag and authorization.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
  docs/configuration.md eea985cc251d6edd8476ade174b10a58aebefab1 

Diff: https://reviews.apache.org/r/42705/diff/


Testing
---


Thanks,

Yongqiao Wang



Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-13 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

(Updated Feb. 14, 2016, 7:59 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Wait for perf statistics processes exit.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/43284/diff/


Testing
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```

This also fix similar error in 
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang



Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-13 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated Feb. 14, 2016, 7:59 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang