Re: Review Request 48247: Added configure check for separate fts library to Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48247/#review136155 --- Patch looks great! Reviews applied: [48244, 48245, 48246, 48247] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 4, 2016, 2:31 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48247/ > --- > > (Updated June 4, 2016, 2:31 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-5540 > https://issues.apache.org/jira/browse/MESOS-5540 > > > Repository: mesos > > > Description > --- > > On some systems (e.g., those that use musl instead of glibc), > the fts(3) family of functions are not provided by libc. > Instead, a separate fts library must be installed. If this is > the case, "libfts" should be added to the list of libraries that > stout is linked against. > > > Diffs > - > > configure.ac f7b9cbf7f49659df74d7ea0f850b8172f43a7d6a > > Diff: https://reviews.apache.org/r/48247/diff/ > > > Testing > --- > > Successful compilation with Alpine Linux 3.3.3; also tested that the build > continues to work on OSX and various supported Linux distributions (CentOS, > Fedora, Debian, Ubuntu). > > > Thanks, > > Neil Conway > >
Re: Review Request 48240: Added /dev/fd to the list of symlinks created by filesystem/linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48240/#review136154 --- Patch looks great! Reviews applied: [48240] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 4, 2016, 2:25 a.m., Silas Snider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48240/ > --- > > (Updated June 4, 2016, 2:25 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5543 > https://issues.apache.org/jira/browse/MESOS-5543 > > > Repository: mesos > > > Description > --- > > This is necessary to enable bash subshell redirection within the > container. > > > Diffs > - > > src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd > > Diff: https://reviews.apache.org/r/48240/diff/ > > > Testing > --- > > I ran a task using the filesystem/linux isolator, that used bash subshell > redirection (i.e., `grep -q -E 'something' <(tail -q -c +0 -f somefile)`. > Without this line, the task fails. With it, it runs just fine. > > > Thanks, > > Silas Snider > >
Review Request 48247: Added configure check for separate fts library to Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48247/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5540 https://issues.apache.org/jira/browse/MESOS-5540 Repository: mesos Description --- On some systems (e.g., those that use musl instead of glibc), the fts(3) family of functions are not provided by libc. Instead, a separate fts library must be installed. If this is the case, "libfts" should be added to the list of libraries that stout is linked against. Diffs - configure.ac f7b9cbf7f49659df74d7ea0f850b8172f43a7d6a Diff: https://reviews.apache.org/r/48247/diff/ Testing --- Successful compilation with Alpine Linux 3.3.3; also tested that the build continues to work on OSX and various supported Linux distributions (CentOS, Fedora, Debian, Ubuntu). Thanks, Neil Conway
Review Request 48245: Added configure check for separate fts library to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48245/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5540 https://issues.apache.org/jira/browse/MESOS-5540 Repository: mesos Description --- On some systems (e.g., those that use musl instead of glibc), the fts(3) family of functions are not provided by libc. Instead, a separate fts library must be installed. If this is the case, "libfts" should be added to the list of libraries that stout is linked against. Diffs - 3rdparty/stout/configure.ac ada1e22c72875fe9d557f07e4846128be0bcef13 Diff: https://reviews.apache.org/r/48245/diff/ Testing --- Successful compilation with Alpine Linux 3.3.3; also tested that the build continues to work on OSX and various supported Linux distributions (CentOS, Fedora, Debian, Ubuntu). Thanks, Neil Conway
Review Request 48246: Added configure check for separate fts library to libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48246/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5540 https://issues.apache.org/jira/browse/MESOS-5540 Repository: mesos Description --- On some systems (e.g., those that use musl instead of glibc), the fts(3) family of functions are not provided by libc. Instead, a separate fts library must be installed. If this is the case, "libfts" should be added to the list of libraries that stout is linked against. Diffs - 3rdparty/libprocess/configure.ac c8fcd35241c10829e7b2fa582491898589f0576f Diff: https://reviews.apache.org/r/48246/diff/ Testing --- Successful compilation with Alpine Linux 3.3.3; also tested that the build continues to work on OSX and various supported Linux distributions (CentOS, Fedora, Debian, Ubuntu). Thanks, Neil Conway
Review Request 48244: Removed support for parsing the filesystem table (fstab).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48244/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5540 https://issues.apache.org/jira/browse/MESOS-5540 Repository: mesos Description --- This functionality relied on the `getfsent` family of functions, which are not portable (e.g., they are not implemented by musl). These functions are not thread-safe, and we don't actually use this functionality in Mesos anyway. Diffs - src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 support/docker_build.sh 058b982d1a9ab5ac624d023fb1a1054128157083 Diff: https://reviews.apache.org/r/48244/diff/ Testing --- Successful compilation with Alpine Linux 3.3.3; also tested that the build continues to work on OSX and various supported Linux distributions (CentOS, Fedora, Debian, Ubuntu). Thanks, Neil Conway
Review Request 48240: Added /dev/fd to the list of symlinks created by filesystem/linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48240/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5543 https://issues.apache.org/jira/browse/MESOS-5543 Repository: mesos Description --- This is necessary to enable bash subshell redirection within the container. Diffs - src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd Diff: https://reviews.apache.org/r/48240/diff/ Testing --- I ran a task using the filesystem/linux isolator, that used bash subshell redirection (i.e., `grep -q -E 'something' <(tail -q -c +0 -f somefile)`. Without this line, the task fails. With it, it runs just fine. Thanks, Silas Snider
Re: Review Request 48219: Replaced unportable usage of `time.h` in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48219/#review136107 --- Patch looks great! Reviews applied: [48219] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 3, 2016, 7:35 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48219/ > --- > > (Updated June 3, 2016, 7:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4901 > https://issues.apache.org/jira/browse/MESOS-4901 > > > Repository: mesos > > > Description > --- > > Previously, `duration.hpp` assumed that including was > sufficient to ensure that `struct timeval` is defined. Per POSIX, > this is not the case: `struct timeval` is actually defined in > . This causes a compilation error on some systems, > notably Alpine Linux. > > > Diffs > - > > 3rdparty/stout/include/stout/duration.hpp > 7a6715059808dd69fd3fde29ff05ecc25a013486 > > Diff: https://reviews.apache.org/r/48219/diff/ > > > Testing > --- > > `make check` on OSX and recent ArchLinux. Successful compilation on CentOS 6, > CentOS 7, Debian 8, Fedora 23, and Ubuntu 12-16. > > > Thanks, > > Neil Conway > >
Re: Review Request 48219: Replaced unportable usage of `time.h` in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48219/#review136100 --- Ship it! Ship It! - Michael Park On June 3, 2016, 7:35 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48219/ > --- > > (Updated June 3, 2016, 7:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4901 > https://issues.apache.org/jira/browse/MESOS-4901 > > > Repository: mesos > > > Description > --- > > Previously, `duration.hpp` assumed that including was > sufficient to ensure that `struct timeval` is defined. Per POSIX, > this is not the case: `struct timeval` is actually defined in > . This causes a compilation error on some systems, > notably Alpine Linux. > > > Diffs > - > > 3rdparty/stout/include/stout/duration.hpp > 7a6715059808dd69fd3fde29ff05ecc25a013486 > > Diff: https://reviews.apache.org/r/48219/diff/ > > > Testing > --- > > `make check` on OSX and recent ArchLinux. Successful compilation on CentOS 6, > CentOS 7, Debian 8, Fedora 23, and Ubuntu 12-16. > > > Thanks, > > Neil Conway > >
Re: Review Request 48219: Replaced unportable usage of `time.h` in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48219/ --- (Updated June 3, 2016, 7:35 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-4901 https://issues.apache.org/jira/browse/MESOS-4901 Repository: mesos Description --- Previously, `duration.hpp` assumed that including was sufficient to ensure that `struct timeval` is defined. Per POSIX, this is not the case: `struct timeval` is actually defined in . This causes a compilation error on some systems, notably Alpine Linux. Diffs - 3rdparty/stout/include/stout/duration.hpp 7a6715059808dd69fd3fde29ff05ecc25a013486 Diff: https://reviews.apache.org/r/48219/diff/ Testing --- `make check` on OSX and recent ArchLinux. Successful compilation on CentOS 6, CentOS 7, Debian 8, Fedora 23, and Ubuntu 12-16. Thanks, Neil Conway
Review Request 48219: Replaced unportable usage of `time.h` in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48219/ --- Review request for mesos and Michael Park. Repository: mesos Description --- Previously, `duration.hpp` assumed that including was sufficient to ensure that `struct timeval` is defined. Per POSIX, this is not the case: `struct timeval` is actually defined in . This causes a compilation error on some systems, notably Alpine Linux. Diffs - 3rdparty/stout/include/stout/duration.hpp 7a6715059808dd69fd3fde29ff05ecc25a013486 Diff: https://reviews.apache.org/r/48219/diff/ Testing --- `make check` on OSX and recent ArchLinux. Successful compilation on CentOS 6, CentOS 7, Debian 8, Fedora 23, and Ubuntu 12-16. Thanks, Neil Conway
Re: Review Request 48206: Fix example in configuration docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48206/#review136068 --- Patch looks great! Reviews applied: [48206] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 3, 2016, 2:31 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48206/ > --- > > (Updated June 3, 2016, 2:31 p.m.) > > > Review request for mesos, haosdent huang, Kapil Arya, and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Previous example configuration of `default_container_info` > leads to following problem: > > Failed to launch container: Relative host path '/./.private/tmp' > > cannot contain relative components; Container destroyed while > > preparing isolators > > > Diffs > - > > docs/configuration.md 7612d39d88dc6c0229b5def9697a97ab387f6ef1 > src/slave/flags.cpp 7b0e347772646c177c1e18334633a71bc6cedb85 > > Diff: https://reviews.apache.org/r/48206/diff/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Review Request 48206: Fix example in configuration docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48206/ --- Review request for mesos, haosdent huang, Kapil Arya, and Jan Schlicht. Repository: mesos Description --- Previous example configuration of `default_container_info` leads to following problem: > Failed to launch container: Relative host path '/./.private/tmp' > cannot contain relative components; Container destroyed while > preparing isolators Diffs - docs/configuration.md 7612d39d88dc6c0229b5def9697a97ab387f6ef1 src/slave/flags.cpp 7b0e347772646c177c1e18334633a71bc6cedb85 Diff: https://reviews.apache.org/r/48206/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 48200: Merge function "socket_send_data" logical judgment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48200/#review136056 --- Patch looks great! Reviews applied: [48200] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 3, 2016, 10:10 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48200/ > --- > > (Updated June 3, 2016, 10:10 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Function "socket_send_data" last logical judgment maybe merge beeter. > > > Diffs > - > > 3rdparty/libprocess/src/poll_socket.cpp d14dd1a > > Diff: https://reviews.apache.org/r/48200/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Review Request 48200: Merge function "socket_send_data" logical judgment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48200/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Function "socket_send_data" last logical judgment maybe merge beeter. Diffs - 3rdparty/libprocess/src/poll_socket.cpp d14dd1a Diff: https://reviews.apache.org/r/48200/diff/ Testing --- make check Thanks, Andy Pang
