Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-08 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/#review151477
---




src/slave/containerizer/docker.cpp (lines 648 - 649)


Put the blank space at the begining for the second sentence.
```
return Failure("The 'allocateNvidiaGpus' function was called"
   " without an 'NvidiaGpuAllocator' set");
```



src/slave/containerizer/docker.cpp (line 677)


s/containers_[containerId]/containers_.at(containerId)



src/slave/containerizer/docker.cpp (lines 687 - 688)


```
return Failure("The 'deallocateNvidiaGpus' function was called"
   " without an 'NvidiaGpuAllocator' set");
```



src/slave/containerizer/docker.cpp (line 691)


s/containers_[containerId]/containers_.at(containerId)



src/slave/containerizer/docker.cpp (line 703)


s/containers_[containerId]/containers_.at(containerId)



src/slave/containerizer/docker.cpp (lines 1339 - 1358)


What about moving this right before #1378?



src/slave/containerizer/docker.cpp (line 1350)


s/scala/scalar



src/slave/containerizer/docker.cpp (lines 1554 - 1564)


I think we do not need the update here as `destroy` will always be called 
even if the container exit normally, relasing the GPU in `___destroy` is good 
enough.



src/slave/containerizer/docker.cpp (lines 2105 - 2109)


Not yours, but I think that the comments can be removed as we have the 
logic of killing those containers forcely in #2118 and #2123. You can fix this 
in a separate patch.



src/slave/containerizer/docker.cpp (lines 2162 - 2182)


What about moving this to a new function named as `destroy` and use 
continuation for `deallocateNvidiaGpus` in #2159?


- Guangya Liu


On 九月 22, 2016, 6:16 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50841/
> ---
> 
> (Updated 九月 22, 2016, 6:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added control logic to allocate/deallocate GPUs to GPU-related task
> when the task is started/terminated.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 
> 
> Diff: https://reviews.apache.org/r/50841/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52664/#review151929
---



Patch looks great!

Reviews applied: [52470, 52520, 52471, 52664]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 8, 2016, 6:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52664/
> ---
> 
> (Updated Oct. 8, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the `decimalFloat` filter to app.js for consistency.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52664/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52664/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Repository: mesos


Description
---

Moved the `decimalFloat` filter to app.js for consistency.


Diffs
-

  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52664/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52244: Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52244/#review151927
---



Patch looks great!

Reviews applied: [52242, 52243, 52244]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 8, 2016, 1:53 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52244/
> ---
> 
> (Updated Oct. 8, 2016, 1:53 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6063
> https://issues.apache.org/jira/browse/MESOS-6063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f1035a0b505a8db7fd495a586e7ce3c23914250a 
> 
> Diff: https://reviews.apache.org/r/52244/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52663: Updated mesos_logo_fb_preview.png.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52663/
---

(Updated Oct. 8, 2016, 4:49 p.m.)


Review request for mesos.


Repository: mesos


Description
---

Updated mesos_logo_fb_preview.png.


Diffs (updated)
-

  site/source/assets/img/mesos_logo_fb_preview.png 
8dc5fa57576a6e89df9e9f6efe0930bee3041d33 

Diff: https://reviews.apache.org/r/52663/diff/


Testing
---


Thanks,

haosdent huang

Review Request 52663: Updated mesos_logo_fb_preview.png.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52663/
---

Review request for mesos.


Repository: mesos


Description
---

Updated mesos_logo_fb_preview.png.


Diffs
-

  site/source/assets/img/mesos_logo_fb_preview.png 
8dc5fa57576a6e89df9e9f6efe0930bee3041d33 

Diff: https://reviews.apache.org/r/52663/diff/


Testing
---


Thanks,

haosdent huang

Review Request 52662: Fixed incorrect link in getting-started document.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52662/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

Fixed incorrect link in getting-started document.


Diffs
-

  docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68 

Diff: https://reviews.apache.org/r/52662/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151926
---



Patch looks great!

Reviews applied: [52470, 52520, 52471]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 8, 2016, 12:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 8, 2016, 12:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52659/#review151924
---



Patch looks great!

Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 
50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 
51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 
51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958, 52039, 52083, 52656, 
52657, 52658, 52659]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 7, 2016, 11:52 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52659/
> ---
> 
> (Updated Oct. 7, 2016, 11:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6329
> https://issues.apache.org/jira/browse/MESOS-6329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a task launch fails due to a transient error (e.g., insufficient
> available resources at an agent), the master sends a TASK_LOST update to
> the framework. For PARTITION_AWARE frameworks, we now send TASK_DROPPED
> instead.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 8837f3d55be99626f79ed7f88eee021f115a2889 
>   src/tests/master_authorization_tests.cpp 
> a4623d15c246651fd1038fdedf16321b1d5f273f 
>   src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 
> 
> Diff: https://reviews.apache.org/r/52659/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 52243: Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryForward`.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52243/
---

(Updated Oct. 8, 2016, 1:52 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
---

Apply @jieyu's adjustments.


Bugs: MESOS-6063
https://issues.apache.org/jira/browse/MESOS-6063


Repository: mesos


Description
---

Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryForward`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f1035a0b505a8db7fd495a586e7ce3c23914250a 

Diff: https://reviews.apache.org/r/52243/diff/


Testing
---

This is the follow up test of https://reviews.apache.org/r/51631/. Wihtout 
https://reviews.apache.org/r/51631/, it would get this error

```
I0925 03:37:14.304280 35835 sched.cpp:917] Scheduler::resourceOffers took 
171325ns
../../src/tests/containerizer/cgroups_isolator_tests.cpp:1219: Failure
(usage).failure(): Unknown container af954115-6297-46e9-bbe9-7b1d4f72ae4b
I0925 03:37:14.307090 35825 master.cpp:1297] Framework 
6803060b-3f90-43eb-87a9-98c5f98b2092- (default) at 
scheduler-ed39be00-91ea-4b3f-85a1-59f1cf6075df@127.0.0.1:57221 disconnected
```


Thanks,

haosdent huang

Re: Review Request 52244: Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52244/
---

(Updated Oct. 8, 2016, 1:53 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
---

Apply @jieyu's adjustments.


Bugs: MESOS-6063
https://issues.apache.org/jira/browse/MESOS-6063


Repository: mesos


Description
---

Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f1035a0b505a8db7fd495a586e7ce3c23914250a 

Diff: https://reviews.apache.org/r/52244/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/
---

(Updated Oct. 8, 2016, 12:43 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-6035
https://issues.apache.org/jira/browse/MESOS-6035


Repository: mesos


Description
---

In most cases, we just want to get the children cgroups instead of
retrieve descendant cgroups recursively. We added an argument to
`cgroups::get` to indicate whether retrieve cgroups recursively and
make non-recursive retrieve become the default behaviour. This patch
fixed some incorrect `TEST_CGROUPS_ROOT` checks as well.


Diffs (updated)
-

  src/linux/cgroups.hpp 3c9d9e21c8332668286e4170be711aa260c12c1d 
  src/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d 
  src/tests/containerizer/cgroups_tests.cpp 
0afaec6ae948cabf1472bf01103210d8f9809cb1 
  src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2 

Diff: https://reviews.apache.org/r/51031/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51624/
---

(Updated Oct. 8, 2016, 12:37 p.m.)


Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Bugs: MESOS-6123
https://issues.apache.org/jira/browse/MESOS-6123


Repository: mesos


Description
---

Implemented 'GetAgent' call in v1 agent API.


Diffs (updated)
-

  include/mesos/agent/agent.proto 5b91677487f8e23301e67af14c2115c6b4a533ac 
  include/mesos/v1/agent/agent.proto 8145669073553dc8aa56cfe2c0a0b756d70fee0e 
  src/slave/http.cpp 67463105d7fa38b2158a64f6994e3dd353a9fcc7 
  src/slave/slave.hpp 13c76d1eaea2b49519948c9116e5db5caf9407ea 
  src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
  src/tests/api_tests.cpp 26f99f7c337fbbc5278d1b30d3d5c8f659ddf5ca 

Diff: https://reviews.apache.org/r/51624/diff/


Testing
---

Added a new test case `AgentAPITest.GetAgent`.


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 8, 2016, 12:20 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/
---

(Updated Oct. 8, 2016, 12:20 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

Set executor id in `protobuf::createTask`.


Diffs
-

  src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 
  src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
  src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 
  src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
  src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 
  src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8 
  src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
  src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
  src/tests/common/http_tests.cpp aea338674f1a3b769958af134d1435292b827ba7 
  src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 

Diff: https://reviews.apache.org/r/52470/diff/


Testing (updated)
---

Add a new test case `CommandExecutorTest.EmptyExecutorIdInTask`.


Thanks,

haosdent huang

Re: Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52520/
---

(Updated Oct. 8, 2016, 12:20 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

Exposed the executor's type in the endpoints.


Diffs (updated)
-

  src/common/http.cpp 538330a4c780fbc2dfcdfb31537b0e75f368e3e0 
  src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8 
  src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f 

Diff: https://reviews.apache.org/r/52520/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/
---

(Updated Oct. 8, 2016, 12:19 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Address @vinodkone's comments.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

Set executor id in `protobuf::createTask`.


Diffs (updated)
-

  src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 
  src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
  src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 
  src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
  src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 
  src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8 
  src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
  src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
  src/tests/common/http_tests.cpp aea338674f1a3b769958af134d1435292b827ba7 
  src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 

Diff: https://reviews.apache.org/r/52470/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52620/#review151923
---



Patch looks great!

Reviews applied: [52620]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 7, 2016, 5:29 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52620/
> ---
> 
> (Updated Oct. 7, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4948
> https://issues.apache.org/jira/browse/MESOS-4948
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated InverseOffers* maintenance tests to use the new scheduler mock.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 77eb405ab7314da906bed9ec1d0018c24928d8d8 
> 
> Diff: https://reviews.apache.org/r/52620/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X 10.11 and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 52653: Modified a test to use the updated Bytes operators.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52653/#review151922
---



Patch looks great!

Reviews applied: [52652, 52653]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 7, 2016, 10:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52653/
> ---
> 
> (Updated Oct. 7, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the only test that multiplies/divides Bytes by a decimal value.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7957873102b3777d47fa9304b85a93d58a746b9d 
> 
> Diff: https://reviews.apache.org/r/52653/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>