Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Address @vinodkone's comments. Bugs: MESOS-6283 https://issues.apache.org/jira/browse/MESOS-6283 Repository: mesos Description --- This fixed the navigate error in Web UI because Web UI uses the executor id of the task to search the corresponding sandbox directory. Web UI uses the task id as the executor id if the executor id of the task is empty when searching the sandbox directory. It works fine when tasks are launched by `CommandExecutor` because the executor id of the task is equal to the task id in this case. However, when tasks are launched by `DefaultExecutor`, the executor id of the task is defined in the framework side and may different with the task id. So we need to fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid the Web UI uses incorrect executor id to search sandbox directory. Diffs (updated) - include/mesos/mesos.proto 05988d4a5cc387f6eafe6453170bcc8764ee1247 include/mesos/v1/mesos.proto 08a536cf345663f81d03e53625c640f946ce5079 src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 src/master/master.cpp 7ef898781ce5c2349ffeaa3ce43e68dede19c852 src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f src/tests/master_validation_tests.cpp 99e350e0587e73e9ee25ef20dd369cd146bd446a Diff: https://reviews.apache.org/r/52470/diff/ Testing --- Add new test case `DefaultExecutorTest.ROOT_TaskUsesExecutor`. Thanks, haosdent huang
Review Request 52817: Added utils method to check if `ExecutorInfo` different.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52817/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283 https://issues.apache.org/jira/browse/MESOS-6283 Repository: mesos Description --- Added utils method to check if `ExecutorInfo` different. Diffs - include/mesos/type_utils.hpp 1d09b4fb5d8db8005506a12e7a179f46ee376ca2 src/common/type_utils.cpp cad243f7222e93030fa5a9c00955e9ef55f3c805 Diff: https://reviews.apache.org/r/52817/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 52803: Changed agent to send TASK_GONE.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/#review152458 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958, 52039, 52083, 52656, 52657, 52658, 52659, 52693, 52719, 52720, 52721, 52722, 52723, 52740, 52746, 52801, 52802, 52803] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 12, 2016, 7:35 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52803/ > --- > > (Updated Oct. 12, 2016, 7:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6332 > https://issues.apache.org/jira/browse/MESOS-6332 > > > Repository: mesos > > > Description > --- > > The agent previously sent TASK_LOST updates for tasks that are killed > for various reasons, such as containerizer errors or QoS preemption. The > agent now sends TASK_GONE to partition-aware frameworks instead. > > > Diffs > - > > src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 > src/tests/oversubscription_tests.cpp > b356fb62a4e068bc171a75a76001c6d0e76af92a > src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc > > Diff: https://reviews.apache.org/r/52803/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Neil Conway > >
Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review152456 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2016, 5 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51009/ > --- > > (Updated Oct. 12, 2016, 5 p.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jie Yu, and Steve > Niemitz. > > > Bugs: MESOS-6031 > https://issues.apache.org/jira/browse/MESOS-6031 > > > Repository: mesos > > > Description > --- > > Collect throttle related cpu.stat for Docker Containerizer. > > > Diffs > - > > src/slave/containerizer/docker.cpp d71386089bf7677872bcb1bd36e07da9263dcf0d > > Diff: https://reviews.apache.org/r/51009/diff/ > > > Testing > --- > > Run agent with cfs quota enabled, and observe that throttle related metrics > are in `/containers` and `/monitoring/statistics` > > > Thanks, > > Zhitao Li > >
