Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55543/ --- (Updated Feb. 12, 2017, 1:08 a.m.) Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Changes --- Address Joseph's comments. Bugs: MESOS-6720 https://issues.apache.org/jira/browse/MESOS-6720 Repository: mesos Description --- Before building Mesos on a Windows machine, it is necessary to set `%PreferredToolArchitecture%` to the value `x64`. This is necessary to work around (at least) two bugs in the MSVC backend: in particular, the linker can sometimes take hours or days to link `mesos-x.x.x.lib`, and the build system occasionally finds it self spuriously unable to find file `mesos-x.x.x.lib` to link against. These issues are well-known and documented (e.g., in the official Mesos "getting started" document), but it is better to simply refuse to build Mesos at all on Windows unless that environment variable is set. This commit will introduce such a check. Diffs (updated) - cmake/CompilationConfigure.cmake 560935b81603dc58c167918d36e2ae0a4060673d src/CMakeLists.txt 3a4ace9c8011ac8eec5067cd085fa7fe4166b9ee src/slave/cmake/AgentConfigure.cmake 8d930d329048440d57b621fe8393b11912cdb27b Diff: https://reviews.apache.org/r/55543/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 56378: Added test case for suppress and revive with multi role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review165246 --- Patch looks great! Reviews applied: [56327, 56328, 56330, 56371, 56373, 56374, 56376, 56378] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 11, 2017, 10:29 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56378/ > --- > > (Updated Feb. 11, 2017, 10:29 a.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > --- > > Added test case for suppress and revive with multi role framework. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > a866d03c0b7a676d08fb2fb1e321133c9f5363fc > > Diff: https://reviews.apache.org/r/56378/diff/ > > > Testing > --- > > make > make check > > ``` > ./bin/mesos-tests.sh > --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole" > --gtest_repeat=100 > ``` > > > Thanks, > > Guangya Liu > >
Re: Review Request 56568: Modified the executor driver to always relink on agent failover.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56568/#review165243 --- Patch looks great! Reviews applied: [56568] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 11, 2017, 12:45 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56568/ > --- > > (Updated Feb. 11, 2017, 12:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7057 > https://issues.apache.org/jira/browse/MESOS-7057 > > > Repository: mesos > > > Description > --- > > A relink is needed in cases where a netfilter module like iptables > can terminate the connection without notifying the executor. This > results in the executor still trying to reuse the stale "half-open" > connection upon receiving the reconnect message from the executor > leading to the erroneous behavior. > > > Diffs > - > > src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b > > Diff: https://reviews.apache.org/r/56568/diff/ > > > Testing > --- > > Performed the steps to reproduce on MESOS-5332 and verified the problem is > fixed with the relink. > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 56378: Added test case for suppress and revive with multi role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/ --- (Updated 二月 11, 2017, 10:29 a.m.) Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 https://issues.apache.org/jira/browse/MESOS-6638 Repository: mesos Description --- Added test case for suppress and revive with multi role framework. Diffs (updated) - src/tests/hierarchical_allocator_tests.cpp a866d03c0b7a676d08fb2fb1e321133c9f5363fc Diff: https://reviews.apache.org/r/56378/diff/ Testing --- make make check ``` ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole" --gtest_repeat=100 ``` Thanks, Guangya Liu
Re: Review Request 56376: Updated allocator test to support create multi role framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56376/ --- (Updated 二月 11, 2017, 10:09 a.m.) Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 https://issues.apache.org/jira/browse/MESOS-6638 Repository: mesos Description --- Updated allocator test to support create multi role framework. Diffs (updated) - src/tests/hierarchical_allocator_tests.cpp a866d03c0b7a676d08fb2fb1e321133c9f5363fc Diff: https://reviews.apache.org/r/56376/diff/ Testing --- make make check Thanks, Guangya Liu
