Re: Review Request 59254: Used loop to implement allocator interval-based allocation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59254/#review174893 --- Patch looks great! Reviews applied: [59254] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 13, 2017, 6:06 a.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59254/ > --- > > (Updated May 13, 2017, 6:06 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Repository: mesos > > > Description > --- > > This also gets rid of the old "batch" (interval-based) allocation concept > because we now > use the term to describe the grouping of all pending allocation candidates in > an allocation run. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 123f97cf495bff0f822838e09df0d88818f04da6 > src/master/allocator/mesos/hierarchical.cpp > b75ed9a20a9a42f958cebbacd91e5e15b0d21394 > > > Diff: https://reviews.apache.org/r/59254/diff/2/ > > > Testing > --- > > make check. > > > Thanks, > > Jiang Yan Xu > >
Re: Review Request 58486: Update the allocator on a per offer operation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/#review174892 --- Patch looks great! Reviews applied: [59194, 59195, 58486] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 13, 2017, 4:51 a.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58486/ > --- > > (Updated May 13, 2017, 4:51 a.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7308 > https://issues.apache.org/jira/browse/MESOS-7308 > > > Repository: mesos > > > Description > --- > > The allocator is updated for each offer operation in the order specified > in the `ACCEPT` call. Once the allocator is updated successfully, we > handle subsequent operations as follows: > > 1) Launch or Launch Group: We launch the tasks or task group on the >agent. > 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send >the `CheckPointResourcesMessage` to the agent. > > If allocation for any of the operations fail, those resources are not > recovered from the allocator. > > > Diffs > - > > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad > > > Diff: https://reviews.apache.org/r/58486/diff/5/ > > > Testing > --- > > Tests passed. > > > Thanks, > > Anindya Sinha > >
Re: Review Request 58778: Supported GCE container registry.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review174890 --- Patch looks great! Reviews applied: [58778] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 13, 2017, 12:45 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58778/ > --- > > (Updated May 13, 2017, 12:45 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7431 > https://issues.apache.org/jira/browse/MESOS-7431 > > > Repository: mesos > > > Description > --- > > Certain registries, such as GCE registry, reply 403 instead of 401 for > unauthorized requests. When fetching image manifests and blobs, instead > of sending out unauthorized requests first and waiting for a possible > 401, we should always look up the docker config and send requests with > basic authorization when possible. > > > Diffs > - > > src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 > > > Diff: https://reviews.apache.org/r/58778/diff/3/ > > > Testing > --- > > sudo make check (covers all supported public registries) > Manually tested on the following private registries: > 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1) > 2. Amazon ECR > 3. Google GCR > 4. JFrog SaaS > 5. Local Nexus registry 3.3.1 > > > Thanks, > > Chun-Hung Hsiao > >
