Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200714
---



PASS: Mesos patch 66293 was successfully built and tested.

Reviews applied: `['66481', '66258', '66259', '66260', '66283', '66284', 
'66291', '66293']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

- Mesos Reviewbot Windows


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 66481: Converted `pid` in command executor to `Option`.

2018-04-07 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/#review200713
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66481']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (114 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1083 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (796 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (823 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (823 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (850 ms total)

[--] Global test environment tear-down
[==] 954 tests from 94 test cases ran. (458920 ms total)
[  PASSED  ] 953 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481/logs/mesos-tests-stderr.log):

```
I0408 01:45:25.728668  5040 exec.cpp:236] Executor registered on agent 
e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
I0408 01:45:25.732687 17672 executor.cpp:177] Received SUBSCRIBED event
I0408 01:45:25.737663 17672 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0408 01:45:25.737663 17672 executor.cpp:177] Received LAUNCH event
I0408 01:45:25.742668 17672 executor.cpp:649] Starting task 
a77eedfe-8fb7-4c9f-a16a-93d2f051cb70
I0408 01:45:25.822664 17672 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0408 01:45:25.852685 17672 executor.cpp:662] Forked command at 5404
I0408 01:45:25.887648 10568 exec.cpp:445] Executor asked to shutdown
I0408 01:45:25.888650  7280 executor.cpp:177] Received SHUTDOWN event
I0408 01:45:25.888650  7280 executor.cpp:759] Shutting down
I0408 01:45:25.888650  7280 executor.cpp:869] Sending SIGTERM to process tree 
at pid 5] Deactivated framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-
I0408 01:45:25.884647 18536 slave.cpp:3973] Shutting down framework 
e7f23cbb-ac84-4025-939a-dc8085d64c8e-
I0408 01:45:25.884647  6160 master.cpp:10452] Updating the state of task 
a77eedfe-8fb7-4c9f-a16a-93d2f051cb70 of framework 
e7f23cbb-ac84-4025-939a-dc8085d64c8e- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0408 01:45:25.885655 18536 slave.cpp:6670] Shutting down executor 
'a77eedfe-8fb7-4c9f-a16a-93d2f051cb70' of framework 
e7f23cbb-ac84-4025-939a-dc8085d64c8e- at executor(1)@10.3.1.8:54367
I0408 01:45:25.886646 18536 slave.cpp:923] Agent terminating
W0408 01:45:25.886646 18536 slave.cpp:3969] Ignoring shutdown framework 
e7f23cbb-ac84-4025-939a-dc8085d64c8e- because it is terminating
I0408 01:45:25.889644  6160 master.cpp:10551] Removing task 
a77eedfe-8fb7-4c9f-a16a-93d2f051cb70 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework e7f23cbb-ac84-4025-939a-dc8085d64c8e- on 
agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0 at slave(423)@10.3.1.8:54346 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0408 01:45:25.891677  8600 containerizer.cpp:2338] Destroying container 
10236355-c203-47da-93c6-afa3cb3f4521 in RUNNING state
I0408 01:45:25.892654  8600 containerizer.cpp:2952] Transitioning the state of 
container 10236355-c203-47da-93c6-afa3cb3f4521 from RUNNING to DESTROYING
I0408 01:45:25.892654  6160 master.cpp:1295] Agent 
e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0 at slave(423)@10.3.1.8:54346 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0408 01:45:25.892654  6160 master.cpp:3286] Disconnecting agent 
e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0 at slave(423)@10.3.1.8:54346 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452n

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
---

(Updated April 7, 2018, 5:54 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename and updated test.


Summary (updated)
-

Tested default executor support of `max_completion_time`.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

Tested default executor support of `max_completion_time`.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66293/diff/2/

Changes: https://reviews.apache.org/r/66293/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66291: Added support to `max_completion_time` in default executor.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66291/
---

(Updated April 7, 2018, 5:53 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename and proper state.


Summary (updated)
-

Added support to `max_completion_time` in default executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

When a task group has multiple tasks:
- each task can have its own `max_completion_time`, or not have one;
- if a task succeeds before its `max_completion_time`, all other tasks
will keep running;
- if a task fails, all other tasks in the same group will fail (as
before);
- if a task does not succeed before its `max_completion_time`, it will
fail with `TASK_FAILED` and reason `REASON_MAX_COMPLETION_TIME_REACHED`,
while other tasks will be killed without above reason.


Diffs (updated)
-

  src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 


Diff: https://reviews.apache.org/r/66291/diff/2/

Changes: https://reviews.apache.org/r/66291/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/
---

(Updated April 7, 2018, 5:53 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Updated test according to rename.


Summary (updated)
-

Tested `max_completion_time` support in docker executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

Tested `max_completion_time` support in docker executor.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 


Diff: https://reviews.apache.org/r/66284/diff/2/

Changes: https://reviews.apache.org/r/66284/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66283: Added support of `max_completion_time` in docker executor.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66283/
---

(Updated April 7, 2018, 5:52 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename and proper state.


Summary (updated)
-

Added support of `max_completion_time` in docker executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

If `TaskInfo.max_completion_time` is set, docker executor will kill
the task immediately. We reuse the `shutdown` method to achieve a
forced kill ignoring any `KillPolicy`.

Framework should only received a `TASK_FAILED` state with
`REASON_MAX_COMPLETION_TIME_REACHED` reason.


Diffs (updated)
-

  src/docker/executor.cpp 1d672112bae889cc9d19343a59e0ff66569785c4 


Diff: https://reviews.apache.org/r/66283/diff/2/

Changes: https://reviews.apache.org/r/66283/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66260: Tested `max_completion_time` support in command executor.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66260/
---

(Updated April 7, 2018, 5:52 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Fix test accordingly.


Summary (updated)
-

Tested `max_completion_time` support in command executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

Tested `max_completion_time` support in command executor.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a 


Diff: https://reviews.apache.org/r/66260/diff/2/

Changes: https://reviews.apache.org/r/66260/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66259: Added `max_completion_time` support to command executor.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66259/
---

(Updated April 7, 2018, 5:51 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename and proper state.


Summary (updated)
-

Added `max_completion_time` support to command executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

If `TaskInfo.max_completion_time` is set, command executor will kill
the task with `SIGKILL` immediately. Note that no KillPolicy will be
observed. Framework should only received a `TASK_FAILED` state with
`REASON_MAX_COMPLETION_TIME_REACHED` reason.


Diffs (updated)
-

  src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 


Diff: https://reviews.apache.org/r/66259/diff/2/

Changes: https://reviews.apache.org/r/66259/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66258: Added `max_completion_time` to `TaskInfo` and new reason.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66258/
---

(Updated April 7, 2018, 5:51 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename as we discussed.


Summary (updated)
-

Added `max_completion_time` to `TaskInfo` and new reason.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

This new field can be used support tasks which have a maximum duration
scheduling requirement. The new reason is added to distinguish from
normal task kills.


Diffs (updated)
-

  include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 
  include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 


Diff: https://reviews.apache.org/r/66258/diff/2/

Changes: https://reviews.apache.org/r/66258/diff/1-2/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 66481: Converted `pid` in command executor to `Option`.

2018-04-07 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/
---

(Updated April 7, 2018, 5:50 p.m.)


Review request for mesos, Andrew Schwartzmeyer and James Peach.


Repository: mesos


Description (updated)
---

This avoids unix's assumption that `pid_t` is a signed integer (which is
not the case on Windows) and explicitly shows whether a pid has been
assigned from launching.

We also changed argument name in `reaped` method to `_pid` to avoid
shadowing.


Diffs (updated)
-

  src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 


Diff: https://reviews.apache.org/r/66481/diff/2/

Changes: https://reviews.apache.org/r/66481/diff/1-2/


Testing
---

`make` on Linux.


Thanks,

Zhitao Li



Re: Review Request 66481: Converted `pid` in command executor to `Option`.

2018-04-07 Thread Zhitao Li


> On April 5, 2018, 5:01 p.m., James Peach wrote:
> > I think we should just change all the usages of `pid` rather than renaming 
> > it to `pid_`.

Fixed.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/#review200605
---


On April 7, 2018, 5:50 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66481/
> ---
> 
> (Updated April 7, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This avoids unix's assumption that `pid_t` is a signed integer (which is
> not the case on Windows) and explicitly shows whether a pid has been
> assigned from launching.
> 
> We also changed argument name in `reaped` method to `_pid` to avoid
> shadowing.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 
> 
> 
> Diff: https://reviews.apache.org/r/66481/diff/2/
> 
> 
> Testing
> ---
> 
> `make` on Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

2018-04-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200707
---



Patch looks great!

Reviews applied: [66493]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 7, 2018, 2:54 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66493/
> ---
> 
> (Updated April 7, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8761
> https://issues.apache.org/jira/browse/MESOS-8761
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made FreeBSD default to non-GNU ld.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
> 
> 
> Diff: https://reviews.apache.org/r/66493/diff/1/
> 
> 
> Testing
> ---
> 
> make on FreeBSD, with both lld and gold.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>



Re: Review Request 66445: Windows: Cleaned up included CRT headers.

2018-04-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/#review200705
---



Patch looks great!

Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 
66428, 66455, 66429, 66430, 66431, 66432, 66434, 66435, 66436, 66437, 66433, 
66438, 66439, 66440, 66442, 66443, 66444, 66445]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 6, 2018, 11:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66445/
> ---
> 
> (Updated April 6, 2018, 11:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8759
> https://issues.apache.org/jira/browse/MESOS-8759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The set `errno` value in `os::kill()` is never checked (especially on
> Windows), so `_set_errno()` and thus `errno.h` were removed.
> 
> The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged
> in `open.hpp`, not `windows.hpp`.
> 
> The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h`
> were no longer used or needed as the respective CRT APIs were
> replaced.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/kill.hpp 
> 9cec1117fac3cf6bd624fc7db524ef1ad10cd55d 
>   3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> 9181429383a991fe2b87701d2bfd0e858ac2537b 
>   3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> a2926dab2c8e219cf5938c4df27f83488198dd6b 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> fff5872db6b3f69464e41e6d108a107e4eeabd12 
>   3rdparty/stout/include/stout/windows.hpp 
> 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 
>   3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 
> 5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
> 
> 
> Diff: https://reviews.apache.org/r/66445/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

2018-04-07 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200704
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66493']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66493

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66493/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (123 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1084 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (45 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (86 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (781 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (812 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (820 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (850 ms total)

[--] Global test environment tear-down
[==] 954 tests from 94 test cases ran. (471114 ms total)
[  PASSED  ] 953 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66493/logs/mesos-tests-stderr.log):

```
I0407 15:54:06.660614  6244 slave.cpp:3973] Shutting down framework 
9a9994b3-1787-4ad6-8233-b01006c6d4cc-
I0407 15:54:06.660614 11604 master.cpp:10452] Updating the state of task 
11cd7869-bc96-4572-9fd5-50a79f56ea4f of framework 
9a9994b3-1787-4ad6-8233-b01006c6d4cc- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0407 15:54:06.660614  6244 slave.cpp:6670] Shutting down executor 
'11cd7869-bc96-4572-9fd5-50a79f56ea4f' of framework 
9a9994b3-1787-4ad6-8233-b01006c6d4cc-I0407 15:54:06.476617 10892 
exec.cpp:162] Version: 1.6.0
I0407 15:54:06.505643 19036 exec.cpp:236] Executor registered on agent 
9a9994b3-1787-4ad6-8233-b01006c6d4cc-S0
I0407 15:54:06.509647 17620 executor.cpp:177] Received SUBSCRIBED event
I0407 15:54:06.515609 17620 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0407 15:54:06.515609 17620 executor.cpp:177] Received LAUNCH event
I0407 15:54:06.520608 17620 executor.cpp:649] Starting task 
11cd7869-bc96-4572-9fd5-50a79f56ea4f
I0407 15:54:06.605608 17620 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0407 15:54:06.633612 17620 executor.cpp:662] Forked command at 19160
I0407 15:54:06.662616  6500 exec.cpp:445] Executor asked to shutdown
I0407 15:54:06.663614 18180 executor.cpp:177] Received SHUTDOWN event
I0407 15:54:06.663614 18180 executor.cpp:759] Shutting down
I0407 15:54:06.663614 18180 executor.cpp:869] Sending SIGTERM to process tree 
at pid  at executor(1)@10.3.1.8:51782
I0407 15:54:06.662616  6244 slave.cpp:923] Agent terminating
W0407 15:54:06.662616  6244 slave.cpp:3969] Ignoring shutdown framework 
9a9994b3-1787-4ad6-8233-b01006c6d4cc- because it is terminating
I0407 15:54:06.663614 11604 master.cpp:10551] Removing task 
11cd7869-bc96-4572-9fd5-50a79f56ea4f with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 9a9994b3-1787-4ad6-8233-b01006c6d4cc- on 
agent 9a9994b3-1787-4ad6-8233-b01006c6d4cc-S0 at slave(423)@10.3.1.8:51761 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0407 15:54:06.665613 12344 containerizer.cpp:2338] Destroying container 
eecdbd30-1cf4-4c9b-8485-0e1260cf5ada in RUNNING state
I0407 15:54:06.13 12344 containerizer.cpp:2952] Transitioning the state of 
container eecdbd30-1cf4-4c9b-8485-0e1260cf5ada from RUNNING to DESTROYING
I0407 15:54:06.13 11604 master.cpp:1295] Agent 
9a9994b3-1787-4ad6-8233-b01006c6d4cc-S0 at slave(423)@10.3.1.8:51761 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0407 15:54:06.13 17440 hierarchical.cpp:344] Removed framework 
9a9994b3-1787-4ad6-8233-b01006c6d4cc-
I0407 15:54:06.667620 11604 master.cpp:3286] Disconnecting agent 
9a99

Review Request 66493: Made FreeBSD default to non-GNU ld.

2018-04-07 Thread David Forsythe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/
---

Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Bugs: MESOS-8761
https://issues.apache.org/jira/browse/MESOS-8761


Repository: mesos


Description
---

Made FreeBSD default to non-GNU ld.


Diffs
-

  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 


Diff: https://reviews.apache.org/r/66493/diff/1/


Testing
---

make on FreeBSD, with both lld and gold.


Thanks,

David Forsythe