Re: Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67821/#review205709
---



Patch looks great!

Reviews applied: [67820, 67821]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 9:31 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67821/
> ---
> 
> (Updated July 3, 2018, 9:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added override specifiers to XfsDiskIsolatorProcess methods.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b 
> 
> 
> Diff: https://reviews.apache.org/r/67821/diff/1/
> 
> 
> Testing
> ---
> 
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67827/#review205708
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67444', '6', '67825', '67826', '67827']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67827

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67827/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (603 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1226 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (798 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1007 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5561 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5258 ms)
[--] 24 tests from DockerContainerizerTest (93839 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00AC3FF5BB00.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00AC3FF5BD60.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @020B480C7890.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @020B487738B8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @020B48FC87B0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67827/logs/mesos-tests-stderr.log):

```
I0704 02:47:51.492888  1828 authenticatee.cpp:299] Authentication success
I0704 02:47:51.493870  8728 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-10e49cd3-1f13-41c6-8a87-79c1f6175935@192.10.1.6:60741
I0704 02:47:51.493870  2728 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:60741
I0704 02:47:51.495057  1828 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-10e49cd3-1f13-41c6-8a87-79c1f6175935@192.10.1.6:60741
I0704 02:47:51.495057  1828 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0704 02:47:51.495887  7476 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0704 02:47:51.496978  7476 master.cpp:9993] Adding framework 
2f17db8c-4e59-471f-9d62-2d3c02232b0a- (default) at 
scheduler-10e49cd3-1f13-41c6-8a87-79c1f6175935@192.10.1.6:60741 with roles {  } 
suppressed
I0704 02:47:51.497874  9732 sched.cpp:749] Framework registered with 
2f17db8c-4e59-471f-9d62-2d3c02232b0a-
I0704 02:47:51.498872 11940 hierarchical.cpp:298] Added framework 
2f17db8c-4e59-471f-9d62-2d3c02232b0a-
E0704 02:47:51.598872  2728 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review205707
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67444', '6']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/6

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/6/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (603 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1225 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1005 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5157 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4958 ms)
[--] 24 tests from DockerContainerizerTest (91902 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00B2D18FBDF0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00B2D18FC050.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @022C4A108500.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @022C4A22F4A0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @022C4AF5A398.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/6/logs/mesos-tests-stderr.log):

```
I0704 01:50:36.285436  9864 authenticatee.cpp:299] Authentication success
I0704 01:50:36.285436  8188 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-46f75a01-a36a-4d74-b2e0-e99a91dfeb17@192.10.1.6:59619
I0704 01:50:36.286437  7284 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:59619
I0704 01:50:36.287441  8188 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-46f75a01-a36a-4d74-b2e0-e99a91dfeb17@192.10.1.6:59619
I0704 01:50:36.287441  8188 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0704 01:50:36.289436  9752 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0704 01:50:36.289436  9752 master.cpp:9993] Adding framework 
ebdb3629-3c86-4c70-8655-c4a251fefbfe- (default) at 
scheduler-46f75a01-a36a-4d74-b2e0-e99a91dfeb17@192.10.1.6:59619 with roles {  } 
suppressed
I0704 01:50:36.290439  5892 sched.cpp:749] Framework registered with 
ebdb3629-3c86-4c70-8655-c4a251fefbfe-
I0704 01:50:36.291432  7248 hierarchical.cpp:298] Added framework 
ebdb3629-3c86-4c70-8655-c4a251fefbfe-
E0704 01:50:36.388473  9752 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recog

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205706
---



Patch looks great!

Reviews applied: [67817]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 8:56 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67817/
> ---
> 
> (Updated July 3, 2018, 8:56 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> Also log at `VLOG(2)` level which resources are offered.
> 
> NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
> setting the following env variable when starting the master:
> `GLOG_vmodule=master=2`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67817/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing =).
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67827/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8916
https://issues.apache.org/jira/browse/MESOS-8916


Repository: mesos


Description
---

This helper removes any resources that the framework is not
capable of receiving based on the given framework capability.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 


Diff: https://reviews.apache.org/r/67827/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 67825: Added a resources utility `hasShared()`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67825/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/resources.hpp 175833c7d08443955d0aacd844c7df180d43e829 
  include/mesos/v1/resources.hpp b607b68fd905c09356288e8bc16081a7fe15e6ba 
  src/common/resources.cpp 253b8bcd720e38f485b5cd2f5b7666ac85e67d38 
  src/v1/resources.cpp ab8fc3e738038b9b34d4902aed9f15a59b416217 


Diff: https://reviews.apache.org/r/67825/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67826/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Currently, depending on already allocated resources,
`HierarchicalAllocatorProcess::Slave::getAvailable()`
may not contain all the shared resources. Since shared
resources are always allocatable, we should include all
shared resources in the agent available resources.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 


Diff: https://reviews.apache.org/r/67826/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205705
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67791']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1326 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1007 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5460 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5054 ms)
[--] 24 tests from DockerContainerizerTest (92239 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00FC116FBA40.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00FC116FBCA0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @028EBD8D7E78.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @028EBF52D1B0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @028EBF84FB00.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stderr.log):

```
I0704 00:54:10.762325  3408 authenticatee.cpp:299] Authentication success
I0704 00:54:10.762325  6072 master.cpp:9786] Successfully authenticated 
principal 'test-principal' at 
scheduler-9e09239f-3963-4e03-ba99-132798caba76@192.10.1.6:58528
I0704 00:54:10.763017  8580 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:58528
I0704 00:54:10.763017  3992 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-9e09239f-3963-4e03-ba99-132798caba76@192.10.1.6:58528
I0704 00:54:10.764011  3992 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0704 00:54:10.765188  6072 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0704 00:54:10.766000  6072 master.cpp:9977] Adding framework 
1b175f28-6707-4d91-a15d-24458fc31daa- (default) at 
scheduler-9e09239f-3963-4e03-ba99-132798caba76@192.10.1.6:58528 with roles {  } 
suppressed
I0704 00:54:10.767010  3900 sched.cpp:749] Framework registered with 
1b175f28-6707-4d91-a15d-24458fc31daa-
I0704 00:54:10.767010  1676 hierarchical.cpp:299] Added framework 
1b175f28-6707-4d91-a15d-24458fc31daa-
E0704 00:54:10.865294  8580 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as 

Re: Review Request 67824: Reduced likelihood of a stack overflow in libprocess socket recv path.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67824/#review205704
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On July 4, 2018, 12:06 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67824/
> ---
> 
> (Updated July 4, 2018, 12:06 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9024
> https://issues.apache.org/jira/browse/MESOS-9024
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, the socket recv path is implemented using an asynchronous
> loop with callbacks. Without using `process::loop`, this pattern is
> prone to a stack overflow in the case that all asynchronous calls
> complete synchronously. This is possible with sockets if the socket
> is always ready for reading. The crash has been reported in MESOS-9024,
> so the stack overflow has been encountered in practice.
> 
> This patch updates the recv path to leverage `process::loop`, which
> is supposed to prevent stack overflows in asynchronous loops. However,
> it is still possible for `process::loop` to stack overflow due to
> MESOS-8852. In practice, I expect that even without MESOS-8852 fixed,
> users won't see any stack overflows in the recv path.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> eb9613f1d47d611a31f7c538216fa324bbca1a56 
> 
> 
> Diff: https://reviews.apache.org/r/67824/diff/2/
> 
> 
> Testing
> ---
> 
> make check and manually tested master/agent/framework communication
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/
---

(Updated July 3, 2018, 5:19 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Added const.


Bugs: MESOS-8916
https://issues.apache.org/jira/browse/MESOS-8916


Repository: mesos


Description
---

`isFrameworkCapableReceivingAgent` checks if a framework
is capable of receiving resources on the agent based on
the framework capability.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 


Diff: https://reviews.apache.org/r/6/diff/3/

Changes: https://reviews.apache.org/r/6/diff/2-3/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

[Meng Zhu]

> On July 2, 2018, 3:42 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1756 (original), 1755 (patched)
> > 
> >
> > How about a member function of the framework struct?
> > 
> > ```
> > if (!framework.isCapableOnAgent(slave)) {
> >   ...
> > }
> > ```
> 
> Meng Zhu wrote:
> That would need to move nested Slave class forward or outside. Currently, 
> all the helper functions for slave/framework are member functions of the 
> outer class. I was trying to be consistent. If you think it is necessary, I 
> can go ahead and overhaul the structure.

I could forward declare Slave in the outer class. Yet it would still depend on 
`filterGpuResources` of the outer class. Need to either cache a reference or 
pass in the flag. Feel cleaner this way.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review205647
---


On June 28, 2018, 4 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6/
> ---
> 
> (Updated June 28, 2018, 4 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8916
> https://issues.apache.org/jira/browse/MESOS-8916
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `isFrameworkCapableReceivingAgent` checks if a framework
> is capable of receiving resources on the agent based on
> the framework capability.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
>   src/master/allocator/mesos/hierarchical.cpp 
> cbdfb2ba9c25755ac631557e0e7dbd721f861a4d 
> 
> 
> Diff: https://reviews.apache.org/r/6/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 67824: Reduced likelihood of a stack overflow in libprocess socket recv path.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67824/
---

Review request for mesos and Chun-Hung Hsiao.


Bugs: MESOS-9024
https://issues.apache.org/jira/browse/MESOS-9024


Repository: mesos


Description
---

Currently, the socket recv path is implemented using an asynchronous
loop with callbacks. Without using `process::loop`, this pattern is
prone to a stack overflow in the case that all asynchronous calls
complete synchronously. This is possible with sockets if the socket
is always ready for reading. The crash has been reported in MESOS-9024,
so the stack overflow has been encountered in practice.

This patch updates the recv path to leverage `process::loop`, which
is supposed to prevent stack overflows in asynchronous loops. However,
it is still possible for `process::loop` to stack overflow due to
MESOS-8852. In practice, I expect that even without MESOS-8852 fixed,
users won't see any stack overflows in the recv path.


Diffs
-

  3rdparty/libprocess/src/process.cpp eb9613f1d47d611a31f7c538216fa324bbca1a56 


Diff: https://reviews.apache.org/r/67824/diff/1/


Testing
---

make check and manually tested master/agent/framework communication


Thanks,

Benjamin Mahler

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67822/#review205701
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67822']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (799 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (602 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1223 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (797 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (798 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (998 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5663 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5054 ms)
[--] 24 tests from DockerContainerizerTest (94432 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @009F9197BAD0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @009F9197BD30.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01DC0E849B70.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01DC102C83F0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01DC1032FF98.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822/logs/mesos-tests-stderr.log):

```
I0703 23:57:27.244422  9236 authenticatee.cpp:299] Authentication success
I0703 23:57:27.244422  8176 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281
I0703 23:57:27.245590  3596 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.5:54281
I0703 23:57:27.246424  8904 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281
I0703 23:57:27.246424  8904 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 23:57:27.247543  5592 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 23:57:27.247543  5592 master.cpp:9993] Adding framework 
47858352-1ace-49d6-acc8-1f058e7e7d50- (default) at 
scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281 with roles {  } 
suppressed
I0703 23:57:27.249433  6716 sched.cpp:749] Framework registered with 
47858352-1ace-49d6-acc8-1f058e7e7d50-
I0703 23:57:27.249433  9236 hierarchical.cpp:299] Added framework 
47858352-1ace-49d6-acc8-1f058e7e7d50-
E0703 23:57:27.339431  9236 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as a

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/
---

(Updated July 3, 2018, 4:57 p.m.)


Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.


Changes
---

Fixed flaky test.


Bugs: MESOS-8987
https://issues.apache.org/jira/browse/MESOS-8987


Repository: mesos


Description
---

The Mesos master sends a `ShutdownMessage` to an agent if there is an
authentication or an authorization error during agent (re)registration.

Upon receipt of this message, the agent kills alls its tasks and commits
suicide. This means that transient auth errors can lead to whole agents
being killed along with it's tasks.

This patch prevents the master from sending a `ShutdownMessage` in these
cases.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
  src/tests/master_authorization_tests.cpp 
80b9d49ba334b915461ff5d6df6c9f922d7593e3 


Diff: https://reviews.apache.org/r/67791/diff/3/

Changes: https://reviews.apache.org/r/67791/diff/2-3/


Testing
---

`bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gastón Kleiman

Re: Review Request 67823: Added a master benchmark test for metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review205700
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812', 
'67813', '67814', '66841', '66842', '66843', '67147', '66844', '66855', 
'66861', '66856', '66870', '66883', '67187', '67235', '67823']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (804 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (602 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1227 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1010 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (600 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5367 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5164 ms)
[--] 24 tests from DockerContainerizerTest (93548 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00717190BDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00717190C010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01CAC70715B8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CAC7CCF3B0.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CAC81EE1F0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823/logs/mesos-tests-stderr.log):

```
I0703 23:52:05.459921  3464 authenticatee.cpp:259] Received SASL authentication 
step
I0703 23:52:05.459921   608 authenticator.cpp:232] Received SASL authentication 
step
I0703 23:52:05.459921   608 authenticator.cpp:318] Authentication success
I0703 23:52:05.460921  4608 authenticatee.cpp:299] Authentication success
I0703 23:52:05.460921  1696 master.cpp:9830] Successfully authenticated 
principal 'test-principal' at 
scheduler-e76bef89-a931-4544-9685-5ed32acf5e19@192.10.1.6:57425
I0703 23:52:05.461932  8588 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:57425
I0703 23:52:05.461932  4608 master.cpp:2941] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-e76bef89-a931-4544-9685-5ed32acf5e19@192.10.1.6:57425
I0703 23:52:05.461932  4608 master.cpp:2242] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 23:52:05.462924  3516 master.cpp:3022] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
E0703 23:52:05.467931  2100 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as an i

Re: Review Request 67823: Added a master benchmark test for metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 3, 2018, 11:10 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description (updated)
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/2/

Changes: https://reviews.apache.org/r/67823/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67822/
---

(Updated July 3, 2018, 4:05 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Changes
---

Minor style fix


Bugs: MESOS-9049
https://issues.apache.org/jira/browse/MESOS-9049


Repository: mesos


Description
---

We could potentially schedule the framework dir, executor dir, and
executor run sandbox to gc at the same time, and then these
paths will be gc independently, although they are parents and
children directories. This patch makes sure we do not call unmount
anymore after a success.


Diffs (updated)
-

  src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3 


Diff: https://reviews.apache.org/r/67822/diff/2/

Changes: https://reviews.apache.org/r/67822/diff/1-2/


Testing
---

```make```


Thanks,

Zhitao Li

Re: Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67821/#review205699
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67820', '67821']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67821

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67821/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1328 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (797 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (799 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1004 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (599 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5361 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5272 ms)
[--] 24 tests from DockerContainerizerTest (93508 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @005E521DBF20.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @005E521DC180.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @020D15562350.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @020D15D81738.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @020D1603C800.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67821/logs/mesos-tests-stderr.log):

```
I0703 22:54:53.205935  8832 authenticatee.cpp:299] Authentication success
I0703 22:54:53.205935  8952 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-402efcf5-1932-44a7-9955-61c71f7d568d@192.10.1.5:53182
I0703 22:54:53.206948  8552 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.5:53182
I0703 22:54:53.208940  8368 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-402efcf5-1932-44a7-9955-61c71f7d568d@192.10.1.5:53182
I0703 22:54:53.208940  8368 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 22:54:53.209935   716 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 22:54:53.210945   716 master.cpp:9993] Adding framework 
85490938-bbc6-47db-905b-68e70fd3ce8d- (default) at 
scheduler-402efcf5-1932-44a7-9955-61c71f7d568d@192.10.1.5:53182 with roles {  } 
suppressed
I0703 22:54:53.210945  5056 sched.cpp:749] Framework registered with 
85490938-bbc6-47db-905b-68e70fd3ce8d-
I0703 22:54:53.212935  8952 hierarchical.cpp:299] Added framework 
85490938-bbc6-47db-905b-68e70fd3ce8d-
E0703 22:54:53.296938   604 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recog

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review205698
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812', 
'67813', '67814', '66841', '66842', '66843', '67147', '66844', '66855', 
'66861', '66856', '66870', '66883', '67187', '67235']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1325 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5165 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4956 ms)
[--] 24 tests from DockerContainerizerTest (90217 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00905693BDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00905693C010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0265933CF4C8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @02659450F360.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0265945C6FB0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stderr.log):

```
I0703 22:51:45.960681  9388 authenticatee.cpp:299] Authentication success
I0703 22:51:45.961689  8204 master.cpp:9830] Successfully authenticated 
principal 'test-principal' at 
scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.961689  8552 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:56346
I0703 22:51:45.962689  9388 master.cpp:2941] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.962689  9388 master.cpp:2242] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 22:51:45.963690  8224 master.cpp:3022] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 22:51:45.975672  8224 master.cpp:10021] Adding framework 
993d0452-bfa9-45ad-a897-56720c36c7ed- (default) at 
scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346 with roles {  } 
suppressed
I0703 22:51:45.976670  5668 sched.cpp:749] Framework registered with 
993d0452-bfa9-45ad-a897-56720c36c7ed-
I0703 22:51:45.978691  8204 hierarchical.cpp:306] Added framework 
993d0452-bfa9-45ad-a897-56720c36c7ed-
E0703 22:51:46.063894  8380 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsof

Review Request 67823: Added a master benchmark test for metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description
---

This benchmark test measures the performance of the unversioned
'metrics/snapshot' endpoint as well as the GET_METRICS call in
the master v1 operator API.


Diffs
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67822/#review205696
---


Fix it, then Ship it!




Could you change the ticket to MESOS-9049?


src/slave/gc.cpp
Line 256 (original), 256 (patched)


Do you think the following will improve the readability?
```
if (unmount.isError()) {
  ...
  
  // Find the next garbage collected path containing this mount point.
  continue;
} else {
  break;
}
```
Please feel free to drop this if you think this is not necessary.


- Chun-Hung Hsiao


On July 3, 2018, 10:08 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67822/
> ---
> 
> (Updated July 3, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-9049
> https://issues.apache.org/jira/browse/MESOS-9049
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We could potentially schedule the framework dir, executor dir, and
> executor run sandbox to gc at the same time, and then these
> paths will be gc independently, although they are parents and
> children directories. This patch makes sure we do not call unmount
> anymore after a success.
> 
> 
> Diffs
> -
> 
>   src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3 
> 
> 
> Diff: https://reviews.apache.org/r/67822/diff/1/
> 
> 
> Testing
> ---
> 
> ```make```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 67822: Avoid duplicate unmount dangling mount point.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67822/
---

Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Bugs: MESOS-8830
https://issues.apache.org/jira/browse/MESOS-8830


Repository: mesos


Description
---

We could potentially schedule the framework dir, executor dir, and
executor run sandbox to gc at the same time, and then these
paths will be gc independently, although they are parents and
children directories. This patch makes sure we do not call unmount
anymore after a success.


Diffs
-

  src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3 


Diff: https://reviews.apache.org/r/67822/diff/1/


Testing
---

```make```


Thanks,

Zhitao Li

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205695
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67817']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1223 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (603 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5457 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5059 ms)
[--] 24 tests from DockerContainerizerTest (92935 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00BE8DF5BE90.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00BE8DF5C0F0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0278864CBF20.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0278867FAD98.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @027887327170.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817/logs/mesos-tests-stderr.log):

```
I0703 21:55:49.018437  8884 authenticatee.cpp:299] Authentication success
I0703 21:55:49.018437   688 master.cpp:9816] Successfully authenticated 
principal 'test-principal' at 
scheduler-e3a6c593-a96f-4741-bf65-e160e0540822@192.10.1.6:55266
I0703 21:55:49.019436  9540 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:55266
I0703 21:55:49.020438  8884 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-e3a6c593-a96f-4741-bf65-e160e0540822@192.10.1.6:55266
I0703 21:55:49.020438  8884 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 21:55:49.021437   688 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 21:55:49.021437   688 master.cpp:10007] Adding framework 
8bbc2376-5d5f-4728-a1f3-263be02da6ec- (default) at 
scheduler-e3a6c593-a96f-4741-bf65-e160e0540822@192.10.1.6:55266 with roles {  } 
suppressed
I0703 21:55:49.022438  1840 sched.cpp:749] Framework registered with 
8bbc2376-5d5f-4728-a1f3-263be02da6ec-
I0703 21:55:49.023437  4164 hierarchical.cpp:299] Added framework 
8bbc2376-5d5f-4728-a1f3-263be02da6ec-
E0703 21:55:49.118428  9540 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
---

(Updated July 3, 2018, 9:41 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940


Repository: mesos


Description
---

Added per-framework metrics for types of resources contained in offers.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 


Diff: https://reviews.apache.org/r/67235/diff/5/

Changes: https://reviews.apache.org/r/67235/diff/4-5/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67187: Tested per-framework task state metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/
---

(Updated July 3, 2018, 9:40 p.m.)


Review request for mesos, Gastón Kleiman and Gilbert Song.


Bugs: MESOS-8847
https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
---

This patch adds `MasterTest.TaskStateMetrics`, which verifies that
per-framework task state metrics for both terminal and active task
states report correct values, even after agent reregistration.


Diffs (updated)
-

  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 


Diff: https://reviews.apache.org/r/67187/diff/2/

Changes: https://reviews.apache.org/r/67187/diff/1-2/


Testing
---

The new test was run ~10,000 times with no failures.


Thanks,

Greg Mann

Re: Review Request 66874: Added per-framework metrics for active task states.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66874/
---

(Updated July 3, 2018, 9:39 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

Added per-framework metrics for active task states.


Diffs
-

  src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718 
  src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66874/diff/3/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66883: Added/updated tests to check per-framework metrics.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66883/
---

(Updated July 3, 2018, 9:39 p.m.)


Review request for mesos, Benjamin Mahler, Gilbert Song, Greg Mann, and Vinod 
Kone.


Summary (updated)
-

Added/updated tests to check per-framework metrics.


Repository: mesos


Description (updated)
---

Added/updated tests to check per-framework metrics.


Diffs (updated)
-

  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 


Diff: https://reviews.apache.org/r/66883/diff/2/

Changes: https://reviews.apache.org/r/66883/diff/1-2/


Testing
---


Thanks,

Gastón Kleiman

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66870/
---

(Updated July 3, 2018, 9:38 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

Added per-framework metrics for suppressed roles.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66870/diff/3/

Changes: https://reviews.apache.org/r/66870/diff/2-3/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66856/
---

(Updated July 3, 2018, 9:35 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This ensures that per-framework metrics which are tracked in the
allocator will be retained as long as the per-framework metrics
which are tracked in the master.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
c19ab64ff1422a68cfb6eecea7e2cc4132da8dcc 
  src/master/allocator/mesos/allocator.hpp 
900c8ee405da6e44532dee598edaa42373ebd4e5 
  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/allocator.hpp 73fc06043746a0498d0dd1846fae9433db136d49 
  src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
  src/tests/master_allocator_tests.cpp 824a7554858fb8356751f34699607505bd98 
  src/tests/master_quota_tests.cpp d836482f5593b462ad235620741148678ac2651d 
  src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 
  src/tests/resource_offers_tests.cpp 6e24cddce65e7f5a0ce8ea4fde8397a19236d8b8 
  src/tests/slave_recovery_tests.cpp e8333402d8524a4bf302872d246fe5f5c006bdc5 


Diff: https://reviews.apache.org/r/66856/diff/4/

Changes: https://reviews.apache.org/r/66856/diff/3-4/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
---

(Updated July 3, 2018, 9:33 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.

This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66861/diff/4/

Changes: https://reviews.apache.org/r/66861/diff/3-4/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/
---

(Updated July 3, 2018, 9:31 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Bugs: MESOS-8849
https://issues.apache.org/jira/browse/MESOS-8849


Repository: mesos


Description
---

These metrics count the number of times that the allocator has
filtered resources out of this framework's offer stream,
with separate metrics for different types of filtering.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66844/diff/7/

Changes: https://reviews.apache.org/r/66844/diff/6-7/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66855: Changed the 'capacity_' member of 'BoundedHashMap' to non-const.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66855/
---

(Updated July 3, 2018, 9:32 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This prevents the assignment operator from being implicitly deleted.


Diffs (updated)
-

  3rdparty/stout/include/stout/boundedhashmap.hpp 
09a9b96f0b4a58c718777aa81a11c6ca4fdb6f8c 


Diff: https://reviews.apache.org/r/66855/diff/3/

Changes: https://reviews.apache.org/r/66855/diff/2-3/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67821/
---

Review request for mesos, Benjamin Mahler and James Peach.


Repository: mesos


Description
---

Added override specifiers to XfsDiskIsolatorProcess methods.


Diffs
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
9a5ca8bd60c61d65beed611a02dd26ed6a0a594b 


Diff: https://reviews.apache.org/r/67821/diff/1/


Testing
---

Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`.


Thanks,

Ilya Pronin

Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/
---

Review request for mesos, Benjamin Mahler and James Peach.


Repository: mesos


Description
---

Change r/67312 replaced std::list with std::vector in several places
including the Isolator interface. However XfsDiskIsolatorProcess was not
updated and because of that its recover() method became "disabled".


Diffs
-

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
9a5ca8bd60c61d65beed611a02dd26ed6a0a594b 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
362996b804be59dff631566d4c9db2d94233e0c9 


Diff: https://reviews.apache.org/r/67820/diff/1/


Testing
---

Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. 
`ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the 
issue, passed.


Thanks,

Ilya Pronin

Re: Review Request 67147: Included a missing header in the master metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67147/
---

(Updated July 3, 2018, 9:30 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.


Bugs: MESOS-8849
https://issues.apache.org/jira/browse/MESOS-8849


Repository: mesos


Description
---

Included a missing header in the master metrics.


Diffs (updated)
-

  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67147/diff/2/

Changes: https://reviews.apache.org/r/67147/diff/1-2/


Testing
---

The subsequent patch in this chain exposes this missing header, since it 
includes 'src/master/metrics.hpp' in the allocator metrics code, in a 
compilation unit in which the scheduler header is not included.


Thanks,

Greg Mann

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/
---

(Updated July 3, 2018, 9:29 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This struct will hold per-framework metrics tracked
by the allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66843/diff/8/

Changes: https://reviews.apache.org/r/66843/diff/7-8/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66842: Added per-framework metrics for offer filter durations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
---

(Updated July 3, 2018, 9:29 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Summary (updated)
-

Added per-framework metrics for offer filter durations.


Repository: mesos


Description
---

These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66842/diff/7/

Changes: https://reviews.apache.org/r/66842/diff/6-7/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66841: Added a hash function for 'Duration'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66841/
---

(Updated July 3, 2018, 9:28 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

Added a hash function for 'Duration'.


Diffs (updated)
-

  3rdparty/stout/include/stout/duration.hpp 
42c43cda21c75fc3bef962af67c4a09df68a95af 


Diff: https://reviews.apache.org/r/66841/diff/5/

Changes: https://reviews.apache.org/r/66841/diff/4-5/


Testing
---


Thanks,

Greg Mann

Review Request 67814: Added per-framework metrics for offer operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67814/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8845
https://issues.apache.org/jira/browse/MESOS-8845


Repository: mesos


Description
---

Added per-framework metrics for offer operations.


Diffs
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67814/diff/1/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Review Request 67813: Added per-framework metrics for task states.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67813/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8847
https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
---

Added per-framework metrics for task states.


Diffs
-

  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67813/diff/1/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205692
---


Ship it!




Ship It!

- Greg Mann


On July 3, 2018, 7:30 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> ---
> 
> (Updated July 3, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 
> 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/2/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67812: Added per-framework offer metrics.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205691
---



Patch looks great!

Reviews applied: [66882, 66819, 66820, 67808, 67809, 67812]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 12:08 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> ---
> 
> (Updated July 3, 2018, 12:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
> Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per-framework offer metrics.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67812/diff/1/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/
---

(Updated July 3, 2018, 1:56 p.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.


Changes
---

Addressed feedback.


Repository: mesos


Description
---

Log offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.

Also log at `VLOG(2)` level which resources are offered.

NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
setting the following env variable when starting the master:
`GLOG_vmodule=master=2`.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 


Diff: https://reviews.apache.org/r/67817/diff/2/

Changes: https://reviews.apache.org/r/67817/diff/1-2/


Testing
---

Manual testing =).


Thanks,

Gastón Kleiman

Re: Review Request 67812: Added per-framework offer metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205690
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (598 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1329 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (797 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (601 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5369 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5168 ms)
[--] 24 tests from DockerContainerizerTest (94967 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00D30C8FBDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00D30C8FC010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @022D6C6654C8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @022D6DBACA60.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @022D6DF8FF80.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67812/logs/mesos-tests-stderr.log):

```
I0703 20:54:33.616942  7660 authenticatee.cpp:299] Authentication success
I0703 20:54:33.617961  5816 master.cpp:9819] Successfully authenticated 
principal 'test-principal' at 
scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064
I0703 20:54:33.617961  3468 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.5:52064
I0703 20:54:33.619947  2272 master.cpp:2940] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064
I0703 20:54:33.619947  2272 master.cpp:2241] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 20:54:33.620942  5732 master.cpp:3021] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 20:54:33.629948  5732 master.cpp:10010] Adding framework 
806e0214-fd2c-461f-bf62-ae7ee5f5ebb0- (default) at 
scheduler-51de20af-9b86-4a1f-92b1-c69446293941@192.10.1.5:52064 with roles {  } 
suppressed
I0703 20:54:33.630949  5816 sched.cpp:749] Framework registered with 
806e0214-fd2c-461f-bf62-ae7ee5f5ebb0-
I0703 20:54:33.631938  4116 hierarchical.cpp:299] Added framework 
806e0214-fd2c-461f-bf62-ae7ee5f5ebb0-
E0703 20:54:33.708940  4116 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205689
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67817']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (600 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1221 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1004 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5259 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4853 ms)
[--] 24 tests from DockerContainerizerTest (91298 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00ABE7B3B870.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00ABE7B3BAD0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0227A82CFF40.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0227A8AC09B0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0227A8D39B28.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67817/logs/mesos-tests-stderr.log):

```
I0703 20:50:21.466701  9152 authenticatee.cpp:299] Authentication success
I0703 20:50:21.466701  8332 master.cpp:9816] Successfully authenticated 
principal 'test-principal' at 
scheduler-bb414125-29b9-4549-8cb0-10f5f602e64f@192.10.1.6:54213
I0703 20:50:21.467741  8372 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:54213
I0703 20:50:21.468708  9152 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-bb414125-29b9-4549-8cb0-10f5f602e64f@192.10.1.6:54213
I0703 20:50:21.468708  9152 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 20:50:21.469713  8332 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 20:50:21.469713  8332 master.cpp:10007] Adding framework 
7e549775-1613-4460-8e5b-2cc2f9685bd9- (default) at 
scheduler-bb414125-29b9-4549-8cb0-10f5f602e64f@192.10.1.6:54213 with roles {  } 
suppressed
E0703 20:50:21.470713  5608 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as an internal or external command,

operable program or batch file.

'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` 

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205688
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67791']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (1314 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1322 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (799 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (903 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5365 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5061 ms)
[--] 24 tests from DockerContainerizerTest (96012 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00AD8ECFB850.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00AD8ECFBAB0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @028392D203B8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @028393653BD0.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0283937FF4A0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stderr.log):

```
I0703 20:46:40.459502  3328 authenticatee.cpp:299] Authentication success
I0703 20:46:40.460461   404 master.cpp:9786] Successfully authenticated 
principal 'test-principal' at 
scheduler-bfb9e46e-983f-4110-8eb6-2bf4232af31a@192.10.1.10:51038
I0703 20:46:40.460461  2688 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.10:51038
I0703 20:46:40.462463   404 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-bfb9e46e-983f-4110-8eb6-2bf4232af31a@192.10.1.10:51038
I0703 20:46:40.462463   404 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 20:46:40.463505  8128 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 20:46:40.463505  8128 master.cpp:9977] Adding framework 
2a447a94-37ea-4d77-ac5f-2469a9b73447- (default) at 
scheduler-bfb9e46e-983f-4110-8eb6-2bf4232af31a@192.10.1.10:51038 with roles {  
} suppressed
I0703 20:46:40.464470  3328 sched.cpp:749] Framework registered with 
2a447a94-37ea-4d77-ac5f-2469a9b73447-
I0703 20:46:40.465461  2416 hierarchical.cpp:299] Added framework 
2a447a94-37ea-4d77-ac5f-2469a9b73447-
E0703 20:46:40.469503   404 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205683
---


Fix it, then Ship it!





src/master/master.cpp
Lines 9573 (patched)


Can we log `*slave` here instead of just slave id? im assuming that pointer 
is still valid here.


- Vinod Kone


On July 3, 2018, 7:16 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67817/
> ---
> 
> (Updated July 3, 2018, 7:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> Also log at `VLOG(2)` level which resources are offered.
> 
> NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
> setting the following env variable when starting the master:
> `GLOG_vmodule=master=2`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67817/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing =).
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67808: Added per-framework metrics for scheduler calls.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67808/#review205682
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66882', '66819', '66820', '67808']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67808

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67808/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1223 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (799 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (903 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5256 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4959 ms)
[--] 24 tests from DockerContainerizerTest (91856 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @000556BDB910.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @000556BDBB70.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CB38D4FD80.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CB3917CC20.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01CB39B5E428.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67808/logs/mesos-tests-stderr.log):

```
I0703 19:55:02.456670  9800 authenticatee.cpp:299] Authentication success
I0703 19:55:02.457677  5660 master.cpp:9815] Successfully authenticated 
principal 'test-principal' at 
scheduler-0d19371f-dc09-41dc-a2d4-6a7bf8303aa6@192.10.1.6:53138
I0703 19:55:02.458675  4568 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:53138
I0703 19:55:02.459671  7000 master.cpp:2940] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-0d19371f-dc09-41dc-a2d4-6a7bf8303aa6@192.10.1.6:53138
I0703 19:55:02.459671  7000 master.cpp:2241] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 19:55:02.460669  8948 master.cpp:3021] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 19:55:02.465670  8948 master.cpp:10006] Adding framework 
f0cb3c3e-3471-4e0b-bbd2-5b96d7e17780- (default) at 
scheduler-0d19371f-dc09-41dc-a2d4-6a7bf8303aa6@192.10.1.6:53138 with roles {  } 
suppressed
I0703 19:55:02.466670  1036 sched.cpp:749] Framework registered with 
f0cb3c3e-3471-4e0b-bbd2-5b96d7e17780-
I0703 19:55:02.466670  5660 hierarchical.cpp:299] Added framework 
f0cb3c3e-3471-4e0b-bbd2-5b96d7e17780-
E0703 19:55:02.558398  5660 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Pro

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/
---

(Updated July 3, 2018, 12:30 p.m.)


Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.


Changes
---

Addressed feedback; pause the clock during the duration of all the modified 
tests.


Bugs: MESOS-8987
https://issues.apache.org/jira/browse/MESOS-8987


Repository: mesos


Description
---

The Mesos master sends a `ShutdownMessage` to an agent if there is an
authentication or an authorization error during agent (re)registration.

Upon receipt of this message, the agent kills alls its tasks and commits
suicide. This means that transient auth errors can lead to whole agents
being killed along with it's tasks.

This patch prevents the master from sending a `ShutdownMessage` in these
cases.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
  src/tests/master_authorization_tests.cpp 
80b9d49ba334b915461ff5d6df6c9f922d7593e3 


Diff: https://reviews.apache.org/r/67791/diff/2/

Changes: https://reviews.apache.org/r/67791/diff/1-2/


Testing
---

`bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gastón Kleiman

Review Request 67817: Improved logging for offers and inverse offers.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/
---

Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.


Repository: mesos


Description
---

Log offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.

Also log at `VLOG(2)` level which resources are offered.

NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
setting the following env variable when starting the master:
`GLOG_vmodule=master=2`.


Diffs
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 


Diff: https://reviews.apache.org/r/67817/diff/1/


Testing
---

Manual testing =).


Thanks,

Gastón Kleiman

Review Request 67812: Added per-framework offer metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848


Repository: mesos


Description
---

Added per-framework offer metrics.


Diffs
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67812/diff/1/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Review Request 67809: Added per-framework metrics for scheduler events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844


Repository: mesos


Description
---

Added per-framework metrics for scheduler events.


Diffs
-

  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67809/diff/1/


Testing
---


Thanks,

Greg Mann

Review Request 67808: Added per-framework metrics for scheduler calls.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67808/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843


Repository: mesos


Description
---

Added per-framework metrics for scheduler calls.


Diffs
-

  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67808/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67722: Fixed unproperly guarded future.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205680
---



Patch looks great!

Reviews applied: [67722]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 10:17 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> ---
> 
> (Updated July 3, 2018, 10:17 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture::get()` on a future which is failed.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/2/
> 
> 
> Testing
> ---
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

[Meng Zhu]

> On July 2, 2018, 3:42 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1756 (original), 1755 (patched)
> > 
> >
> > How about a member function of the framework struct?
> > 
> > ```
> > if (!framework.isCapableOnAgent(slave)) {
> >   ...
> > }
> > ```

That would need to move nested Slave class forward or outside. Currently, all 
the helper functions for slave/framework are member functions of the outer 
class. I was trying to be consistent. If you think it is necessary, I can go 
ahead and overhaul the structure.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review205647
---


On June 28, 2018, 4 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6/
> ---
> 
> (Updated June 28, 2018, 4 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8916
> https://issues.apache.org/jira/browse/MESOS-8916
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `isFrameworkCapableReceivingAgent` checks if a framework
> is capable of receiving resources on the agent based on
> the framework capability.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
>   src/master/allocator/mesos/hierarchical.cpp 
> cbdfb2ba9c25755ac631557e0e7dbd721f861a4d 
> 
> 
> Diff: https://reviews.apache.org/r/6/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 67722: Fixed unproperly guarded future.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205671
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67722']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1331 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (805 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (908 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (599 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5770 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5283 ms)
[--] 24 tests from DockerContainerizerTest (101357 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0038F44FBDC0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0038F44FC020.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01C5E6C68A20.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01C5E70831B0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01C5E854E918.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/mesos-tests-stderr.log):

```
I0703 15:00:38.963938  2080 authenticatee.cpp:299] Authentication success
I0703 15:00:38.963938  3924 master.cpp:9795] Successfully authenticated 
principal 'test-principal' at 
scheduler-916ef65e-48e8-4773-b789-8ed5098067f6@192.10.1.5:49804
I0703 15:00:38.964939  7152 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.5:49804
I0703 15:00:38.965941  6424 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-916ef65e-48e8-4773-b789-8ed5098067f6@192.10.1.5:49804
I0703 15:00:38.965941  6424 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 15:00:38.966938  3924 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 15:00:38.967943  3924 master.cpp:9996] Adding framework 
43b92ebc-87f8-4359-bf53-cd4e3bf7c6cf- (default) at 
scheduler-916ef65e-48e8-4773-b789-8ed5098067f6@192.10.1.5:49804 with roles {  } 
suppressed
I0703 15:00:38.969936  6424 sched.cpp:749] Framework registered with 
43b92ebc-87f8-4359-bf53-cd4e3bf7c6cf-
I0703 15:00:38.969936  5112 hierarchical.cpp:299] Added framework 
43b92ebc-87f8-4359-bf53-cd4e3bf7c6cf-
E0703 15:00:39.029072  6788 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as 

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
---

(Updated July 3, 2018, 2:40 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Updated error messages.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description
---

This will facilitate the introduction of `PYTHON_3` and
`PYTHON_3_VERSION` to build the CLI in a future commit.


Diffs (updated)
-

  configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 


Diff: https://reviews.apache.org/r/67413/diff/9/

Changes: https://reviews.apache.org/r/67413/diff/8-9/


Testing
---

My machine runs Python 2 when using `python` but `python3` is available. The 
result of `configure` was:

`../configure` works.
`PYTHON_VERSION=3 ../configure` returns `configure: error: Mesos requires 
Python < 3.0`.
`PYTHON=python3 ../configure` returns `configure: error: Mesos requires Python 
< 3.0`.
`PYTHON=python3 ../configure --disable-python` works.
`PYTHON=python3 ../configure --disable-python --enable-new-cli` returns 
`configure: error: Mesos requires Python < 3.0`.


Thanks,

Armand Grillet

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
---

(Updated July 3, 2018, 2:32 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Updated review request to not use `PYTHON_3` and `PYTHON_3_VERSION` yet.


Summary (updated)
-

Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
---

This will facilitate the introduction of `PYTHON_3` and
`PYTHON_3_VERSION` to build the CLI in a future commit.


Diffs (updated)
-

  configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 


Diff: https://reviews.apache.org/r/67413/diff/8/

Changes: https://reviews.apache.org/r/67413/diff/7-8/


Testing
---

I added two lines after the new code:

```
AC_MSG_NOTICE([$PYTHON])
AC_MSG_NOTICE([$PYTHON_3])
```

My machine runs Python 2 when using `python` but `python3` is available. The 
result of `configure` was:
```
configure: /usr/bin/python
configure: python3
```


Thanks,

Armand Grillet

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205665
---




src/tests/authentication_tests.cpp
Line 82 (original), 82 (patched)


s/shutdown/shut down/



src/tests/master_authorization_tests.cpp
Line 2394 (original), 2394 (patched)


s/but not shut down/and is not shut down/



src/tests/master_authorization_tests.cpp
Line 2409 (original), 2409 (patched)


Maybe leave a comment here explaining to future readers why this is here?

"Previously, agents were shut down when registration failed due to 
authorization. We verify that this no longer occurs."

Here and elsewhere.



src/tests/master_authorization_tests.cpp
Line 2416 (original), 2421-2427 (patched)


I think that this block is correct, but it doesn't read very intuitively to 
me. Since the clock is resumed and then we await the registration message, it's 
not immediately obvious that we're verifying anything about what happens 
_after_ the registration message is sent.

I would recommend either pausing the entire test (which makes it clear that 
the previous `settle()` has caused all work related to the registration message 
to occur already), or perhaps placing the `AWAIT_READY(registerSlaveMessage)` 
inside the paused block?

WDYT?

Here and elsewhere.


- Greg Mann


On July 2, 2018, 5:04 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> ---
> 
> (Updated July 2, 2018, 5:04 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 
> 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67722: Fixed unproperly guarded future.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/
---

(Updated July 3, 2018, 12:17 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.


Repository: mesos


Description
---

This patch fixes a bug where the code path could cause a crash because
of calling `Fture::get()` on a future which is failed.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 


Diff: https://reviews.apache.org/r/67722/diff/2/

Changes: https://reviews.apache.org/r/67722/diff/1-2/


Testing
---

```sh
make check
```


Thanks,

Alexander Rojas

Re: Review Request 67722: Fixed unproperly guarded future.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205662
---




src/master/master.cpp
Lines 9667-9672 (patched)


Honestly, I'm not even sure there should be a warning there unless there is 
an error now that I think about it.

If a framework is refused authentication because of invalid credentials, 
that is just normal behavior and should be logged as info.


- Alexander Rojas


On June 25, 2018, 7:56 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> ---
> 
> (Updated June 25, 2018, 7:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture::get()` on a future which is failed.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/1/
> 
> 
> Testing
> ---
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 67795: Moved `CheckInfo` validation to common code.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67795/#review205659
---


Ship it!




Ship It!

- Alexander Rukletsov


On July 3, 2018, 6:32 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67795/
> ---
> 
> (Updated July 3, 2018, 6:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9043
> https://issues.apache.org/jira/browse/MESOS-9043
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master validation uses `validation::checkStatus` and
> `validation::checkStatusInfo`, so move them to the common
> validation library so that the master doesn't have a
> dependency on the checker library.
> 
> 
> Diffs
> -
> 
>   src/checks/checker.hpp 07507a5265613255e778a869094b68a228237f21 
>   src/checks/checker.cpp 6d01349f5a6b7df90c20c2014ad850f312e98593 
>   src/common/validation.hpp 3f60d7ac084b5341e4f33737bff931e3c3daf404 
>   src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 
>   src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
>   src/slave/validation.cpp 7b4c15a13402665c566236b86326ea324c2e4349 
>   src/tests/check_tests.cpp 73ea5a9e26e58f33d24a1594bbdab7ccceb0ce0f 
> 
> 
> Diff: https://reviews.apache.org/r/67795/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67794: Moved `validation::healthCheck` to common code.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67794/#review205658
---


Ship it!




Ship It!

- Alexander Rukletsov


On July 3, 2018, 6:32 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67794/
> ---
> 
> (Updated July 3, 2018, 6:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9043
> https://issues.apache.org/jira/browse/MESOS-9043
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master validation uses `validation::healthCheck`, so move
> it to common validation library so that the master doesn't have
> a dependency on the checker library.
> 
> 
> Diffs
> -
> 
>   src/checks/health_checker.hpp b3f508edf3ac8f6125a7bfe58ec9657c290ab258 
>   src/checks/health_checker.cpp 497549540ea90826e6d266024af2b76e7bade8e4 
>   src/common/validation.hpp 3f60d7ac084b5341e4f33737bff931e3c3daf404 
>   src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 
>   src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
>   src/tests/health_check_tests.cpp 8c7100ff53e44be511af9618899bd662bd547376 
> 
> 
> Diff: https://reviews.apache.org/r/67794/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>