Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.
> On Aug. 10, 2018, 7:41 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos binaries failed to build. > > > > Reviews applied: `['67931', '67930', '67984', '67932']` > > > > Failed command: `cmake.exe --build . --config Release -- /maxcpucount` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2135/mesos-review-67932 Seems like a dependency problem. All the tests built and ran and passed. But the "binaries" target(?) failed with: ``` CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 503 first byte timeout [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 503 first byte timeout [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 503 first byte timeout [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 503 first byte timeout [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 502 Bad Gateway [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/wclayer.exe' failed [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] CUSTOMBUILD : The requested URL returned error : 502 Bad Gateway [D:\DCOS\mesos\3rdparty\wclayer-WIP.vcxproj] ``` - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207103 --- On Aug. 6, 2018, 11:46 a.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > --- > > (Updated Aug. 6, 2018, 11:46 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, > Jie Yu, Joseph Wu, and Qian Zhang. > > > Repository: mesos > > > Description > --- > > The `tar` command cannot work successfully on Windows, so we use > `wclayer` instead. Note that the folder generated from extraction also > cannot be deleted by `rmdir`, so the GC is also changed to use > `wclayer remove`. > > > Diffs > - > > src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc > src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 60507aa1b7951666ed758d1b3800eddd67ba7be6 > > > Diff: https://reviews.apache.org/r/67932/diff/8/ > > > Testing > --- > > > Thanks, > > Liangyu Zhao > >
Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207103 --- FAIL: Mesos binaries failed to build. Reviews applied: `['67931', '67930', '67984', '67932']` Failed command: `cmake.exe --build . --config Release -- /maxcpucount` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2135/mesos-review-67932 - Mesos Reviewbot Windows On Aug. 6, 2018, 11:46 a.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > --- > > (Updated Aug. 6, 2018, 11:46 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, > Jie Yu, Joseph Wu, and Qian Zhang. > > > Repository: mesos > > > Description > --- > > The `tar` command cannot work successfully on Windows, so we use > `wclayer` instead. Note that the folder generated from extraction also > cannot be deleted by `rmdir`, so the GC is also changed to use > `wclayer remove`. > > > Diffs > - > > src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc > src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 60507aa1b7951666ed758d1b3800eddd67ba7be6 > > > Diff: https://reviews.apache.org/r/67932/diff/8/ > > > Testing > --- > > > Thanks, > > Liangyu Zhao > >
Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207101 --- PASS: Mesos patch 68304 was successfully built and tested. Reviews applied: `['68304']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2134/mesos-review-68304 - Mesos Reviewbot Windows On Aug. 10, 2018, 4:41 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68304/ > --- > > (Updated Aug. 10, 2018, 4:41 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9147 > https://issues.apache.org/jira/browse/MESOS-9147 > > > Repository: mesos > > > Description > --- > > This patch fixed the backoff time calculation > overflow bug described in MESOS-9147. > > This patch also combines the authentication timeout and > authentication retry backoff interval into a single > wait time interval. > > > Diffs > - > > src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 > src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c > src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 > > > Diff: https://reviews.apache.org/r/68304/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/#review207099 --- PASS: Mesos patch 68303 was successfully built and tested. Reviews applied: `['68303']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2133/mesos-review-68303 - Mesos Reviewbot Windows On Aug. 10, 2018, 10:17 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68303/ > --- > > (Updated Aug. 10, 2018, 10:17 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-9149 > https://issues.apache.org/jira/browse/MESOS-9149 > > > Repository: mesos > > > Description > --- > > Fixed gRPC compilation for non-SSL build. > > > Diffs > - > > 3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc > 3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 > > > Diff: https://reviews.apache.org/r/68303/diff/1/ > > > Testing > --- > > `make check` on a fresh Ubuntu 16.04 box. > > > Thanks, > > Chun-Hung Hsiao > >
Review Request 68304: Fixed a bug in the agent authentication retry logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9147 https://issues.apache.org/jira/browse/MESOS-9147 Repository: mesos Description --- This patch fixed the backoff time calculation overflow bug described in MESOS-9147. This patch also combines the authentication timeout and authentication retry backoff interval into a single wait time interval. Diffs - src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 Diff: https://reviews.apache.org/r/68304/diff/1/ Testing --- make check Thanks, Meng Zhu
Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/#review207098 --- Ship it! Tested with `libssl-dev` uninstalled; repro'ed without, built with. Thanks! - Andrew Schwartzmeyer On Aug. 10, 2018, 3:17 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68303/ > --- > > (Updated Aug. 10, 2018, 3:17 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-9149 > https://issues.apache.org/jira/browse/MESOS-9149 > > > Repository: mesos > > > Description > --- > > Fixed gRPC compilation for non-SSL build. > > > Diffs > - > > 3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc > 3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 > > > Diff: https://reviews.apache.org/r/68303/diff/1/ > > > Testing > --- > > `make check` on a fresh Ubuntu 16.04 box. > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 68301: WIP: Tests with `default:id`. Not for merging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/#review207095 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68297', '68301']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2132/mesos-review-68301 - Mesos Reviewbot Windows On Aug. 10, 2018, 8:51 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68301/ > --- > > (Updated Aug. 10, 2018, 8:51 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > WIP: Tests with `default:id`. Not for merging. > > > Diffs > - > > src/tests/master_validation_tests.cpp > ec4fd13724a44a86ad655fb2a8affbb9f476834f > src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 > src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 > > > Diff: https://reviews.apache.org/r/68301/diff/1/ > > > Testing > --- > > This should have _almost_ all the tests pass, except for: > > ``` > [ FAILED ] 9 tests, listed below: > [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where > GetParam() = "mesos" > [ FAILED ] > MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where > GetParam() = "mesos" > [ FAILED ] > MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where > GetParam() = "mesos" > [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, > where GetParam() = "mesos" > [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where > GetParam() = "mesos" > [ FAILED ] > ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, > where GetParam() = "docker,mesos" > [ FAILED ] > ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, > where GetParam() = "docker,mesos" > [ FAILED ] > ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, > where GetParam() = "docker,mesos" > [ FAILED ] > ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, > where GetParam() = "docker,mesos" > ``` > > Due to long-path issues with `SetCurrentDirectory` that cannot be worked > around except via regedit + manifest. > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 68303: Fixed gRPC compilation for non-SSL build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-9149 https://issues.apache.org/jira/browse/MESOS-9149 Repository: mesos Description --- Fixed gRPC compilation for non-SSL build. Diffs - 3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc 3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 Diff: https://reviews.apache.org/r/68303/diff/1/ Testing --- `make check` on a fresh Ubuntu 16.04 box. Thanks, Chun-Hung Hsiao
Re: Review Request 68054: Added networking statistics to cni isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207092 --- PASS: Mesos patch 68054 was successfully built and tested. Reviews applied: `['68052', '68053', '68054']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2131/mesos-review-68054 - Mesos Reviewbot Windows On Aug. 10, 2018, 7:08 p.m., Sergey Urbanovich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68054/ > --- > > (Updated Aug. 10, 2018, 7:08 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5647 > https://issues.apache.org/jira/browse/MESOS-5647 > > > Repository: mesos > > > Description > --- > > On receiving a request for getting `usage` for a given container > the `network/cni` isolator uses getifaddrs(3) glibc function. The > function returns basic networking metrics for each networking > interface in the container networking namespace. It should work > right out of the box on all modern Linux-based systems. > > To get more networking metrics please use Netlink Protocol Library. > However, you will have to open NETLINK sockets in each networking > namespace and manage them from the `network/cni` isolator. > > JIRA: https://issues.apache.org/jira/browse/MESOS-5647 > > > Diffs > - > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 31ec4ddb1049b7259b0784e5e40b002e29f6a8da > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f46c962d8f044092aaa113fafc536c6b25bab45c > src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe > src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 > src/tests/containerizer/cni_isolator_tests.cpp > cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a > > > Diff: https://reviews.apache.org/r/68054/diff/5/ > > > Testing > --- > > bin/mesos-tests.sh --verbose > --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Sergey Urbanovich > >
Review Request 68301: WIP: Tests with `default:id`. Not for merging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Repository: mesos Description --- WIP: Tests with `default:id`. Not for merging. Diffs - src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 Diff: https://reviews.apache.org/r/68301/diff/1/ Testing --- This should have _almost_ all the tests pass, except for: ``` [ FAILED ] 9 tests, listed below: [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer
Re: Review Request 68300: Added `gpus` to failure message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/#review207089 --- PASS: Mesos patch 68300 was successfully built and tested. Reviews applied: `['68300']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2129/mesos-review-68300 - Mesos Reviewbot Windows On Aug. 10, 2018, 11:11 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68300/ > --- > > (Updated Aug. 10, 2018, 11:11 a.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Repository: mesos > > > Description > --- > > This message would be propagated all the way to scheduler, so making it > explicit that this is related to gpu can speed up debugging. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > c288ad634b856702483b9751f41445308babd0c9 > > > Diff: https://reviews.apache.org/r/68300/diff/1/ > > > Testing > --- > > > Thanks, > > Zhitao Li > >
Re: Review Request 68054: Added networking statistics to cni isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 10, 2018, 7:08 p.m.) Review request for mesos, Jie Yu and Qian Zhang. Changes --- Added veth CNI plugin. Bugs: MESOS-5647 https://issues.apache.org/jira/browse/MESOS-5647 Repository: mesos Description --- On receiving a request for getting `usage` for a given container the `network/cni` isolator uses getifaddrs(3) glibc function. The function returns basic networking metrics for each networking interface in the container networking namespace. It should work right out of the box on all modern Linux-based systems. To get more networking metrics please use Netlink Protocol Library. However, you will have to open NETLINK sockets in each networking namespace and manage them from the `network/cni` isolator. JIRA: https://issues.apache.org/jira/browse/MESOS-5647 Diffs (updated) - src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 31ec4ddb1049b7259b0784e5e40b002e29f6a8da src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 src/tests/containerizer/cni_isolator_tests.cpp cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a Diff: https://reviews.apache.org/r/68054/diff/5/ Changes: https://reviews.apache.org/r/68054/diff/4-5/ Testing --- bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" --gtest_break_on_failure --gtest_repeat=100 Thanks, Sergey Urbanovich
Re: Review Request 68299: Documented new `--cgroups_destroy_timeout` agent option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68299/#review207085 --- FAIL: Failed to apply the dependent review: 68088. Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68088` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2130/mesos-review-68299 - Mesos Reviewbot Windows On Aug. 10, 2018, 10:37 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68299/ > --- > > (Updated Aug. 10, 2018, 10:37 a.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Repository: mesos > > > Description > --- > > Documented new `--cgroups_destroy_timeout` agent option. > > > Diffs > - > > docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 > > > Diff: https://reviews.apache.org/r/68299/diff/1/ > > > Testing > --- > > > Thanks, > > Zhitao Li > >
Re: Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68297/#review207084 --- PASS: Mesos patch 68297 was successfully built and tested. Reviews applied: `['68297']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2128/mesos-review-68297 - Mesos Reviewbot Windows On Aug. 10, 2018, 5:26 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68297/ > --- > > (Updated Aug. 10, 2018, 5:26 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. > > > Bugs: MESOS-9109 > https://issues.apache.org/jira/browse/MESOS-9109 > > > Repository: mesos > > > Description > --- > > Per MESOS-9109, some frameworks, such as Chronos, use a `:` in their > `executorId`, but this is a reserved character on Windows, and when > its use as part of the path on disk results in an OS error. > Unfortunately, we need to remain backward-compatible with existing > frameworks, so now we escape `:` as `_COLON_` when writing to disk, > and unescape it when parsing. > > Note that we explicitly do not escape to `%3A` (the ASCII equivalent), > because otherwise it is impossible to query for the file over HTTP, as > libprocess helpfully (but not in this case) pre-emptively decodes it > to `:` and so queries for the incorrect path. > > > Diffs > - > > src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 > src/tests/paths_tests.cpp 4808402f789ebc783b308c03b8e412ba22bf9f5d > > > Diff: https://reviews.apache.org/r/68297/diff/1/ > > > Testing > --- > > ``` > [--] Global test environment tear-down > [==] 1008 tests from 98 test cases ran. (446260 ms total) > [ PASSED ] 1008 tests. > ``` > > Note that this is without changing the used-everywhere default executor ID of > `default` to `default:id`, which I also tested, but required changes of > asserts (and caused long path issues only solvable by changing the machine's > registry, so I'd rather not include it). > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 68300: Added `gpus` to failure message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/#review207083 --- Ship it! Ship It! - Gilbert Song On Aug. 10, 2018, 11:11 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68300/ > --- > > (Updated Aug. 10, 2018, 11:11 a.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Repository: mesos > > > Description > --- > > This message would be propagated all the way to scheduler, so making it > explicit that this is related to gpu can speed up debugging. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > c288ad634b856702483b9751f41445308babd0c9 > > > Diff: https://reviews.apache.org/r/68300/diff/1/ > > > Testing > --- > > > Thanks, > > Zhitao Li > >
Review Request 68296: WIP: Add 'handler' field to batched state requests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository: mesos Description --- Add 'handler' field to batched state requests. A WIP follow-up commit is https://github.com/lava/mesos/commit/ed245f5cf3ccbc01a5d179c3285ee2a17791ef78 ; I'm currently not able to push it to reviewboard due to a Diffs - src/master/http.cpp 3812478afead2eba521e169d4e533c631c23f03d src/master/master.hpp cb9d74cd5edc53894955ff405addbba9b89147c9 src/master/master.cpp 21de9739d2891c96cd036621e3f87a160c1d7c30 Diff: https://reviews.apache.org/r/68296/diff/1/ Testing --- Thanks, Benno Evers
Review Request 68300: Added `gpus` to failure message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/ --- Review request for mesos, Gilbert Song and Jason Lai. Repository: mesos Description --- This message would be propagated all the way to scheduler, so making it explicit that this is related to gpu can speed up debugging. Diffs - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c288ad634b856702483b9751f41445308babd0c9 Diff: https://reviews.apache.org/r/68300/diff/1/ Testing --- Thanks, Zhitao Li
Review Request 68299: Documented new `--cgroups_destroy_timeout` agent option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68299/ --- Review request for mesos, Gilbert Song and Jason Lai. Repository: mesos Description --- Documented new `--cgroups_destroy_timeout` agent option. Diffs - docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 Diff: https://reviews.apache.org/r/68299/diff/1/ Testing --- Thanks, Zhitao Li
Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ --- (Updated Aug. 10, 2018, 10:36 a.m.) Review request for mesos, Gilbert Song, Jason Lai, and James Peach. Bugs: MESOS-8038 https://issues.apache.org/jira/browse/MESOS-8038 Repository: mesos Description (updated) --- The new agent flag can be used to reconfigure how long a container destroy is allowed to take on Mesos containerizer. Diffs (updated) - src/linux/cgroups.hpp 6a6f0e6df208bc0b0a888d132b3befd062755851 src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp e016d6dcff15bf49b003c9f3ca94477ce313f7b6 src/slave/containerizer/mesos/linux_launcher.cpp cd677cc652dc53ea3bf9a715b415c3e5c48c1f89 src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 Diff: https://reviews.apache.org/r/68088/diff/3/ Changes: https://reviews.apache.org/r/68088/diff/2-3/ Testing --- `make` and `./bin/mesos-slave.sh --help` Thanks, Zhitao Li
Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68297/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Bugs: MESOS-9109 https://issues.apache.org/jira/browse/MESOS-9109 Repository: mesos Description --- Per MESOS-9109, some frameworks, such as Chronos, use a `:` in their `executorId`, but this is a reserved character on Windows, and when its use as part of the path on disk results in an OS error. Unfortunately, we need to remain backward-compatible with existing frameworks, so now we escape `:` as `_COLON_` when writing to disk, and unescape it when parsing. Note that we explicitly do not escape to `%3A` (the ASCII equivalent), because otherwise it is impossible to query for the file over HTTP, as libprocess helpfully (but not in this case) pre-emptively decodes it to `:` and so queries for the incorrect path. Diffs - src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 src/tests/paths_tests.cpp 4808402f789ebc783b308c03b8e412ba22bf9f5d Diff: https://reviews.apache.org/r/68297/diff/1/ Testing --- ``` [--] Global test environment tear-down [==] 1008 tests from 98 test cases ran. (446260 ms total) [ PASSED ] 1008 tests. ``` Note that this is without changing the used-everywhere default executor ID of `default` to `default:id`, which I also tested, but required changes of asserts (and caused long path issues only solvable by changing the machine's registry, so I'd rather not include it). Thanks, Andrew Schwartzmeyer
Re: Review Request 68054: Added networking statistics to cni isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207079 --- PASS: Mesos patch 68054 was successfully built and tested. Reviews applied: `['68052', '68053', '68054']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2127/mesos-review-68054 - Mesos Reviewbot Windows On Aug. 10, 2018, 2:39 a.m., Sergey Urbanovich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68054/ > --- > > (Updated Aug. 10, 2018, 2:39 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5647 > https://issues.apache.org/jira/browse/MESOS-5647 > > > Repository: mesos > > > Description > --- > > On receiving a request for getting `usage` for a given container > the `network/cni` isolator uses getifaddrs(3) glibc function. The > function returns basic networking metrics for each networking > interface in the container networking namespace. It should work > right out of the box on all modern Linux-based systems. > > To get more networking metrics please use Netlink Protocol Library. > However, you will have to open NETLINK sockets in each networking > namespace and manage them from the `network/cni` isolator. > > JIRA: https://issues.apache.org/jira/browse/MESOS-5647 > > > Diffs > - > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 31ec4ddb1049b7259b0784e5e40b002e29f6a8da > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f46c962d8f044092aaa113fafc536c6b25bab45c > src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe > src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 > src/tests/containerizer/cni_isolator_tests.cpp > cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a > > > Diff: https://reviews.apache.org/r/68054/diff/4/ > > > Testing > --- > > bin/mesos-tests.sh --verbose > --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Sergey Urbanovich > >
Re: Review Request 68054: Added networking statistics to cni isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207077 --- PASS: Mesos patch 68054 was successfully built and tested. Reviews applied: `['68052', '68053', '68054']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2126/mesos-review-68054 - Mesos Reviewbot Windows On Aug. 10, 2018, 2:39 a.m., Sergey Urbanovich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68054/ > --- > > (Updated Aug. 10, 2018, 2:39 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5647 > https://issues.apache.org/jira/browse/MESOS-5647 > > > Repository: mesos > > > Description > --- > > On receiving a request for getting `usage` for a given container > the `network/cni` isolator uses getifaddrs(3) glibc function. The > function returns basic networking metrics for each networking > interface in the container networking namespace. It should work > right out of the box on all modern Linux-based systems. > > To get more networking metrics please use Netlink Protocol Library. > However, you will have to open NETLINK sockets in each networking > namespace and manage them from the `network/cni` isolator. > > JIRA: https://issues.apache.org/jira/browse/MESOS-5647 > > > Diffs > - > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 31ec4ddb1049b7259b0784e5e40b002e29f6a8da > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f46c962d8f044092aaa113fafc536c6b25bab45c > src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe > src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 > src/tests/containerizer/cni_isolator_tests.cpp > cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a > > > Diff: https://reviews.apache.org/r/68054/diff/4/ > > > Testing > --- > > bin/mesos-tests.sh --verbose > --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Sergey Urbanovich > >
Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68213/#review207058 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2018, 7:11 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68213/ > --- > > (Updated Aug. 7, 2018, 7:11 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-8814 > https://issues.apache.org/jira/browse/MESOS-8814 > > > Repository: mesos > > > Description > --- > > Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`. > > > Diffs > - > > src/tests/containerizer/volume_host_path_isolator_tests.cpp > 3c925bcb2250ea7aea26443c866ac4bfd26d55b9 > > > Diff: https://reviews.apache.org/r/68213/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68212/#review207057 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2018, 7:09 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68212/ > --- > > (Updated Aug. 7, 2018, 7:09 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-8814 > https://issues.apache.org/jira/browse/MESOS-8814 > > > Repository: mesos > > > Description > --- > > Updated `volume/host_path` isolator to honor volume mode. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > 9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a > > > Diff: https://reviews.apache.org/r/68212/diff/2/ > > > Testing > --- > > > Thanks, > > Qian Zhang > >
