Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/
---

(Updated Aug. 30, 2018, 5:09 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.


Changes
---

Fixed test compilation.


Bugs: MESOS-9193
https://issues.apache.org/jira/browse/MESOS-9193


Repository: mesos


Description (updated)
---

Clang 3.5 incorrectly keeps const qualifiers when inferring the return
types of lambdas if their return expressions are const-qualified. This
patch makes the return types explicit to avoid this issue when compiling
SLRP and its tests.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
fc48072aac531bac3cbffc3ba089b8dfa2a2f200 
  src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed 


Diff: https://reviews.apache.org/r/68565/diff/2/

Changes: https://reviews.apache.org/r/68565/diff/1-2/


Testing
---

make check with clang 3.5.


Thanks,

Chun-Hung Hsiao

Review Request 68565: Fixed SLRP compilation with Clang 3.5.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.


Repository: mesos


Description
---

Clang 3.5 incorrectly keeps const qualifiers when inferring the return
types of lambdas if their return expressions are const-qualified. This
patch makes the return types explicit to avoid this issue when compiling
SLRP.


Diffs
-

  src/resource_provider/storage/provider.cpp 
fc48072aac531bac3cbffc3ba089b8dfa2a2f200 


Diff: https://reviews.apache.org/r/68565/diff/1/


Testing
---

make check with clang 3.5.


Thanks,

Chun-Hung Hsiao

Review Request 68564: Disabled the `-Wunknown-warning-option` warnings for Clang 3.5.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68564/
---

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
---

Clang 3.5 does not support `-Wno-inconsisent-missing-override` so we
have to suppress `-Wunknown-warning-option` warnings if `-Werror` is on.


Diffs
-

  configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 


Diff: https://reviews.apache.org/r/68564/diff/1/


Testing
---

make with clang 3.5.


Thanks,

Chun-Hung Hsiao

Re: Review Request 68562: Windows: Add comment about V2S2 Docker image Manifest.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68562/#review208116
---



PASS: Mesos patch 68562 was successfully built and tested.

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2261/mesos-review-68562

- Mesos Reviewbot Windows


On Aug. 29, 2018, 1:50 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68562/
> ---
> 
> (Updated Aug. 29, 2018, 1:50 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Add comment about V2S2 Docker image Manifest.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 656f097be303ed2a44be7da016cfa323da9ae8ea 
> 
> 
> Diff: https://reviews.apache.org/r/68562/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 68562: Windows: Add comment about V2S2 Docker image Manifest.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68562/#review208113
---


Ship it!




Ship It!

- Jie Yu


On Aug. 29, 2018, 8:50 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68562/
> ---
> 
> (Updated Aug. 29, 2018, 8:50 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Add comment about V2S2 Docker image Manifest.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 656f097be303ed2a44be7da016cfa323da9ae8ea 
> 
> 
> Diff: https://reviews.apache.org/r/68562/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Review Request 68562: Windows: Add comment about V2S2 Docker image Manifest.

[Liangyu Zhao via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68562/
---

Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie 
Yu, Joseph Wu, and Qian Zhang.


Repository: mesos


Description
---

Windows: Add comment about V2S2 Docker image Manifest.


Diffs
-

  src/uri/fetchers/docker.cpp 656f097be303ed2a44be7da016cfa323da9ae8ea 


Diff: https://reviews.apache.org/r/68562/diff/1/


Testing
---


Thanks,

Liangyu Zhao

[GitHub] gouravrattihalli commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

gouravrattihalli commented on issue #285: mesos.scheduler and mesos.executor 
seem to cause errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-417097086
 
 
   @tillt I see mesos-executor==1.0.0 on my system but don't see 
mesos.scheduler. Also looks like the egg is not available on 
[pypi](https://pypi.org/project/mesos.scheduler/ ). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tillt edited a comment on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

tillt edited a comment on issue #285: mesos.scheduler and mesos.executor seem 
to cause errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-417087053
 
 
   @gouravrattihalli are you sure you were testing the current master and its 
resulting eggs?
   
   We did split them into two separate eggs `mesos.executor` and 
`mesos.scheduler` a while ago and adapted the examples accordingly. It seems to 
me that you are trying to use older versions of the Mesos python egg together 
with more recent example code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tillt edited a comment on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

tillt edited a comment on issue #285: mesos.scheduler and mesos.executor seem 
to cause errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-417087053
 
 
   @gouravrattihalli are you sure you were testing the current master and its 
resulting eggs?
   
   We did split them into two separate eggs `mesos.executor` and 
`mesos.scheduler` a while ago and adapted the examples accordingly. It seems to 
me that you are trying to use older versions of the Mesos python eggs together 
with more recent example code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tillt commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

tillt commented on issue #285: mesos.scheduler and mesos.executor seem to cause 
errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-417087053
 
 
   @gouravrattihalli are you sure you were testing the current master and its 
resulting eggs?
   
   We did split them into two separate eggs `mesos.executor` and 
`mesos.scheduler` a while ago and adapted the eggs accordingly. It seems to me 
that you are trying to use older versions of the Mesos python eggs together 
with more recent example code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67984/#review208108
---


Ship it!




Ship It!

- Jie Yu


On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67984/
> ---
> 
> (Updated Aug. 6, 2018, 6:46 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added CMake logic to download and "install" `wclayer.exe`.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 8a69685e4713a9c8355a5c3f2f10aedc737f453b 
>   src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c 
> 
> 
> Diff: https://reviews.apache.org/r/67984/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68454/#review208107
---


Ship it!




Ship It!

- Jie Yu


On Aug. 28, 2018, 11:26 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68454/
> ---
> 
> (Updated Aug. 28, 2018, 11:26 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9159
> https://issues.apache.org/jira/browse/MESOS-9159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
> disk when agent is running on Windows. Linux part of the code in
> agent is unchanged. In addition to fetching from DockerHub,
> DockerFetcher now supports fetching from foreign URLs provided in
> V2S2 Docker image manifest.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.hpp 7a6193dd75dc10846f52cb039f6a162cc8805c16 
>   src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 
> 
> 
> Diff: https://reviews.apache.org/r/68454/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 67930: Windows: Enabled `DockerFetcherPluginTest` suite.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67930/#review208106
---


Ship it!




Ship It!

- Jie Yu


On Aug. 25, 2018, 9:57 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67930/
> ---
> 
> (Updated Aug. 25, 2018, 9:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled `Internet` test environment on Windows. Disabled `Internet`
> `HealthCheckTests` on Windows, since they require complete
> development. Modified `DockerFetcherPluginTest` to fetch
> `microsoft/nanoserver` for more extensive test for fetcher on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
>   src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638 
>   src/tests/uri_fetcher_tests.cpp 260ae9c96f78ee5528cbd61983e1d61bda48c23b 
> 
> 
> Diff: https://reviews.apache.org/r/67930/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 67894: Migrated mesos python package to python3.6.

[Eric Chung]

> On Aug. 29, 2018, 3:42 p.m., Kevin Klues wrote:
> > I manually removed the changes in the tox.ini file since they have been 
> > added by armand in an already commited RR.

thanks!


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67894/#review208096
---


On July 12, 2018, 8:09 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67894/
> ---
> 
> (Updated July 12, 2018, 8:09 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrated mesos python package to python3.6.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/exceptions.py 63c7aa632da618d6efb74124d607f5744ca64ce5 
>   src/python/lib/mesos/http.py 073c159dc6916fa5d7349a033db022d7175aef05 
>   src/python/lib/tests/conftest.py d4d6efcc45d1266749c5750c3ab47dd742b927c1 
>   src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b 
>   src/python/lib/tests/test_mesos.py 285a071e3d8ed2b61646264ddccd8bb38df2c0dd 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
> 
> 
> Diff: https://reviews.apache.org/r/67894/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `tox` under `src/python/lib`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68560: Updated the python2 'PyLinter' to only lint python2 based code.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/#review208097
---



PASS: Mesos patch 68560 was successfully built and tested.

Reviews applied: `['68560']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2260/mesos-review-68560

- Mesos Reviewbot Windows


On Aug. 29, 2018, 7:14 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68560/
> ---
> 
> (Updated Aug. 29, 2018, 7:14 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Robin Gögge.
> 
> 
> Bugs: MESOS-8770
> https://issues.apache.org/jira/browse/MESOS-8770
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, this includes no longer linting all code under the
> `src/python` directory.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990 
> 
> 
> Diff: https://reviews.apache.org/r/68560/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 67894: Migrated mesos python package to python3.6.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67894/#review208096
---


Ship it!




I manually removed the changes in the tox.ini file since they have been added 
by armand in an already commited RR.

- Kevin Klues


On Juli 12, 2018, 8:09 vorm., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67894/
> ---
> 
> (Updated Juli 12, 2018, 8:09 vorm.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrated mesos python package to python3.6.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/exceptions.py 63c7aa632da618d6efb74124d607f5744ca64ce5 
>   src/python/lib/mesos/http.py 073c159dc6916fa5d7349a033db022d7175aef05 
>   src/python/lib/tests/conftest.py d4d6efcc45d1266749c5750c3ab47dd742b927c1 
>   src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b 
>   src/python/lib/tests/test_mesos.py 285a071e3d8ed2b61646264ddccd8bb38df2c0dd 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
> 
> 
> Diff: https://reviews.apache.org/r/67894/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `tox` under `src/python/lib`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68560: Updated the python2 'PyLinter' to only lint python2 based code.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/#review208092
---


Ship it!




As we are migrating the Mesos python package to python 3.6 in a later commit, 
the last thing we want to lint when using Python 2 are the Python 2 suppport 
scripts. This patch is thus correct.

- Armand Grillet


On Aug. 29, 2018, 4:14 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68560/
> ---
> 
> (Updated Aug. 29, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Robin Gögge.
> 
> 
> Bugs: MESOS-8770
> https://issues.apache.org/jira/browse/MESOS-8770
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, this includes no longer linting all code under the
> `src/python` directory.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990 
> 
> 
> Diff: https://reviews.apache.org/r/68560/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 68560: Updated the python2 'PyLinter' to only lint python2 based code.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68560/
---

Review request for mesos, Armand Grillet and Robin Gögge.


Bugs: MESOS-8770
https://issues.apache.org/jira/browse/MESOS-8770


Repository: mesos


Description
---

Specifically, this includes no longer linting all code under the
`src/python` directory.


Diffs
-

  support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990 


Diff: https://reviews.apache.org/r/68560/diff/1/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 68535: Updated Python 3 dependencies for 3.7.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/#review208089
---



PASS: Mesos patch 68535 was successfully built and tested.

Reviews applied: `['68535']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2259/mesos-review-68535

- Mesos Reviewbot Windows


On Aug. 29, 2018, 6:48 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68535/
> ---
> 
> (Updated Aug. 29, 2018, 6:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Robin Gögge.
> 
> 
> Bugs: MESOS-9186
> https://issues.apache.org/jira/browse/MESOS-9186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All the dependencies for Python 3 are now set using `==` so that we will
> only need to update them when a new Python version is being released.
> 
> The files `pip-requirements` have been renamed depending on which
> versions of pip should use them, this way we do not end up with
> Python 2 trying to install Python 3 dependencies and vice versa.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/pip-requirements.txt 
> 8645912a63b22878f477e96bfa8bc95abe893f85 
>   src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17 
>   support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3 
>   support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990 
>   support/pip-requirements.txt  
>   support/python3/pip-requirements.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68535/diff/2/
> 
> 
> Testing
> ---
> 
> Used the scripts and saw that the error describe in MESOS-9186 is gone. 
> Multiple packages had issues with Python 3.7 and I have used versions that 
> include fixes for those.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208087
---



PASS: Mesos patch 68538 was successfully built and tested.

Reviews applied: `['68538']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2258/mesos-review-68538

- Mesos Reviewbot Windows


On Aug. 29, 2018, 12:10 p.m., Robin Gögge wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> ---
> 
> (Updated Aug. 29, 2018, 12:10 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
> 
> 
> Diffs
> -
> 
>   support/mesos-build/centos-7.dockerfile 
> 068f946f8410772afd9aa45c6f864e475efe84c9 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 
> 352156fb14d90a4b248bc5d15f1d0127bec00161 
>   support/mesos-build/ubuntu-16.04.dockerfile 
> 503b2e370b9222a0e92b8d5db2b08256df3adef8 
> 
> 
> Diff: https://reviews.apache.org/r/68538/diff/2/
> 
> 
> Testing
> ---
> 
> For each of the docker files I have built the docker image and ran 
> `PYTHON=python3 src/python/cli_new/bootstrap`.
> 
> 
> Thanks,
> 
> Robin Gögge
> 
>

Re: Review Request 68535: Updated Python 3 dependencies for 3.7.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/
---

(Updated Aug. 29, 2018, 12:48 p.m.)


Review request for mesos, Benjamin Bannier and Robin Gögge.


Summary (updated)
-

Updated Python 3 dependencies for 3.7.


Bugs: MESOS-9186
https://issues.apache.org/jira/browse/MESOS-9186


Repository: mesos


Description (updated)
---

All the dependencies for Python 3 are now set using `==` so that we will
only need to update them when a new Python version is being released.

The files `pip-requirements` have been renamed depending on which
versions of pip should use them, this way we do not end up with
Python 2 trying to install Python 3 dependencies and vice versa.


Diffs (updated)
-

  src/python/cli_new/pip-requirements.txt 
8645912a63b22878f477e96bfa8bc95abe893f85 
  src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17 
  support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3 
  support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990 
  support/pip-requirements.txt  
  support/python3/pip-requirements.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/68535/diff/2/

Changes: https://reviews.apache.org/r/68535/diff/1-2/


Testing
---

Used the scripts and saw that the error describe in MESOS-9186 is gone. 
Multiple packages had issues with Python 3.7 and I have used versions that 
include fixes for those.


Thanks,

Armand Grillet

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68232/#review208085
---




src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1033 (patched)


I'd suggest to move this to L1037 (righer after `startRedirect`) and still 
name it `redirectFinished`.



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1710 (patched)


Here we set the `promise` in the `readLoop`'s `onAny` callback, but what if 
`readLoop` fails? Will the failure be hidden in this case?


- Qian Zhang


On Aug. 25, 2018, 6:12 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68232/
> ---
> 
> (Updated Aug. 25, 2018, 6:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> and Qian Zhang.
> 
> 
> Bugs: MESOS-9131
> https://issues.apache.org/jira/browse/MESOS-9131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, when a corresponding nested container terminated, while the
> user was attached to the container's stdin via `ATTACH_CONTAINER_INPUT`
> IOSwitchboard didn't terminate immediately. IOSwitchboard was waiting
> for EOF message from the input HTTP connection. Since the IOSwitchboard
> was stuck, the corresponding nested container was also stuck in
> `DESTROYING` state.
> 
> This patch fixes the aforementioned issue by sending 200 `OK` response
> for `ATTACH_CONTAINER_INPUT` call in the case when io redirect is
> finished while reading from the HTTP input connection is not.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/68232/diff/2/
> 
> 
> Testing
> ---
> 
> 1. internal CI
> 2. sudo make check (Fedora 25)
> 
> This test fixes `LaunchNestedContainerSessionKillTask` test, which can be 
> found in the first patch of this patch chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

[Robin Gögge]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/
---

(Updated Aug. 29, 2018, 10:10 a.m.)


Review request for mesos, Armand Grillet and Kevin Klues.


Summary (updated)
-

Added Python 3.6 and pip to Docker images.


Repository: mesos


Description
---

Following the update of the CLI to Python 3, we embed Python 3.6
(the minimum required Python version) to the docker images used
during continuous integration.


Diffs (updated)
-

  support/mesos-build/centos-7.dockerfile 
068f946f8410772afd9aa45c6f864e475efe84c9 
  support/mesos-build/ubuntu-16.04-arm.dockerfile 
352156fb14d90a4b248bc5d15f1d0127bec00161 
  support/mesos-build/ubuntu-16.04.dockerfile 
503b2e370b9222a0e92b8d5db2b08256df3adef8 


Diff: https://reviews.apache.org/r/68538/diff/2/

Changes: https://reviews.apache.org/r/68538/diff/1-2/


Testing (updated)
---

For each of the docker files I have built the docker image and ran 
`PYTHON=python3 src/python/cli_new/bootstrap`.


Thanks,

Robin Gögge

Re: Review Request 68555: Made checker library retry to remove the previous check container.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68555/#review208084
---



PASS: Mesos patch 68555 was successfully built and tested.

Reviews applied: `['68495', '68555']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2257/mesos-review-68555

- Mesos Reviewbot Windows


On Aug. 29, 2018, 7:22 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68555/
> ---
> 
> (Updated Aug. 29, 2018, 7:22 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, 
> and Gilbert Song.
> 
> 
> Bugs: MESOS-8568
> https://issues.apache.org/jira/browse/MESOS-8568
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously when checker library fails to remove the previous check
> container, it will discard the promise and launch a new check container
> which will cause two problems:
>   1. The discarded promise is used to launch the new check container,
>  that means even the new check container is launched successfully,
>  we still have no chance to process its check result since the
>  promise has already been discarded.
>   2. The previous check container will never get a chance to be removed
>  which is leak, i.e., its runtime directory and sandbox directory
>  will not be removed.
> 
> Now in this patch, when checker library fails to remove the previous
> check container, we make it remove the previous check container again.
> 
> 
> Diffs
> -
> 
>   src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 
> 
> 
> Diff: https://reviews.apache.org/r/68555/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68231/#review208083
---



This patch seems not related to MESOS-9131?


src/tests/api_tests.cpp
Lines 6961 (patched)


I see we have called `GetParam()` at the beginning of this test, why do we 
need to call it here again?



src/tests/api_tests.cpp
Lines 7086 (patched)


Why do we need to count `stderrReceived` here?


- Qian Zhang


On Aug. 25, 2018, 6:12 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68231/
> ---
> 
> (Updated Aug. 25, 2018, 6:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-9131
> https://issues.apache.org/jira/browse/MESOS-9131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that we can call `ATTACH_CONTAINER_INPUT` more
> than once. We send a short message first then we send a long message
> in chunks.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 
> 
> 
> Diff: https://reviews.apache.org/r/68231/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68230: Added `AgentAPITest.LaunchNestedContainerSessionKillTask` test.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68230/#review208081
---



I think this patch should be put in the end of this patch chain since it can 
only succeed after r/68232 is applied.


src/tests/api_tests.cpp
Lines 6585 (patched)


This is a parameterized test, but I do not see you call `GetParam()` to get 
the parameter.



src/tests/api_tests.cpp
Lines 6740 (patched)


Is `taskContainerId` same with the `status.container_id()` that we got from 
status update? If yes, why not just use that one?



src/tests/api_tests.cpp
Lines 6744-6746 (patched)


Can we just do the following instead?
```
containerId.mutable_parent()->CopyFrom(status.container_id());
```



src/tests/api_tests.cpp
Lines 6777 (patched)


Can we do `pkill sleep` instead?


- Qian Zhang


On Aug. 25, 2018, 6:11 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68230/
> ---
> 
> (Updated Aug. 25, 2018, 6:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-9131
> https://issues.apache.org/jira/browse/MESOS-9131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that IOSwitchboard, which holds an open HTTP input
> connection, terminates once IO redirects finish for the corresponding
> nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 
> 
> 
> Diff: https://reviews.apache.org/r/68230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68495: Made command check always waits before removing the nested container.

[Qian Zhang]

> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote:
> > src/checks/checker_process.cpp
> > Lines 878-889 (original), 890-901 (patched)
> > 
> >
> > It looks like we should always call `waitNestedContainer()` after we 
> > said `previousCheckContainerId = checkContainerId;`. For example here.
> > 
> > Maybe it makes sense to call `waitNestedContainer()` right in the 
> > beginning? We can end up calling it twice, but I think it's fine?
> 
> Qian Zhang wrote:
> > Maybe it makes sense to call waitNestedContainer() right in the 
> beginning? We can end up calling it twice, but I think it's fine?
> 
> That means we will call agent API `WAIT_NESTED_CONTAINER` twice for each 
> successful launch of check container, I think that might be a burden for 
> agent in a large scale env. So I'd still prefer to call it only in the places 
> where we have to do it.
> 
> Qian Zhang wrote:
> And for the case (L879:L888, i.e., the connection to agent failed) that 
> you pointed out above, I think when the connection to agent is back (e.g., 
> agent starts up again), the check container will be treated as orphan 
> container and destroyed by agent, and then we will remove it here: 
> https://github.com/apache/mesos/blob/1.6.1/src/checks/checker_process.cpp#L616:L638.
>  However I am going to post another patch to change these codes 
> (https://github.com/apache/mesos/blob/1.6.1/src/checks/checker_process.cpp#L660:L664)
>  to something like:
> ```
>   promise->discard();
> } else {
>   previousCheckContainerId = None();
>   _nestedCommandCheck(promise, cmd, nested);
> }
> ```
> In this way, if we fail to remove the check container (e.g., due to agent 
> has not finished recovery, or the check container is still in `DESTROYING` 
> state), we will try to remove it again.

I posted another patch https://reviews.apache.org/r/68555/ as I mentioned above.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68495/#review207984
---


On Aug. 24, 2018, 5:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68495/
> ---
> 
> (Updated Aug. 24, 2018, 5:54 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, 
> and Gilbert Song.
> 
> 
> Bugs: MESOS-8568
> https://issues.apache.org/jira/browse/MESOS-8568
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made command check always waits before removing the nested container.
> 
> 
> Diffs
> -
> 
>   src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 
> 
> 
> Diff: https://reviews.apache.org/r/68495/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 68555: Made checker library retry to remove the previous check container.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68555/
---

Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, 
and Gilbert Song.


Bugs: MESOS-8568
https://issues.apache.org/jira/browse/MESOS-8568


Repository: mesos


Description
---

Previously when checker library fails to remove the previous check
container, it will discard the promise and launch a new check container
which will cause two problems:
  1. The discarded promise is used to launch the new check container,
 that means even the new check container is launched successfully,
 we still have no chance to process its check result since the
 promise has already been discarded.
  2. The previous check container will never get a chance to be removed
 which is leak, i.e., its runtime directory and sandbox directory
 will not be removed.

Now in this patch, when checker library fails to remove the previous
check container, we make it remove the previous check container again.


Diffs
-

  src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 


Diff: https://reviews.apache.org/r/68555/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang