Re: Review Request 70049: Assured a set USER within RPM build.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/#review213146
---



Patch looks great!

Reviews applied: [70047, 70049]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2019, 2:31 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70049/
> ---
> 
> (Updated Feb. 25, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9605
> https://issues.apache.org/jira/browse/MESOS-9605
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Assured a set USER within RPM build.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/build_rpm.sh 
> 4c5b9617cfcef591b33d11f7f84170c0781d1fa1 
> 
> 
> Diff: https://reviews.apache.org/r/70049/diff/1/
> 
> 
> Testing
> ---
> 
> Installed resulting package and ran agent;
> ```
> [root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
> I0225 02:30:16.11352897 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
> I0225 02:30:16.11360697 main.cpp:351] Version: 1.8.0
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70049: Assured a set USER within RPM build.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/#review213145
---



Patch looks great!

Reviews applied: [70047, 70049]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2019, 2:31 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70049/
> ---
> 
> (Updated Feb. 25, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9605
> https://issues.apache.org/jira/browse/MESOS-9605
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Assured a set USER within RPM build.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/build_rpm.sh 
> 4c5b9617cfcef591b33d11f7f84170c0781d1fa1 
> 
> 
> Diff: https://reviews.apache.org/r/70049/diff/1/
> 
> 
> Testing
> ---
> 
> Installed resulting package and ran agent;
> ```
> [root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
> I0225 02:30:16.11352897 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
> I0225 02:30:16.11360697 main.cpp:351] Version: 1.8.0
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70049: Assured a set USER within RPM build.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/#review213143
---



PASS: Mesos patch 70049 was successfully built and tested.

Reviews applied: `['70047', '70049']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2929/mesos-review-70049

- Mesos Reviewbot Windows


On Feb. 25, 2019, 2:31 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70049/
> ---
> 
> (Updated Feb. 25, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9605
> https://issues.apache.org/jira/browse/MESOS-9605
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Assured a set USER within RPM build.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/build_rpm.sh 
> 4c5b9617cfcef591b33d11f7f84170c0781d1fa1 
> 
> 
> Diff: https://reviews.apache.org/r/70049/diff/1/
> 
> 
> Testing
> ---
> 
> Installed resulting package and ran agent;
> ```
> [root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
> I0225 02:30:16.11352897 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
> I0225 02:30:16.11360697 main.cpp:351] Version: 1.8.0
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70048/#review213142
---



Patch looks great!

Reviews applied: [65811, 68832, 69286, 69287, 70048]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2019, 1:19 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70048/
> ---
> 
> (Updated Feb. 25, 2019, 1:19 a.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the new `--host_path_volume_force_creation` agent option.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md bb0f5d0c5d2f0fd1ecf14de7259ecb1688c2272c 
> 
> 
> Diff: https://reviews.apache.org/r/70048/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70048/#review213141
---



Patch looks great!

Reviews applied: [65811, 68832, 69286, 69287, 70048]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2019, 1:19 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70048/
> ---
> 
> (Updated Feb. 25, 2019, 1:19 a.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the new `--host_path_volume_force_creation` agent option.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md bb0f5d0c5d2f0fd1ecf14de7259ecb1688c2272c 
> 
> 
> Diff: https://reviews.apache.org/r/70048/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69481/#review213133
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 6, 2019, 4:51 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69481/
> ---
> 
> (Updated Jan. 6, 2019, 4:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Deallocated the shared persistent volume's gid when it is removed.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ad3b693a716cf6103345a157bf28dd60a7b07d32 
> 
> 
> Diff: https://reviews.apache.org/r/69481/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review213132
---




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 889 (patched)


we called update in multiple places in slave.cpp, is it true that for PV, 
the update would only be invoked once?

Also, does it hurt if our volumeGidManager invokes allocate a particular 
`path` multiple times?


- Gilbert Song


On Jan. 6, 2019, 4:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Jan. 6, 2019, 4:49 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review213137
---


Ship it!




Ship It!

- Gilbert Song


On Dec. 10, 2018, 10:51 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Dec. 10, 2018, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69579/#review213139
---


Ship it!




Ship It!

- Gilbert Song


On Dec. 18, 2018, 12:25 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69579/
> ---
> 
> (Updated Dec. 18, 2018, 12:25 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c 
> 
> 
> Diff: https://reviews.apache.org/r/69579/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69547/#review213138
---


Ship it!




Ship It!

- Gilbert Song


On Dec. 20, 2018, 4:57 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69547/
> ---
> 
> (Updated Dec. 20, 2018, 4:57 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c 
> 
> 
> Diff: https://reviews.apache.org/r/69547/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69613: Added tests for volume gid manager.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69613/#review213140
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 6, 2019, 5:03 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69613/
> ---
> 
> (Updated Jan. 6, 2019, 5:03 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8767
> https://issues.apache.org/jira/browse/MESOS-8767
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for volume gid manager.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/tests/CMakeLists.txt c588183e9d2b1cc733fdf3df70f37d47a5fdd7c0 
>   src/tests/containerizer/volume_gid_manager_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69613/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68162/#review213136
---


Ship it!




Ship It!

- Gilbert Song


On Dec. 10, 2018, 10:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68162/
> ---
> 
> (Updated Dec. 10, 2018, 10:49 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 84b342cdd4b8ef4803725ecfa9f922687ccdadd8 
> 
> 
> Diff: https://reviews.apache.org/r/68162/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/#review213135
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 6, 2019, 4:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67997/
> ---
> 
> (Updated Jan. 6, 2019, 4:58 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
> cbe677880d6a7dc44697fa5a425b8164dbb4f6e2 
> 
> 
> Diff: https://reviews.apache.org/r/67997/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69676: Implemented recovery for volume gid manager.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69676/#review213134
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 6, 2019, 5:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69676/
> ---
> 
> (Updated Jan. 6, 2019, 5:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-8767
> https://issues.apache.org/jira/browse/MESOS-8767
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented recovery for volume gid manager.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/slave/slave.hpp 2eadf5fce9a314f1ec0ac5d51820c6381f5f1468 
>   src/slave/slave.cpp ad3b693a716cf6103345a157bf28dd60a7b07d32 
>   src/slave/volume_gid_manager/state.hpp PRE-CREATION 
>   src/slave/volume_gid_manager/state.proto PRE-CREATION 
>   src/slave/volume_gid_manager/volume_gid_manager.hpp PRE-CREATION 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69676/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69478/#review213131
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 28, 2019, 11:36 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69478/
> ---
> 
> (Updated Jan. 28, 2019, 11:36 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `task_supplementary_groups` into `ContainerLaunchInfo`.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 7d16463fcce3df14d256f5a4f2deb42c482d0734 
> 
> 
> Diff: https://reviews.apache.org/r/69478/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69345/#review213129
---




src/slave/containerizer/mesos/containerizer.cpp
Lines 2684 (patched)


IIRC, this is because we want to do GID deallocate based on the PARENT 
sandbox_path volume life cycle?

Could you remind me that:
if there are more hierarchies, any sandbox_path volume gid deallocation 
rely on the top level executor container destroy?



src/slave/main.cpp
Lines 641 (patched)


we have been leaking for a while?

:(


- Gilbert Song


On Jan. 28, 2019, 11:34 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69345/
> ---
> 
> (Updated Jan. 28, 2019, 11:34 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If a nested container running as a non-root user tries to use a PARENT
> type SANDBOX_PATH volume, we will make sure the volume owned by a unique
> gid allocated by the volume gid manager and the container process
> launched with that gid as its supplementary group.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 7d16463fcce3df14d256f5a4f2deb42c482d0734 
>   src/local/local.cpp 608706811486e59b9472c026876d1d84cbccc279 
>   src/slave/containerizer/containerizer.hpp 
> 66f73a306deffc51503479420531ea1948c574e1 
>   src/slave/containerizer/containerizer.cpp 
> c6b5e64a72d16b871dcbfc17c05566affea6bd44 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 3102b8755c1fa3b205081d0198c6021c02d15ec6 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 35f51ad33da53b3e6a8eec275fbf3e77782b0fba 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp 
> 1631160236379f84c6e1ed1be1370b5f2f2fd563 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> ecd467c5a33c2f41396bc72ddd7cb806bb8adc52 
>   src/slave/containerizer/mesos/launch.cpp 
> 7f401cdf481123b8c6cc500ac02bb7daf2613d2c 
>   src/slave/main.cpp d1ce45455f2867cb71378da122fbd598aca4546d 
>   src/slave/slave.hpp 2bcd7a93a8f25b77c71c7f931bfaac87649f987c 
>   src/slave/slave.cpp ed92f672f5155d70a36ba3619bb6f06fa09bc836 
>   src/tests/cluster.cpp 61489840fb1491ab56fd9edd5bcbb1c1dca2c0d2 
>   src/tests/mock_slave.hpp 3c0d602a981d76dcf10f9e413851e606d835e113 
>   src/tests/mock_slave.cpp a78ca9c7911bb7928a93be6867abe62e8cd20712 
> 
> 
> Diff: https://reviews.apache.org/r/69345/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70048/#review213130
---



PASS: Mesos patch 70048 was successfully built and tested.

Reviews applied: `['70048']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2928/mesos-review-70048

- Mesos Reviewbot Windows


On Feb. 24, 2019, 5:19 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70048/
> ---
> 
> (Updated Feb. 24, 2019, 5:19 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the new `--host_path_volume_force_creation` agent option.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md bb0f5d0c5d2f0fd1ecf14de7259ecb1688c2272c 
> 
> 
> Diff: https://reviews.apache.org/r/70048/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 70047: Updated build specific artefact generation.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70047/
---

(Updated Feb. 25, 2019, 2:35 a.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9605
https://issues.apache.org/jira/browse/MESOS-9605


Repository: mesos


Description
---

For autotools, we extracted additional build info like the git branch
and sha during the automake phase handing them into libbuild via
commandline defines.

CMake builds however used a configuration file for this purpose.

This patch updates both build systems to make use of
build_config.hpp.in for build specific configuration artefacts.


Diffs
-

  cmake/CompilationConfigure.cmake c330324e2e3dea6e71980ae8c9ed71632ebb018e 
  configure.ac ee29fc784e53ebaf1bb016c33136b200c646ee9b 
  src/Makefile.am 283d5ed89b36d74da36f38c26aec03c6129d6261 
  src/common/build.cpp f5271d87d33ac429fb94093a347be1d6c25d3432 
  src/common/build_config.hpp.in 4cce2403c1d7a5feee8fd2fffa7cf4308507cd0c 


Diff: https://reviews.apache.org/r/70047/diff/1/


Testing (updated)
---

manually tested both cmake and autotools.

WIP: A test using the centos RPM toolchain does not yield the intended result;
```
[root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
I0225 02:30:16.11352897 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
I0225 02:30:16.11360697 main.cpp:351] Version: 1.8.0
I0225 02:30:16.12117397 systemd.cpp:240] systemd version `219` detected
I0225 02:30:16.12119997 main.cpp:453] Initializing systemd state
E0225 02:30:16.12125197 main.cpp:462] EXIT with status 1: Failed to 
initialize systemd: Failed to locate systemd runtime directory: 
/run/systemd/system
```

It still lacks the SHA!


Thanks,

Till Toenshoff

Re: Review Request 70049: Assured a set USER within RPM build.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/
---

(Updated Feb. 25, 2019, 2:31 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-9605
https://issues.apache.org/jira/browse/MESOS-9605


Repository: mesos


Description
---

Assured a set USER within RPM build.


Diffs
-

  support/packaging/centos/build_rpm.sh 
4c5b9617cfcef591b33d11f7f84170c0781d1fa1 


Diff: https://reviews.apache.org/r/70049/diff/1/


Testing (updated)
---

Installed resulting package and ran agent;
```
[root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
I0225 02:30:16.11352897 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
I0225 02:30:16.11360697 main.cpp:351] Version: 1.8.0
```


Thanks,

Till Toenshoff

Re: Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70048/#review213128
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 24, 2019, 5:19 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70048/
> ---
> 
> (Updated Feb. 24, 2019, 5:19 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the new `--host_path_volume_force_creation` agent option.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md bb0f5d0c5d2f0fd1ecf14de7259ecb1688c2272c 
> 
> 
> Diff: https://reviews.apache.org/r/70048/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Review Request 70049: Assured a set USER within RPM build.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-9605
https://issues.apache.org/jira/browse/MESOS-9605


Repository: mesos


Description
---

Assured a set USER within RPM build.


Diffs
-

  support/packaging/centos/build_rpm.sh 
4c5b9617cfcef591b33d11f7f84170c0781d1fa1 


Diff: https://reviews.apache.org/r/70049/diff/1/


Testing
---


Thanks,

Till Toenshoff

Review Request 70047: Updated build specific artefact generation.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70047/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9605
https://issues.apache.org/jira/browse/MESOS-9605


Repository: mesos


Description
---

For autotools, we extracted additional build info like the git branch
and sha during the automake phase handing them into libbuild via
commandline defines.

CMake builds however used a configuration file for this purpose.

This patch updates both build systems to make use of
build_config.hpp.in for build specific configuration artefacts.


Diffs
-

  cmake/CompilationConfigure.cmake c330324e2e3dea6e71980ae8c9ed71632ebb018e 
  configure.ac ee29fc784e53ebaf1bb016c33136b200c646ee9b 
  src/Makefile.am 283d5ed89b36d74da36f38c26aec03c6129d6261 
  src/common/build.cpp f5271d87d33ac429fb94093a347be1d6c25d3432 
  src/common/build_config.hpp.in 4cce2403c1d7a5feee8fd2fffa7cf4308507cd0c 


Diff: https://reviews.apache.org/r/70047/diff/1/


Testing
---

manually tested both cmake and autotools.


Thanks,

Till Toenshoff

Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70048/
---

Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and James Peach.


Bugs: MESOS-9009
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Documented the new `--host_path_volume_force_creation` agent option.


Diffs
-

  docs/configuration/agent.md bb0f5d0c5d2f0fd1ecf14de7259ecb1688c2272c 


Diff: https://reviews.apache.org/r/70048/diff/1/


Testing
---

N/A.


Thanks,

Jason Lai

Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213127
---



PASS: Mesos patch 70045 was successfully built and tested.

Reviews applied: `['70045']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2927/mesos-review-70045

- Mesos Reviewbot Windows


On Feb. 24, 2019, 2:03 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> ---
> 
> (Updated Feb. 24, 2019, 2:03 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
> 
> Incidentally with this patch a previous comment matches now matches
> what is happening.
> 
> 
> Diffs
> -
> 
>   support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73 
> 
> 
> Diff: https://reviews.apache.org/r/70045/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213126
---


Ship it!




Ship It!

- Till Toenshoff


On Feb. 24, 2019, 10:03 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> ---
> 
> (Updated Feb. 24, 2019, 10:03 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
> 
> Incidentally with this patch a previous comment matches now matches
> what is happening.
> 
> 
> Diffs
> -
> 
>   support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73 
> 
> 
> Diff: https://reviews.apache.org/r/70045/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/
---

(Updated Feb. 24, 2019, 11:03 p.m.)


Review request for mesos, Till Toenshoff and Vinod Kone.


Repository: mesos


Description
---

Due to flakes test results reported by reviewbot need manual
verification so we can skip executing tests when validating the
`master` branch. This saves some execution time during validation.

Incidentally with this patch a previous comment matches now matches
what is happening.


Diffs (updated)
-

  support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73 


Diff: https://reviews.apache.org/r/70045/diff/2/

Changes: https://reviews.apache.org/r/70045/diff/1-2/


Testing
---


Thanks,

Benjamin Bannier