Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213719
---



PASS: Mesos patch 70208 was successfully built and tested.

Reviews applied: `['70200', '70208']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2963/mesos-review-70208

- Mesos Reviewbot Windows


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a test to verify that operation reconciliation
> via the v1 scheduler API works correctly when multiple
> operations in different states are reconciled at the same time.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70129: Updated advanced contributing guide.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/#review213717
---



PASS: Mesos patch 70129 was successfully built and tested.

Reviews applied: `['70129']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2961/mesos-review-70129

- Mesos Reviewbot Windows


On March 6, 2019, 6:32 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70129/
> ---
> 
> (Updated March 6, 2019, 6:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the instruction to create a reviewboard account
> from the advanced contributing guide, since this instruction
> became impossible to follow for contributors.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 
> 
> 
> Diff: https://reviews.apache.org/r/70129/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69582: Added a test to verify a bug fix for the master.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213715
---



PASS: Mesos patch 69582 was successfully built and tested.

Reviews applied: `['70147', '69582']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2962/mesos-review-69582

- Mesos Reviewbot Windows


On March 6, 2019, 4:11 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> ---
> 
> (Updated March 6, 2019, 4:11 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and 
> Meng Zhu.
> 
> 
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to verify a bug fix for the master.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
> 
> 
> Diff: https://reviews.apache.org/r/69582/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this test before and after the preceding fix. Before the fix, the test 
> fails reliably. After the fix, the test passes reliably.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70158: WIP.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70158/#review213714
---



PASS: Mesos patch 70158 was successfully built and tested.

Reviews applied: `['70158']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2960/mesos-review-70158

- Mesos Reviewbot Windows


On March 7, 2019, 8:50 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70158/
> ---
> 
> (Updated March 7, 2019, 8:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP.
> 
> 
> Diffs
> -
> 
>   NOTICE aa2fc8b2124bac35eb6e22c7188a8e38ef4d37a2 
> 
> 
> Diff: https://reviews.apache.org/r/70158/diff/1/
> 
> 
> Testing
> ---
> 
> Testing RB webhook trigger.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213712
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70200']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2959/mesos-review-70200

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2959/mesos-review-70200/logs/mesos-tests.log):

```
I0314 02:38:05.019166  7228 exec shutdown framework 
55cee390-4666-4e16-91c5-2d72ce153f11- because it is terminating
I0314 02:38:05.021153  5740 master.cpp:1295] Agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0314 02:38:05.021153  5740 master.cpp:3330] Disconnecting agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0314 02:38:05.022153  5740 master.cpp:3349] Deactivating agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0314 02:38:05.022153  5348 hierarchical.cpp:390] Removed framework 
55cee390-4666-4e16-91c5-2d72ce153f11-
I0314 02:38:05.022153  5348 hierarchical.cpp:827] Agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 deactivated
I0314 02:38:05.024169 13204 containerizer.cpp:2576] Destroying container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 in RUNN[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (691 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (708 ms total)

[--] Global test environment tear-down
[==] 1115 tests from 106 test cases ran. (540795 ms total)
[  PASSED  ] 1114 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

ING state
I0314 02:38:05.024169 13204 containerizer.cpp:3278] Transitioning the state of 
container 0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 from RUNNING to DESTROYING
I0314 02:38:05.024169 13204 launcher.cpp:161] Asked to destroy container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5
W0314 02:38:05.025177 11352 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=3720 to peer '192.10.1.4:57708': IO failed with error 
code: The specified network name is no longer available.

W0314 02:38:05.026144 11352 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2140 to peer '192.10.1.4:57709': IO failed with error 
code: The specified network name is no longer available.

I0314 02:38:05.093176  5348 containerizer.cpp:3117] Container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 has exited
I0314 02:38:05.126160  4404 master.cpp:1135] Master terminating
I0314 02:38:05.127148 11604 hierarchical.cpp:678] Removed agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0
I0314 02:38:05.405552 11352 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70206: Displayed error message on resource validation failures.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213711
---



PASS: Mesos patch 70206 was successfully built and tested.

Reviews applied: `['70206']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2954/mesos-review-70206

- Mesos Reviewbot Windows


On March 13, 2019, 3:54 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> ---
> 
> (Updated March 13, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
> 
> 
> Diffs
> -
> 
>   src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f 
> 
> 
> Diff: https://reviews.apache.org/r/70206/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

(Updated March 14, 2019, 1:41 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs (updated)
-

  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/2/

Changes: https://reviews.apache.org/r/70200/diff/1-2/


Testing
---

`make check`


Thanks,

Greg Mann

Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/
---

Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch adds a test to verify that operation reconciliation
via the v1 scheduler API works correctly when multiple
operations in different states are reconciled at the same time.


Diffs
-

  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 


Diff: https://reviews.apache.org/r/70208/diff/1/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann

Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70203/#review213710
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70061', '70062', '70069', '70063', '70148', '70149', 
'70150', '70151', '70152', '70159', '70160', '70198', '70161', '70202', 
'70203']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2955/mesos-review-70203

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2955/mesos-review-70203/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review213709
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 68508`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2958/mesos-review-68508

Relevant logs:

- 
[apply-review-68508.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2958/mesos-review-68508/logs/apply-review-68508.log):

```
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:109
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Sept. 25, 2018, 1:49 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> ---
> 
> (Updated Sept. 25, 2018, 1:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e09a615979014909e7b88d44e6617fd1476415c5 
>   src/master/allocator/mesos/hierarchical.cpp 
> 906fddc48c52ec222b93d15d53edf9680d2cd861 
> 
> 
> Diff: https://reviews.apache.org/r/68508/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 67044: Renamed a method in the master metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review213707
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 67044`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2956/mesos-review-67044

Relevant logs:

- 
[apply-review-67044.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2956/mesos-review-67044/logs/apply-review-67044.log):

```
error: patch failed: src/master/master.cpp:10908
error: src/master/master.cpp: patch does not apply
error: patch failed: src/master/metrics.hpp:210
error: src/master/metrics.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On May 14, 2018, 5:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> ---
> 
> (Updated May 14, 2018, 5:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed a method in the master metrics.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67044/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66344/#review213708
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66344`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2957/mesos-review-66344

Relevant logs:

- 
[apply-review-66344.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2957/mesos-review-66344/logs/apply-review-66344.log):

```
error: patch failed: src/slave/slave.cpp:4298
error: src/slave/slave.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On March 28, 2018, 9:41 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66344/
> ---
> 
> (Updated March 28, 2018, 9:41 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We use `getResourceConversions` to calculate `conversions`,
> apply that to agent default resources if not on resource provider,
> and send `UpdateOperationStatusMessage` message back to master.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66344/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 70158: WIP.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70158/#review213706
---



PASS: Mesos patch 70158 was successfully built and tested.

Reviews applied: `['70158']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2953/mesos-review-70158

- Mesos Reviewbot Windows


On March 7, 2019, 8:50 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70158/
> ---
> 
> (Updated March 7, 2019, 8:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP.
> 
> 
> Diffs
> -
> 
>   NOTICE aa2fc8b2124bac35eb6e22c7188a8e38ef4d37a2 
> 
> 
> Diff: https://reviews.apache.org/r/70158/diff/1/
> 
> 
> Testing
> ---
> 
> Testing RB webhook trigger.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 69582: Added a test to verify a bug fix for the master.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213705
---



PASS: Mesos patch 69582 was successfully built and tested.

Reviews applied: `['70147', '69582']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2951/mesos-review-69582

- Mesos Reviewbot Windows


On March 7, 2019, 12:11 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> ---
> 
> (Updated March 7, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and 
> Meng Zhu.
> 
> 
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to verify a bug fix for the master.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
> 
> 
> Diff: https://reviews.apache.org/r/69582/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this test before and after the preceding fix. Before the fix, the test 
> fails reliably. After the fix, the test passes reliably.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70129: Updated advanced contributing guide.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/#review213704
---



PASS: Mesos patch 70129 was successfully built and tested.

Reviews applied: `['70129']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2949/mesos-review-70129

- Mesos Reviewbot Windows


On March 6, 2019, 6:32 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70129/
> ---
> 
> (Updated March 6, 2019, 6:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the instruction to create a reviewboard account
> from the advanced contributing guide, since this instruction
> became impossible to follow for contributors.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 
> 
> 
> Diff: https://reviews.apache.org/r/70129/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68916/#review213702
---



FAIL: Failed to apply the dependent review: 68904.

Failed command: `python.exe .\support\apply-reviews.py -n -r 68904`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2952/mesos-review-68916

Relevant logs:

- 
[apply-review-68904.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2952/mesos-review-68916/logs/apply-review-68904.log):

```
error: patch failed: configure.ac:1490
error: configure.ac: patch does not apply
error: patch failed: m4/libevent.m4:18
error: m4/libevent.m4: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 3, 2018, 7:32 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68916/
> ---
> 
> (Updated Oct. 3, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Combines all libevent related header and library checks into
> libevent.m4.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c3e39643924dd4581d46e3d4e1b89b409d823e88 
>   3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
> 
> 
> Diff: https://reviews.apache.org/r/68916/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70165/#review213701
---



PASS: Mesos patch 70165 was successfully built and tested.

Reviews applied: `['70165']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2943/mesos-review-70165

- Mesos Reviewbot Windows


On March 11, 2019, 9:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70165/
> ---
> 
> (Updated March 11, 2019, 9:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9612
> https://issues.apache.org/jira/browse/MESOS-9612
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The resource provider manager didn't allow operations originating from
> operator API calls. For speculatively applied operations, this is
> allowed now.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70165/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 68736: Added `task cat` command to new CLI.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68736/#review213700
---



FAIL: Failed to apply the dependent review: 68711.

Failed command: `python.exe .\support\apply-reviews.py -n -r 68711`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2950/mesos-review-68736

Relevant logs:

- 
[apply-review-68711.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2950/mesos-review-68736/logs/apply-review-68711.log):

```
error: patch failed: src/python/cli_new/lib/cli/mesos.py:22
error: src/python/cli_new/lib/cli/mesos.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:42
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:18
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply
```

- Mesos Reviewbot Windows


On Sept. 17, 2018, 3:46 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68736/
> ---
> 
> (Updated Sept. 17, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `task cat` command to new CLI.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/task.py 
> b54ade557f579a489e459f6022807146e0211fb0 
> 
> 
> Diff: https://reviews.apache.org/r/68736/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_cat (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 6 tests in 13.934s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213699
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70061', '70062', '70069', '70063', '70148', '70149', 
'70150', '70151', '70152', '70201']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2947/mesos-review-70201

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2947/mesos-review-70201/logs/mesos-tests.log):

```
I0313 23:16:16.362215  6332 master.cpp:11596] Removing task 
0ea3b1ed-35e0-4293-961a-30d0ab5ad9fc with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 7ee2d1a3-1972-408f-aeac-0d08b0404979- on 
agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.365253  6332 master.cpp:1295] Agent 
7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0313 23:16:16.365253  6332 master.cpp:3330] Disconnecting agent 
7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.365253  6332 master.cpp:3349] Deactivating agent 
7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.366219 10364 hierarchical.cpp:391] Removed framework 
7ee2d1a3-1972-408f-aeac-0d08b0404979-
I0313 23:16:16.366219 10364 hierarchical.cpp:828] Agent 
7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 deactivated
I0313 23:16:16.366219  7156 containerizer.cpp:2576] Destroying container 
9efd9e6f-c104-48b6-8eca-4bb5fb80c00a in RUNNING state
I0313 23:16:16.366219  7156 containerizer.cpp:3278] Transitioning the state of 
container 9efd9e6f-c104-48b6-8eca-4bb5fb80c00a from RUNNING to DESTROYING
I0313 23:16:16.367223  7156 launcher.cpp:161] Asked to destroy container 
9efd9e6f-c104-48b6-8eca-4bb5fb80c00a
W0313 23:16:16.368203 10476 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=492[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (691 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (710 ms total)

[--] Global test environment tear-down
[==] 1122 tests from 107 test cases ran. (534305 ms total)
[  PASSED  ] 1121 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

4 to peer '192.10.1.4:52280': IO failed with error code: The specified network 
name is no longer available.

W0313 23:16:16.369210 10476 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4688 to peer '192.10.1.4:52281': IO failed with error 
code: The specified network name is no longer available.

I0313 23:16:16.440227  6332 containerizer.cpp:3117] Container 
9efd9e6f-c104-48b6-8eca-4bb5fb80c00a has exited
I0313 23:16:16.469226  9224 master.cpp:1135] Master terminating
I0313 23:16:16.471221 12100 hierarchical.cpp:679] Removed agent 
7ee2d1a3-1972-408f-aeac-0d08b0404979-S0
I0313 23:16:16.801226 10476 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 13, 2019, 2:13 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> ---
> 
> (Updated March 13, 2019, 2:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added tests.
> 
> 
> Diffs
> -
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
>   src/tests/resource_quantities_tests.cpp 
> 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70201/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66881: Added benchmark test for master metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66881/#review213698
---



FAIL: Failed to apply the dependent review: 66845.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66845`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2948/mesos-review-66881

Relevant logs:

- 
[apply-review-66845.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2948/mesos-review-66881/logs/apply-review-66845.log):

```
error: patch failed: src/master/master.hpp:380
error: src/master/master.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On June 21, 2018, 12:08 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66881/
> ---
> 
> (Updated June 21, 2018, 12:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added benchmark test for master metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/66881/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68123/#review213697
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68123']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2946/mesos-review-68123

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2946/mesos-review-68123/logs/mesos-tests.log):

```
W0313 23:08:36.134205 15336 slave.cpp:3932] Ignoring shutdown framework 
b1343df1-994d-4280-a8b9-d9277ca6e264- because it is terminating
I0313 23:08:36.136200 15580 master.cpp:1295] Agent 
b1343df1-994d-4280-a8b9-d9277ca6e264-S0 at slave(494)@192.10.1.6:57145 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0313 23:08:36.137207 15580 master.cpp:3330] Disconnecting agent 
b1343df1-994d-4280-a8b9-d9277ca6e264-S0 at slave(494)@192.10.1.6:57145 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:08:36.137207 15580 master.cpp:3349] Deactivating agent 
b1343df1-994d-4280-a8b9-d9277ca6e264-S0 at slave(494)@192.10.1.6:57145 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:08:36.137207 12060 hierarchical.cpp:390] Removed framework 
b1343df1-994d-4280-a8b9-d9277ca6e264-
I0313 23:08:36.138200 12060 hierarchical.cpp:827] Agent 
b1343df1-994d-4280-a8b9-d9277ca6e264-S0 deactivated
I0313 23:08:36.138200  9672 containerizer.cpp:2576] Destroying container 
9ab3053b-49ee-4399-84d9-ec14155f48ff in RUNNING state
I0313 23:08:36.138200  9672 containerizer.cpp:3278] Transitioning the state of 
container 9ab3053b-49ee-4399-84d9-ec14155f48ff from RUNNING to DESTROYING
I0313 23:08:36.139206  9672 launcher.cpp:161] Asked to destroy container 
9ab3053b-49ee-4399-84d9-ec14155f48ff
W0313 23:08:36.140194 14464 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=6620 to peer '192.10.1.6:59486': IO failed with error 
code: The specified network name is no longer available.

W0313 23:08:36.140194 14464 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=6580 to peer '192.10.1.6:59487': IO failed with error 
code: The specified network name is no longer available.

I0313 23:08:36.163215 15140 containerizer.cpp:3117] Container 9ab3053b-49ee-43[ 
  OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (588 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (604 ms total)

[--] Global test environment tear-down
[==] 1115 tests from 106 test cases ran. (504580 ms total)
[  PASSED  ] 1114 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

99-84d9-ec14155f48ff has exited
I0313 23:08:36.192247 15620 master.cpp:1135] Master terminating
I0313 23:08:36.194221 15580 hierarchical.cpp:678] Removed agent 
b1343df1-994d-4280-a8b9-d9277ca6e264-S0
I0313 23:08:36.508219 14464 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On July 31, 2018, 5:17 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68123/
> ---
> 
> (Updated July 31, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 35992474eacb8b14ae57e1dc23307e1542f63cb5 
> 
> 
> Diff: https://reviews.apache.org/r/68123/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213696
---



Patch looks great!

Reviews applied: [70200]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 13, 2019, 6:09 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 13, 2019, 6:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70084/#review213695
---



PASS: Mesos patch 70084 was successfully built and tested.

Reviews applied: `['70084']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2940/mesos-review-70084

- Mesos Reviewbot Windows


On March 2, 2019, 1:04 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70084/
> ---
> 
> (Updated March 2, 2019, 1:04 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, Meng Zhu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-8467
> https://issues.apache.org/jira/browse/MESOS-8467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When launching executors and tasks, there is no guarantee that the
> executors still remain after `Slave::publishResources` is returned. If
> not, the executor struct should not be dereferenced and the executor
> containers should not be launched at all.
> 
> NOTE: The patch makes `Slave::launchExecutor` called asynchronously even
> if there is no secret generator. However this should not affect the
> correctness of executor launching.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 
>   src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 
> 
> 
> Diff: https://reviews.apache.org/r/70084/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67177: Sorted container mounts by their target paths.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67177/#review213694
---



FAIL: Failed to apply the dependent review: 67175.

Failed command: `python.exe .\support\apply-reviews.py -n -r 67175`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2945/mesos-review-67177

Relevant logs:

- 
[apply-review-67175.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2945/mesos-review-67177/logs/apply-review-67175.log):

```
error: patch failed: src/linux/fs.hpp:283
error: src/linux/fs.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On May 16, 2018, 6:28 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67177/
> ---
> 
> (Updated May 16, 2018, 6:28 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-6798
> https://issues.apache.org/jira/browse/MESOS-6798
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Container mounts are sorted by:
> 1) their target paths, and then
> 2) their source paths,
> before mounting them upon container launch.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> f25d90651ef32495c9161c3eaed8a327d1b2b926 
> 
> 
> Diff: https://reviews.apache.org/r/67177/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65847/#review213693
---



FAIL: Failed to apply the dependent review: 65819.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65819`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2944/mesos-review-65847

Relevant logs:

- 
[apply-review-65819.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2944/mesos-review-65847/logs/apply-review-65819.log):

```
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1574
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 28, 2018, 1 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65847/
> ---
> 
> (Updated Feb. 28, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-8456
> https://issues.apache.org/jira/browse/MESOS-8456
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `QuotaAbsentFramework` assumes the coarse grained nature
> of second stage resource allocation. This is no longer
> true given #65821. This patch fixes the test by asserting
> the allocation in terms of quantity.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> c97b2ba0884a7ded867c2d80e4749de54c89b5e4 
> 
> 
> Diff: https://reviews.apache.org/r/65847/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213691
---




src/master/master.cpp
Line 9557 (original), 9557-9564 (patched)


Should this lambda leverage move semantics? It could take an rvalue and do 
an assignment instead of a copy:

```
update.mutable_update_operation_status()
  ->mutable_status() = status;
```

It would also be possible to create a single `scheduler::Event` message 
instead of one per lambda invocation.



src/tests/operation_reconciliation_tests.cpp
Line 200 (original), 204 (patched)


`s/ASSERT/EXPECT/` here and on the other tests.

The updated test doesn't call `result->response()`, so there is no risk of 
it crashing.



src/tests/storage_local_resource_provider_tests.cpp
Lines 4658-4660 (original), 4662-4664 (patched)


`%s/ASSERT/EXPECT/g`


- Gastón Kleiman


On March 13, 2019, 11:09 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 13, 2019, 11:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 69615: Disable containerizer ptrace attach.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69615/#review213692
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69615']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2942/mesos-review-69615

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2942/mesos-review-69615/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70169/#review213690
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70168', '70169']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2941/mesos-review-70169

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2941/mesos-review-70169/logs/mesos-tests.log):

```
I0313 21:49:52.153338 13108 master.cpp:11596] Removing task 
501f2cba-a103-4807-a1b3-9b82533c60ef with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework d2ab3f23-c49e-452a-8df7-23361e63b23f- on 
agent d2ab3f23-c49e-452a-8df7-23361e63b23f-S0 at slave(494)@192.10.1.7:56848 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 21:49:52.157333 13108 master.cpp:1295] Agent 
d2ab3f23-c49e-452a-8df7-23361e63b23f-S0 at slave(494)@192.10.1.7:56848 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0313 21:49:52.157333 13108 master.cpp:3330] Disconnecting agent 
d2ab3f23-c49e-452a-8df7-23361e63b23f-S0 at slave(494)@192.10.1.7:56848 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 21:49:52.157333 13108 master.cpp:3349] Deactivating agent 
d2ab3f23-c49e-452a-8df7-23361e63b23f-S0 at slave(494)@192.10.1.7:56848 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 21:49:52.158335  8956 hierarchical.cpp:390] Removed framework 
d2ab3f23-c49e-452a-8df7-23361e63b23f-
I0313 21:49:52.158335  8956 hierarchical.cpp:827] Agent 
d2ab3f23-c49e-452a-8df7-23361e63b23f-S0 deactivated
I0313 21:49:52.158335  9620 containerizer.cpp:2576] Destroying container 
b8b9d05c-3a90-4839-b308-7fa95fe55840 in RUNNING state
I0313 21:49:52.158335  9620 containerizer.cpp:3278] Transitioning the state of 
container b8b9d05c-3a90-4839-b308-7fa95fe55840 from RUNNING to DESTROYING
I0313 21:49:52.159339  9620 launcher.cpp:161] Asked to destroy container 
b8b9d05c-3a90-4839-b308-7fa95fe55840
W0313 21:49:52.160332 15040 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=10028 to peer '192.10.1.7:59186': IO failed with error 
code: The specified network name is no longer available.

W0313 21:49:52.161321 15040 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=10148 to peer '192.10.1.7:59187': IO failed with error 
code: The spe[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (690 
ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (706 ms total)

[--] Global test environment tear-down
[==] 1115 tests from 106 test cases ran. (502409 ms total)
[  PASSED  ] 1114 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

cified network name is no longer available.

I0313 21:49:52.238680  8956 containerizer.cpp:3117] Container 
b8b9d05c-3a90-4839-b308-7fa95fe55840 has exited
I0313 21:49:52.267634  9620 master.cpp:1135] Master terminating
I0313 21:49:52.268743  9568 hierarchical.cpp:678] Removed agent 
d2ab3f23-c49e-452a-8df7-23361e63b23f-S0
I0313 21:49:52.54 15040 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 12, 2019, 8:43 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70169/
> ---
> 
> (Updated March 12, 2019, 8:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored SLRP to use `ServiceManager`.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> fea623c292158deb1b4b4b9ab1ac208031471519 
>   src/resource_provider/storage/provider_process.hpp 
> a5536b3d735e01eb1c4dc52d0602d973155f3c93 
> 
> 
> Diff: https://reviews.apache.org/r/70169/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69955/#review213689
---



PASS: Mesos patch 69955 was successfully built and tested.

Reviews applied: `['69954', '69955']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2938/mesos-review-69955

- Mesos Reviewbot Windows


On March 4, 2019, 7:23 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69955/
> ---
> 
> (Updated March 4, 2019, 7:23 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds 3 unit tests: `DestroyUnpublishedPersistentVolume`,
> `DestroyUnpublishedPersistentVolumeWithRecovery`, and
> `DestroyUnpublishedPersistentVolumeWithReboot` to test that the SLRP is
> resilient to misbehaved CSI plugins that fail to publish volumes.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/69955/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review213688
---



PASS: Mesos patch 70133 was successfully built and tested.

Reviews applied: `['70132', '70133']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2936/mesos-review-70133

- Mesos Reviewbot Windows


On March 6, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> ---
> 
> (Updated March 6, 2019, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 
> seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/#review213687
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 54987`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2939/mesos-review-54987

Relevant logs:

- 
[apply-review-54987.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2939/mesos-review-54987/logs/apply-review-54987.log):

```
error: patch failed: docs/monitoring.md:1782
error: docs/monitoring.md: patch does not apply
```

- Mesos Reviewbot Windows


On April 30, 2018, 2:09 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54987/
> ---
> 
> (Updated April 30, 2018, 2:09 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `docs/monitoring/md` for new agent event queue metrics.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb 
> 
> 
> Diff: https://reviews.apache.org/r/54987/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review213686
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68297', '68374', '68301']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2937/mesos-review-68301

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2937/mesos-review-68301/logs/mesos-tests.log):

```

W0313 20:25:34.569185  9964 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=14064 to peer '192.10.1.4:63426': IO failed with error 
code: The specified network name is no longer available.

I0313 20:25:34.585218  8552 containerizer.cpp:3117] Container 
98dfa831-a280-4247-a5ac-63fa58cef8db has exited
I0313 20:25:34.617194  8552 master.cpp:1135] Master terminating
I0313 20:25:34.618181  2412 hierarc[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (692 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (711 ms total)

[--] Global test environment tear-down
[==] 1115 tests from 106 test cases ran. (660523 ms total)
[  PASSED  ] 1104 tests.
[  FAILED  ] 11 tests, listed below:
[  FAILED  ] GarbageCollectorIntegrationTest.LongLivedDefaultExecutor
[  FAILED  ] GarbageCollectorIntegrationTest.LongLivedDefaultExecutorRestart
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where 
GetParam() = "mesos"
[  FAILED  ] 
MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where 
GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, 
where GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where 
GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where 
GetParam() = "mesos"
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where 
GetParam() = "docker,mesos"
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0,
 where GetParam() = "docker,mesos"
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0,
 where GetParam() = "docker,mesos"
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, 
where GetParam() = "docker,mesos"

11 FAILED TESTS
  YOU HAVE 232 DISABLED TESTS

hical.cpp:678] Removed agent f1807198-588f-42ab-ba0d-83bfd0c0ff6c-S0
I0313 20:25:34.881379  9964 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Aug. 23, 2018, 6:26 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> ---
> 
> (Updated Aug. 23, 2018, 6:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 
> 81bf72e869d36edb162b121f9e84a53d2096dae3 
>   src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
>   src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638 
>   src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135 
>   src/tests/master_validation_tests.cpp 
> ec4fd13724a44a86ad655fb2a8affbb9f476834f 
>   src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 
>   src/tests/slave_authorization_tests.cpp 
> 061e230b52805c4260e93ac83734aed5454ea3b5 
>   src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 
>   src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274 
> 
> 
> Diff: https://reviews.apache.org/r/68301/diff/4/
> 
> 
> Testing
> ---
> 
> This should have _almost_ all the tests pass, except for:
> 
> ```
> [  FAILED  ] 9 tests, listed below:
> [  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where 
> GetParam() = "mesos"
> [  FAILED  ] 
> MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where 
> GetParam() = "mesos"
> [  FAILED  ] 
> MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where 
> GetParam() = "mesos"
> [  FAILED  ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, 
> where GetParam() = "mesos"
> [  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where 
> GetParam() = "mesos"
> [  FAILED  ] 
> ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, 
> where GetParam() = 

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213685
---



Patch looks great!

Reviews applied: [70115, 70156, 70185, 70116, 70117]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 13, 2019, 4:01 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> ---
> 
> (Updated March 13, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
> 
> 
> Diffs
> -
> 
>   src/tests/agent_operation_feedback_tests.cpp 
> 5a8f54c7c53272e90ed5fa6366e8154cedf1375f 
>   src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 002be27bf0731e2dba8937697b347cd1dd0a 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 
>   src/tests/reservation_endpoints_tests.cpp 
> b1897592797c40574de7995b2335f2b4bc5fc699 
>   src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 
>   src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70117/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69313: Enabled parallel test runner to cmake build.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69313/#review213684
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69311', '69312', '69313']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2935/mesos-review-69313

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2935/mesos-review-69313/logs/mesos-tests.log):

```
I0313 19:39:56.309106 10024 executor.cpp:726] Forked command at 14488
W0313 19:46:09.772416 12652 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=120 to peer '192.10.1.6:52776': IO failed with error 
code: The specified network name is no longer available.

W0313 19:46:09.773432 12652 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=152 to peer '192.10.1.6:51759': IO failed with error 
code: The specified network name is no longer available.

I0313 I0313 19:39:00.779943  9460 exec.cpp:162] Version: 1.8.0
W0313 19:46:09.772416 10312 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=440 to peer '192.10.1.6:51759': IO failed with error 
code: The specified network name is no longer available.

I0313 19:46:09.772416 15556 exec.cpp:527] Agent exited ... shutting down
I0313 19:46:09.773432 11020 v0_v1executor.cpp:172] Implicitly connecting the 
executor to shut it down
I0313 19:46:09.774415 15036 executor.cpp:190] Received SHUTDOWN event
I0313 19:46:09.778455 15036 executor.cpp:829] Shutting down
I0313 19:46:09.779428 10312 process.cpp:927] Stopped the socket accept loop
19:46:09.728420 14852 exec.cpp:518] Agent exited, but framework has 
checkpointing enabled. Waiting 15mins to reconnect with agent 
a6f83e7b-928a-46c7-b1af-d0f3813db984-S0
I0313 19:54:27.609165 14852 executor.cpp:1027] Command exited with status 0 
(pid: 14864)
I0313 19:54:28.613957 11056 process.cpp:927] Stopped the socket accept loop
W0313 19:54:28.614946 11056 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:51759', connect: IO failed 
with error code: The remote computer refused the network connection.

.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=392 to peer 
'192.10.1.6:52713': IO failed with error code: The specified network name is no 
longer available.

I0313 19:55:08.837858  7840 executor.cpp:1027] Command exited with status 0 
(pid: 13548)
I0313 19:55:09.841377 16232 process.cpp:927] Stopped the socket accept loop
W0313 19:55:09.843376 16232 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:51759', connect: IO failed 
with error code: The remote computer refused the network connection.

19:46:09.773432 14212 exec.cpp:518] Agent exited, but framework has 
checkpointing enabled. Waiting 15mins to reconnect with agent 
6ac199e2-95f8-45ba-9772-c4b6245813e1-S0
I0313 19:56:36.600431 12296 executor.cpp:1027] Command exited with status 0 
(pid: 14488)
W0313 19:56:37.605705 12652 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:51759', connect: IO failed 
with error code: The remote computer refused the network connection.

I0313 19:56:37.606717 12652 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 11, 2018, 12:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69313/
> ---
> 
> (Updated Nov. 11, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled parallel test runner to cmake build.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/CMakeLists.txt 
> ff0660707c116cae8174f2ebffb6e2a2698a2c49 
> 
> 
> Diff: https://reviews.apache.org/r/69313/diff/1/
> 
> 
> Testing
> ---
> 
> `ninja check`
> `ninja tests && ctest -j3 -V`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70202: Added call handler for `UPDATE_QUOTA`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70202/#review213683
---


Fix it, then Ship it!





src/master/master.hpp
Lines 1169 (patched)


Hm.. what does "available" mean here? Is this expressing an intention to 
only use it for v1? Or something else?



src/master/quota_handler.cpp
Lines 429 (patched)


auto&& or const auto&?



src/master/quota_handler.cpp
Lines 433-434 (patched)


Maybe this should more directly say the role is not in the whitelist?



src/master/quota_handler.cpp
Lines 451 (patched)


Rather than saying "failed to validate" maybe say "Invalid `QuotaConfig`: 
..." or something?

Failed to validate seems to suggest we failed at doing something?

Ditto above in the other BadRequest


- Benjamin Mahler


On March 13, 2019, 6:43 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70202/
> ---
> 
> (Updated March 13, 2019, 6:43 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
> https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current implementation is incomplete and only does call
> validation. It returns 501 `NOT_IMPLEMENTED`.
> 
> Further work includes authorization and actual enforcement
> of the quota in the allocator.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/quota_handler.cpp 8d417a9b2a2fa0d83d98d65167adfada2994f75c 
> 
> 
> Diff: https://reviews.apache.org/r/70202/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> dedicated test added in subsequent patches
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213682
---


Ship it!





src/common/resource_quantities.cpp
Lines 406-418 (patched)


This is very clean and readable! I guess we're ok with the re-scanning 
approach instead of walking both alphabetically for now?

(I think it's fine, we can consider optimizing it later if needed)



src/common/resource_quantities.cpp
Lines 408-409 (patched)


How about s/quantityScalar/quantity/ ?

Also fits cleanly on one line that way:

```
>>> len(' foreachpair (const string& name, const Value::Scalar& quantity, 
quantities) {')
78
```



src/tests/resource_quantities_tests.cpp
Lines 434-473 (patched)


This was easy to read, thanks!


- Benjamin Mahler


On March 13, 2019, 2:13 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> ---
> 
> (Updated March 13, 2019, 2:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added tests.
> 
> 
> Diffs
> -
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
>   src/tests/resource_quantities_tests.cpp 
> 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70201/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70203/#review213681
---


Ship it!




Nice!


src/tests/master_validation_tests.cpp
Lines 307-308 (original), 164-165 (patched)


Do we want the extra spaces after { and before }?


- Benjamin Mahler


On March 13, 2019, 6:46 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70203/
> ---
> 
> (Updated March 13, 2019, 6:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
> https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated a test for `UPDATE_QUOTA` call validation.
> 
> 
> Diffs
> -
> 
>   src/tests/master_validation_tests.cpp 
> 9568d39accb00eec68b622fdc7f02249fefbc063 
> 
> 
> Diff: https://reviews.apache.org/r/70203/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70161: Added validation for `QuotaConfig`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70161/#review213680
---


Ship it!





src/master/quota.cpp
Lines 323-349 (patched)


At first I thought there was a missing closing / opening single quotes on 
these, maybe we should use braces?

```
Invalid guarantee configuration {'cpus': NaN}: NaN not supported
```



src/master/quota.cpp
Lines 341-350 (patched)


Nice!


- Benjamin Mahler


On March 13, 2019, 6:41 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70161/
> ---
> 
> (Updated March 13, 2019, 6:41 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
> https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A `QuotaConfig` is valid if the following conditions are met:
> 
>  (1) The config has a valid non-"*" role.
> 
>  (2) Resource scalar values are non-negative and finite.
> 
>  (3) If both guarantees and limits are set for a particular
>  resource, then guarantee <= limit for that resource.
> 
> 
> Diffs
> -
> 
>   src/master/quota.hpp 5cd2bb0e8669ee0290a4c1fe1058b87251772939 
>   src/master/quota.cpp 671626c01ada595d7557d5266e39a17cce243b94 
> 
> 
> Diff: https://reviews.apache.org/r/70161/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> dedicated test added in subsequent patches
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70151: Added `class ResourceLimits`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70151/#review213676
---



Looks like a bug was introduced? See below


src/common/resource_quantities.hpp
Lines 192 (patched)


Ditto from previous review, `get` seems more readable?

```
limits.get("cpus")
vs
limits.limit("cpus")
```

The first seems to suggest I'm getting the cpus limit, the second seems to 
suggest I'm limiting cpus (i.e. the action looks to be "limit cpus")



src/common/resource_quantities.cpp
Lines 374-375 (patched)


Ditto here:

```
size_t leftIndex = 0;
size_t rightIndex = 0;

while (leftIndex < size() && rightIndex < right.size()) {
 ...
```



src/common/resource_quantities.cpp
Lines 376-377 (patched)


Ditto here:

```
const pair& left_ = limits.at(leftIndex);
const pair& right_ = right.limits.at(rightIndex);
```



src/common/resource_quantities.cpp
Lines 379-380 (patched)


Ditto here, this seems to belong above the loop?



src/common/resource_quantities.cpp
Lines 382 (patched)


We probably want to be a little more concrete here to make this readable:

```
// Left has a finite limit but right has no limit.
```

Ditto below for the other cases.



src/common/resource_quantities.cpp
Lines 398 (patched)


Ah, this is indeed a little more concrete than saying "items" like above, 
but maybe we can use "limits"?

```
Left has finite limits for resources that right has no limits for.
```



src/common/resource_quantities.cpp
Lines 416 (patched)


Hm.. don't you need to return here?

Looks like it's going to overwrite then insert an extra entry below after 
the loop? i.e. seems like a bug?


- Benjamin Mahler


On March 7, 2019, 7:56 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70151/
> ---
> 
> (Updated March 7, 2019, 7:56 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9608
> https://issues.apache.org/jira/browse/MESOS-9608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Similar to `ResourceQuantities`. `ResourceLimits`
> is an efficient collection of resource quantities.
> The main difference lies in the absence semantic.
> Absent entry in `ResourceQuantities` implies zero
> quantity while in `ResourceLimits`, it implies no
> limit (i.e. infinite amount). Also, due to the
> absence semantic, zero values in `ResourceLimits`
> are not dropped.
> 
> 
> Diffs
> -
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
> 
> 
> Diff: https://reviews.apache.org/r/70151/diff/2/
> 
> 
> Testing
> ---
> 
> test added in r/70152
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70053/#review213679
---



PASS: Mesos patch 70053 was successfully built and tested.

Reviews applied: `['70053']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2931/mesos-review-70053

- Mesos Reviewbot Windows


On Feb. 25, 2019, 9:20 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70053/
> ---
> 
> (Updated Feb. 25, 2019, 9:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a non-functional change to avoid manual memory management. By
> using a `std::string` instead of an explicitly heap-allocated buffer the
> used pattern might even avoid hitting the heap altogether due to the SSO
> but this function might be runtime bounded by I/O anyway.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/mktemp.hpp 
> 8dab2599f13c3e1dab109423c8a938ec16540aaf 
> 
> 
> Diff: https://reviews.apache.org/r/70053/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70184/#review213678
---



PASS: Mesos patch 70184 was successfully built and tested.

Reviews applied: `['70184']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2933/mesos-review-70184

- Mesos Reviewbot Windows


On March 11, 2019, 8:39 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70184/
> ---
> 
> (Updated March 11, 2019, 8:39 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9594
> https://issues.apache.org/jira/browse/MESOS-9594
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under some circumstances, offers would be filtered, resulting in the
> test being stuck while waiting for offers. This has been resolved by
> removing all offer filters before waiting for offers.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70184/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> I could not reproduce the flaky behavior of this test case, hence only assume 
> that this patch resolves the flakiness.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 70160: Added `<<` operator to `protobuf::Map`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70160/#review213677
---


Ship it!




Ship It!

- Benjamin Mahler


On March 8, 2019, 7:22 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70160/
> ---
> 
> (Updated March 8, 2019, 7:22 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `<<` operator to `protobuf::Map`.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 630f21f34c2215092e5ca14ffc5c966cce2b63e4 
> 
> 
> Diff: https://reviews.apache.org/r/70160/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70149: Added a `contains` method in `ResourceQuantities`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70149/#review213675
---



Looks good, just some minor stylistic comments that are similar to the ones I 
just made in the quantities refactoring patch.


src/common/resource_quantities.cpp
Lines 144-145 (patched)


This looks a bit cleaner and we can use this loop structure consistently in 
all of the functions here? (see my review on the other quantities patch):

```
size_t leftIndex = 0u;
size_t rightIndex = 0u;

while (leftIndex < size() && rightIndex < right.size()) {
  ...
```



src/common/resource_quantities.cpp
Lines 146-147 (patched)


Whoa this confused me at first, let's also use two statements here, we 
don't make much use of the comma syntax for declaring multiple variables in one 
statement:

```
  const pair& left_ = quantities.at(leftIndex);
  const pair& right_ = 
right.quantities.at(rightIndex);
```



src/common/resource_quantities.cpp
Lines 149-150 (patched)


Ditto here from my other review on the quantities patch, this seems to 
belong above the loop?



src/common/resource_quantities.cpp
Lines 162-163 (patched)


We should stick to pre-increment instead of using post-increment here?


- Benjamin Mahler


On March 12, 2019, 11:30 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70149/
> ---
> 
> (Updated March 12, 2019, 11:30 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The method checks if the ResourceQuantities object
> contains another ResourceQuantities.
> 
> Also added tests.
> 
> 
> Diffs
> -
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
>   src/tests/resource_quantities_tests.cpp 
> 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70149/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70062/#review213672
---



Looks good, just one minor quirk about the += operator, and some stylistic 
comments.


src/common/resource_quantities.hpp
Line 122 (original), 114 (patched)


I'm curious why the rename, `get` still seems like a more readable name to 
me:

```
quantities.get("cpus")
vs
quantities.quantity("cpus")
```

"quantity" doesn't seem to suggest the action of retrieving the value for 
the name?



src/common/resource_quantities.hpp
Lines 124-125 (original), 116-117 (patched)


Up here in the public interface seems like we should name the argument 
`quantities`? We can still name using `left`/`right` or `this`/`that` in the 
.cpp



src/common/resource_quantities.cpp
Lines 145 (patched)


Don't know if style guide allows this, can you do:

```
size_t leftIndex = 0u;
size_t rightIndex = 0u;

while (leftIndex < size() && rightIndex < right.size()) {
  ...
```



src/common/resource_quantities.cpp
Lines 150-151 (patched)


This comment seems to belong up above the loop to explain the overall 
approach?



src/common/resource_quantities.cpp
Lines 158-159 (patched)


Why not advance left here? The current code does this AFAICT:

// Before:
//LeftIndex
//v
// Left  [0, ..., b, ...]
// Right [0, ..., a, ...]
//^ RightIndex

// After:
//LeftIndex
//v
// Left  [0, ..., a, b, ...]
// Right [0, ..., a, z, ...]
//   ^ RightIndex

We insert the missing entry into left, and we know that since we moved 
right index forward the next loop iteration will just execute ++leftIndex. So 
there's no correctness issue. However, it seems a bit strange that we've 
essentially taken one step backwards with left index and are now pointing to 
the item before `b`.

Logically, it seems a bit clearer to increment left since we want to stay 
indexed on `b` for the next iteration?

// Before:
//LeftIndex
//v
// Left  [0, ..., b, ...]
// Right [0, ..., a, ...]
//^ RightIndex

// After:
//   LeftIndex
//   v
// Left  [0, ..., a, b, ...]
// Right [0, ..., a, z, ...]
//   ^ RightIndex



src/common/resource_quantities.cpp
Lines 168-174 (patched)


Might read a bit more consistent and succinct like this?

```
  // Copy the remaining items in `right`.
  while (rightIndex < right.size()) {
quantities.push_back(right.quantities.at(rightIndex));
++rightIndex;
  }
```

Basically just "finishing" the loop above for the right index.



src/common/resource_quantities.cpp
Lines 183-184 (patched)


Maybe just pull these out and have a more consistent while loop style to 
the += operator?

```
size_t leftIndex = 0u;
size_t rightIndex = 0u;

while (leftIndex < size() &&  rightIndex < right.size()) {
  ...
```

Seems a bit "cleaner" looking too?



src/common/resource_quantities.cpp
Lines 188-189 (patched)


Ditto here, seems to belong above the loop?



src/common/resource_quantities.cpp
Lines 194-195 (patched)


A little unclear that this is because it's negative?

```
  // Item exists in the right but not in the left (i.e. 0), this
  // would result in a negative entry, so skip it.
```



src/common/resource_quantities.cpp
Lines 217 (patched)


Any thoughts on CHECKing > 0 or >= 0 vs no CHECK?


- Benjamin Mahler


On March 12, 2019, 11:17 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70062/
> ---
> 
> (Updated March 12, 2019, 11:17 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9608
> https://issues.apache.org/jira/browse/MESOS-9608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removed the map interface of
> `class ResourceQuantities`, added a few 

Re: Review Request 70186: Updated protobuf comments related to operation feedback.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213674
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 70186`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2934/mesos-review-70186

Relevant logs:

- 
[apply-review-70186.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2934/mesos-review-70186/logs/apply-review-70186.log):

```
error: patch failed: include/mesos/mesos.proto:2124
error: include/mesos/mesos.proto: patch does not apply
error: patch failed: include/mesos/scheduler/scheduler.proto:130
error: include/mesos/scheduler/scheduler.proto: patch does not apply
error: patch failed: include/mesos/v1/mesos.proto:2117
error: include/mesos/v1/mesos.proto: patch does not apply
error: patch failed: include/mesos/v1/scheduler/scheduler.proto:128
error: include/mesos/v1/scheduler/scheduler.proto: patch does not apply
```

- Mesos Reviewbot Windows


On March 11, 2019, 7:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70186/
> ---
> 
> (Updated March 11, 2019, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While the `id` field in `Offer::Operation` was previously marked
> experimental, it is also wise to explicitly mark the related
> scheduler API calls and events as experimental to avoid any
> confusion.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb 
>   include/mesos/scheduler/scheduler.proto 
> 27634153b372584a214c9631a939254bd984c735 
>   include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3 
>   include/mesos/v1/scheduler/scheduler.proto 
> 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0 
> 
> 
> Diff: https://reviews.apache.org/r/70186/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213673
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70115', '70156', '70185', '70116', '70117']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2930/mesos-review-70117

Relevant logs:

- 
[stout-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2930/mesos-review-70117/logs/stout-tests.log):

```
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (1 ms)
[ RUN  ] SocketTests.IntFD
[   OK ] SocketTests.IntFD (1 ms)
[--] 2 tests from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (0 ms total)

[--] 2 tests from OsSendfileTest
[ RUN  ] OsSendfileTest.Sendfile
[   OK ] OsSendfileTest.Sendfile (1248 ms)
[ RUN  ] OsSendfileTest.SendfileAsync
[   OK ] OsSendfileTest.SendfileAsync (18 ms)
[--] 2 tests from OsSendfileTest (1266 ms total)

[--] Global test environment tear-down
[==] 345 tests from 53 test cases ran. (7675 ms total)
[  PASSED  ] 344 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OsTest.Children

 1 FAILED TEST
  YOU HAVE 1 DISABLED TEST

```

- Mesos Reviewbot Windows


On March 13, 2019, 4:01 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> ---
> 
> (Updated March 13, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
> 
> 
> Diffs
> -
> 
>   src/tests/agent_operation_feedback_tests.cpp 
> 5a8f54c7c53272e90ed5fa6366e8154cedf1375f 
>   src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 002be27bf0731e2dba8937697b347cd1dd0a 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 
>   src/tests/reservation_endpoints_tests.cpp 
> b1897592797c40574de7995b2335f2b4bc5fc699 
>   src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 
>   src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70117/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70198: Added validation method for input scalar values.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70198/#review213671
---


Fix it, then Ship it!




Nice to see this consolidated!


src/common/validation.hpp
Lines 74 (patched)


s/const//

Was expecting this to take a Value::Scalar, might be worth a comment about 
why it's taking double?



src/common/validation.cpp
Line 629 (original), 629 (patched)


s/strinf/string/



src/common/validation.cpp
Line 634 (original), 634 (patched)


Can you include the quantity name? E.g.

```
Invalid resource quantity for 'cpu': NaN not supported
```



src/common/values.cpp
Line 729 (original), 730 (patched)


`*value_`?



src/v1/values.cpp
Line 758 (original), 760 (patched)


`*value_`?


- Benjamin Mahler


On March 13, 2019, 12:10 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70198/
> ---
> 
> (Updated March 13, 2019, 12:10 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The method validates the input scalar values to be
> non-negative normal values ("normal" as defined by
> `std::fpclassify`).
> 
> Also refactored some related validation logic and tests.
> 
> 
> Diffs
> -
> 
>   src/common/validation.hpp d09528f56e8b3675d677159c597399688019e65e 
>   src/common/validation.cpp b622a3284cfc528f8245b0300df667d525b7eea3 
>   src/common/values.cpp c788302b928747a1aed66efd4d654711410928f1 
>   src/tests/common_validation_tests.cpp 
> 214b993fa1942f15cfb4c732a5d280274d0512e9 
>   src/tests/master_validation_tests.cpp 
> 9568d39accb00eec68b622fdc7f02249fefbc063 
>   src/v1/values.cpp 5fd9dc5a03ec7b8f6ed31acb3f868764a45b2bfd 
> 
> 
> Diff: https://reviews.apache.org/r/70198/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 70200: Changed operation reconciliation to send updates on the event stream.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs
-

  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/1/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66746/#review213669
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66746`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2932/mesos-review-66746

Relevant logs:

- 
[apply-review-66746.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2932/mesos-review-66746/logs/apply-review-66746.log):

```
error: patch failed: include/mesos/type_utils.hpp:23
error: include/mesos/type_utils.hpp: patch does not apply
error: patch failed: include/mesos/v1/mesos.hpp:23
error: include/mesos/v1/mesos.hpp: patch does not apply
error: patch failed: src/common/type_utils.cpp:36
error: src/common/type_utils.cpp: patch does not apply
error: patch failed: src/v1/mesos.cpp:35
error: src/v1/mesos.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66746/
> ---
> 
> (Updated April 20, 2018, 8:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The MessageDifferencer utility has been available since protobuf 3.0.0.
> When comparing most repeated fields, we treat them as sets so the order
> of elements doesn't matter. In some exceptional cases, we treat them as
> list so the order becomes important. Further, fields with default
> purposes are considered to be set for comparison purposes.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa 
>   include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb 
>   src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 
>   src/tests/master_allocator_tests.cpp 
> e1aef8a9625a805e7ad2dfad37bfeedee82f160d 
>   src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf 
> 
> 
> Diff: https://reviews.apache.org/r/66746/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` currently fails with:
> DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask
> DefaultExecutorCheckTest.MultipleTasksWithChecks
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 70156: Added helper to test for metrics values.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70156/
---

(Updated March 13, 2019, 5:45 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.


Changes
---

Removed unnecessary double lookup.


Repository: mesos


Description
---

This patch adds a new helper function to check
whether a given metric has some specified value.


Diffs (updated)
-

  src/tests/utils.hpp b2f22cd4db223d167aa35109cd8de6df82ed1f4d 


Diff: https://reviews.apache.org/r/70156/diff/3/

Changes: https://reviews.apache.org/r/70156/diff/2-3/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70206: Displayed error message on resource validation failures.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213670
---



Patch looks great!

Reviews applied: [70206]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 13, 2019, 3:54 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> ---
> 
> (Updated March 13, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
> 
> 
> Diffs
> -
> 
>   src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f 
> 
> 
> Diff: https://reviews.apache.org/r/70206/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

[Benno Evers]

> On March 13, 2019, 12:29 a.m., Joseph Wu wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3832-3845 (original), 3833-3846 (patched)
> > 
> >
> > In cases like this, it would be more appropriate to use `Metrics()` 
> > since we'd otherwise make multiple calls to `/metrics/snapshot` for each 
> > metric.
> > 
> > Alternatively, you could add a verion of the `metricsEqual` which takes 
> > a map.  The downside of a helper is that reporting which metric(s) don't 
> > match would be harder.
> > 
> > ... also you forgot to delete `snapshot = Metrics();` ;)

I actually thought about your first point when implementing this, but thought 
that readability would be more important than shaving off a few milliseconds 
from a test case.

Regarding the `snapshot`, you are of course right and I should have read the 
comment before pushing the next revision ;)


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213641
---


On March 13, 2019, 4:01 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> ---
> 
> (Updated March 13, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
> 
> 
> Diffs
> -
> 
>   src/tests/agent_operation_feedback_tests.cpp 
> 5a8f54c7c53272e90ed5fa6366e8154cedf1375f 
>   src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 002be27bf0731e2dba8937697b347cd1dd0a 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 
>   src/tests/reservation_endpoints_tests.cpp 
> b1897592797c40574de7995b2335f2b4bc5fc699 
>   src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 
>   src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70117/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
---

(Updated March 13, 2019, 4:01 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.


Changes
---

Removed one more line.


Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241


Repository: mesos


Description
---

This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.


Diffs (updated)
-

  src/tests/agent_operation_feedback_tests.cpp 
5a8f54c7c53272e90ed5fa6366e8154cedf1375f 
  src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 
  src/tests/master_slave_reconciliation_tests.cpp 
002be27bf0731e2dba8937697b347cd1dd0a 
  src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/persistent_volume_endpoints_tests.cpp 
40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 
  src/tests/reservation_endpoints_tests.cpp 
b1897592797c40574de7995b2335f2b4bc5fc699 
  src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 
  src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70117/diff/6/

Changes: https://reviews.apache.org/r/70117/diff/5-6/


Testing
---


Thanks,

Benno Evers

Review Request 70206: Displayed error message on resource validation failures.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/
---

Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.


Repository: mesos


Description
---

When pushing a reservation, the validation code would not
print the error that caused validation to fail. This could
result in developers scratching their heads in confusion.


Diffs
-

  src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f 


Diff: https://reviews.apache.org/r/70206/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
---

(Updated March 13, 2019, 3:51 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.


Changes
---

Fixed flakiness observed in CI.


Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241


Repository: mesos


Description
---

This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.


Diffs (updated)
-

  src/tests/agent_operation_feedback_tests.cpp 
5a8f54c7c53272e90ed5fa6366e8154cedf1375f 
  src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 
  src/tests/master_slave_reconciliation_tests.cpp 
002be27bf0731e2dba8937697b347cd1dd0a 
  src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/persistent_volume_endpoints_tests.cpp 
40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 
  src/tests/reservation_endpoints_tests.cpp 
b1897592797c40574de7995b2335f2b4bc5fc699 
  src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 
  src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70117/diff/5/

Changes: https://reviews.apache.org/r/70117/diff/4-5/


Testing
---


Thanks,

Benno Evers

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko commented on a change in pull request #326: MESOS-6874: Validate 
the match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r265197006
 
 

 ##
 File path: src/tests/containerizer/composing_containerizer_tests.cpp
 ##
 @@ -57,6 +57,32 @@ namespace tests {
 
 class ComposingContainerizerTest : public MesosTest {};
 
+TEST_F(ComposingContainerizerTest, FailsOnContainerInfoTypeMismatch)
 
 Review comment:
   After discussion with Benno I moved the validation to master. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko commented on a change in pull request #326: MESOS-6874: Validate 
the match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r265196258
 
 

 ##
 File path: src/slave/containerizer/composing.cpp
 ##
 @@ -425,6 +425,28 @@ Future 
ComposingContainerizerProcess::_launch(
 }
 
 
+static Try validateContainerInfoType(const ContainerInfo& info)
 
 Review comment:
   Converted this into a templated helper.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213665
---



Patch looks great!

Reviews applied: [70061, 70062, 70069, 70063, 70148, 70149, 70150, 70151, 
70152, 70201]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 12, 2019, 7:13 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> ---
> 
> (Updated March 12, 2019, 7:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added tests.
> 
> 
> Diffs
> -
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
>   src/tests/resource_quantities_tests.cpp 
> 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70201/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70161: Added validation for `QuotaConfig`.

[Meng Zhu]

> On March 8, 2019, 9:45 a.m., Benjamin Mahler wrote:
> > src/master/quota.cpp
> > Lines 328-331 (patched)
> > 
> >
> > Maybe also check isnormal?

Checked as part of the input scalar validation.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70161/#review213567
---


On March 12, 2019, 11:41 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70161/
> ---
> 
> (Updated March 12, 2019, 11:41 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
> https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A `QuotaConfig` is valid if the following conditions are met:
> 
>  (1) The config has a valid non-"*" role.
> 
>  (2) Resource scalar values are non-negative and finite.
> 
>  (3) If both guarantees and limits are set for a particular
>  resource, then guarantee <= limit for that resource.
> 
> 
> Diffs
> -
> 
>   src/master/quota.hpp 5cd2bb0e8669ee0290a4c1fe1058b87251772939 
>   src/master/quota.cpp 671626c01ada595d7557d5266e39a17cce243b94 
> 
> 
> Diff: https://reviews.apache.org/r/70161/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> dedicated test added in subsequent patches
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70203/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9596
https://issues.apache.org/jira/browse/MESOS-9596


Repository: mesos


Description
---

Updated a test for `UPDATE_QUOTA` call validation.


Diffs
-

  src/tests/master_validation_tests.cpp 
9568d39accb00eec68b622fdc7f02249fefbc063 


Diff: https://reviews.apache.org/r/70203/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 70202: Added call handler for `UPDATE_QUOTA`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70202/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9596
https://issues.apache.org/jira/browse/MESOS-9596


Repository: mesos


Description
---

The current implementation is incomplete and only does call
validation. It returns 501 `NOT_IMPLEMENTED`.

Further work includes authorization and actual enforcement
of the quota in the allocator.


Diffs
-

  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/quota_handler.cpp 8d417a9b2a2fa0d83d98d65167adfada2994f75c 


Diff: https://reviews.apache.org/r/70202/diff/1/


Testing
---

make check
dedicated test added in subsequent patches


Thanks,

Meng Zhu

Re: Review Request 70161: Added validation for `QuotaConfig`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70161/
---

(Updated March 12, 2019, 11:41 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Addressed Ben's comment.


Bugs: MESOS-9596
https://issues.apache.org/jira/browse/MESOS-9596


Repository: mesos


Description
---

A `QuotaConfig` is valid if the following conditions are met:

 (1) The config has a valid non-"*" role.

 (2) Resource scalar values are non-negative and finite.

 (3) If both guarantees and limits are set for a particular
 resource, then guarantee <= limit for that resource.


Diffs (updated)
-

  src/master/quota.hpp 5cd2bb0e8669ee0290a4c1fe1058b87251772939 
  src/master/quota.cpp 671626c01ada595d7557d5266e39a17cce243b94 


Diff: https://reviews.apache.org/r/70161/diff/2/

Changes: https://reviews.apache.org/r/70161/diff/1-2/


Testing
---

make check
dedicated test added in subsequent patches


Thanks,

Meng Zhu