Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70165/#review213771
---



Thanks for the fixes, this looks good now.

I raised an issue about a possible race where the framework would never see the 
expected offer. Like you explained to me offline, this is an issue with other 
tests following the same pattern as well. @chhsia0, can you see how this could 
be fixed in general? Added another flaky test doesn't sound good to me.


src/resource_provider/manager.cpp
Line 512 (original), 525-526 (patched)


Nit:
```
<< " to resource provider " << resourceProviderId.get()
<< ": connection closed";
```



src/tests/storage_local_resource_provider_tests.cpp
Lines 5480 (patched)


Thanks for adding these, I think the tests very well now.



src/tests/storage_local_resource_provider_tests.cpp
Lines 5496 (patched)


Even though above we wait for the second `UpdateSlaveMessage` we might 
still never get the offers we expect here.

I was able to break this test with `stress-ng` in less than 100 iterations. 
/cc @chun


- Benjamin Bannier


On March 11, 2019, 10:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70165/
> ---
> 
> (Updated March 11, 2019, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9612
> https://issues.apache.org/jira/browse/MESOS-9612
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The resource provider manager didn't allow operations originating from
> operator API calls. For speculatively applied operations, this is
> allowed now.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70165/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

[GitHub] [mesos] asekretenko commented on issue #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko commented on issue #326: MESOS-6874: Validate the match between 
Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#issuecomment-473894061
 
 
   Test results from CI:
   
   Configuration Name | Duration | All | Failed | Skipped
   -- | -- | -- | -- | --
   FLAG=Plain,label=mesos-ec2-ubuntu-16.04 | 18 min | 3312 | 0 | 0
   FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 | 5.4 sec | 607 | 0 | 0
   FLAG=CMake,label=mesos-ec2-centos-7 | 22 min | 3256 | 0 | 0
   FLAG=SSL,label=mesos-ec2-centos-6 | 23 sec | 677 | 1 | 0
   FLAG=SSL,label=mesos-ec2-debian-9 | 16 min | 3297 | 0 | 0
   FLAG=CMake,label=mesos-ec2-ubuntu-16.04 | 19 min | 3265 | 0 | 0
   FLAG=Clang,label=mesos-ec2-ubuntu-16.04 | 18 min | 3312 | 0 | 0
   FLAG=SSL,label=mesos-ec2-ubuntu-16.04 | 18 min | 3383 | 0 | 0
   FLAG=SSL,label=mesos-ec2-centos-7 | 20 min | 3381 | 0 | 0
   FLAG=SSL,label=mesos-ec2-debian-8 | 20 min | 3379 | 0 | 0
   FLAG=SSL,label=mesos-ec2-ubuntu-14.04 | 19 min | 3382 | 0 | 0
   FLAG=SSL,label=mac | 9 min 19 sec | 2775 | 0 | 0
   FLAG=Plain,label=mesos-ec2-centos-7 | 20 min | 3303 | 0 | 0
   
   centos-7 seems to have failed due to some completely unrelated problem:
   
   > 19:22:48 ../../3rdparty/libprocess/include/process/gmock.hpp:247: ERROR: 
this mock object (used in test SlaveTest.MetricsSlaveLaunchErrors) should be 
deleted but never is. Its address is @0x56279ea978e8.
   19:22:48 ../../src/tests/mock_registrar.cpp:54: ERROR: this mock object 
(used in test SlaveTest.MetricsSlaveLaunchErrors) should be deleted but never 
is. Its address is @0x56279eb0d9f0.
   19:22:48 ../../src/tests/containerizer.cpp:387: ERROR: this mock object 
(used in test SlaveTest.MetricsSlaveLaunchErrors) should be deleted but never 
is. Its address is @0x7ffd372b1220.
   19:22:48 ../../src/tests/slave_tests.cpp:1400: ERROR: this mock object (used 
in test SlaveTest.MetricsSlaveLaunchErrors) should be deleted but never is. Its 
address is @0x7ffd372b16c0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] asekretenko closed pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko closed pull request #326: MESOS-6874: Validate the match between 
Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] asekretenko opened a new pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko opened a new pull request #326: MESOS-6874: Validate the match 
between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326
 
 
   To avoid situations like described in 
[MESOS-6874](https://issues.apache.org/jira/browse/MESOS-6874), I'm clarifying 
the validity criteria for the `ContainerInfo` protobuf and adding validation of 
this protobuf into the ComposingContainerizer.
   
   There basically has been three ways to validate this protobuf:
   1. hardcoded check
   2. labelling all the *Infos with protobuf options and use some protobuf 
reflection
   3. require exact match between the Type enum members and the *Info fields, 
and use a bit more reflection.
   
   Hardcoded check will not "scale well" in case more container types are 
added. Protobuf options are not a good option in our case (mesos.proto 
constututes a part of an external interface and adding an option there would 
require to register it globally). That's why I opted for the third option.
   
   I'm also adding a test for this validation: passing ContainerInfo with 
Type==MESOS and docker set should make the ComposingContainerizer fail.
   
   After adding this validation I discovered an invalid ContainerInfo used in 
the test DefaultExecutorWithDockerImageCommandHealthCheck. This PR contains a 
fix for this test.
   
   Testing done:
   - run make check after adding the test only: test expectedly fails
   - run make check after adding validation code and fixing the problem with 
the health check  test: tests pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Review Request 70230: Made volume gid manager not handle non-shared PV.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/
---

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-9641
https://issues.apache.org/jira/browse/MESOS-9641


Repository: mesos


Description
---

This patch reverts the following 3 patches which made volume gid manager
allocate & deallocate gid to non-shared PV.
  https://reviews.apache.org/r/70137/
  https://reviews.apache.org/r/70139/
  https://reviews.apache.org/r/70140/

We want to keep the original behavior of non-shared PV, i.e., change its
owner to the task user, so that the task can fully control the volume,
i.e., the task can not only access the volume but also change its
metadata like changing the permissions of the volume (`chmod`).


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
dbf149ad9c8fb900bb3b56f6e90b3a8643097d25 
  src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
60e9ae5970a0a45314d0b3569556bef36d350d2b 
  src/tests/persistent_volume_tests.cpp 
7e929a5a3a92e16a5dec10206f37caebc20d66a8 


Diff: https://reviews.apache.org/r/70230/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 70230: Made volume gid manager not handle non-shared PV.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213775
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70230']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2974/mesos-review-70230

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2974/mesos-review-70230/logs/mesos-tests.log):

```

I0318 14:44:44.174928 20968 executor.cpp:1027] Command exited with status 0 
(pid: 20220)
I0318 14:44:45.177696 20196 process.cpp:927] Stopped the socket accept loop
W0318 14:44:45.179706 20196 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed 
with error code: The remote computer refused the network connection.

14:37:36.087920 16952 exec.cpp:518] Agent exited, but framework has 
checkpointing enabled. Waiting 15mins to reconnect with agent 
91d24ac5-4ae1-4ca8-9ae7-f496c2fec447-S0
I0318 14:46:24.347802 13332 executor.cpp:1027] Command exited with status 0 
(pid: 21164)
I0318 14:46:25.352614 10744 process.cpp:927] Stopped the socket accept loop
.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=396 to peer 
'192.10.1.6:54191': IO failed with error code: The specified network name is no 
longer available.

I0318 14:47:06.878350 12912 executor.cpp:1027] Command exited with status 0 
(pid: 15008)
I0318 14:47:07.883435 18168 process.cpp:927] Stopped the socket accept loop
W0318 14:47:07.883435 18168 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed 
with error code: The remote computer refused the network connection.

4:37:36.087920 15832 exec.cpp:518] Agent exited, but framework has 
checkpointing enabled. Waiting 15mins to reconnect with agent 
a2d17922-91c2-4d97-b6cc-1c1414f1d709-S0
I0318 14:47:48.735365 15832 executor.cpp:1027] Command exited with status 0 
(pid: 8188)
I0318 14:47:49.739440 18712 process.cpp:927] Stopped the socket accept loop
W0318 14:47:49.740430 18712 process.cpp:1890] Failed to send 
'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed 
with error code: The remote computer refused the network connection.

I0318 14:52:36.143553 16700 executor.cpp:568] Recovery timeout of 15mins 
exceeded; Shutting down
I0318 14:52:36.143553  8760 executor.cpp:568] Recovery timeout of 15mins 
exceeded; Shutting down
I0318 14:52:36.144632 21048 default_executor.cpp:204] Received SHUTDOWN event
I0318 14:52:36.144632  4688 default_executor.cpp:204] Received SHUTDOWN event
I0318 14:52:36.144632 21048 default_executor.cpp:1025] Shutting down
I0318 14:52:36.144632  4688 default_executor.cpp:1025] Shutting down
I0318 14:52:36.144632 21048 default_executor.cpp:1081] Terminating after 1secs
I0318 14:52:36.144632  4688 default_executor.cpp:1081] Terminating after 1secs
I0318 14:52:37.148291 19188 process.cpp:927] Stopped the socket accept loop
I0318 14:52:37.148291 14748 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 18, 2019, 9:30 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> ---
> 
> (Updated March 18, 2019, 9:30 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
>   https://reviews.apache.org/r/70137/
>   https://reviews.apache.org/r/70139/
>   https://reviews.apache.org/r/70140/
> 
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> dbf149ad9c8fb900bb3b56f6e90b3a8643097d25 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 60e9ae5970a0a45314d0b3569556bef36d350d2b 
>   src/tests/persistent_volume_tests.cpp 
> 7e929a5a3a92e16a5dec10206f37caebc20d66a8 
> 
> 
> Diff: https://reviews.apache.org/r/70230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

asekretenko commented on a change in pull request #326: MESOS-6874: Validate 
the match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266492065
 
 

 ##
 File path: src/common/protobuf_utils.hpp
 ##
 @@ -64,6 +64,63 @@ struct Slave;
 
 namespace protobuf {
 
+//
+// A "protobuf union" is a protobuf message
+// which has an enum named "Type" defined in its scope,
+// a required field named "type" of a "Type" type
+// and a field corresponding to each member of the "Type" enum.
+//
+// A valid "protobuf union" should satisfy the following requirements.
+// 1. A member of the Type enum with a number (not index!) of 0,
+//if there is any, should be named "UNKNOWN".
+// 2. For each other member of the Type enum there should be an optional field
+//in the message with an exactly matching name in lowercase.
+// 3. The fields that correspond to members of the Type enum other than
+//message.type(), should not be set.
+//
+// NOTE: If possible, oneof should be used in the new messages instead
+// of the "protobuf union".
+//
+class UnionValidatorHelper
+{
+public:
+  UnionValidatorHelper(
+  const google::protobuf::Descriptor*,
+  const google::protobuf::EnumDescriptor*);
+
+  Option Validate(
+  const int messageTypeNumber, const google::protobuf::Message&) const;
+
+private:
+  std::vector>
+UnionFieldDescriptors;
+  const google::protobuf::EnumDescriptor* TypeDescriptor;
+};
+
+
+template 
+class UnionValidator
+{
+public:
+  static Option Validate(const Message& message)
+  {
+static const UnionValidatorHelper helper(
 
 Review comment:
   Exactly. We do not need this class at all. Moved and renamed, as you 
suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70230: Made volume gid manager not handle non-shared PV.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213778
---



Patch looks great!

Reviews applied: [70230]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 18, 2019, 1:30 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> ---
> 
> (Updated March 18, 2019, 1:30 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
>   https://reviews.apache.org/r/70137/
>   https://reviews.apache.org/r/70139/
>   https://reviews.apache.org/r/70140/
> 
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> dbf149ad9c8fb900bb3b56f6e90b3a8643097d25 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 60e9ae5970a0a45314d0b3569556bef36d350d2b 
>   src/tests/persistent_volume_tests.cpp 
> 7e929a5a3a92e16a5dec10206f37caebc20d66a8 
> 
> 
> Diff: https://reviews.apache.org/r/70230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 70232: Fixed an agent crash bug when SLRP recovers dropped operations.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/
---

Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.


Bugs: MESOS-9661
https://issues.apache.org/jira/browse/MESOS-9661


Repository: mesos


Description
---

Fixed an agent crash bug when SLRP recovers dropped operations.


Diffs
-

  src/resource_provider/storage/provider.cpp 
fea623c292158deb1b4b4b9ab1ac208031471519 


Diff: https://reviews.apache.org/r/70232/diff/1/


Testing
---

`make check`


Thanks,

Chun-Hung Hsiao

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the 
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266581027
 
 

 ##
 File path: src/common/protobuf_utils.hpp
 ##
 @@ -64,6 +64,53 @@ struct Slave;
 
 namespace protobuf {
 
+//
+// A "protobuf union" is a protobuf message
+// which has an enum named "Type" defined in its scope,
+// a required field named "type" of a "Type" type
+// and a field corresponding to each member of the "Type" enum.
+//
+// A valid "protobuf union" should satisfy the following requirements.
+// 1. A member of the Type enum with a number (not index!) of 0,
+//if there is any, should be named "UNKNOWN".
+// 2. For each other member of the Type enum there should be an optional field
+//in the message with an exactly matching name in lowercase.
+// 3. The fields that correspond to members of the Type enum other than
+//message.type(), should not be set.
+//
+// NOTE: If possible, oneof should be used in the new messages instead
+// of the "protobuf union".
+//
+class UnionValidator
+{
+public:
+  UnionValidator(
+  const google::protobuf::Descriptor*,
+  const google::protobuf::EnumDescriptor*);
+
+  Option validate(
+  const int messageTypeNumber, const google::protobuf::Message&) const;
+
+private:
+  std::vector>
+unionFieldDescriptors_;
+  const google::protobuf::EnumDescriptor* typeDescriptor_;
+};
+
+
+// This function returns Error if the protobuf union is not valid
+// and Nothing otherwise.
+// In case MessageWithUnion is not a protobuf union,
+// this function will abort the process on the first use.
+template 
+Option validateProtobufUnion(const MessageWithUnion& message)
 
 Review comment:
   This might be easy to miss from reading the implementation:
   ```
   // NOTE: A protobuf union is only invalid when unexpected member fields are 
set.
   // It is valid when all members of a protobuf union are empty.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the 
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266577009
 
 

 ##
 File path: src/common/protobuf_utils.cpp
 ##
 @@ -77,6 +77,56 @@ namespace mesos {
 namespace internal {
 namespace protobuf {
 
+
+UnionValidator::UnionValidator(
+  const google::protobuf::Descriptor* descriptor,
+  const google::protobuf::EnumDescriptor* typeDescriptor)
+{
+  typeDescriptor_ = typeDescriptor;
+  const auto* unknownTypeValueDescriptor = 
typeDescriptor->FindValueByNumber(0);
 
 Review comment:
   Consider leaving a newline after `typeDescriptor_ = typeDescriptor;` and 
inserting a short comment after this section, i.e.:
   ```
   // If present, the the `0` value of the `Type` enum must be named "UNKNOWN".
   const auto* unknownTypeValueDescriptor = 
typeDescriptor->FindValueByNumber(0);
   ...
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

[GitBox]

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the 
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266586290
 
 

 ##
 File path: src/common/protobuf_utils.hpp
 ##
 @@ -64,6 +64,53 @@ struct Slave;
 
 namespace protobuf {
 
+//
+// A "protobuf union" is a protobuf message
+// which has an enum named "Type" defined in its scope,
+// a required field named "type" of a "Type" type
+// and a field corresponding to each member of the "Type" enum.
+//
+// A valid "protobuf union" should satisfy the following requirements.
+// 1. A member of the Type enum with a number (not index!) of 0,
+//if there is any, should be named "UNKNOWN".
+// 2. For each other member of the Type enum there should be an optional field
+//in the message with an exactly matching name in lowercase.
+// 3. The fields that correspond to members of the Type enum other than
+//message.type(), should not be set.
+//
+// NOTE: If possible, oneof should be used in the new messages instead
+// of the "protobuf union".
+//
+class UnionValidator
+{
+public:
+  UnionValidator(
+  const google::protobuf::Descriptor*,
+  const google::protobuf::EnumDescriptor*);
+
+  Option validate(
+  const int messageTypeNumber, const google::protobuf::Message&) const;
+
+private:
+  std::vector>
+unionFieldDescriptors_;
+  const google::protobuf::EnumDescriptor* typeDescriptor_;
+};
+
+
+// This function returns Error if the protobuf union is not valid
+// and Nothing otherwise.
+// In case MessageWithUnion is not a protobuf union,
+// this function will abort the process on the first use.
+template 
+Option validateProtobufUnion(const MessageWithUnion& message)
+{
+  static const UnionValidator validator(
+  MessageWithUnion::descriptor(), MessageWithUnion::Type_descriptor());
 
 Review comment:
   Looking at this again, arriving at a `google::protobuf::EnumDescriptor` for 
the second argument can be easily missed, especially for those unfamiliar with 
protobuf generated code.  A note like this might help:
   ```
   // NOTE: The `::Type_descriptor()` method is a protobuf generated method 
corresponding
   // to the `Type` field of the given protobuf.  We expect this to be an enum 
field.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers dropped operations.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213779
---


Ship it!




Ship It!

- Benjamin Bannier


On March 18, 2019, 7:20 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> ---
> 
> (Updated March 18, 2019, 7:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an agent crash bug when SLRP recovers dropped operations.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> fea623c292158deb1b4b4b9ab1ac208031471519 
> 
> 
> Diff: https://reviews.apache.org/r/70232/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers dropped operations.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213782
---



PASS: Mesos patch 70232 was successfully built and tested.

Reviews applied: `['70232']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2975/mesos-review-70232

- Mesos Reviewbot Windows


On March 18, 2019, 11:20 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> ---
> 
> (Updated March 18, 2019, 11:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an agent crash bug when SLRP recovers dropped operations.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> fea623c292158deb1b4b4b9ab1ac208031471519 
> 
> 
> Diff: https://reviews.apache.org/r/70232/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers dropped operations.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213783
---



Patch looks great!

Reviews applied: [70232]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 18, 2019, 11:20 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> ---
> 
> (Updated March 18, 2019, 11:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an agent crash bug when SLRP recovers dropped operations.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> fea623c292158deb1b4b4b9ab1ac208031471519 
> 
> 
> Diff: https://reviews.apache.org/r/70232/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70203/#review213784
---



FAIL: Failed to apply the dependent review: 70061.

Failed command: `python.exe .\support\apply-reviews.py -n -r 70061`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2976/mesos-review-70203

Relevant logs:

- 
[apply-review-70061.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2976/mesos-review-70203/logs/apply-review-70061.log):

```
error: patch failed: src/common/resource_quantities.hpp:22
error: src/common/resource_quantities.hpp: patch does not apply
error: patch failed: src/tests/resource_quantities_tests.cpp:144
error: src/tests/resource_quantities_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On March 12, 2019, 11:46 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70203/
> ---
> 
> (Updated March 12, 2019, 11:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
> https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated a test for `UPDATE_QUOTA` call validation.
> 
> 
> Diffs
> -
> 
>   src/tests/master_validation_tests.cpp 
> 9568d39accb00eec68b622fdc7f02249fefbc063 
> 
> 
> Diff: https://reviews.apache.org/r/70203/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70230: Made volume gid manager not handle non-shared PV.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213785
---



Seems like this is not an optoin since then we have to read the mount table.

- Gilbert Song


On March 18, 2019, 6:30 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> ---
> 
> (Updated March 18, 2019, 6:30 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
>   https://reviews.apache.org/r/70137/
>   https://reviews.apache.org/r/70139/
>   https://reviews.apache.org/r/70140/
> 
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> dbf149ad9c8fb900bb3b56f6e90b3a8643097d25 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 60e9ae5970a0a45314d0b3569556bef36d350d2b 
>   src/tests/persistent_volume_tests.cpp 
> 7e929a5a3a92e16a5dec10206f37caebc20d66a8 
> 
> 
> Diff: https://reviews.apache.org/r/70230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662


Repository: mesos


Description
---

Allowed for optionally unbundled ZooKeeper for CMake builds.


Diffs
-

  3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
  3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 


Diff: https://reviews.apache.org/r/70233/diff/1/


Testing
---


Thanks,

Till Toenshoff

Review Request 70235: Fixed the persistent volume ownership to allow apps to chown.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/
---

Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian 
Zhang.


Repository: mesos


Description
---

Fixed the persistent volume ownership to allow apps to chown.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
341853a2df74f6ec3135e942b59a5da9d8f8460e 


Diff: https://reviews.apache.org/r/70235/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213786
---



PASS: Mesos patch 70233 was successfully built and tested.

Reviews applied: `['70233']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2977/mesos-review-70233

- Mesos Reviewbot Windows


On March 18, 2019, 2:32 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> ---
> 
> (Updated March 18, 2019, 2:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213787
---



Patch looks great!

Reviews applied: [70233]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 18, 2019, 9:32 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> ---
> 
> (Updated March 18, 2019, 9:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70235: Fixed the persistent volume ownership to allow apps to chown.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213788
---



Can you link a ticket to the bug and provide some brief description of the 
issue?

- Jie Yu


On March 18, 2019, 10:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> ---
> 
> (Updated March 18, 2019, 10:20 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian 
> Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the persistent volume ownership to allow apps to chown.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 341853a2df74f6ec3135e942b59a5da9d8f8460e 
> 
> 
> Diff: https://reviews.apache.org/r/70235/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
---

(Updated March 19, 2019, 12:03 a.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662


Repository: mesos


Description
---

Allowed for optionally unbundled ZooKeeper for CMake builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
  3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 


Diff: https://reviews.apache.org/r/70233/diff/2/

Changes: https://reviews.apache.org/r/70233/diff/1-2/


Testing
---


Thanks,

Till Toenshoff

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
---

(Updated March 19, 2019, 12:11 a.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662


Repository: mesos


Description
---

Allowed for optionally unbundled ZooKeeper for CMake builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
  3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 


Diff: https://reviews.apache.org/r/70233/diff/3/

Changes: https://reviews.apache.org/r/70233/diff/2-3/


Testing
---


Thanks,

Till Toenshoff

Re: Review Request 70235: Fixed the persistent volume ownership to allow apps to chown.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213789
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70235']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2978/mesos-review-70235

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2978/mesos-review-70235/logs/mesos-tests.log):

```
W0319 00:22:10.935292 22644 slave.cpp:3932] Ignoring shutdown framework 
78ebb5e8-abc9-4273-b0af-04e126844af1- because it is terminating
I0319 00:22:10.938289 19524 master.cpp:1295] Agent 
78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0319 00:22:10.938289 19524 master.cpp:3330] Disconnecting agent 
78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0319 00:22:10.938289 19524 master.cpp:3349] Deactivating agent 
78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0319 00:22:10.939296 22976 hierarchical.cpp:391] Removed framework 
78ebb5e8-abc9-4273-b0af-04e126844af1-
I0319 00:22:10.939296 22976 hierarchical.cpp:828] Agent 
78ebb5e8-abc9-4273-b0af-04e126844af1-S0 deactivated
I0319 00:22:10.939296 18580 containerizer.cpp:2576] Destroying container 
07d60320-f210-45bb-b935-3aeefeaeab54 in RUNNING state
I0319 00:22:10.939296 18580 containerizer.cpp:3278] Transitioning the state of 
container 07d60320-f210-45bb-b935-3aeefeaeab54 from RUNNING to DESTROYING
I0319 00:22:10.940289 18580 launcher.cpp:161] Asked to destroy container 
07d60320-f210-45bb-b935-3aeefeaeab54
W0319 00:22:10.941294 18052 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=10348 to peer '192.10.1.6:51006': IO failed with error 
code: The specified network name is no longer available.

W0319 00:22:10.941294 18052 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=10308 to peer '192.10.1.6:51007': IO failed with error 
code: The specified network name is no longer available.

I0319 00:2[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[--] Global test environment tear-down
[==] 1122 tests from 107 test cases ran. (503029 ms total)
[  PASSED  ] 1121 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

2:11.042927 19524 containerizer.cpp:3117] Container 
07d60320-f210-45bb-b935-3aeefeaeab54 has exited
I0319 00:22:11.071938 20296 master.cpp:1135] Master terminating
I0319 00:22:11.072906 18548 hierarchical.cpp:679] Removed agent 
78ebb5e8-abc9-4273-b0af-04e126844af1-S0
I0319 00:22:11.438617 18052 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 18, 2019, 3:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> ---
> 
> (Updated March 18, 2019, 3:20 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian 
> Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the persistent volume ownership to allow apps to chown.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 341853a2df74f6ec3135e942b59a5da9d8f8460e 
> 
> 
> Diff: https://reviews.apache.org/r/70235/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213790
---



PASS: Mesos patch 70233 was successfully built and tested.

Reviews applied: `['70233']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2979/mesos-review-70233

- Mesos Reviewbot Windows


On March 19, 2019, 12:11 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> ---
> 
> (Updated March 19, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213792
---



Patch looks great!

Reviews applied: [70233]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 19, 2019, 8:11 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> ---
> 
> (Updated March 19, 2019, 8:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 70235: Fixed the persistent volume ownership to allow apps to chown.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213798
---



Patch looks great!

Reviews applied: [70235]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 19, 2019, 6:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> ---
> 
> (Updated March 19, 2019, 6:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian 
> Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the persistent volume ownership to allow apps to chown.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 341853a2df74f6ec3135e942b59a5da9d8f8460e 
> 
> 
> Diff: https://reviews.apache.org/r/70235/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>