Re: Review Request 70587: Fixed unguarded calls to `Option::get()` in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70587/#review215051 --- Patch looks great! Reviews applied: [70587] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 2, 2019, 10 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70587/ > --- > > (Updated May 2, 2019, 10 p.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Till > Toenshoff. > > > Bugs: MESOS-9698 > https://issues.apache.org/jira/browse/MESOS-9698 > > > Repository: mesos > > > Description > --- > > This patch avoids making unguarded calls to `Option::get()` > in `Master::updateOperationStatus()`. During agent reregistration, it's > possible that a `ReregisterSlaveMessage` from the agent can race with a > `SlaveReregisteredMessage` from the master, leading to multiple rounds > of master/agent operation reconciliation. The duplicate operation status > updates which occur as a result would crash the master before this fix. > > > Diffs > - > > src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 > src/tests/agent_operation_feedback_tests.cpp > e427441b3ef702acf0fba52adf7ba027ea6bc508 > > > Diff: https://reviews.apache.org/r/70587/diff/1/ > > > Testing > --- > > `make check` > `bin/mesos-tests.sh --gtest_filter="*DroppedOperationDuplicateStatusUpdate*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
Re: Review Request 70595: Adds a regression test for MESOS-9766.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215050 --- Patch looks great! Reviews applied: [70594, 70595] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2019, 7:58 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70595/ > --- > > (Updated May 3, 2019, 7:58 p.m.) > > > Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao. > > > Bugs: MESOS-9766 > https://issues.apache.org/jira/browse/MESOS-9766 > > > Repository: mesos > > > Description > --- > > This test fails on master prior to applying the fix for MESOS-9766. > It attempts to ensure that processes are terminated after the > /__processes__ handler dispatches to them. > > > Diffs > - > > 3rdparty/libprocess/src/tests/process_tests.cpp > 60f3dd653153c2b2ccf9c3a7eae8c75fd6ff025c > > > Diff: https://reviews.apache.org/r/70595/diff/1/ > > > Testing > --- > > Ran in repetition, although it appears to consistently fail on master without > repetition needed. > > > Thanks, > > Benjamin Mahler > >
Re: Review Request 70596: Launched tasks with more memory in SLRP unit tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70596/#review215049 --- Patch looks great! Reviews applied: [70596] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2019, 9:09 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70596/ > --- > > (Updated May 3, 2019, 9:09 p.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9765 > https://issues.apache.org/jira/browse/MESOS-9765 > > > Repository: mesos > > > Description > --- > > Raised the task memory to 128MB (which are the value used in most persistent > volume tests) in all SLRP tests that launch tasks to avoid OOM. > > > Diffs > - > > src/tests/storage_local_resource_provider_tests.cpp > ecd7aeef1cb3d1a5b4b3419dfd912d41a8c6 > > > Diff: https://reviews.apache.org/r/70596/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 70573: Updated bintray upload scripts to remove hard-coded accounts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70573/#review215048 --- Patch looks great! Reviews applied: [70573] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2019, 7:48 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70573/ > --- > > (Updated May 3, 2019, 7:48 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9697 > https://issues.apache.org/jira/browse/MESOS-9697 > > > Repository: mesos > > > Description > --- > > This updates the Jenkinsfile used in the ASF Jenkins as well > as the associated upload script for bintray to make the > used credential id configurable and to upload the built packages > to the official `apache/mesos` bintray account. > > > Diffs > - > > support/packaging/Jenkinsfile 7446b2b8b88df6c146f4415b06dda227ca8ce631 > support/packaging/bintray.sh 4f1795f14b078e8eebe95aaa40cf860d6d19ee97 > > > Diff: https://reviews.apache.org/r/70573/diff/1/ > > > Testing > --- > > Not sure how to test jenkins pipelines :/ > > > Thanks, > > Benno Evers > >
Re: Review Request 70591: Introduced struct RoleInfo to track reservations and framework IDs in one map.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215047 --- Patch looks great! Reviews applied: [70591] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2019, 3:50 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70591/ > --- > > (Updated May 3, 2019, 3:50 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9701 > https://issues.apache.org/jira/browse/MESOS-9701 > > > Repository: mesos > > > Description > --- > > This patch introduces `struct RoleInfo` which contains the framework IDs and > reservations tied to the role and replaces `roles` and > `reservationScalarQuantities` hashmaps with `hashmap`. > > I personally do not like the name `RoleInfo` and would appreciate any better > naming ideas. > However, naming this entity `Role` would have been even worse: it would imply > using `const Role& role` throughout the code, which would require changing > all the places which use `std::string role` as a key... > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > c2058baca5159da4cdcab77afd5de3c0d5ae6c48 > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70591/diff/1/ > > > Testing > --- > > make check > > Benchmarking: 5 runs of > `BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5` with > the optimized build. > > Performance impact in this benchmark seems to be negligible. > > BEFORE: > Added 3000 agents in 51.553929ms > Added 3000 frameworks in 15.174748344secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.400805171secs > Made 0 allocation in 12.5850238secs > > Added 3000 agents in 55.739336ms > Added 3000 frameworks in 14.730404769secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.563439682secs > Made 0 allocation in 13.063555055secs > > Added 3000 agents in 54.414733ms > Added 3000 frameworks in 15.10136842secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 13.501664915secs > Made 0 allocation in 12.89034382secs > > Added 3000 agents in 52.58252ms > Added 3000 frameworks in 14.048350298secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.299952145secs > Made 0 allocation in 11.888248811secs > > Added 3000 agents in 52.821439ms > Added 3000 frameworks in 15.344450583secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.63425secs > Made 0 allocation in 12.427171541secs > > > AFTER: > > Added 3000 agents in 69.716648ms > Added 3000 frameworks in 15.249001979secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.860494226secs > Made 0 allocation in 12.228866329secs > > Added 3000 agents in 52.639388ms > Added 3000 frameworks in 15.207895482secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.504777266secs > Made 0 allocation in 12.70388062secs > > Added 3000 agents in 56.865794ms > Added 3000 frameworks in 15.284003915secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 13.86859815secs > Made 0 allocation in 12.538958231secs > > Added 3000 agents in 56.028013ms > Added 3000 frameworks in 13.892577869secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.341724418secs > Made 0 allocation in 12.23022189secs > > Added 3000 agents in 52.368219ms > Added 3000 frameworks in 13.978581104secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 12.701682501secs > Made 0 allocation in 12.141360313secs > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 70589: Logged when `/__processes__` returns.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70589/#review215046 --- Patch looks great! Reviews applied: [70589] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2019, 11:27 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70589/ > --- > > (Updated May 3, 2019, 11:27 a.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Adds a log entry when a response with generated by `/__processes__` > is about to be returned to the client. > > > Diffs > - > > 3rdparty/libprocess/src/process.cpp > 124836472313721a5dbfe4b1ca55f0da3cecd66b > > > Diff: https://reviews.apache.org/r/70589/diff/1/ > > > Testing > --- > > built & run on Mac OS 10.13.6 > > ``` > I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for > process '__processes__' with path: '/__processes__' > I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ > from 192.168.178.47:59548: '200 OK' after 1.06214ms > ``` > > > Thanks, > > Alexander Rukletsov > >
