Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70712/
---

Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-9769
https://issues.apache.org/jira/browse/MESOS-9769


Repository: mesos


Description
---

The `filesystem/linux` isolator was using pre-exec commands
to set up Linux ABI symlinks. Not only is this inefficient,
it has the undesirable security property of running programs
in a user-controlled container image.

The fix added a new `ContainerFileOperation` message to the
containerizer launch information. The containerizer executes
the requested file operation after performing the container
mounts.


Diffs
-

  include/mesos/slave/containerizer.proto 
e9924489000efabebd55bf070f18149f23e4a510 
  src/common/protobuf_utils.hpp 273ae270695db33b6c9d8b32cb38f8840a815787 
  src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
8f94453a7354927ae918d3f2fd746cdf5ef63cb7 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
190054c26b949aa9ba0f49377b77d9e472edb95a 
  src/slave/containerizer/mesos/launch.cpp 
5ddb4c7d998c17b59164825acc0627a1311b691b 


Diff: https://reviews.apache.org/r/70712/diff/1/


Testing
---

sudo make check (Fedora 30)


Thanks,

James Peach

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215492
---



Patch looks great!

Reviews applied: [70702, 70651]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2019, 4:17 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 23, 2019, 4:17 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
>   src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70678: Add containerizer support for masking paths.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70678/#review215491
---


Ship it!




Ship It!

- Jason Lai


On May 22, 2019, 8:25 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70678/
> ---
> 
> (Updated May 22, 2019, 8:25 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-9771
> https://issues.apache.org/jira/browse/MESOS-9771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add support to the `filesystem/linux` isolator for masking container
> paths. Add a set of standard default paths to be masked, as derived
> from commonly used container runtimes. These paths either expose
> information about other system processes, or capabilities that
> should not be exposed to untrusted containers.
> 
> We don't mask if the container is privileged, which is defined
> as sharing the host's PID namespace. For nested containers, we
> verify that the PID namespace is shared from the host all the way
> up the tree.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 48ffa2e6bd1a03f3dc68a3a78d883855f14bf10c 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
>   src/slave/containerizer/mesos/launch.cpp 
> 88b97a572916defbe65692036be77395053eb8e8 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 60e9ae5970a0a45314d0b3569556bef36d350d2b 
>   src/tests/containerizer/rootfs.cpp 48eb0108cf26729a0528528a1102247410cf80fe 
> 
> 
> Diff: https://reviews.apache.org/r/70678/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 70678: Add containerizer support for masking paths.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70678/#review215489
---


Ship it!




Ship It!

- Gilbert Song


On May 22, 2019, 1:25 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70678/
> ---
> 
> (Updated May 22, 2019, 1:25 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-9771
> https://issues.apache.org/jira/browse/MESOS-9771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add support to the `filesystem/linux` isolator for masking container
> paths. Add a set of standard default paths to be masked, as derived
> from commonly used container runtimes. These paths either expose
> information about other system processes, or capabilities that
> should not be exposed to untrusted containers.
> 
> We don't mask if the container is privileged, which is defined
> as sharing the host's PID namespace. For nested containers, we
> verify that the PID namespace is shared from the host all the way
> up the tree.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 48ffa2e6bd1a03f3dc68a3a78d883855f14bf10c 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 
>   src/slave/containerizer/mesos/launch.cpp 
> 88b97a572916defbe65692036be77395053eb8e8 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 60e9ae5970a0a45314d0b3569556bef36d350d2b 
>   src/tests/containerizer/rootfs.cpp 48eb0108cf26729a0528528a1102247410cf80fe 
> 
> 
> Diff: https://reviews.apache.org/r/70678/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 70707: Refactored role quota info into `Struct Role`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70707/#review215488
---



Patch looks great!

Reviews applied: [70705, 70706, 70707]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2019, 2:48 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70707/
> ---
> 
> (Updated May 23, 2019, 2:48 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This avoids an extra map of tracking role quota info.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7e4f30d16010a777ff29ba35366ae80ff2631322 
>   src/master/allocator/mesos/hierarchical.cpp 
> ccca391fbf73d9aa9c31f7552e39fb78c242e242 
> 
> 
> Diff: https://reviews.apache.org/r/70707/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

[GitHub] [mesos] lava commented on issue #335: Return early in fetcher if no uris are specified.

[GitBox]

lava commented on issue #335: Return early in fetcher if no uris are specified.
URL: https://github.com/apache/mesos/pull/335#issuecomment-495281497
 
 
   Hey @carlonelong , 
   
   thanks for contributing!
   
   Your patch looks reasonable to me, however when I ran it through our CI it 
seemed to break a few unit tests, in particular:
   
   Test Name | Duration | Age
   -- | -- | --
   
mesos-ec2-ubuntu-16.04-SSL.Mesos.DockerContainerizerTest.ROOT_DOCKER_UNPRIVILEGED_USER_NonRootSandbox
 | 6 sec | 1
   
mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerExecuteTest.ROOT_UNPRIVILEGED_USER_SandboxFileOwnership
 | 0.1 sec | 1
   
mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerDestroyTest.DestroyWhileFetching
 | 15 sec | 1
   mesos-ec2-ubuntu-16.04-SSL.Mesos.ProvisionerDockerTest.ROOT_INTER
   
   (and the same for debian9, centos6/7, ubuntu 14.04, etc.)
   
   I did not have the time to investigate what exactly is causing these tests 
to fail, but I think this will need to be investigated before we can commit the 
patch.
   
   Best regards,
   Benno


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Review Request 70707: Refactored role quota info into `Struct Role`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70707/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

This avoids an extra map of tracking role quota info.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
7e4f30d16010a777ff29ba35366ae80ff2631322 
  src/master/allocator/mesos/hierarchical.cpp 
ccca391fbf73d9aa9c31f7552e39fb78c242e242 


Diff: https://reviews.apache.org/r/70707/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 70705: Added comment regarding tracking role consumed quota.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70705/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

Added comment regarding tracking role consumed quota.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
ccca391fbf73d9aa9c31f7552e39fb78c242e242 


Diff: https://reviews.apache.org/r/70705/diff/1/


Testing
---

M/A


Thanks,

Meng Zhu

Review Request 70706: Clarified a comment regarding role `reservationScalarQuantities`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70706/
---

Review request for mesos and Andrei Sekretenko.


Repository: mesos


Description
---

Clarified a comment regarding role `reservationScalarQuantities`.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
7e4f30d16010a777ff29ba35366ae80ff2631322 


Diff: https://reviews.apache.org/r/70706/diff/1/


Testing
---

N/A


Thanks,

Meng Zhu

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

[Meng Zhu]

> On May 23, 2019, 4:23 a.m., Alexander Rukletsov wrote:
> > include/mesos/authorizer/authorizer.proto
> > Lines 149-150 (patched)
> > 
> >
> > I would like us to challenge the necessity of passing `QuotaConfig` 
> > here. The built-in authorizer only looks at `role`, ignoring any 
> > information about resources. One might say that a custom authorizer might 
> > utilize that extra information, however, that extra information might not 
> > be enough to make a decision, because it does not include the current state 
> > or the state change, e.g., resource delta.
> > 
> > Imagine an authorizer that allows decreasing quota for a number of 
> > principals, but only a few are allowed to increase. Passing `QuotaConfig` 
> > does not really help that authorizer to make a decision. Note that 
> > authorizer cannot tract previous requests to deduce the current quota state 
> > because previous request could have been dropped after successful 
> > authorization.
> > 
> > I tend to keep it simple and use just the role. We should consult Till 
> > Tönshoff and Jan-Philip Gehrcke as maintainers of DC/OS authorizer for more 
> > input.

Thanks for the comment.

Yes, the two authorizers that I am aware of only looks into the role field.

I choose to pass `QuotaConfig` mainly to try to be parity with the legacy 
`QuotaInfo`, i.e. pass info regarding the requested quota setting.

For your example of needing more information (e.g. to also pass a role's 
current old quota config), I think if that need ever arise, we could add 
another optional object field. The Object message states that 
(https://github.com/apache/mesos/blob/a8c411d3f8d2895ff5e95c412ef2f3e94713520f/include/mesos/authorizer/authorizer.proto#L40-L46)

> An `Object` has a number of optional fields of which depending on the action, 
> one or more fields must be set.

So we can use that as a wrapper for adding extra fields if needed.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70549/#review215484
---


On May 22, 2019, 5:48 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70549/
> ---
> 
> (Updated May 22, 2019, 5:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, and 
> Benjamin Mahler.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new authorizable action `UPDATE_QUOTA_WITH_CONFIG` is added.
> This disambiguates with the old action `UPDATE_QUOTA` which
> are used for the old `SetQuota` and `RemoveQuota` calls.
> `UPDATE_QUOTA` action requires `QuotaInfo` as the object while
> the new `UpdatedQuota` call uses `QuotaConfig`. To keep it compatible
> with any external authorization modules, a new action  is introduced.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> e2740c402732bb37db991ec92b9301e58b33215b 
>   src/master/master.hpp 5ad128d00d3cdf0dca89eb637ae196987bdce412 
>   src/master/quota_handler.cpp a18d8bafda5604d1844f7f7ed31d4ea80fbf6d04 
>   src/tests/master_authorization_tests.cpp 
> ee69910a34416728bf14ed23f4a6faae6c1204a0 
> 
> 
> Diff: https://reviews.apache.org/r/70549/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70589: Logged when `/__processes__` returns.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/#review215486
---



Patch looks great!

Reviews applied: [70589]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2019, 10:59 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70589/
> ---
> 
> (Updated May 23, 2019, 10:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-9766
> https://issues.apache.org/jira/browse/MESOS-9766
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a log entry when a response with generated by `/__processes__`
> is about to be returned to the client.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> a47b5709095665bbe6141b7531b956aeb911d04a 
> 
> 
> Diff: https://reviews.apache.org/r/70589/diff/2/
> 
> 
> Testing
> ---
> 
> built & run on Mac OS 10.13.6
> 
> ```
> I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for 
> process '__processes__' with path: '/__processes__'
> I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ 
> from 192.168.178.47:59548: '200 OK' after 1.06214ms
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

[Andrei Sekretenko]

> On May 22, 2019, 7:52 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 3172-3173 (patched)
> > 
> >
> > This is undefined behavior (and may crash, this has caught me before), 
> > because `call` is moved in the same expression as the 
> > `call.framework_info()` is touched, and C++ doesn't not guarantee the order 
> > of evaluation.
> > 
> > We have to split it out:
> > 
> > ```
> >   Future authorized = authorizeFramework(call.framework_info());
> >   
> >   return authorized
> > .then(defer(self(), &Self::_updateFramework, std::move(call), 
> > lambda::_1));
> > ```

Yeah, and a crash could be a relatively good outcome of UB ;) Many thanks for 
catching this!


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70533/#review215466
---


On May 22, 2019, 1:49 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70533/
> ---
> 
> (Updated May 22, 2019, 1:49 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is based on the previous implementation attempt:
> https://reviews.apache.org/r/66229/
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1618794cdb9f44656e697de2abbf6c7e0b6fa50d 
>   src/master/master.hpp 5ad128d00d3cdf0dca89eb637ae196987bdce412 
>   src/master/master.cpp 7c9d9c3d566e29d3f8a5781ee6cdf11973a755e6 
>   src/master/validation.cpp 39f5bfdb39fd6944a3e893b1587e3c2e26818d27 
> 
> 
> Diff: https://reviews.apache.org/r/70533/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70549/#review215484
---




include/mesos/authorizer/authorizer.proto
Line 139 (original), 141-147 (patched)


How about something like:
```
// TODO(mzhu): Remove this action after associated API calls `SET_QUOTA` 
and `REMOVE_QUOTA` are no longer supported.
//
// NOTE: We cannot reuse this action for the `UPDATE_QUOTA` API call, 
because the associated `QuotaConfig` message contains more information than 
`QuotaInfo`.
```



include/mesos/authorizer/authorizer.proto
Lines 149-150 (patched)


I would like us to challenge the necessity of passing `QuotaConfig` here. 
The built-in authorizer only looks at `role`, ignoring any information about 
resources. One might say that a custom authorizer might utilize that extra 
information, however, that extra information might not be enough to make a 
decision, because it does not include the current state or the state change, 
e.g., resource delta.

Imagine an authorizer that allows decreasing quota for a number of 
principals, but only a few are allowed to increase. Passing `QuotaConfig` does 
not really help that authorizer to make a decision. Note that authorizer cannot 
tract previous requests to deduce the current quota state because previous 
request could have been dropped after successful authorization.

I tend to keep it simple and use just the role. We should consult Till 
Tönshoff and Jan-Philip Gehrcke as maintainers of DC/OS authorizer for more 
input.


- Alexander Rukletsov


On May 22, 2019, 12:48 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70549/
> ---
> 
> (Updated May 22, 2019, 12:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, and 
> Benjamin Mahler.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new authorizable action `UPDATE_QUOTA_WITH_CONFIG` is added.
> This disambiguates with the old action `UPDATE_QUOTA` which
> are used for the old `SetQuota` and `RemoveQuota` calls.
> `UPDATE_QUOTA` action requires `QuotaInfo` as the object while
> the new `UpdatedQuota` call uses `QuotaConfig`. To keep it compatible
> with any external authorization modules, a new action  is introduced.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> e2740c402732bb37db991ec92b9301e58b33215b 
>   src/master/master.hpp 5ad128d00d3cdf0dca89eb637ae196987bdce412 
>   src/master/quota_handler.cpp a18d8bafda5604d1844f7f7ed31d4ea80fbf6d04 
>   src/tests/master_authorization_tests.cpp 
> ee69910a34416728bf14ed23f4a6faae6c1204a0 
> 
> 
> Diff: https://reviews.apache.org/r/70549/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70691: Added more comments regarding `message QuotaConfig`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70691/#review215483
---


Ship it!




Thank you for adding clarity, Meng!

- Alexander Rukletsov


On May 21, 2019, 3:23 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70691/
> ---
> 
> (Updated May 21, 2019, 3:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more comments regarding `message QuotaConfig`.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/quota/quota.proto b109ca2a9c7c4b8f1444cc654298c9e580d0ca42 
> 
> 
> Diff: https://reviews.apache.org/r/70691/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70589: Logged when `/__processes__` returns.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/
---

(Updated May 23, 2019, 10:59 a.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-9766
https://issues.apache.org/jira/browse/MESOS-9766


Repository: mesos


Description
---

Adds a log entry when a response with generated by `/__processes__`
is about to be returned to the client.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp a47b5709095665bbe6141b7531b956aeb911d04a 


Diff: https://reviews.apache.org/r/70589/diff/2/

Changes: https://reviews.apache.org/r/70589/diff/1-2/


Testing
---

built & run on Mac OS 10.13.6

```
I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for 
process '__processes__' with path: '/__processes__'
I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ 
from 192.168.178.47:59548: '200 OK' after 1.06214ms
```


Thanks,

Alexander Rukletsov