Re: Review Request 70863: Assign cgroup processes after configuring the subsystem.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/#review215921 --- Patch looks great! Reviews applied: [70863] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 17, 2019, 2:47 a.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70863/ > --- > > (Updated June 17, 2019, 2:47 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-9805 > https://issues.apache.org/jira/browse/MESOS-9805 > > > Repository: mesos > > > Description > --- > > Currently, the PID targeted by the cgroups isolator is moved into > the cgroup before the subsystem runs to apply any type-specific > cgroup configuration. We should reverse the order of this so that > the PID is only moved once the cgroup is fully configured by the > subsystem. > > A specific case that can happen is where a PID is assigned to a net_cls > cgroup before that cgroup has its class ID set. This intermediate > process state can be observed by system monitoring process, causing > confusion that is hard to debug. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 4a1871b3b06b54a02dfe09289f7fb304a3f7f24c > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > e7819d732172bdbd215106e3b781588c1f78b2ec > > > Diff: https://reviews.apache.org/r/70863/diff/1/ > > > Testing > --- > > sudo make check (Fedora 30) > > > Thanks, > > James Peach > >
Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215920 --- Patch looks great! Reviews applied: [70862] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 17, 2019, 2:13 a.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70862/ > --- > > (Updated June 17, 2019, 2:13 a.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Since the blkio cgroup tests immediately require the result of > `blkio_statistics()`, we should test for the presence of statistics > with `ASSERT_TRUE` rather than `EXPECT_TRUE`. > > > Diffs > - > > src/tests/containerizer/cgroups_isolator_tests.cpp > eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 > > > Diff: https://reviews.apache.org/r/70862/diff/1/ > > > Testing > --- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
Review Request 70863: Assign cgroup processes after configuring the subsystem.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Bugs: MESOS-9805 https://issues.apache.org/jira/browse/MESOS-9805 Repository: mesos Description --- Currently, the PID targeted by the cgroups isolator is moved into the cgroup before the subsystem runs to apply any type-specific cgroup configuration. We should reverse the order of this so that the PID is only moved once the cgroup is fully configured by the subsystem. A specific case that can happen is where a PID is assigned to a net_cls cgroup before that cgroup has its class ID set. This intermediate process state can be observed by system monitoring process, causing confusion that is hard to debug. Diffs - src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4a1871b3b06b54a02dfe09289f7fb304a3f7f24c src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp e7819d732172bdbd215106e3b781588c1f78b2ec Diff: https://reviews.apache.org/r/70863/diff/1/ Testing --- sudo make check (Fedora 30) Thanks, James Peach
Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/ --- Review request for mesos, Gilbert Song and Qian Zhang. Repository: mesos Description --- Since the blkio cgroup tests immediately require the result of `blkio_statistics()`, we should test for the presence of statistics with `ASSERT_TRUE` rather than `EXPECT_TRUE`. Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 Diff: https://reviews.apache.org/r/70862/diff/1/ Testing --- make check (Fedora 30) Thanks, James Peach
