Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/#review216879
---



Bad patch!

Reviews applied: [71143, 71144, 71145, 71146, 71147, 71148, 71149, 71150, 71151]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71151"]

Error:
..
HAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.9.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.9.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.9.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include  
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsig
 n-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
slave/containerizer/mesos/isolators/cgroups/subsystems/libmesos_no_3rdparty_la-net_cls.lo
 `test -f 'slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp' 
|| echo 
'../../src/'`slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" "-DPACKAGE_STRING=\"mesos 1.9.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror 
-DLIBDIR=\"/mesos/mesos-1.9.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.9.0/_inst/share/mesos\" -DPKGMODULED
 IR=\"/mesos/mesos-1.9.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare 
-Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c 
../../src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp  
-fPIC -DPIC -o 
slave/containerizer/mesos/isolators/cgroups/subsystems/.libs/libmesos_no_3rdp
 arty_la-net_cls.o
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.9.0\" 
-DPACKAGE_STRING=\"mesos\ 1.9.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.9.0/_inst/lib\"

Re: Review Request 71149: Renamed a storage provider function.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71149/#review216878
---


Ship it!




You know what? I got stuck at this step trying to come up with a good name when 
I worked on this ticket ;) Thanks for coming up with this name!

- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71149/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed a storage provider function.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 6d632606f411d3ca99d3573a57c9f68b02ba8072 
> 
> 
> Diff: https://reviews.apache.org/r/71149/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/#review216877
---




src/tests/storage_local_resource_provider_tests.cpp
Line 846 (original), 846 (patched)


How about using zero here, as described in `mesos.proto`?

And since most tests require no reconciliation, maybe making zero the 
default in `setupResourceProviderConfig`?


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71148/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Explicitly disabled periodic reconciliation for some provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69861265d94ddf344da96b593797ce145394413e 
> 
> 
> Diff: https://reviews.apache.org/r/71148/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71147: Update config factory to set resource provider reconciliation interval.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review216876
---




src/tests/storage_local_resource_provider_tests.cpp
Lines 331 (patched)


I'm actually thinking about haveing a really short reconciliation interval 
for testing here, so certain tests won't wait for a long time. WDYT?

Or, maybe we can inject proper reconciliation intervals only in the tests 
that checks for reconciliations.


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71147/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update config factory to set resource provider reconciliation interval.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69861265d94ddf344da96b593797ce145394413e 
> 
> 
> Diff: https://reviews.apache.org/r/71147/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71146: Clarified a comment in storage local resource provider tests.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71146/#review216875
---


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 615 (original), 615 (patched)


The RP "daemon" does not "get subscribed." The RP daemon is started after 
agent registration, which instantiate the resource providers, which subscribes 
to the RP manager.

So maybe "Since the local resource provider gets subscribed after the agent 
is registered?"

Ditto below.


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71146/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified a comment in storage local resource provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69861265d94ddf344da96b593797ce145394413e 
> 
> 
> Diff: https://reviews.apache.org/r/71146/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71145: Fixed signature to pass parameter by const ref instead of value.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71145/#review216874
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71145/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed signature to pass parameter by const ref instead of value.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69861265d94ddf344da96b593797ce145394413e 
> 
> 
> Diff: https://reviews.apache.org/r/71145/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71144: Added `reconciliation_interval_seconds` for storage resource providers.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71144/
---

(Updated July 26, 2019, 4:26 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Addressed Benjamin's comment.


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

This new configuration option controls how frequent a storage resource
provider reconciles existing volumes and storage pools against its CSI
plugin to detect new or missing disk resources.


Diffs (updated)
-

  include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 
  include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e 
  src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
  src/resource_provider/constants.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71144/diff/2/

Changes: https://reviews.apache.org/r/71144/diff/1-2/


Testing
---


Thanks,

Chun-Hung Hsiao

Re: Review Request 71143: Moved default constants for CSI RPC retry to a new header.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71143/
---

(Updated July 26, 2019, 4:25 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Rebased.


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Since the default constants for CSI RPC retry do not depend on CSI
versions, these constants are pulled off from version-specific headers
to a common header.


Diffs (updated)
-

  src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
  src/csi/constants.hpp PRE-CREATION 
  src/csi/v0_volume_manager.cpp e19dc7c2933e2bbee5e817f3089bd569b259786b 
  src/csi/v0_volume_manager_process.hpp 
4cfb5b564af9e187a6e3d81f86964db288ae852e 
  src/csi/v1_volume_manager.cpp e7e032988bce576ef8d6a0c3457f26f1aad9bb58 
  src/csi/v1_volume_manager_process.hpp 
30788c3593d4b4bd6271705a1188f73836bc7a85 
  src/tests/storage_local_resource_provider_tests.cpp 
38233053452259571743317326a6efc74d97bd29 


Diff: https://reviews.apache.org/r/71143/diff/2/

Changes: https://reviews.apache.org/r/71143/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 71159: Updated quota related endpoints to return quota configurations.

2019-07-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71159/#review216873
---



Bad patch!

Reviews applied: [71158, 71159]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71159"]

Error:
..
tests.cpp' || echo '../../../3rdparty/stout/'`tests/interval_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" -DPACKAGE_STRING=\"mesos\ 1.9.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/stout  
-I../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/inc
 lude -I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS 
-I../picojson-1.3.0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include  
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
-Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o stout_tests-ip_tests.o `test -f 
'tests/ip_tests.cpp' || echo '../../../3rdparty/stout/'`tests/ip_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" -DPACKAGE_STRING=\"mesos\ 1.9.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/stout  
-I../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/inc
 lude -I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS 
-I../picojson-1.3.0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include  
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
-Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o stout_tests-json_tests.o `test -f 
'tests/json_tests.cpp' || echo '../../../3rdparty/stout/'`tests/json_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" -DPACKAGE_STRING=\"mesos\ 1.9.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/stout  
-I../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/inc
 lude -I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS 
-I../picojson-1.3.0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include  
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
-Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o stout_tests-jsonify_tests.o `test 
-f

Re: Review Request 71158: Added proper support for protobuf Map in jsonify.

2019-07-25 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71158/
---

(Updated July 25, 2019, 5:16 p.m.)


Review request for mesos, Andrei Sekretenko, Benjamin Bannier, and Benjamin 
Mahler.


Changes
---

Addressed Andrei's comments.


Bugs: MESOS-9901
https://issues.apache.org/jira/browse/MESOS-9901


Repository: mesos


Description
---

Before this patch jsonify treats protobuf Map as a regular
repeated field. This means a Map with schema:

```
message QuotaConfig {
  required string role = 1;

  map guarantees = 2;
  map limits = 3;
}
```
may be jsonify to an JSON array:

```
{
  "configs": [
{
  "role": "role1",
  "guarantees": [
{
  "key": "cpus",
  "value": {
"value": 1
  }
},
{
  "key": "mem",
  "value": {
"value": 512
  }
}
  ]
}
  ]
}
```
Per standard proto3 JSON mapping, the Map type should be mapped
to an JSON object, i.e.
```
{
  "configs": [
{
  "role": "role1",
  "guarantees": {
"cpus": 1,
"mem": 512
  }
}
  ]
}
```

This patch added jsonify support for such mapping.

Also revised a test to test the jsonify map support.


Diffs (updated)
-

  3rdparty/stout/include/stout/protobuf.hpp 
4b3db7eb807723359af85e8a0324b176e49a954a 
  3rdparty/stout/tests/protobuf_tests.cpp 
95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5 


Diff: https://reviews.apache.org/r/71158/diff/2/

Changes: https://reviews.apache.org/r/71158/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 71158: Added proper support for protobuf Map in jsonify.

2019-07-25 Thread Meng Zhu 


> On July 25, 2019, 7:12 a.m., Andrei Sekretenko wrote:
> > 3rdparty/stout/include/stout/protobuf.hpp
> > Lines 901 (patched)
> > 
> >
> > A typo? (`Nmae`)

Oops! Fixed.


> On July 25, 2019, 7:12 a.m., Andrei Sekretenko wrote:
> > 3rdparty/stout/include/stout/protobuf.hpp
> > Lines 955-958 (patched)
> > 
> >
> > Is there any reason not to use `Reflection::GetRepeatedFieldRef()`?

Thanks, does look cleaner.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71158/#review216857
---


On July 24, 2019, 5:18 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71158/
> ---
> 
> (Updated July 24, 2019, 5:18 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Bannier, and Benjamin 
> Mahler.
> 
> 
> Bugs: MESOS-9901
> https://issues.apache.org/jira/browse/MESOS-9901
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before this patch jsonify treats protobuf Map as a regular
> repeated field. This means a Map with schema:
> 
> ```
> message QuotaConfig {
>   required string role = 1;
> 
>   map guarantees = 2;
>   map limits = 3;
> }
> ```
> may be jsonify to an JSON array:
> 
> ```
> {
>   "configs": [
> {
>   "role": "role1",
>   "guarantees": [
> {
>   "key": "cpus",
>   "value": {
> "value": 1
>   }
> },
> {
>   "key": "mem",
>   "value": {
> "value": 512
>   }
> }
>   ]
> }
>   ]
> }
> ```
> Per standard proto3 JSON mapping, the Map type should be mapped
> to an JSON object, i.e.
> ```
> {
>   "configs": [
> {
>   "role": "role1",
>   "guarantees": {
> "cpus": 1,
> "mem": 512
>   }
> }
>   ]
> }
> ```
> 
> This patch added jsonify support for such mapping.
> 
> Also revised a test to test the jsonify map support.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 4b3db7eb807723359af85e8a0324b176e49a954a 
>   3rdparty/stout/tests/protobuf_tests.cpp 
> 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5 
> 
> 
> Diff: https://reviews.apache.org/r/71158/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

2019-07-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216868
---



Patch looks great!

Reviews applied: [71033, 71034, 71035]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 8, 2019, 6:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> ---
> 
> (Updated July 8, 2019, 6:28 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
>   src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a6217581e20168c5114f733323e927a83ac59fd0 
> 
> 
> Diff: https://reviews.apache.org/r/71035/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> Verified that this new test fails on current master, and passes when the 
> preceding patches in this chain are applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71033: Moved the Docker executor declaration into a header.

2019-07-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
---

(Updated July 25, 2019, 8:31 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
---

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs (updated)
-

  src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
  src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
  src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/3/

Changes: https://reviews.apache.org/r/71033/diff/2-3/


Testing
---

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71033: Moved the Docker executor declaration into a header.

2019-07-25 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/#review216866
---


Fix it, then Ship it!




Just fix this line up before commit.


src/CMakeLists.txt
Line 647 (original), 648 (patched)


I forgot about this line in my previous CMake-related comment.  Since the 
file in here is now deleted, this line can go too.


- Joseph Wu


On July 25, 2019, 12:24 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71033/
> ---
> 
> (Updated July 25, 2019, 12:24 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This moves the declaration of the Docker executor into the
> Docker executor header file and moves the code for the Docker
> executor binary into a new launcher implementation file.
> 
> This change will enable the Mesos executor driver
> implementation to make use of the `DockerExecutor` symbol.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
>   src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
>   src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
>   src/launcher/docker_executor.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71033/diff/2/
> 
> 
> Testing
> ---
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

2019-07-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/
---

(Updated July 25, 2019, 7:24 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
---

This adds a new `killTask()` overload to the Docker executor
and updates the Mesos executor driver to call into that
overload when the loaded executor is the Docker executor.

This allows the executor driver to pass the kill policy
override, when present, into the Docker executor.


Diffs (updated)
-

  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 


Diff: https://reviews.apache.org/r/71034/diff/3/

Changes: https://reviews.apache.org/r/71034/diff/2-3/


Testing
---

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71033: Moved the Docker executor declaration into a header.

2019-07-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
---

(Updated July 25, 2019, 7:24 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
---

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs (updated)
-

  src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
  src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
  src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/2/

Changes: https://reviews.apache.org/r/71033/diff/1-2/


Testing
---

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71081: Exposed agent drain information in the webui.

2019-07-25 Thread Greg Mann 


> On July 16, 2019, 12:25 p.m., Benjamin Bannier wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > 
> >
> > This information is essential useless to users as they have no idea at 
> > what point tasks would slip out of the grace period (interval without start 
> > time).
> 
> Greg Mann wrote:
> I think this is fine; it's difficult for the master to say exactly when 
> draining has actually begun on an agent, since the agent doesn't ACK the 
> `DrainSlaveMessage`. Unless we have some idea of how to make this more 
> meaningful without lots of effort, I'd say leave as-is.
> 
> Benjamin Bannier wrote:
> I don't think we would need exact information. If the master could e.g., 
> keep the last time a `DrainSlaveMessage` was sent to the agent in memory and 
> expose it here one would be able to infer a deadline on a sub-minute level 
> (unless the agent is completely overloaded ¯\_(?)_/¯). This information is 
> always only a best guess since e.g., an agent failover could reset the clock, 
> by potentially  triggering another drain cycle.

Sounds like a good plan to me, and simple :)

Here's a JIRA: https://issues.apache.org/jira/browse/MESOS-9907
Let's follow up on this ASAP. Dropping this issue for now.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
---


On July 25, 2019, 8:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> ---
> 
> (Updated July 25, 2019, 8:52 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed agent drain information in the webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5 
>   src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d 
>   src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9 
> 
> 
> Diff: https://reviews.apache.org/r/71081/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71158: Added proper support for protobuf Map in jsonify.

2019-07-25 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71158/#review216857
---




3rdparty/stout/include/stout/protobuf.hpp
Lines 901 (patched)


A typo? (`Nmae`)



3rdparty/stout/include/stout/protobuf.hpp
Lines 955-958 (patched)


Is there any reason not to use `Reflection::GetRepeatedFieldRef()`?


- Andrei Sekretenko


On July 25, 2019, 12:18 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71158/
> ---
> 
> (Updated July 25, 2019, 12:18 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Bannier, and Benjamin 
> Mahler.
> 
> 
> Bugs: MESOS-9901
> https://issues.apache.org/jira/browse/MESOS-9901
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before this patch jsonify treats protobuf Map as a regular
> repeated field. This means a Map with schema:
> 
> ```
> message QuotaConfig {
>   required string role = 1;
> 
>   map guarantees = 2;
>   map limits = 3;
> }
> ```
> may be jsonify to an JSON array:
> 
> ```
> {
>   "configs": [
> {
>   "role": "role1",
>   "guarantees": [
> {
>   "key": "cpus",
>   "value": {
> "value": 1
>   }
> },
> {
>   "key": "mem",
>   "value": {
> "value": 512
>   }
> }
>   ]
> }
>   ]
> }
> ```
> Per standard proto3 JSON mapping, the Map type should be mapped
> to an JSON object, i.e.
> ```
> {
>   "configs": [
> {
>   "role": "role1",
>   "guarantees": {
> "cpus": 1,
> "mem": 512
>   }
> }
>   ]
> }
> ```
> 
> This patch added jsonify support for such mapping.
> 
> Also revised a test to test the jsonify map support.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 4b3db7eb807723359af85e8a0324b176e49a954a 
>   3rdparty/stout/tests/protobuf_tests.cpp 
> 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5 
> 
> 
> Diff: https://reviews.apache.org/r/71158/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71081: Exposed agent drain information in the webui.

2019-07-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216856
---



Patch looks great!

Reviews applied: [71081]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2019, 8:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> ---
> 
> (Updated July 25, 2019, 8:52 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed agent drain information in the webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5 
>   src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d 
>   src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9 
> 
> 
> Diff: https://reviews.apache.org/r/71081/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.

2019-07-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70831/#review216853
---



Bad patch!

Reviews applied: [70728, 70831]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_70831"]

Error:
..
sos-1.9.0/_build/..\" -DBUILD_DIR=\"/mesos/mesos-1.9.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.9.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include 
-I/usr/lib/jvm/java-7-openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3.4.8\" 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE 
-g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o 
tests/mesos_tests-disk_quota_tests.o `test -f 'tests/disk_quota_tests.cpp' || 
echo '../../src/'`tests/disk_quota_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" -DPACKAGE_STRING=\"mesos\ 1.9.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.9.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.9.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-
 1.9.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.9.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.9.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.9.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include -I/usr/lib/jvm/java-7-
 openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3.4.8\" 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
-pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC 
-fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o 
tests/mesos_tests-dynamic_weights_tests.o `test -f 
'tests/dynamic_weights_tests.cpp' || echo 
'../../src/'`tests/dynamic_weights_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" -DPACKAGE_STRING=\"mesos\ 1.9.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.9.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.9.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.9.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-
 1.9.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

2019-07-25 Thread Benjamin Bannier 


> On July 18, 2019, 9:48 p.m., Chun-Hung Hsiao wrote:
> > src/tests/mesos.hpp
> > Lines 3361-3372 (patched)
> > 
> >
> > No need to introduce this type alias in this class template since the 
> > class template `MockResourceProviderProcess` is already public.

We use this to bind the `MockResourceProviderProcess`'s template arguments in a 
single place instead of us having to spell out the full instantiations again 
and again, e.g., when passed to `dispatch` or elsewhere.

Dropping.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70728/#review216741
---


On May 27, 2019, 6:32 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70728/
> ---
> 
> (Updated May 27, 2019, 6:32 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9560
> https://issues.apache.org/jira/browse/MESOS-9560
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were passing callbacks into `MockResourceProvider` to the HTTP
> driver. Since the lifecycle of the callbacks and the mock provider were
> decoupled and these callbacks were binding the mock provider instance
> the code was not safe as written as the driver could invoke the callback
> after the provider had been destructed.
> 
> This patch makes sure that the callbacks are defered to a process. We
> also dispatch a number of other functions which are strongly coupled to
> the lifecycle of the provider. We still do not hide the provider away
> completely so the provider can be mocked in tests.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 641eb15153ddb85df322aa6a133ca8e4c6d6a510 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b6ac50adacc8416b91c0dde55ff7ba46a20515c 
>   src/tests/master_tests.cpp b9ef13c31a9c3ae16e55d3ae8f9b1538a49cf49a 
>   src/tests/mesos.hpp 4612e2e3d2bd32590248df58b546de8756636964 
>   src/tests/operation_reconciliation_tests.cpp 
> eae318da2273faae904f0155e49bb23cdb24f007 
>   src/tests/resource_provider_manager_tests.cpp 
> 7d48f18e89f046df6c92e52edeef592acfb13b10 
>   src/tests/slave_tests.cpp abee107720d6b78bb017d2762431ae36c0679026 
> 
> 
> Diff: https://reviews.apache.org/r/70728/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71081: Exposed agent drain information in the webui.

2019-07-25 Thread Benjamin Bannier 


> On July 16, 2019, 2:25 p.m., Benjamin Bannier wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > 
> >
> > This information is essential useless to users as they have no idea at 
> > what point tasks would slip out of the grace period (interval without start 
> > time).
> 
> Greg Mann wrote:
> I think this is fine; it's difficult for the master to say exactly when 
> draining has actually begun on an agent, since the agent doesn't ACK the 
> `DrainSlaveMessage`. Unless we have some idea of how to make this more 
> meaningful without lots of effort, I'd say leave as-is.

I don't think we would need exact information. If the master could e.g., keep 
the last time a `DrainSlaveMessage` was sent to the agent in memory and expose 
it here one would be able to infer a deadline on a sub-minute level (unless the 
agent is completely overloaded ¯\_(?)_/¯). This information is always only a 
best guess since e.g., an agent failover could reset the clock, by potentially  
triggering another drain cycle.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
---


On July 25, 2019, 10:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> ---
> 
> (Updated July 25, 2019, 10:52 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed agent drain information in the webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5 
>   src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d 
>   src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9 
> 
> 
> Diff: https://reviews.apache.org/r/71081/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71081: Exposed agent drain information in the webui.

2019-07-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/
---

(Updated July 25, 2019, 10:52 a.m.)


Review request for mesos, Greg Mann and Joseph Wu.


Changes
---

Fix units


Bugs: MESOS-9846
https://issues.apache.org/jira/browse/MESOS-9846


Repository: mesos


Description
---

Exposed agent drain information in the webui.


Diffs (updated)
-

  src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5 
  src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d 
  src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9 


Diff: https://reviews.apache.org/r/71081/diff/3/

Changes: https://reviews.apache.org/r/71081/diff/2-3/


Testing
---


File Attachments


agents summary
  
https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
agent detail
  
https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
agents summary
  
https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png


Thanks,

Benjamin Bannier

Re: Review Request 71081: Exposed agent drain information in the webui.

2019-07-25 Thread Benjamin Bannier 


> On July 25, 2019, 2:34 a.m., Greg Mann wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > 
> >
> > Looks like this conversion is off by a factor of 1000?

It is, thanks for catching this.

This came about because I was initially trying to format a deadline as a 
`m-timestamp` which requires millisecond input.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216840
---


On July 25, 2019, 10:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> ---
> 
> (Updated July 25, 2019, 10:52 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed agent drain information in the webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5 
>   src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d 
>   src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9 
> 
> 
> Diff: https://reviews.apache.org/r/71081/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71157: Update docker image before build.

2019-07-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71157/#review216847
---


Ship it!




Ship It!

- Benjamin Bannier


On July 24, 2019, 7:19 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71157/
> ---
> 
> (Updated July 24, 2019, 7:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9906
> https://issues.apache.org/jira/browse/MESOS-9906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We need to run `docker pull` before `docker run` to endusre build is done 
> against latest docker image.
> 
> 
> Diffs
> -
> 
>   support/mesos-build.sh ee8ef8b8cfa84067fd7067dd8bf7dbde1cc7e67e 
> 
> 
> Diff: https://reviews.apache.org/r/71157/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>