Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:19 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.apache.org/jira/browse/MESOS-3240 Repository: mesos Description --- Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. Diffs (updated) - src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 Diff: https://reviews.apache.org/r/37500/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.apache.org/jira/browse/MESOS-3240 Repository: mesos Description --- Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. Diffs (updated) - src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 Diff: https://reviews.apache.org/r/37500/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 37500: Update the FrameworkInfo.user on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.apache.org/jira/browse/MESOS-3240 Repository: mesos Description --- Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. Diffs - src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 Diff: https://reviews.apache.org/r/37500/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 37501: Add support for removing capabilities.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3258 https://issues.apache.org/jira/browse/MESOS-3258 Repository: mesos Description --- The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo. Diffs - src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505 Diff: https://reviews.apache.org/r/37501/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37501: Add support for removing capabilities.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/ --- (Updated Aug. 15, 2015, 4:35 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3258 https://issues.apache.org/jira/browse/MESOS-3258 Repository: mesos Description --- The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo. Diffs (updated) - src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505 Diff: https://reviews.apache.org/r/37501/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37072: Added test for allocator update on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/ --- (Updated Aug. 5, 2015, 6:51 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- Added test for allocator update on scheduler failover Diffs (updated) - src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a Diff: https://reviews.apache.org/r/37072/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 37072: Added test for allocator update on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- Added test for allocator update on scheduler failover Diffs - src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a Diff: https://reviews.apache.org/r/37072/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 25, 2015, 6:38 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description (updated) --- This updates both the master as well as the allocator. Added test for master. Diffs (updated) - src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
On July 16, 2015, 8:13 p.m., Vinod Kone wrote: src/tests/fault_tolerance_tests.cpp, line 1831 https://reviews.apache.org/r/35797/diff/3/?file=1013501#file1013501line1831 Nice test! Thanks :) On July 16, 2015, 8:13 p.m., Vinod Kone wrote: src/master/master.hpp, line 534 https://reviews.apache.org/r/35797/diff/3/?file=1013500#file1013500line534 s/capabilities_size()/capabilities.size()/ In mesos.pb.h, capabilities_size() is defined in line 1147 :) - Aditi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/#review91955 --- On July 18, 2015, 2:23 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 18, 2015, 2:23 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- This only updates the master, not the allocator. Added test too. Diffs - src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 18, 2015, 2:23 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- This only updates the master, not the allocator. Added test too. Diffs (updated) - src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 16, 2015, 6:46 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description (updated) --- This only updates the master, not the allocator. Added test too. Diffs (updated) - src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35687: Added capabilities to state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 15, 2015, 5:20 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900 https://issues.apache.org/jira/browse/MESOS-2900 Repository: mesos Description --- Added capabilities to state.json and test for the same Diffs (updated) - src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/35687/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35687: Added capabilities to state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 12, 2015, 6:25 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900 https://issues.apache.org/jira/browse/MESOS-2900 Repository: mesos Description --- Added capabilities to state.json and test for the same Diffs (updated) - src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/35687/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35687: Added capabilities to state.json
On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote: src/master/http.cpp, line 124 https://reviews.apache.org/r/35687/diff/1/?file=988871#file988871line124 Let's make it `foreachvalue` for consistency. Hi, I'm sorry, but I'm unable to understand how foreachvalue works. - Aditi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review88640 --- On July 12, 2015, 6:25 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 12, 2015, 6:25 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900 https://issues.apache.org/jira/browse/MESOS-2900 Repository: mesos Description --- Added capabilities to state.json and test for the same Diffs - src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/35687/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35687: Added capabilities to state.json
On July 9, 2015, 4:26 p.m., Vinod Kone wrote:
src/master/http.cpp, lines 124-125
https://reviews.apache.org/r/35687/diff/2/?file=1003411#file1003411line124
were you not able to use 'foreach' here?
foreach(FrameworkInfo::Capability capability,
framework.info.capabilities()) {
}
No. I think the problem is occurring because capabilities is a repeated field.
- Aditi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91113
---
On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---
(Updated July 9, 2015, 4:04 p.m.)
Review request for mesos, Marco Massenzio and Vinod Kone.
Bugs: MESOS-2900
https://issues.apache.org/jira/browse/MESOS-2900
Repository: mesos
Description
---
Added capabilities to state.json and test for the same
Diffs
-
src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332
src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22
Diff: https://reviews.apache.org/r/35687/diff/
Testing
---
make check
Thanks,
Aditi Dixit
Re: Review Request 35687: Added capabilities to state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 9, 2015, 4:04 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900 https://issues.apache.org/jira/browse/MESOS-2900 Repository: mesos Description (updated) --- Added capabilities to state.json and test for the same Diffs (updated) - src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/35687/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 7:14 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description (updated) --- This only updates the master, not the allocator. Diffs - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 7:13 p.m.) Review request for mesos and Vinod Kone. Summary (updated) - Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities Diffs - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 2 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description (updated) --- Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities Diffs - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 2:44 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.apache.org/jira/browse/MESOS-2880 Repository: mesos Description --- Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities Diffs (updated) - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 Diff: https://reviews.apache.org/r/35797/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 35687: Added capabilities to state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900 https://issues.apache.org/jira/browse/MESOS-2900 Repository: mesos Description --- Added capabilities to state.json Diffs - src/master/http.cpp 8b694137fe3491e4d40af0f31ee87d3e3ef8ab5a Diff: https://reviews.apache.org/r/35687/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 34984: Added help for files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/ --- (Updated June 4, 2015, 9:40 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Changes --- Fixed issues Bugs: MESOS-2277 https://issues.apache.org/jira/browse/MESOS-2277 Repository: mesos Description --- Added help for files Diffs (updated) - src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 Diff: https://reviews.apache.org/r/34984/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 34984: Added help for files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2277 https://issues.apache.org/jira/browse/MESOS-2277 Repository: mesos Description --- Added help for files Diffs - src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 Diff: https://reviews.apache.org/r/34984/diff/ Testing --- make check Thanks, Aditi Dixit
Review Request 34926: Added help for state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34926/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2277 https://issues.apache.org/jira/browse/MESOS-2277 Repository: mesos Description --- Added help for roles.json, state-summary and edited help for state.json Fixed issues Diffs - src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/34926/diff/ Testing --- Make check Thanks, Aditi Dixit
Re: Review Request 34926: Added help for state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34926/ --- (Updated June 2, 2015, 6:34 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2277 https://issues.apache.org/jira/browse/MESOS-2277 Repository: mesos Description --- Added help for roles.json, state-summary and edited help for state.json Fixed issues Diffs - src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/34926/diff/ Testing --- Make check Thanks, Aditi Dixit
Review Request 34904: Added help for state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34904/ --- Review request for mesos. Bugs: mesos-2277 https://issues.apache.org/jira/browse/mesos-2277 Repository: mesos Description --- Added help for roles.json, state-summary and state.json Diffs - src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/34904/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 34837: Added help for state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34837/ --- (Updated May 30, 2015, 1:17 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: mesos-2277 https://issues.apache.org/jira/browse/mesos-2277 Repository: mesos Description --- Added help for state.json and fixed some spelling errors Diffs - src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/34837/diff/ Testing (updated) --- make check Thanks, Aditi Dixit
