Re: Review Request 63437: Slave heartbeat add message sender distinguish.
> On 十一月 3, 2017, 10:26 p.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 4996-5001 (patched) > > <https://reviews.apache.org/r/63437/diff/1/?file=1873291#file1873291line4996> > > > > Can you explain the context for this change? The change itself seems > > reasonable, but I would like to understand what prompted you to add this. we meet double master leader, and the incorrect leader send the ping-pong to the agent, agent can't recognize even if it detect the real correct leader. - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/#review190074 --- On 十月 31, 2017, 3:45 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63437/ > --- > > (Updated 十月 31, 2017, 3:45 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Slave ping-pong message add master from judge. > > > Diffs > - > > src/slave/slave.cpp 337083d > > > Diff: https://reviews.apache.org/r/63437/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Review Request 63437: Slave heartbeat add message sender distinguish.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Slave ping-pong message add master from judge. Diffs - src/slave/slave.cpp 337083d Diff: https://reviews.apache.org/r/63437/diff/1/ Testing --- make check Thanks, Andy Pang
Review Request 61808: Add task env overwriting executor env glog print
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61808/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos Description --- When user assign environment by `CommandInfo` environment, it will overwrite the same name environment get by before. Diffs - src/slave/containerizer/docker.cpp b84c392 Diff: https://reviews.apache.org/r/61808/diff/1/ Testing --- make check Thanks, Andy Pang
Review Request 58987: Add failure print when socket recv data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58987/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Add failure print when socket recv data. Diffs - 3rdparty/libprocess/src/process.cpp 96ce7db Diff: https://reviews.apache.org/r/58987/diff/1/ Testing --- make check Thanks, Andy Pang
Re: Review Request 58557: Print failure reason when socket accept failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/ --- (Updated 四月 25, 2017, 1:14 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print failure reason when socket accept failed. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58557/diff/2/ Changes: https://reviews.apache.org/r/58557/diff/1-2/ Testing --- make check Thanks, Andy Pang
Re: Review Request 58287: Print corresponding address when socket shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 20, 2017, 11:34 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print corresponding address when socket shutdown. Default just print socket 'fd',it's not convenient to find corresponding address. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58287/diff/5/ Changes: https://reviews.apache.org/r/58287/diff/4-5/ Testing --- make check File Attachments process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang
Review Request 58557: Print failure reason when socket accept failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print failure reason when socket accept failed. Diffs - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58557/diff/1/ Testing --- make check Thanks, Andy Pang
Re: Review Request 58287: Print corresponding address when socket shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 20, 2017, 9:09 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print corresponding address when socket shutdown. Default just print socket 'fd',it's not convenient to find corresponding address. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58287/diff/4/ Changes: https://reviews.apache.org/r/58287/diff/3-4/ Testing --- make check File Attachments process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang
Re: Review Request 58287: Print corresponding address when socket shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 13, 2017, 12:44 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print corresponding address when socket shutdown. Default just print socket 'fd',it's not convenient to find corresponding address. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58287/diff/3/ Changes: https://reviews.apache.org/r/58287/diff/2-3/ Testing --- make check File Attachments (updated) process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang
Re: Review Request 58287: Print corresponding address when socket shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 12, 2017, 1:42 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Changes --- Fixed as suggestion. Repository: mesos Description --- Print corresponding address when socket shutdown. Default just print socket 'fd',it's not convenient to find corresponding address. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58287/diff/2/ Changes: https://reviews.apache.org/r/58287/diff/1-2/ Testing --- make check Thanks, Andy Pang
Review Request 58287: Print corresponding address when socket shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Print corresponding address when socket shutdown. Default just print socket 'fd',it's not convenient to find corresponding address. Diffs - 3rdparty/libprocess/src/process.cpp d0cba0c Diff: https://reviews.apache.org/r/58287/diff/1/ Testing --- make check Thanks, Andy Pang
Re: Review Request 55042: Let MesosContainerizer support ramdisk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55042/ --- (Updated 十二月 26, 2016, 12:23 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Add slave startup flags ramdisk_enable environment variable to make Mesos work when the root is on a ramdisk, because 'pivot_root' don't support on ramdisk FS. Diffs (updated) - src/launcher/executor.cpp cc9adfe src/launcher/posix/executor.hpp d057ff6 src/launcher/posix/executor.cpp a29b31c src/linux/fs.hpp da49c9e src/linux/fs.cpp 913e233 src/slave/containerizer/mesos/launch.hpp 5bba139 src/slave/containerizer/mesos/launch.cpp e482ab8 src/slave/flags.hpp 6ac0d45 src/slave/flags.cpp 1eccea9 src/slave/slave.cpp f8f2ccf Diff: https://reviews.apache.org/r/55042/diff/ Testing --- make check Thanks, Andy Pang
Review Request 55042: Let MesosContainerizer support ramdisk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55042/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Add slave startup flags ramdisk_enable environment variable to make Mesos work when the root is on a ramdisk, because 'pivot_root' don't support on ramdisk FS. Diffs - src/launcher/executor.cpp cc9adfe src/launcher/posix/executor.hpp d057ff6 src/launcher/posix/executor.cpp a29b31c src/linux/fs.hpp da49c9e src/linux/fs.cpp 913e233 src/slave/containerizer/mesos/launch.hpp 5bba139 src/slave/containerizer/mesos/launch.cpp e482ab8 src/slave/flags.hpp 6ac0d45 src/slave/flags.cpp 1eccea9 src/slave/slave.cpp f8f2ccf Diff: https://reviews.apache.org/r/55042/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52185/ --- (Updated 九月 23, 2016, 2:43 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- If task has not been in hashmap pendingTasks, indicate it has been erase, so don't need to erase twice. Diffs (updated) - src/master/master.cpp 66a672f Diff: https://reviews.apache.org/r/52185/diff/ Testing --- make check Thanks, Andy Pang
Review Request 52185: Do not need to erase task if it not in pendingTasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52185/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- If task has not been in hashmap pendingTasks, indicate it has been erase, so don't need to erase twice. Diffs - src/master/master.cpp 66a672f Diff: https://reviews.apache.org/r/52185/diff/ Testing --- make check Thanks, Andy Pang
Review Request 52142: Adjust indentation alignment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52142/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Adjust the _accept() indentation alignment. Diffs - src/master/master.hpp 35db198 Diff: https://reviews.apache.org/r/52142/diff/ Testing --- make check Thanks, Andy Pang
Review Request 48200: Merge function "socket_send_data" logical judgment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48200/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Function "socket_send_data" last logical judgment maybe merge beeter. Diffs - 3rdparty/libprocess/src/poll_socket.cpp d14dd1a Diff: https://reviews.apache.org/r/48200/diff/ Testing --- make check Thanks, Andy Pang
Review Request 46550: Fixed slave to initialize libprocess before modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/ --- Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and Vinod Kone. Repository: mesos Description --- This is important because otherwise a module might call libprocess `initialize()` before slave calls `initialize(id)`. If this happens the HTTP request process "delegate" will be wrong, Diffs - src/slave/main.cpp 38bd005 Diff: https://reviews.apache.org/r/46550/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 46249: Hook and module process operation before main process initialize.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---
(Updated 四月 19, 2016, 2:52 a.m.)
Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and
Vinod Kone.
Repository: mesos
Description (updated)
---
If we in hook/module manager use libprocess library,
it will auto use process initialize fucntion,
as the process::initialize will only call once,
then in the main fucnton process initialize
process::initialize("master") will not be called.
So the HTTP request process "delegate" will be wrong,
http request will not be response.
Diffs (updated)
-
src/master/main.cpp 7bbc982
Diff: https://reviews.apache.org/r/46249/diff/
Testing
---
make check
Thanks,
Andy Pang
Re: Review Request 46249: Hook and module process operation before main process initialize.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---
(Updated 四月 18, 2016, 5:41 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Summary (updated)
-
Hook and module process operation before main process initialize.
Repository: mesos
Description
---
If we in hook/module manager use libprocess library, it will auto use process
initialize fucntion, as the process::initialize will only call once,then in the
main fucnton process initialize process::initialize("master") will not be
called. So the HTTP request process "delegate" will be wrong, http request will
not be response.
Diffs
-
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
---
make check
Thanks,
Andy Pang
Re: Review Request 46249: hook/module process operation before main process initialize.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---
(Updated 四月 18, 2016, 2:44 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Repository: mesos
Description
---
If we in hook/module manager use libprocess library, it will auto use process
initialize fucntion, as the process::initialize will only call once,then in the
main fucnton process initialize process::initialize("master") will not be
called. So the HTTP request process "delegate" will be wrong, http request will
not be response.
Diffs (updated)
-
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
---
make check
Thanks,
Andy Pang
Re: Review Request 46249: hook/module process operation before main process initialize.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---
(Updated 四月 15, 2016, 8:09 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Summary (updated)
-
hook/module process operation before main process initialize.
Repository: mesos
Description
---
If we in hook/module manager use libprocess library, it will auto use process
initialize fucntion, as the process::initialize will only call once,then in the
main fucnton process initialize process::initialize("master") will not be
called. So the HTTP request process "delegate" will be wrong, http request will
not be response.
Diffs
-
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
---
make check
Thanks,
Andy Pang
Review Request 46249: Support hook/module process operation before main process initialize.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Repository: mesos
Description
---
If we in hook/module manager use libprocess library, it will auto use process
initialize fucntion, as the process::initialize will only call once,then in the
main fucnton process initialize process::initialize("master") will not be
called. So the HTTP request process "delegate" will be wrong, http request will
not be response.
Diffs
-
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
---
make check
Thanks,
Andy Pang
Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/ --- (Updated 三月 2, 2016, 6:21 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description (updated) --- When fopen is failed,we should curl_easy_cleanup curl_handle and close fd Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 Diff: https://reviews.apache.org/r/44254/diff/ Testing --- make check Thanks, Andy Pang
Review Request 44254: Add curl_easy_cleanup when fopen is failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- When fopen is failed,we should curl_easy_cleanup curl_handle. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 Diff: https://reviews.apache.org/r/44254/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 43183: Support routing_tests run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/ --- (Updated 二月 5, 2016, 1:13 a.m.) Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs: MESOS-4577 https://issues.apache.org/jira/browse/MESOS-4577 Repository: mesos Description --- Support routing_tests run in aarch64 cpu. Diffs - src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43183/diff/ Testing --- make test ok Thanks, Andy Pang
Review Request 43183: Support routing_tests run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Repository: mesos Description --- Support routing_tests run in aarch64 cpu. Diffs - src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43183/diff/ Testing --- make test ok Thanks, Andy Pang
Re: Review Request 43136: Support libprocess build run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- (Updated 二月 4, 2016, 8:56 a.m.) Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Changes --- split dir src/...and 3rdparty/... modify into different patches Bugs: MESOS-4577 https://issues.apache.org/jira/browse/MESOS-4577 Repository: mesos Description --- Support libprocess build run in aarch64 cpu. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang
Re: Review Request 43136: Support libprocess build run in aarch64 cpu.
> On 二月 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do you have already run > `./bootstrap` in local? > > haosdent huang wrote: > Could you check whether `.git/hooks/pre-commit` exist in your local > machine and that `reset --soft` and submit again? Usually it would execute > `support/mesos_split.py` to make sure `the commits are properly split between > mesos, libprocess and stout.`. > > haosdent huang wrote: > yes, it would generate two patches finally. Thanks,i have modify it. - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117771 --- On 二月 4, 2016, 8:56 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43136/ > --- > > (Updated 二月 4, 2016, 8:56 a.m.) > > > Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-4577 > https://issues.apache.org/jira/browse/MESOS-4577 > > > Repository: mesos > > > Description > --- > > Support libprocess build run in aarch64 cpu. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 > src/tests/containerizer/routing_tests.cpp > 4ebb01213ce20f954c2633df95e898cf66a2d9e9 > > Diff: https://reviews.apache.org/r/43136/diff/ > > > Testing > --- > > test run ok in AArch64. > > > Thanks, > > Andy Pang > >
Review Request 43135: Support libprocess build run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43135/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs: MESOS-4577 https://issues.apache.org/jira/browse/MESOS-4577 Repository: mesos Description --- on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess achieve syscal "clone" must distinguish different cpus. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a Diff: https://reviews.apache.org/r/43135/diff/ Testing --- test run ok in AArch64 Thanks, Andy Pang
Review Request 43136: Support libprocess build run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs: MESOS-4577 https://issues.apache.org/jira/browse/MESOS-4577 Repository: mesos Description --- on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess achieve syscal "clone" must distinguish different cpus. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang
Re: Review Request 43136: Support libprocess build run in aarch64 cpu.
> On 二月 3, 2016, 8:43 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 71
> > <https://reviews.apache.org/r/43136/diff/1/?file=1230818#file1230818line71>
> >
> > Do we also need fix similar ::clone syscall in routing_tests.cpp?
> > ```
> > TEST_F(RoutingVethTest, ROOT_LinkCreatePid)
> > {
> > // Stack used in the child process.
> > unsigned long long stack[32];
> >
> > pid_t pid = ::clone(child, [31], CLONE_NEWNET | SIGCHLD, NULL);
> > ```
Add routing_tests.cpp support aarch64 cpu.
- Andy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117595
-------
On 二月 4, 2016, 7:40 a.m., Andy Pang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> ---
>
> (Updated 二月 4, 2016, 7:40 a.m.)
>
>
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Support libprocess build run in aarch64 cpu.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8
> src/tests/containerizer/routing_tests.cpp
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9
>
> Diff: https://reviews.apache.org/r/43136/diff/
>
>
> Testing
> ---
>
> test run ok in AArch64.
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 43136: Support libprocess build run in aarch64 cpu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- (Updated 二月 4, 2016, 7:40 a.m.) Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Changes --- Add routing_tests.cpp support aarch64 cpu. Bugs: MESOS-4577 https://issues.apache.org/jira/browse/MESOS-4577 Repository: mesos Description (updated) --- Support libprocess build run in aarch64 cpu. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang
Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 26, 2016, 1:16 a.m.) Review request for mesos, Jie Yu and Timothy Chen. Changes --- remove the comment Bugs: MESOS-4328 https://issues.apache.org/jira/browse/MESOS-4328 Repository: mesos Description --- Docker container REST API /monitor/statistics.json output have no timestamp field, in docker.cpp function cgroupsStatistics add the timestamp value set. Diffs (updated) - src/slave/containerizer/docker.cpp d2b77e3 Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.
> On 一月 21, 2016, 6:12 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-21 06:12:19 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > > Total errors found: 0 > > Checking 1 files > > Error: Commit message summary (the first line) must end in a period. Thanks,I have fix it - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review115570 --- On 一月 21, 2016, 6:18 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42288/ > --- > > (Updated 一月 21, 2016, 6:18 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-4328 > https://issues.apache.org/jira/browse/MESOS-4328 > > > Repository: mesos > > > Description > --- > > Docker container REST API /monitor/statistics.json output have no timestamp > field, in docker.cpp function cgroupsStatistics add the timestamp value set. > > > Diffs > - > > src/slave/containerizer/docker.cpp 40f6f0b > > Diff: https://reviews.apache.org/r/42288/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Timothy Chen. Changes --- modify the summary,length less than 72 chars Summary (updated) - Add timestamp to DockerContainerizer's ResourceStatistics Bugs: MESOS-4328 https://issues.apache.org/jira/browse/MESOS-4328 Repository: mesos Description --- Docker container REST API /monitor/statistics.json output have no timestamp field Diffs - src/slave/containerizer/docker.cpp da19975 Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 4:12 a.m.) Review request for mesos, Jie Yu and Timothy Chen. Changes --- merge the newest git branch Bugs: MESOS-4328 https://issues.apache.org/jira/browse/MESOS-4328 Repository: mesos Description --- Docker container REST API /monitor/statistics.json output have no timestamp field Diffs (updated) - src/slave/containerizer/docker.cpp 40f6f0b Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang
Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics
> On 一月 14, 2016, 9:19 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > > Total errors found: 0 > > Checking 1 files > > Error: Commit message summary (the first line) must not exceed 72 > > characters. Thanks?I have fix it, modify the summary as "Add timestamp to DockerContainerizer's ResourceStatistics" - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review114443 --- On 一月 21, 2016, 3:46 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42288/ > --- > > (Updated 一月 21, 2016, 3:46 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-4328 > https://issues.apache.org/jira/browse/MESOS-4328 > > > Repository: mesos > > > Description > --- > > Docker container REST API /monitor/statistics.json output have no timestamp > field > > > Diffs > - > > src/slave/containerizer/docker.cpp da19975 > > Diff: https://reviews.apache.org/r/42288/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Review Request 42288: Docker container REST API /monitor/statistics.json output have no timestamp field
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-4328 https://issues.apache.org/jira/browse/MESOS-4328 Repository: mesos Description --- Docker container REST API /monitor/statistics.json output have no timestamp field Diffs - src/slave/containerizer/docker.cpp da19975 Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang
