Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176290 --- When using the command `mesos` after applying your patch on top of master, I got this error: ``` Traceback (most recent call last): File "/Users/Armand/Code/apache-mesos/src/cli_new/bin/main.py", line 151, in main(sys.argv[1:]) File "/Users/Armand/Code/apache-mesos/src/cli_new/bin/main.py", line 87, in main config = cli.config.Config() TypeError: __init__() takes exactly 2 arguments (1 given) ``` Replacing the line 87 of bin/main.py by `config = cli.config.Config(settings)` solved the issue. - Armand Grillet On May 29, 2017, 11:32 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59634/ > --- > > (Updated May 29, 2017, 11:32 p.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Previously, we were importing settings directly from the `bin` > directory, which is obviously not portable. Instead, we need to be > passing the settings into the constructor for the config so that it > can access it from there. > > > Diffs > - > > src/cli_new/lib/cli/config.py 353785b8bdc13b745d2dc9469201c16a8816ebc6 > > > Diff: https://reviews.apache.org/r/59634/diff/1/ > > > Testing > --- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Kevin Klues > >
Re: Review Request 58137: Added 'mesos config show' command in the new Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated May 29, 2017, 3:46 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- The code has been rebased and improved now that we have a Config class. Summary (updated) - Added 'mesos config show' command in the new Mesos CLI. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs (updated) - src/cli_new/lib/cli/plugins/config/main.py 6e19e5c2e148b92323a6ea0e9a7610eb938a84d9 Diff: https://reviews.apache.org/r/58137/diff/8/ Changes: https://reviews.apache.org/r/58137/diff/7-8/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 29, 2017, 3:27 p.m.) Review request for mesos and Kevin Klues. Changes --- Code rebased. Summary (updated) - Extended the unit test infrastructure in the new Mesos CLI. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3 src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/constants.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/13/ Changes: https://reviews.apache.org/r/58720/diff/12-13/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Review Request 59628: Moved settings.py from bin to lib/cli in the new Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59628/ --- Review request for mesos and Kevin Klues. Repository: mesos Description --- The file contains constants used by the CLI and upcoming tests. Diffs - src/cli_new/bin/main.py d0ec2bdb04631fbaa62efb6ae67e138140a1296a src/cli_new/bin/settings.py Diff: https://reviews.apache.org/r/59628/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 59177: CLI: Added Config class to manage the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- (Updated May 29, 2017, 12:36 p.m.) Review request for mesos and Kevin Klues. Bugs: MESOS-7582 https://issues.apache.org/jira/browse/MESOS-7582 Repository: mesos Description --- This new class simplifies the management of the configuration file given by the user; it loads the TOML file on initialization and has one method for each element that the user can set. This new class and its associated content is also given to the plugins at initialization so that they can read the user configuration and use it. Diffs - src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/config.py PRE-CREATION src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7 src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448 Diff: https://reviews.apache.org/r/59177/diff/2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 25, 2017, 9:08 a.m.) Review request for mesos and Kevin Klues. Changes --- Lambdas removed. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/constants.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/11/ Changes: https://reviews.apache.org/r/58720/diff/10-11/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 24, 2017, 1:28 p.m.) Review request for mesos and Kevin Klues. Changes --- Solved the issues raised by Andrei. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/constants.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/7/ Changes: https://reviews.apache.org/r/58720/diff/6-7/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Re: Review Request 59177: CLI: Added Config class to manage the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- (Updated May 15, 2017, 1:59 a.m.) Review request for mesos and Kevin Klues. Changes --- Patch modified to resolve the comments I have received offline. Repository: mesos Description (updated) --- This new class simplifies the management of the configuration file given by the user; it loads the TOML file on initialization and has one method for each element that the user can set. This new class and its associated content is also given to the plugins at initialization so that they can read the user configuration and use it. Diffs (updated) - src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/config.py PRE-CREATION src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7 src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448 Diff: https://reviews.apache.org/r/59177/diff/2/ Changes: https://reviews.apache.org/r/59177/diff/1-2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 59177: CLI: Added Config class to manage the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- Review request for mesos and Kevin Klues. Repository: mesos Description --- This new class simplifies the management of the configuration file given by the user; it loads the TOML file on initialization and has one method for each element that the user can set. Diffs - src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/config.py PRE-CREATION Diff: https://reviews.apache.org/r/59177/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
> On May 7, 2017, 8:13 p.m., Kevin Klues wrote:
> > src/cli_new/lib/cli/constants.py
> > Lines 18-25 (patched)
> > <https://reviews.apache.org/r/58720/diff/4/?file=1709419#file1709419line18>
> >
> > Aso is, I think we should bundle this under cli/tests/constants.py.
> >
> > However, if you want to keep this file as cli/constants.py, that's
> > fine, but the default ports should be 5050 and 5051.
> >
> > I chose 9090 and 9091 for the tests so they wouldn't conflict with and
> > mesos instances running on the (normal) default ports.
> >
> > If you want to keep these constants all in one place, we should add
> > separate default ports for the tests. Something like:
> > ```
> > class namespace:
> > def __init__(self, **entries): self.__dict__.update(entries)
> >
> > DEFAULT_MASTER_IP = "127.0.0.1"
> > DEFAULT_MASTER_PORT = "9090"
> >
> > DEFAULT_AGENT_IP = "127.0.0.1"
> > DEFAULT_AGENT_PORT = "9091"
> >
> > test = namespace(
> > DEFAULT_MASTER_IP = DEFAULT_MASTER_IP,
> > DEFAULT_MASTER_PORT = "9090",
> >
> > DEFAULT_AGENT_IP = DEFAULT_AGENT_IP
> > DEFAULT_AGENT_PORT = "9091"
> > )
> > ```
> >
> > Though I'd probably put the namespace function into `cli/util.py`
Having constants with different values depending on the namespace seems
cumbersome. I will put the constants in this review request back under
cli/tests/constants.py and create cli/constants.py in a future review request.
> On May 7, 2017, 8:13 p.m., Kevin Klues wrote:
> > src/cli_new/lib/cli/tests/base.py
> > Lines 139 (patched)
> > <https://reviews.apache.org/r/58720/diff/4/?file=1709421#file1709421line139>
> >
> > The parameters to this function should not mix having 2 parameters on
> > one line and just one on the next.
> >
> > Either choose:
> > ```
> > self.executable = os.path.join(mesos_build_path(),
> >"bin",
> >"mesos-{name}.sh".format(name=self.name))
> >
> > ```
> >
> > or
> > ```
> > self.executable = os.path.join(
> > mesos_build_path(),
> > "bin",
> > "mesos-{name}.sh".format(name=self.name))
> > ```
> >
> > I typically prefer the second.
I have used the first solution as it is everywhere like this right now.
> On May 7, 2017, 8:13 p.m., Kevin Klues wrote:
> > src/cli_new/lib/cli/tests/base.py
> > Lines 384-401 (patched)
> > <https://reviews.apache.org/r/58720/diff/4/?file=1709421#file1709421line384>
> >
> > This is fine for now, but I'm wondering if we can't find a more generic
> > way of discovering the build directorty. This current method assumes we
> > always create the build directory in a specific location.
> >
> > It also assumes we have a build directory at all. Which maybe we should
> > safeguard againts.
True, we could add an option like for our configure script with
`--with-mesos-build-dir`. Our script mesos-cli-tests is currently small and
supporting long command line options is gonna require a lot of code (it does
not work out of the box on macOS). The easiest solution would be to have a
short command line option to specify your build path (e.g. `mesos-cli-tests
-b=path/to/mesos/build/dir`).
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review174131
---
On May 8, 2017, 5:27 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> ---
>
> (Updated May 8, 2017, 5:27 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 8, 2017, 5:27 p.m.) Review request for mesos and Kevin Klues. Changes --- Changed code following the issues raised. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/constants.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/5/ Changes: https://reviews.apache.org/r/58720/diff/4-5/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 5, 2017, 5:02 p.m.) Review request for mesos and Kevin Klues. Changes --- Constants moved to be accessible from the CLI and not just the tests. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb src/cli_new/lib/cli/constants.py PRE-CREATION src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/4/ Changes: https://reviews.apache.org/r/58720/diff/3-4/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated May 4, 2017, 9:39 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- Fixed issues raised in comments. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs (updated) - src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7 Diff: https://reviews.apache.org/r/58137/diff/7/ Changes: https://reviews.apache.org/r/58137/diff/6-7/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 4, 2017, 1:59 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed raised issues. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs (updated) - src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/constants.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/2/ Changes: https://reviews.apache.org/r/58720/diff/1-2/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Review Request 58719: CLI: Added utility functions related to HTTP.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58719/ --- Review request for mesos and Kevin Klues. Repository: mesos Description --- This will be used by future plugins and tests. Diffs - src/cli_new/lib/cli/http.py PRE-CREATION Diff: https://reviews.apache.org/r/58719/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 58720: CLI: Extended the unit test infrastructure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7283 https://issues.apache.org/jira/browse/MESOS-7283 Repository: mesos Description --- This infrastructure includes the ability to bring up a test cluster to run the CLI against. Future unit tests will use this infrastructure to test their commands against a running mesos cluster. The tests require some binaries created when building Mesos. Diffs - src/cli_new/lib/cli/tests/__init__.py PRE-CREATION src/cli_new/lib/cli/tests/base.py PRE-CREATION src/cli_new/lib/cli/tests/tests.py PRE-CREATION src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/1/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 12, 2017, 7:59 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- Rebased. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- These settings were previously in settings.py. We now use a TOML file containing the configuration, this format has been chosen because: * It supports comments. * It is well-specified. * It allows logical grouping. * It maps ubiquitous data types. The config file environment variable, previously `MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This change follows the design doc about the new CLI. This environement variable `MESOS_CLI_PLUGINS` is not used anymore as plugins can be added using the TOML file instead. Diffs (updated) - src/cli_new/README.md aa118132688253d3cec0b27fd6b394f5bc2bdd94 src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f src/cli_new/pip-requirements.txt e73bbfde98f28693463a46b166197ad1fd53c0cb Diff: https://reviews.apache.org/r/57951/diff/6/ Changes: https://reviews.apache.org/r/57951/diff/5-6/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58137: Added 'mesos config show' command to display the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated April 12, 2017, 9:21 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs (updated) - src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58137/diff/4/ Changes: https://reviews.apache.org/r/58137/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57952: Added 'config' plugin to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 12, 2017, 9:19 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- Used to show the plugins available for the user. Diffs (updated) - src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f src/cli_new/lib/cli/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/57952/diff/5/ Changes: https://reviews.apache.org/r/57952/diff/4-5/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 58381: Added a Table abstraction to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58381/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-7282 https://issues.apache.org/jira/browse/MESOS-7282 Repository: mesos Description --- This will be used by future plugins. Diffs - src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b Diff: https://reviews.apache.org/r/58381/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 12, 2017, 9:07 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- These settings were previously in settings.py. We now use a TOML file containing the configuration, this format has been chosen because: * It supports comments. * It is well-specified. * It allows logical grouping. * It maps ubiquitous data types. The config file environment variable, previously `MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This change follows the design doc about the new CLI. The environement variable `MESOS_CLI_PLUGINS` is not used anymore as plugins can be added using the TOML file instead. Diffs (updated) - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/5/ Changes: https://reviews.apache.org/r/57951/diff/4-5/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58137: Added 'mesos config show' command to display the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated April 11, 2017, 2:53 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- Rebased. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs (updated) - src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58137/diff/3/ Changes: https://reviews.apache.org/r/58137/diff/2-3/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57952: Added 'config' plugin to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 11, 2017, 2:52 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- Rebased. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description --- Used to show the plugins available for the user. A Table abstraction has been added to print the plugins. Diffs (updated) - src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f src/cli_new/lib/cli/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b Diff: https://reviews.apache.org/r/57952/diff/4/ Changes: https://reviews.apache.org/r/57952/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 11, 2017, 2:51 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Changes --- Rebased. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- These settings were previously in `settings.py`. We now use a TOML file containing the configuration, this format has been chosen because: * It supports comments. * It is well-specified. * It allows logical grouping. * It maps ubiquitous data types. The config file environment variable, previously `MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This change follows the design doc about the new CLI. This environement variable `MESOS_CLI_PLUGINS` is not used anymore as plugins can be added using the TOML file instead. Diffs (updated) - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/4/ Changes: https://reviews.apache.org/r/57951/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 58137: Added 'mesos config show' command to display the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated April 10, 2017, 6:38 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Summary (updated) - Added 'mesos config show' command to display the config file. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs (updated) - src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58137/diff/2/ Changes: https://reviews.apache.org/r/58137/diff/1-2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57952: Added 'config' plugin to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 10, 2017, 6:37 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- Used to show the plugins available for the user. A Table abstraction has been added to print the plugins. Diffs (updated) - src/cli_new/bin/settings.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 Diff: https://reviews.apache.org/r/57952/diff/3/ Changes: https://reviews.apache.org/r/57952/diff/2-3/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 10, 2017, 6:33 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- These settings were previously in `settings.py`. We now use a TOML file containing the configuration, this format has been chosen because: * It supports comments. * It is well-specified. * It allows logical grouping. * It maps ubiquitous data types. This environement variable `MESOS_CLI_PLUGINS` is not used anymore as plugins can be added using the TOML file instead. Diffs (updated) - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/3/ Changes: https://reviews.apache.org/r/57951/diff/2-3/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58146/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6032 https://issues.apache.org/jira/browse/MESOS-6032 Repository: mesos Description --- This is the base to develop unit tests for the Mesos CLI. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/mesos-cli-tests PRE-CREATION src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf src/cli_new/tests/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58146/diff/1/ Testing --- $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet
Review Request 58137: Added `mesos config show` command to display the config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- Review request for mesos and Kevin Klues. Repository: mesos Description --- This command displays the contents of the user-defined config.toml file. Diffs - src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58137/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated March 27, 2017, noon) Review request for mesos and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description --- These settings were previously in 'bin/settings.py'. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57952: Added 'config' plugin to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated March 27, 2017, noon) Review request for mesos and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description --- Used to show and validate the configuration file given by the user. Diffs - src/cli_new/bin/settings.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/57952/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 57952: Added 'config' plugin to the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- Review request for mesos. Repository: mesos Description --- Used to show and validate the configuration file given by the user. Diffs - src/cli_new/bin/settings.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/57952/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated March 27, 2017, 11:58 a.m.) Review request for mesos. Repository: mesos Description --- These settings were previously in 'bin/settings.py'. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/1/ Testing (updated) --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 57951: Moved new CLI settings into a user-defined TOML file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- Review request for mesos. Repository: mesos Description --- These settings were previously in 'bin/settings.py'. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/settings.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/1/ Testing --- Thanks, Armand Grillet
Re: Review Request 57896: Renamed 'config.py' to 'settings.py' in the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/ --- (Updated March 27, 2017, 11:56 a.m.) Review request for mesos and Kevin Klues. Summary (updated) - Renamed 'config.py' to 'settings.py' in the new CLI. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description (updated) --- Change made due to the upcoming introduction of a 'config' plugin. Diffs (updated) - src/cli_new/bin/config.py src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d Diff: https://reviews.apache.org/r/57896/diff/2/ Changes: https://reviews.apache.org/r/57896/diff/1-2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 57896: Configuration of cli_new in config.toml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description --- Documentation added to create a correct configuration file. Plugin to handle this configuration file added. config.py moved to settings.py to differentiate it from the plugin. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d src/cli_new/bin/settings.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57896/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 57896: Configuration of cli_new in config.toml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7269 https://issues.apache.org/jira/browse/MESOS-7269 Repository: mesos Description --- Documentation added to create a correct configuration file. Plugin to handle this configuration file added. config.py moved to settings.py to differentiate it from the plugin. Diffs - src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d src/cli_new/bin/settings.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57896/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet
Review Request 56326: Size of the favicon optimized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56326/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --- The favicon keeps the same images as before but its size has been reduced (in a lossless manner) from 361 KB to 115 KB. Diffs - src/webui/master/static/ico/favicon.ico 11dd3de5f124550be141bce9a9a96a516a9c9b7b Diff: https://reviews.apache.org/r/56326/diff/ Testing --- None. I took care of converting 'favicon.ico' to '.png' images using imagemagick, optimized their size using ImageOptim, and rebundled them as 'favicon.ico' using imagemagick again. Thanks, Armand Grillet
Re: Review Request 50010: Added example framework for handling inverse offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/#review156730 --- src/examples/inverse_offer_framework.cpp (line 529) <https://reviews.apache.org/r/50010/#comment226995> `class Flags : public virtual flags::FlagsBase` in other frameworks. src/examples/inverse_offer_framework.cpp (line 534) <https://reviews.apache.org/r/50010/#comment226996> The format is `add(&Flags::role,` in other frameworks. Same for the other flags added. Doing a `make check` with this patch on top of `master` did not work, modifying it following the two comments above fixed the problem. - Armand Grillet On Sept. 16, 2016, 9:35 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50010/ > --- > > (Updated Sept. 16, 2016, 9:35 p.m.) > > > Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues. > > > Bugs: MESOS-5827 > https://issues.apache.org/jira/browse/MESOS-5827 > > > Repository: mesos > > > Description > --- > > This framework shows how one might handle inverse offers by launching > persistent sleep tasks and migrating them ahead of planned maintenance. > > > Diffs > - > > src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede > src/examples/inverse_offer_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50010/diff/ > > > Testing > --- > > make check > > TODO: Add a helper binary for generating random maintenance schedules. > > > Thanks, > > Joseph Wu > >
Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53559/ --- (Updated Nov. 9, 2016, 8:26 p.m.) Review request for mesos and Joseph Wu. Changes --- Updated comment for libprocess port and the `advertise_port` cannot be 0 anymore. Bugs: MESOS-4609 https://issues.apache.org/jira/browse/MESOS-4609 Repository: mesos Description (updated) --- Environment variables LIBPROCESS_ + (IP, ADVERTISE_IP,PORT, ADVERTISE_PORT) are now in a Flags object. Diffs (updated) - 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d Diff: https://reviews.apache.org/r/53559/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Re: Review Request 53558: Added net::IP parsing template to the flags parsers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/ --- (Updated Nov. 8, 2016, 2:57 p.m.) Review request for mesos and Joseph Wu. Repository: mesos Description (updated) --- Will be used to have flags of type `net::IP`. Diffs - 3rdparty/stout/include/stout/flags/parse.hpp 67a89c9068207b2197d60f3542962e82327a43a4 Diff: https://reviews.apache.org/r/53558/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Re: Review Request 53558: Added net::IP parsing template to the flags parsers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/ --- (Updated Nov. 8, 2016, 2:56 p.m.) Review request for mesos and Joseph Wu. Repository: mesos Description (updated) --- Will be used to have flags of type `net::IP`. Diffs (updated) - 3rdparty/stout/include/stout/flags/parse.hpp 67a89c9068207b2197d60f3542962e82327a43a4 Diff: https://reviews.apache.org/r/53558/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Re: Review Request 53509: Changed mesos-execute --master flag parsing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/ --- (Updated Nov. 8, 2016, 2:01 a.m.) Review request for mesos, Joseph Wu and Till Toenshoff. Summary (updated) - Changed mesos-execute --master flag parsing. Bugs: MESOS-2723 https://issues.apache.org/jira/browse/MESOS-2723 Repository: mesos Description (updated) --- This commit makes the --master argument required. The parsing of the argument now happens in src/master/detector.cpp. Diffs - src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 Diff: https://reviews.apache.org/r/53509/diff/ Testing --- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet
Review Request 53560: LOG(FATAL) transformed into EXIT(EXIT_FAILURE) in process::initialize.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53560/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4601 https://issues.apache.org/jira/browse/MESOS-4601 Repository: mesos Description --- We now do an `EXIT(EXIT_FAILURE)` instead of `LOG(FATAL)` when initialising a process. Diffs - 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d Diff: https://reviews.apache.org/r/53560/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Review Request 53559: Transformed env variable parsing into Flags in process.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53559/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4609 https://issues.apache.org/jira/browse/MESOS-4609 Repository: mesos Description --- Environment variables LIBPROCESS_ + (IP, ADVERTISE_IP,PORT, ADVERTISE_PORT) are now in a Flags object. Heavily inspired by Joseph's review request [43261](https://reviews.apache.org/r/43261/). Diffs - 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d Diff: https://reviews.apache.org/r/53559/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Review Request 53558: Added net::IP parsing template to the flags parsers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/ --- Review request for mesos and Joseph Wu. Repository: mesos Description --- Will be used to have flags of type `net::IP`. Diffs - 3rdparty/stout/include/stout/flags/parse.hpp 67a89c9068207b2197d60f3542962e82327a43a4 Diff: https://reviews.apache.org/r/53558/diff/ Testing --- make check (macOS) Thanks, Armand Grillet
Re: Review Request 53509: Flag --master now required and parsed by MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/ --- (Updated Nov. 7, 2016, 8:42 a.m.) Review request for mesos, Joseph Wu and Till Toenshoff. Summary (updated) - Flag --master now required and parsed by MasterDetector. Bugs: MESOS-2723 https://issues.apache.org/jira/browse/MESOS-2723 Repository: mesos Description --- This commit makes the --master argument mandatory. The parsing of the argument now happens in src/master/detector.cpp. Diffs - src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 Diff: https://reviews.apache.org/r/53509/diff/ Testing --- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet
Re: Review Request 53509: Flag —master now required and parsed by MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/ --- (Updated Nov. 5, 2016, 12:51 a.m.) Review request for mesos, Joseph Wu and Till Toenshoff. Bugs: MESOS-2723 https://issues.apache.org/jira/browse/MESOS-2723 Repository: mesos Description (updated) --- This commit makes the --master argument mandatory. The parsing of the argument now happens in src/master/detector.cpp. Diffs - src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 Diff: https://reviews.apache.org/r/53509/diff/ Testing --- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet
Review Request 53509: Flag —master now required and parsed by MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/ --- Review request for mesos. Bugs: MESOS-2723 https://issues.apache.org/jira/browse/MESOS-2723 Repository: mesos Description --- This commit makes the —master argument mandatory. The parsing of the argument now happens in src/master/detector.cpp. Diffs - src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 Diff: https://reviews.apache.org/r/53509/diff/ Testing --- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet
