Re: Review Request 68497: Added --skip-verify flag to verify-reviews.py to skip verification.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68497/ --- (Updated Aug. 24, 2018, 1:40 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added --skip-verify flag to verify-reviews.py to skip verification. Repository: mesos Description (updated) --- This flag allows devs to skip verification and just print or write to a file the review ids that need verification. Diffs (updated) - support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb Diff: https://reviews.apache.org/r/68497/diff/4/ Changes: https://reviews.apache.org/r/68497/diff/3-4/ Testing --- python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password Thanks, Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to verify-reviews.py to skip verification and just print or write to file the review ids that need verification.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68497/ --- (Updated Aug. 24, 2018, 12:22 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added --skip-verify flag to verify-reviews.py to skip verification and just print or write to file the review ids that need verification. Repository: mesos Description (updated) --- Added --skip-verify flag to verify-reviews.py to skip verification and just print or write to file the review ids that need verification. Diffs (updated) - support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb Diff: https://reviews.apache.org/r/68497/diff/3/ Changes: https://reviews.apache.org/r/68497/diff/2-3/ Testing --- python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password Thanks, Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68497/ --- (Updated Aug. 24, 2018, 9:47 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification. Repository: mesos Description (updated) --- Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification. Diffs (updated) - support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb Diff: https://reviews.apache.org/r/68497/diff/2/ Changes: https://reviews.apache.org/r/68497/diff/1-2/ Testing --- python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password Thanks, Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to verify-reviews.py to skip verification
> On Aug. 24, 2018, 9:40 a.m., Benjamin Bannier wrote: > > I like the idea to make more traceable what would be verified. > > > > That said, thinking about a script called `verify-reviews.py` with a flag > > called `--no-verify` made me slightly dizzy :D. Could what you are after > > also be accomplished by a `--dry-run` option? That one would, at least to > > me, both have more straight-forward semantics, and potentially allow wider > > use cases. We have such a flag in `support/apply-reviews.py` already where > > it is very useful. We would use this option in our CI pipeline in order to batch process the review IDs that need verification in Jenkins. This helps us spawn multiple jobs in parallel and is a part of how our CI for mesos is setup right now. I've thought about naming it --dry-run as well, but I figured we only need to print some review IDs, something like --dry-run would print other stuff too, which would defeat the purpose for what we're trying to accomplish. - Dragos --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68497/#review207862 --- On Aug. 24, 2018, 9:30 a.m., Dragos Schebesch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68497/ > --- > > (Updated Aug. 24, 2018, 9:30 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Added --skip-verify flag to verify-reviews.py to skip verification > altogether, and just print or write to file the review ids that need > verification. > > > Diffs > - > > support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb > > > Diff: https://reviews.apache.org/r/68497/diff/1/ > > > Testing > --- > > python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p > $password > > > Thanks, > > Dragos Schebesch > >
Review Request 68497: Added --skip-verify flag to verify-reviews.py to skip verification
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68497/ --- Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added --skip-verify flag to verify-reviews.py to skip verification altogether, and just print or write to file the review ids that need verification. Diffs - support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb Diff: https://reviews.apache.org/r/68497/diff/1/ Testing --- python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated Aug. 16, 2018, 6:52 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Refactored ReviewBoard API functionality into separate module. Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/6/ Changes: https://reviews.apache.org/r/67502/diff/5-6/ Testing --- For example, to call the api on a specific review_url, with some data, we would use the following code: ``` ReviewBoardHandler().api(review_url, data) ``` Thanks, Dragos Schebesch
Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated Aug. 7, 2018, 5:37 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Refactored verify-reviews.py to use commons.py and argparse. Diffs (updated) - support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 Diff: https://reviews.apache.org/r/67505/diff/5/ Changes: https://reviews.apache.org/r/67505/diff/4-5/ Testing --- Sample run on this review request: ``` ./support/python3/verify-reviews.py -u -p -r 67505 file -o test.txt 07-18-18_11:09:22 - Running support/python3/verify-reviews.py 0 review requests need verification ``` Thanks, Dragos Schebesch
Re: Review Request 67503: Added support helper for fetching review ids.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated Aug. 7, 2018, 5:36 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description (updated) --- Added support helper for fetching review ids. Diffs (updated) - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/5/ Changes: https://reviews.apache.org/r/67503/diff/4-5/ Testing --- Sample run on this review request id: ``` ./get-review-ids.py -r 67503 Dependent review: https://reviews.apache.org/api/review-requests/67502/ 67502 67503 ``` Thanks, Dragos Schebesch
Re: Review Request 67504: Added support script to post build results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated Aug. 7, 2018, 5:37 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added support script to post build results. Diffs (updated) - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/5/ Changes: https://reviews.apache.org/r/67504/diff/4-5/ Testing --- Sample test run that can be seen on this review request: ``` ./python3/post-build-result.py -r 67504 -u -p -m 'dummy' -o http://dummy.com/artifact Posting to review request: https://reviews.apache.org/r/67504 dummy All the build artifacts available at: http://dummy.com/artifact ``` Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated Aug. 7, 2018, 5:36 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description (updated) --- Refactored ReviewBoard API functionality into separate module. Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/5/ Changes: https://reviews.apache.org/r/67502/diff/4-5/ Testing --- For example, to call the api on a specific review_url, with some data, we would use the following code: ``` ReviewBoardHandler().api(review_url, data) ``` Thanks, Dragos Schebesch
Re: Review Request 67503: Added support helper for fetching review ids.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 19, 2018, 3:48 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description (updated) --- Added helper for fetching review id, which is needed to decouple this logic from verify-reviews.py. We need this for the windows build so we can trigger a downstream job for each review request on another server. Diffs - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/4/ Testing --- Sample run on this review request id: ``` ./get-review-ids.py -r 67503 Dependent review: https://reviews.apache.org/api/review-requests/67502/ 67502 67503 ``` Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 19, 2018, 3:48 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description (updated) --- Refactored API functionality into separate module -- this was done to clean up the codebase and put all API calls in single place. Diffs - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/4/ Testing --- For example, to call the api on a specific review_url, with some data, we would use the following code: ``` ReviewBoardHandler().api(review_url, data) ``` Thanks, Dragos Schebesch
Re: Review Request 67504: Added support script to post build results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated July 19, 2018, 3:39 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added support script to post build results. Diffs - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/4/ Testing (updated) --- Sample test run that can be seen on this review request: ``` ./python3/post-build-result.py -r 67504 -u -p -m 'dummy' -o http://dummy.com/artifact Posting to review request: https://reviews.apache.org/r/67504 dummy All the build artifacts available at: http://dummy.com/artifact ``` Thanks, Dragos Schebesch
Re: Review Request 67504: Added support script to post build results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review206240 --- dummy All the build artifacts available at: http://dummy.com/artifact - Dragos Schebesch On July 18, 2018, 8:50 a.m., Dragos Schebesch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67504/ > --- > > (Updated July 18, 2018, 8:50 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Added support script to post build results. > > > Diffs > - > > support/python3/post-build-result.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/67504/diff/4/ > > > Testing > --- > > Tests have been done later in the chain. > > > Thanks, > > Dragos Schebesch > >
Re: Review Request 67503: Added support helper for fetching review ids.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added support helper for fetching review ids. Repository: mesos Description (updated) --- Added support helper for fetching review ids. Diffs (updated) - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/4/ Changes: https://reviews.apache.org/r/67503/diff/3-4/ Testing (updated) --- Sample run on this review request id: ``` ./get-review-ids.py -r 67503 Dependent review: https://reviews.apache.org/api/review-requests/67502/ 67502 67503 ``` Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Refactored ReviewBoard API functionality into separate module. Repository: mesos Description (updated) --- Refactored ReviewBoard API functionality into separate module. Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/4/ Changes: https://reviews.apache.org/r/67502/diff/3-4/ Testing (updated) --- For example, to call the api on a specific review_url, with some data, we would use the following code: ``` ReviewBoardHandler().api(review_url, data) ``` Thanks, Dragos Schebesch
Re: Review Request 67504: Added support script to post build results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added support script to post build results. Repository: mesos Description (updated) --- Added support script to post build results. Diffs (updated) - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/4/ Changes: https://reviews.apache.org/r/67504/diff/3-4/ Testing --- Tests have been done later in the chain. Thanks, Dragos Schebesch
Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated July 18, 2018, 8:36 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Changes --- Fixed misuse of handler class Repository: mesos Description --- Refactored verify-reviews.py to use commons.py and argparse. Diffs (updated) - support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 Diff: https://reviews.apache.org/r/67505/diff/4/ Changes: https://reviews.apache.org/r/67505/diff/3-4/ Testing (updated) --- Sample run on this review request: ``` ./support/python3/verify-reviews.py -u -p -r 67505 file -o test.txt 07-18-18_11:09:22 - Running support/python3/verify-reviews.py 0 review requests need verification ``` Thanks, Dragos Schebesch
Re: Review Request 67504: Added helper for posting the result of a build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated July 11, 2018, 11:54 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added helper for posting the result of a build. Repository: mesos Description (updated) --- Added helper for posting the result of a build. Diffs (updated) - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/3/ Changes: https://reviews.apache.org/r/67504/diff/2-3/ Testing (updated) --- Tests have been done later in the chain. Thanks, Dragos Schebesch
Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated July 11, 2018, 11:54 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Refactored verify-reviews.py to use commons.py and argparse. Repository: mesos Description (updated) --- Refactored verify-reviews.py to use commons.py and argparse. Diffs (updated) - support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 Diff: https://reviews.apache.org/r/67505/diff/3/ Changes: https://reviews.apache.org/r/67505/diff/2-3/ Testing (updated) --- Tests have been done later in the chain. Thanks, Dragos Schebesch
Re: Review Request 67503: Added helper for fetching review id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 11, 2018, 11:54 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added helper for fetching review id. Diffs - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/3/ Testing (updated) --- Tests have been done later in the chain. Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 11, 2018, 11:53 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Refactored API functionality into separate module. Diffs - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/3/ Testing (updated) --- Tests have been done later in the chain. Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored API functionality into separate module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 11, 2018, 11:52 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Refactored API functionality into separate module. Repository: mesos Description (updated) --- Refactored API functionality into separate module. Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/3/ Changes: https://reviews.apache.org/r/67502/diff/2-3/ Testing --- Thanks, Dragos Schebesch
Re: Review Request 67503: Added helper for fetching review id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 11, 2018, 11:52 a.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Summary (updated) - Added helper for fetching review id. Repository: mesos Description (updated) --- Added helper for fetching review id. Diffs (updated) - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/3/ Changes: https://reviews.apache.org/r/67503/diff/2-3/ Testing --- Thanks, Dragos Schebesch
Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Refactored verify-reviews.py to use commons.py and argparse Diffs (updated) - support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 Diff: https://reviews.apache.org/r/67505/diff/2/ Changes: https://reviews.apache.org/r/67505/diff/1-2/ Testing --- Thanks, Dragos Schebesch
Re: Review Request 67503: Added helper for fetching review id
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added helper for fetching review id Diffs (updated) - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/2/ Changes: https://reviews.apache.org/r/67503/diff/1-2/ Testing --- Thanks, Dragos Schebesch
Re: Review Request 67502: Refactored API functionality into separate module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Refactored API functionality into separate module Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/2/ Changes: https://reviews.apache.org/r/67502/diff/1-2/ Testing --- Thanks, Dragos Schebesch
Re: Review Request 67504: Added helper for posting the result of a build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew Schwartzmeyer and Armand Grillet. Repository: mesos Description --- Added helper for posting the result of a build Diffs (updated) - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/2/ Changes: https://reviews.apache.org/r/67504/diff/1-2/ Testing --- Thanks, Dragos Schebesch
Review Request 67504: Added helper for posting the result of a build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Description --- Added helper for posting the result of a build Diffs (updated) - support/python3/post-build-result.py PRE-CREATION Diff: https://reviews.apache.org/r/67504/diff/1/ Testing --- Thanks, Dragos Schebesch
Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Description --- Refactored verify-reviews.py to use commons.py and argparse Diffs - support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 Diff: https://reviews.apache.org/r/67505/diff/1/ Testing --- Thanks, Dragos Schebesch
Review Request 67502: Refactored API functionality into separate module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Description --- Refactored API functionality into separate module Diffs (updated) - support/python3/common.py PRE-CREATION Diff: https://reviews.apache.org/r/67502/diff/1/ Testing --- Thanks, Dragos Schebesch
Review Request 67503: Added helper for fetching review id
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Description --- Added helper for fetching review id Diffs (updated) - support/python3/get-review-ids.py PRE-CREATION Diff: https://reviews.apache.org/r/67503/diff/1/ Testing --- Thanks, Dragos Schebesch
