Re: Review Request 58944: Fixed compilation error on recent glibc for device whitelist.

2017-05-03 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58944/
---

(Updated May 3, 2017, 6:40 p.m.)


Review request for mesos.


Bugs: MESOS-7456
https://issues.apache.org/jira/browse/MESOS-7456


Repository: mesos


Description
---

Fixed compilation error on recent glibc for device whitelist.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
3055b7d41d31a353d672c8934b8545c01b70d2de 


Diff: https://reviews.apache.org/r/58944/diff/1/


Testing
---


Thanks,

Zhongbo Tian



Review Request 58944: Fixed compilation error on recent glibc for device whitelist.

2017-05-02 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58944/
---

Review request for mesos.


Repository: mesos


Description
---

Fixed compilation error on recent glibc for device whitelist.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
3055b7d41d31a353d672c8934b8545c01b70d2de 


Diff: https://reviews.apache.org/r/58944/diff/1/


Testing
---


Thanks,

Zhongbo Tian



Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-27 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58603/
---

(Updated April 27, 2017, 7:01 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Allowed whitelist additional devices in cgroups devices subsystem.


Diffs (updated)
-

  docs/configuration.md 159f946216299fc52171e0a58c7eb7c888c1eec8 
  include/mesos/mesos.proto 46bb7813cc402f2a71879d26d4bbc62abd852d52 
  include/mesos/type_utils.hpp 5f771aaf2f4e76ac06bfd8f77b0b744ed2854b27 
  include/mesos/v1/mesos.proto f7c05a82f8265aedc0bd8fd20dd30e21af46e775 
  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 
  src/common/type_utils.cpp 9bc32af7df3242906633ac75d47922be8e5f 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 


Diff: https://reviews.apache.org/r/58603/diff/4/

Changes: https://reviews.apache.org/r/58603/diff/3-4/


Testing
---

For test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`

- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices  
--allowed_devices='{"allowed_devices":[{"device":{"path":"/dev/rtc0"}, 
"access":{"mknod":true, "read":true, "write":true}}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-24 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58603/
---

(Updated April 25, 2017, 5:40 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Allowed whitelist additional devices in cgroups devices subsystem.


Diffs (updated)
-

  docs/configuration.md 159f946216299fc52171e0a58c7eb7c888c1eec8 
  include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
  include/mesos/type_utils.hpp 5f771aaf2f4e76ac06bfd8f77b0b744ed2854b27 
  include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 
  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 
  src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 


Diff: https://reviews.apache.org/r/58603/diff/3/

Changes: https://reviews.apache.org/r/58603/diff/2-3/


Testing (updated)
---

For test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`

- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices  
--allowed_devices='{"allowed_devices":[{"device":{"path":"/dev/rtc0"}, 
"access":{"mknod":true, "read":true, "write":true}}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-24 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58603/
---

(Updated April 24, 2017, 8 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Allowed whitelist additional devices in cgroups devices subsystem.


Diffs (updated)
-

  docs/configuration.md 159f946216299fc52171e0a58c7eb7c888c1eec8 
  include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
  include/mesos/type_utils.hpp 5f771aaf2f4e76ac06bfd8f77b0b744ed2854b27 
  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 
  src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 


Diff: https://reviews.apache.org/r/58603/diff/2/

Changes: https://reviews.apache.org/r/58603/diff/1-2/


Testing (updated)
---

For test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`

- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices  
--allowed_devices='{"devices":[{"device":{"path":"/dev/rtc0"}, 
"access":{"mknod":true, "read":true, "write":true}}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-21 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58603/
---

(Updated April 21, 2017, 7:02 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Allowed whitelist additional devices in cgroups devices subsystem.


Diffs
-

  docs/configuration.md 159f946216299fc52171e0a58c7eb7c888c1eec8 
  include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
  include/mesos/type_utils.hpp 5f771aaf2f4e76ac06bfd8f77b0b744ed2854b27 
  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 
  src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 


Diff: https://reviews.apache.org/r/58603/diff/1/


Testing (updated)
---

For test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`

- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices  
--cgroups_whitelist_devices='{"devices":[{"device":{"path":"/dev/rtc0"}, 
"access":{"mknod":true, "read":true, "write":true}}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-21 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58603/
---

Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Allowed whitelist additional devices in cgroups devices subsystem.


Diffs
-

  docs/configuration.md 159f946216299fc52171e0a58c7eb7c888c1eec8 
  include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
  include/mesos/type_utils.hpp 5f771aaf2f4e76ac06bfd8f77b0b744ed2854b27 
  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 
  src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 


Diff: https://reviews.apache.org/r/58603/diff/1/


Testing
---

For test:

- Launch without additional devices:

  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`

- Launch with additional devices:

  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices  
--cgroups_whitelist_devices='{"devices":[{"device":{"path":"/dev/rtc0"}, 
"access":{"mknod":true, "read":true, "write":true}}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Review Request 58561: Enabling automatic protobuf flag parsing (for mesos).

2017-04-20 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58561/
---

Review request for mesos.


Repository: mesos


Description
---

Enabling automatic protobuf flag parsing (for mesos).


Diffs
-

  src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641 


Diff: https://reviews.apache.org/r/58561/diff/1/


Testing
---


Thanks,

Zhongbo Tian



Review Request 58560: Enabling automatic protobuf flag parsing (for stout).

2017-04-20 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58560/
---

Review request for mesos.


Repository: mesos


Description
---

Enabling automatic protobuf flag parsing (for stout).


Diffs
-

  3rdparty/stout/include/stout/flags/parse.hpp 
65edd86372596c2107e9f29cf27301e025e6620e 


Diff: https://reviews.apache.org/r/58560/diff/1/


Testing
---


Thanks,

Zhongbo Tian



Re: Review Request 58337: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-16 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

(Updated April 17, 2017, 3:51 a.m.)


Review request for mesos and haosdent huang.


Summary (updated)
-

Allowed whitelist additional devices in cgroups devices subsystem.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/3/


Testing (updated)
---

For simple test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`


- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices 
--cgroups_whitelist_devices=[{'"path":"/dev/rtc0", "mknod_access":true, 
"ad_access":true, "write_access":true}]'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

(Updated April 12, 2017, 4:17 a.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/3/

Changes: https://reviews.apache.org/r/58337/diff/2-3/


Testing (updated)
---

For simple test:

- Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`


- Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices 
--cgroups_allowed_devices='{"devices":[{"path":"/dev/rtc0", 
"mknod_access":true, "read_access":true, "write_access":true}]}'`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

(Updated April 11, 2017, 11:13 a.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/2/

Changes: https://reviews.apache.org/r/58337/diff/1-2/


Testing
---

For simple test:

1. Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`
2. Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices 
--cgroups_allowed_devices=/dev/rtc0`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

(Updated April 11, 2017, 9:40 a.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-6791
https://issues.apache.org/jira/browse/MESOS-6791


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/1/


Testing
---

For simple test:

1. Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`
2. Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices 
--cgroups_allowed_devices=/dev/rtc0`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

(Updated April 11, 2017, 9:32 a.m.)


Review request for mesos.


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/1/


Testing (updated)
---

For simple test:

1. Launch without additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices`
  2. try open `/dev/rtc0` and failed with permission denied. `sudo 
mesos-execute --master=127.0.0.1:5050 --name=test --command="head -c 0 
/dev/rtc0"`
2. Launch with additional devices:
  1. Start agent with `sudo mesos-agent --master=127.0.0.1:5050 
--work_dir=/tmp/mesos --isolation=cgroups/devices 
--cgroups_allowed_devices=/dev/rtc0`
  2. open `/dev/rtc0` successfully. `sudo mesos-execute --master=127.0.0.1:5050 
--name=test --command="head -c 0 /dev/rtc0"`


Thanks,

Zhongbo Tian



Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58337/
---

Review request for mesos.


Repository: mesos


Description
---

Add allowed devices whitelist for cgroups/devices isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
ca2727142a9f257168f3cae0958f7b4665b63cf6 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
9b5cf83093796b0c0cc5057b612f80bc8b8ba72f 
  src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
  src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 


Diff: https://reviews.apache.org/r/58337/diff/1/


Testing
---


Thanks,

Zhongbo Tian



Review Request 54645: MESOS-6644: Fix failure of large message devolution.

2016-12-11 Thread Zhongbo Tian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54645/
---

Review request for mesos.


Repository: mesos


Description
---

MESOS-6644: Fix failure of large message devolution.


Diffs
-

  src/internal/devolve.cpp 27918f1 

Diff: https://reviews.apache.org/r/54645/diff/


Testing
---


Thanks,

Zhongbo Tian